D19019: Verify that model.AppPid is defined

broulik added a comment. Only actual windows have PIDs, the role isn't implemented for startup tasks or launchers iirc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19019 To: serhiyz, #plasma, davidedmundson Cc: broulik, hein, plasma-devel, jraleigh, GB_2,

D19024: Exclude powerdevil from session management

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I have seen reports of powerdevil sometimes not properly starting, but that's probably unrelated to this? It's started by an autostart file I think and isn't dbus-activated REPOSITORY

D19028: [ksmserver] Restore legacy sessions

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.15 branch please REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19028 To: davidedmundson, #plasma, broulik Cc: broulik,

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/111/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 04:42:33 + Build duration: 9 min 12 sec and counting CONSOLE OUTPUT [...truncated

D19029: Guard virtualDesktopManagement being accessed before fetched

davidedmundson added a comment. The other option is: connection->roundTrip(); at the end of init, which effectively is a (slightly safer) nested event loop until we've send a ping to kwin and back, which indicates that kwin must have also finished sending the registry REPOSITORY

D19029: Guard virtualDesktopManagement being accessed before fetched

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The WaylandPrivate::virtualDesktopManagement object is loaded

D19028: [ksmserver] Restore legacy sessions

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KSMServer has two modes, the slightly ancient mode (XSMP), and the really

D19026: Exclude kuiserver from session management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Service is DBus activated, we don't want to manually restore it. TEST PLAN

D19025: Exclude kscreen backend launcher from session management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Found in my ksmserverrc being restarted every session. TEST PLAN Code is

D19024: Exclude powerdevil from session management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY I found this process in my ksmserverrc This is autostarted through

D17217: Implement free memory notifier

rooty added a comment. My two cents - I really like this idea and this would be a **very** useful feature for those of us that really dislike swap space and have OOM problems (one too many browser tabs). But I'd set the intervals at 5-10 or even 20 minutes (not seconds). Also, I

D18999: Remove ignored style properties from CSS

andrzej1_1 added a comment. @ngraham done; I updated revison. My full name is //Andrzej Broński// and my email: //andrzej...@o2.pl//. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18999 To: andrzej1_1, #breeze, ngraham Cc: ngraham, plasma-devel, jraleigh,

D18999: Remove ignored style properties from CSS

andrzej1_1 updated this revision to Diff 51720. andrzej1_1 edited the summary of this revision. andrzej1_1 added a comment. Include fixes for //-GtkExpander-expander-size// and //-GtkCheckButton-indicator-size// REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D19011: Thunderbolt KCM and KDED module

ognarb added inline comments. INLINE COMMENTS > fakeserver.h:1 > +#ifndef FAKESERVER_H > +#define FAKESERVER_H You forgot to add a GPL license header for this file. Same for: - autotests/bolt/fakeserver/fakeserver.cpp - autotests/bolt/kded/kdedtest.cpp - autotests/bolt/lib/managertest.cpp -

D18716: Add a TextField component

ognarb added a comment. @mart thanks for the review, I don't have enough time this weekend, but I will start working on it next Tuesday :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18716 To: ognarb, apol, #kirigami, ngraham, mart Cc: broulik, mart, apol,

D18999: Remove ignored style properties from CSS

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh ok. If you want to do that in separate patch, let me know and I'll land this one for you. ...on that subject, can you give me your full name and email address so I can land the

D19019: Verify that model.AppPid is defined

hein added a comment. Remote clients have no pid, but might be nicer to fix the model to return 0. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19019 To: serhiyz, #plasma, davidedmundson Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18999: Remove ignored style properties from CSS

andrzej1_1 added a comment. @ngraham This fix was prepared for totally ignored style properties **only**. For example GtkCheckButton:indicator-size cannot be just removed: >

D19019: Verify that model.AppPid is defined

davidedmundson added a comment. In what situation is it undefined? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19019 To: serhiyz, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts

ngraham created this revision. ngraham added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch does for Kickoff what Kicker already does, and sets the maximum height equal

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for fixing the bug, but this should really have a better UI. Using a checkbox for more something that has more than just binary on/off states is a poor practice because it's never

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren created this revision. Zren added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY In 12h system locales (eg: en_US), checked=1 is cast as Qt::PartiallyChecked=1 which defaults to the

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

abetts added a comment. In D18893#412372 , @rooty wrote: > Hey guys so I opened up another diff to deal with the icons specifically: D19020 > > > For this image with the dots and type, shouldn't that be

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. Hey guys so I opened up another diff to deal with the icons specifically: D19020 > For this image with the dots and type, shouldn't that be centered and not touch the edge of the circle? That works too, but the idea here

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ccefa20ae859: [sddm-theme] Add buttons to username prompt to make it a full-fledged login… (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. Thanks in advance for fixing these minor typos. INLINE COMMENTS > DeviceView.qml:122 > +function() { > +console.log("Device " + device.uid + " enrolled > successfuly"); > +}, Typo:

D19019: Verify that model.AppPid is defined

serhiyz created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. serhiyz requested review of this revision. REVISION SUMMARY Verify that model.AppPid is defined to avoid error messages on every hover of an item in Task Manager. BUG: 396316

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1a10e201e919: [containment] Show an inline message when the Desktop Toolbox is hidden (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18990: [containment] Modernize tweaks page layout and port to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R119:191a901d09c4: [containment] Modernize tweaks page layout and port to QQC2 (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/110/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Feb 2019 17:46:41 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT [...truncated

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY If you have many applications running (e.g. browser tabs) it's very annoying to manually switch them all to another device. With this

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vpilo/minimumSize REVISION DETAIL https://phabricator.kde.org/D19013 AFFECTED FILES

D19009: Use better KDE GTK Config KCM desktop file comment

This revision was automatically updated to reflect the committed changes. Closed by commit R99:bceb50cb8ec3: Use better KDE GTK Config KCM desktop file comment (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D19006: Use KCM name in KCM header

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19006?vs=51688=51695 REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

dvratil created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The KCM allows user to authorize and store (or forget) the authorization of Thunderbolt 3 devices. This is done by communicating

D19009: Use better KDE GTK Config KCM desktop file comment

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use a better KDE GTK Config KCM desktop file comment that is correct and consistent with others.

D19006: Use KCM name in KCM header

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. A clear bug. I always wondered why the QTWidgets KCMs got their header text from the comment field in the desktop file while the QML KCMs got it from the KAboutData string. +1 for always

D19006: Use KCM name in KCM header

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the KCM name in Qt Widgets KCM headers, to make them consistent with others. F6614892: KCM Name

D18999: Remove ignore style properties from CSS

ngraham added a comment. Nice catch. Upon testing, I noticed two remaining warnings from Pavucontrol: $ (arcpatch-D18999) pavucontrol (pavucontrol:7385): Gtk-WARNING **: 09:18:56.255: Theme parsing error: gtk.css:68:34: The style property GtkCheckButton:indicator-size is

D18896: [plasma-nm] Refresh wifi networks as fast as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1b49255d81f0: [plasma-nm] Refresh wifi networks as fast as possible (authored by vpilo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

abetts added a comment. In D18893#412025 , @rooty wrote: > Thanks for accepting the patch! > Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"? > >

D18575: Remove warning before hidding the MenuBar

ngraham added a comment. In D18575#411906 , @tcanabrava wrote: > The hidding / displaying the menus should not be the *app* responsability, but KXmlGuiWindow. If this code is moved there, all apps that are currently doing this manually can

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

ngraham accepted this revision. ngraham added a comment. Land this now, then let's do the icons in another patch. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D18893 REVISION DETAIL https://phabricator.kde.org/D18893 To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham Cc:

D19004: Remove extra nested dbus session

bshah added a comment. git log says it is needed for systems where dbus-user-session is not installed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19004 To: davidedmundson, #plasma Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19004: Remove extra nested dbus session

bshah added a comment. Hmm, does git blame tell anything useful? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19004 To: davidedmundson, #plasma Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good. Thank you. REPOSITORY R116 Plasma Network Management Applet BRANCH vpilo/wifiRefresh (branched from master) REVISION DETAIL https://phabricator.kde.org/D18896 To:

D19004: Remove extra nested dbus session

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's not needed if the systemd pam session is loaded. (or presumably CK2

D18896: [plasma-nm] Refresh wifi networks as fast as possible

vpilo updated this revision to Diff 51677. vpilo added a comment. - Review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18896?vs=51525=51677 BRANCH vpilo/wifiRefresh (branched from master) REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/109/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Feb 2019 13:15:45 + Build duration: 2 min 25 sec and counting CONSOLE OUTPUT [...truncated

D19002: Fix window thumbnails not working since frameworks 5.55

mathiastillman closed this revision. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19002 To: mathiastillman, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. Thanks for accepting the patch! Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"? Then again, I might have to change the code here (the new icons have different labels).

KDE CI: Plasma » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Feb 2019 12:45:00 + Build duration: 11 min and counting CONSOLE OUTPUT [...truncated 128

D19003: Update visibility of mainItem of the window thumbnail since this is no longer done automatically in KDE Frameworks 5.55.

mathiastillman created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D19003 AFFECTED FILES

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty updated this revision to Diff 51667. rooty added a comment. Add visible: !inputPanel.keyboardActive REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18893?vs=51303=51667 BRANCH arcpatch-D18893 REVISION DETAIL

D19002: Fix window thumbnails not working since frameworks 5.55

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. nice, can you commit it? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19002 To: mathiastillman, mvourlakos Cc: plasma-devel, jraleigh, GB_2,

D19002: Fix window thumbnails not working since frameworks 5.55

mathiastillman created this revision. mathiastillman added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY This fixes a problem where window thumbnails are no longer visible since

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

rooty added a comment. In D18893#409907 , @davidedmundson wrote: > From my POV, +1 too. Good point! I'll just add it REPOSITORY R120 Plasma Workspace BRANCH login-prompt-buttons (branched from master) REVISION DETAIL

D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich added inline comments. INLINE COMMENTS > vpilo wrote in main.qml:78 > I did it for consistency, so in both files there's only one action. It's also > useful for debugging. It would still be one action even if you call "handler.requestScan()" instead of adding additional unnecessary

Remote desktop on Plasma Wayland session

Hi, I've spent quite a bit time on remote desktop support for Plasma Wayland sessions. I have full mouse support in xdg-desktop-portal-kde and also in Krfb so it can be easily tested and used. Problem is that I'm currently blocked by my additions to the FakeInput protocol on KWayland and KWin

D18896: [plasma-nm] Refresh wifi networks as fast as possible

vpilo added inline comments. INLINE COMMENTS > jgrulich wrote in main.qml:78 > Since this is just one line function, you can use handler.requestScan() > directly as before. I did it for consistency, so in both files there's only one action. It's also useful for debugging. REPOSITORY R116

D18716: Add a TextField component

mart added inline comments. INLINE COMMENTS > mart wrote in TextField.qml:106 > text will go under both buttons, in order to avoid that, probably anchors > should be added to the TextField's contentItem to make space for the buttons. err, TextField is not a Control, right. so, it should set

D18716: Add a TextField component

mart added a comment. also, the name should possibily not conflict with QQC2 TextField, like ActionTextField or something like that. INLINE COMMENTS > TextField.qml:21 > +import QtQuick 2.5 > +import QtQuick.Controls 2.1 > +import org.kde.kirigami 2.4 as Kirigami always namespace the

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. I think i'll introduce an heuristic to analyze the image and decide if it's monochrome and drop all this transparent nonsense (would make it a bit inefficient as it wuld need to read pixels colors in software but may be justified). locally i was trying with Shannon

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I can't think of a reason why it doesn't work for you :/. Maybe we can debug this on your side. Or the problem is on my side and it only works for me. Maybe someone other can comment if it works for them or not? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18579: Rework Sensor Browser

tcanabrava updated this revision to Diff 51655. tcanabrava added a comment. - Fix code style - re-add assert - Fix code style REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18579?vs=50423=51655 BRANCH CleanSensorBrowser REVISION DETAIL

D18576: Simpe C updates to ksysguardd code

This revision was automatically updated to reflect the committed changes. Closed by commit R106:b4bde28dc7af: Simpe C updates to ksysguardd code (authored by tcanabrava). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18576?vs=50419=51654 REVISION DETAIL

D18999: Remove ignore style properties from CSS

andrzej1_1 created this revision. andrzej1_1 added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andrzej1_1 requested review of this revision. REVISION SUMMARY When I was running //GTK3// application //pavucontrol//, I was getting warnings:

D18578: Reduce string objects

This revision was automatically updated to reflect the committed changes. Closed by commit R106:91b1f7115bf3: Reduce string objects (authored by tcanabrava). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18578?vs=50421=51653 REVISION DETAIL

D18575: Remove warning before hidding the MenuBar

tcanabrava added a comment. In D18575#401418 , @ngraham wrote: > > No other KDE app does this > > That's not true. Kate and Gwenview do this too, and for good reason: without this warning, there's no way to know how to get the menu bar back