Re: Breeze Dark theme question ?

2019-02-17 Thread Kai Uwe Broulik
Hi, I assume you're refering to the blue line when expanding an applet. That one is only shown if it comes from the current theme to avoid issues when using older Plasma 4 themes that don't expect this item to be used in said context. It seems Breeze Dark just inherits the SVG from Breeze

D16886: [windowswitcher] Implement keyboard navigation

2019-02-17 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16886 To: ngraham, #plasma, graesslin Cc: abetts, szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16886: [windowswitcher] Implement keyboard navigation

2019-02-17 Thread Shadab Zafar
szafar added a comment. Is there a similar feature for the "Large Icons" switcher? Using Left/Right arrow keys there would make a lot of sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16886 To: ngraham, #plasma, graesslin Cc: szafar,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Still Failing!

2019-02-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/102/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 04:25:32 + Build duration: 57 sec and counting CONSOLE OUTPUT

D19096: Increase the label's area to display 2 lines of text when needed

2019-02-17 Thread Tranter Madi
trmdi updated this revision to Diff 51941. trmdi retitled this revision from "Increase the label's area" to "Increase the label's area to display 2 lines of text when needed". trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma

Re: Remote desktop on Plasma Wayland session

2019-02-17 Thread Aleix Pol
On Thu, Feb 14, 2019 at 12:29 PM Jan Grulich wrote: > Hi, > > I've spent quite a bit time on remote desktop support for Plasma Wayland > sessions. I have full mouse support in xdg-desktop-portal-kde and also in > Krfb > so it can be easily tested and used. Problem is that I'm currently blocked >

D19110: Don't show the tooltip when the drop-down menu is shown

2019-02-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, Frameworks. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The menu itself should already offer enough information BUG: 404371 REPOSITORY R169

D19077: WIP: Fix long labels not being wrapped

2019-02-17 Thread Andres Betts
abetts added a comment. Just added some visual adjustments (mockup) F6620598: Screen Shot 2019-02-17 at 4.56.46 PM.png REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma,

D19077: WIP: Fix long labels not being wrapped

2019-02-17 Thread Filip Fila
filipf planned changes to this revision. filipf added a comment. Added inline comments for things I'm struggling with. INLINE COMMENTS > main.qml:25 > id: root > -SystemPalette { id: palette; colorGroup: SystemPalette.Active } > -color: palette.base > +frameVisible: true >

D19077: Fix long labels not being wrapped

2019-02-17 Thread Filip Fila
filipf updated this revision to Diff 51932. filipf added a comment. running into a wall so posting s WIP in hopes of help REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51852=51932 BRANCH master REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 116 - Still Failing!

2019-02-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/116/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 19:48:29 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Fixed!

2019-02-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 18:51:38 + Build duration: 2 min 40 sec and counting

D19091: Fix Breeze Light color scheme to match regular Breeze version, where appropriate

2019-02-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R31:07e94543b2b0: Fix Breeze Light color scheme to match regular Breeze version, where appropriate (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > emoticonslist.cpp:364 > { > -const QString name = KInputDialog::getText(i18n("New Emoticon Theme"), > i18n("Enter the name of the new emoticon theme:")); > +const QString name = KInputDialog::getText(i18n("New Emoticon Theme"), >

D19091: Fix Breeze Light color scheme to match regular Breeze version, where appropriate

2019-02-17 Thread Krešimir Čohar
rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R31 Breeze BRANCH fix-breeze-light-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D19091 To: ngraham, #vdg, GB_2, rooty Cc: rooty,

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Nathaniel Graham
ngraham added a comment. Awesome! Works great and looks so much better now. This new layout eliminates that horizontal scrollbar too. Just a few little nitpicks. INLINE COMMENTS > emoticonslist.ui:48 > > - This will remove the selected theme from your disk. > - > -

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Still Failing!

2019-02-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/101/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 18:06:38 + Build duration: 53 sec and counting CONSOLE OUTPUT

D19096: Increase the label's area

2019-02-17 Thread Tranter Madi
trmdi created this revision. trmdi added reviewers: ngraham, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Decrease some others' areas to increase the label's area to enable it to display 2 lines of

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2019-02-17 Thread M. Vefa Bicakci
bicakci added a comment. Hello! This commit causes a regression on my system. [1] In summary, during plasma's start-up the desktop background/wallpaper is initially displayed, but as soon as kscreen sets up the displays there are a number of flickers and the wallpaper is replaced with

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Björn Feber
GB_2 updated this revision to Diff 51905. GB_2 added a comment. Fix resizing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51903=51905 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, make buttons consistent and make the KCM look better. F6619998: Improved

D19091: Fix Breeze Light color scheme to match regular Breeze version, where appropriate

2019-02-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, GB_2. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY When I improved the contrast of the Breeze color scheme in D7424

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

2019-02-17 Thread Nathaniel Graham
ngraham added a comment. In D18991#413911 , @broulik wrote: > Bonus points if we could check for whether user has actually configured a "standard menu" action so we could show a big fat warning that they would lock themselves out now if they

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

2019-02-17 Thread Kai Uwe Broulik
broulik added a comment. Bonus points if we could check for whether user has actually configured a "standard menu" action so we could show a big fat warning that they would lock themselves out now if they did that. Preferably even with a button to auto-assign it back if it is missing.

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

2019-02-17 Thread Valerio Pilo
This revision was automatically updated to reflect the committed changes. Closed by commit R115:6e53d78136df: [plasma-pa] Increase minimum size of expanded plasmoid (authored by vpilo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D19014: [plasma-pa] Add command to switch all applications to the selected device

2019-02-17 Thread Valerio Pilo
vpilo updated this revision to Diff 51895. vpilo added a comment. - Review comments REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19014?vs=51699=51895 BRANCH vpilo/switchStreamsToDevice (branched from master) REVISION DETAIL

D19014: [plasma-pa] Add command to switch all applications to the selected device

2019-02-17 Thread Valerio Pilo
vpilo added inline comments. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:306 > How about "Play all audio using this device" Better already; I'm also concerned whether the label should become too long. Let's see what happens. REPOSITORY R115 Plasma Audio Volume Applet REVISION

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 105 - Still Failing!

2019-02-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/105/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 08:52:42 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT

D19079: Make look of Font Management KCM UI more consistent

2019-02-17 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8596ae908533: Make look of Font Management KCM UI more consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51877=51893

Breeze Dark theme question ?

2019-02-17 Thread Michail Vourlakos
Hello dear plasma devs, one question in case you know the answer and can help. Breeze Dark plasma theme accomplishies the following: 1. For its applets does NOT show an active indicator line 2. For its PlasmaComponents2.TabBar it shows the active tab line just fine 3. In the plasma theme