D19194: # Enter a commit message. # # Changes: # # applets/digital-clock/package/contents/ui/DigitalClock.qml Adjust date string height to match time string with vertical panel

antnyzilla added a comment. Before F6627819: before.png After F6627820: after.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19194 To: antnyzilla, #vdg Cc: plasma-devel,

D19194: # Enter a commit message. # # Changes: # # applets/digital-clock/package/contents/ui/DigitalClock.qml Adjust date string height to match time string with vertical panel

antnyzilla created this revision. antnyzilla added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. antnyzilla requested review of this revision. REVISION SUMMARY Changes the height of the date string to match that of the time string so the date is

D19077: Redesign the theme preview window

rooty added a comment. The shadow's the culprit! If you add the height of the shadow (assign it an id beforehand), then there's no white bar at the bottom :D REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg,

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416439 , @filipf wrote: > In D19077#416432 , @rooty wrote: > > > In D19077#416430 , @filipf wrote: > > > > > You have

D19077: Redesign the theme preview window

filipf added a comment. In D19077#416432 , @rooty wrote: > In D19077#416430 , @filipf wrote: > > > You have to install the Elarun theme because it's the only one that's considerably taller than the

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416430 , @filipf wrote: > You have to install the Elarun theme because it's the only one that's considerably taller than the other themes. Elarun will then break the height for your other themes. Still

D19077: Redesign the theme preview window

filipf added a comment. You have to install the Elarun theme because it's the only one that's considerably taller than the other themes. Elarun will then break the height for your other themes. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416427 , @filipf wrote: > @davidedmundson yes, so without the hack I get this happening: > > F6627430: image.png > > When using childrenRect, I believe the

D19077: Redesign the theme preview window

filipf added a comment. @davidedmundson yes, so without the hack I get this happening: F6627430: image.png When using childrenRect, I believe the rectangle's height is properly adjusted for the **tallest** theme preview, but ends up being too

D19077: Redesign the theme preview window

davidedmundson added inline comments. INLINE COMMENTS > main.qml:39 > > +//HACK: fills the QuickWidget area root wouldn't normally cover > +Rectangle { can you explain this? It's the size of root and the same colour REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D19077: Fix long labels not being wrapped

filipf added a comment. In D19077#416397 , @ngraham wrote: > With the default System Settings window size (and default font & size), the URLs now get cut off at the bottom nearly all the time. I probably need to add bottom padding to the

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:315 > Of those, I'd say `audio-ready` seems least inappropriate, but It almost > seems like we need a new icon that uses the speaker symbol with an arrow > somewhere in it to connote movement and change. I hoped I

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#416391 , @hein wrote: > What's all the unrelated code changes about mouse handling trying to achieve? > > Have you tested this with a few common screen resolutions / aspect ratios? The original grid was

powerdevil screen brightness linear vs nonlinear adjustment idea

I have noticed that every laptop backlight brightness tool I have used, including powerdevil and xbacklight and brightnessctl, increments and decrements linearly through the available range of brightness values for the backlight driver. powerdevil attempts to split the range into 20 steps, so on

D19077: Fix long labels not being wrapped

ngraham requested changes to this revision. ngraham added a subscriber: davidedmundson. ngraham added a comment. With the default System Settings window size (and default font & size), the URLs now get cut off at the bottom nearly all the time. Also, having all the metadata in a stacked list

D19179: Use PointingHand when hovering links in Label

filipf added a comment. In D19179#416235 , @leinir wrote: > In D19179#416222 , @filipf wrote: > > > I had to use I think identical code precisely for this use case recently, however it resulted in

D19096: Improvements for long label items in Application Dashboard

hein added a comment. What's all the unrelated code changes about mouse handling trying to achieve? Have you tested this with a few common screen resolutions / aspect ratios? The original grid was designed to try and avoid getting into awkward row configurations on common ones.

D19077: Fix long labels not being wrapped

filipf planned changes to this revision. filipf marked 12 inline comments as done. filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:26 > Is this actually going to work with all color schemes? Why are the colors not > identical in the first place? I tested it with

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 52181. filipf added a comment. address Nate's comments: fix import versions, use Layout.fillWidth: true REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52179=52181 BRANCH master

D19077: Fix long labels not being wrapped

ngraham added inline comments. INLINE COMMENTS > main.qml:26 > +//WORKAROUND: makes the rectangle's color match the background color > +color: Qt.tint(Kirigami.Theme.backgroundColor, > Qt.rgba(Kirigami.Theme.viewBackgroundColor.r, > Kirigami.Theme.viewBackgroundColor.g,

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 52179. filipf added a comment. rectangle will now fit seamlessly into the window (color matches the bg color), slightly reduce the margins REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D19077: Fix long labels not being wrapped

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Neato, getting there... INLINE COMMENTS > main.qml:18 > +import QtQuick 2.4 > +import QtQuick.Layouts 1.4 > +import QtQuick.Controls 2.4 Version does not exist, use version

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

ngraham added a comment. In D19185#416355 , @davidedmundson wrote: > Even if we do change it, krunner should still match for search queries "suspend" and "sleep" It still does. See F6626030: KRunner, searched for Suspend

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Even if we do change it, krunner should still match for search queries "suspend" and "sleep" I like how Kickoff in the other review has "Sleep" <---title

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52177. filipf added a comment. email address will be opened in mail client, added version number to the heading REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52175=52177 BRANCH

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. Limiting the height to 400, font size is 16pt: F6626929: Screenshot_20190220_210617.png Using the height hack, font size is 16pt: F6626931: Screenshot_20190220_210535.png

D19192: [Updates page] Improve selected/unselected explanation view

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Improve the clarity of the information that's being displayed, reduce string

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. In D19077#416325 , @ngraham wrote: > Hmm, you might have to keep the hardcoded height, given that the QWidgets container expects the QML view to have a certain size. That breaks apart as soon as the font isn't

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52175. filipf added a comment. Use a hack for the aforementioned problem until something better is proposed REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52174=52175 BRANCH master

D19077: WIP: Fix long labels not being wrapped

ngraham added a comment. Hmm, you might have to keep the hardcoded height, given that the QWidgets container expects the QML view to have a certain size. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. Here's the problem I'm running into with setting root's height. With Elarun it's good: F6626883: Screenshot_20190220_203244.png But with other previews the Rectangle just doesn't cover the underlying widget:

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52174. filipf added a comment. Use Kirigami.Theme for color, use childrenRect for root height, make website info clickable, drop shadow has a vertical offset of 2 REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D19126: block screen filtering for global menu applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:39d220b4b657: block screen filtering for global menu applet (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19126?vs=52168=52170

D18928: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6a4e90f2faa: Fix warnings (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18928?vs=51420=52169 REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52167. trmdi added a comment. This revision is now accepted and ready to land. Do not drag the item after right clicking on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52130=52167 REVISION DETAIL

D19126: block screen filtering for global menu applet

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. <3 thanks REPOSITORY R120 Plasma Workspace BRANCH bug404500 REVISION DETAIL https://phabricator.kde.org/D19126 To: mvourlakos, #plasma, davidedmundson, broulik Cc:

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415585 , @davidedmundson wrote: > David I followed your proposal, in case this is approved I believe that it should be provided also for plasma 5.15. Do you agree to cherry-pick it from master

D19126: block screen filtering for global menu applet

mvourlakos updated this revision to Diff 52168. mvourlakos added a comment. - follow David comment for devicePixelRation usage REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19126?vs=52000=52168 BRANCH bug404500 REVISION DETAIL

D16635: Add declarative plugin

apol added a comment. Is there a reason not to submit this? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D16635 To: nicolasfella, drosca, broulik, apol Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416222 , @filipf wrote: > I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416214 , @mart wrote: > that's the thing in question > https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html Thanks for the link. Hm, i imagine this would probably end up in a late enough release that

D19179: Use PointingHand when hovering links in Label

filipf added a comment. I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice tinkerer so apologies if the question is stupid, but could it cause similar issues if

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added inline comments. INLINE COMMENTS > vpilo wrote in ListItemBase.qml:315 > All three options for icons are for me ok, what about #vdg > ? Of those, I'd say `audio-ready` seems least inappropriate, but It almost seems like we need a new icon

D19179: Use PointingHand when hovering links in Label

mart added a comment. that's the thing in question https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh,

D19179: Use PointingHand when hovering links in Label

mart added a comment. ideally, this should use pointer handlers (which sadly they are 5.12 only) it may use preprocessing how we sometimes did for menus for instance REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D18716: Add an ActionTextField component

ngraham added a comment. Then again there's an argument to be made for consistency. I would be okay with using clickable icons instead of toolbuttons as long as we make sure to use a pointing hand cursor when hovered. REPOSITORY R169 Kirigami REVISION DETAIL

D19179: Use PointingHand when hovering links in Label

mart added a comment. I'm very hesitant to add a MouseArea in evert single Label REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19179: Use PointingHand when hovering links in Label

apol added a comment. LGTM +1 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, lesliezhai, ali-mohamed,

D18716: Add an ActionTextField component

ngraham added a comment. Even though we use clickable icons rather than toolbuttons in the QWidgets version, I think we should use ToolButtons if the visual style isn't too bad. People complained about the lack of pressed and hover states when the `SwipeListItem` used clickable icons

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52156. ngraham added a comment. Add context REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52149=52156 BRANCH use-the-word-sleep (branched from master) REVISION DETAIL

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52155. ngraham added a comment. Add context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19185?vs=52148=52155 BRANCH use-the-word-sleep (branched from master) REVISION DETAIL

D19096: Improvements for long label items in Application Dashboard

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52153. ngraham added a comment. Add context REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19184?vs=52147=52153 BRANCH use-the-word-sleep (branched from master) REVISION DETAIL

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY [copy-pasted from T10500 :] Problems with the

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

broulik added a comment. Can we give it a context, please? "Schlafen" is not what you typically say in German. i18nc("Suspend to RAM", "Sleep"); REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19184 To: ngraham, #vdg, #plasma Cc: broulik,

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY [copy-pasted from T10500

D19182: [about-distro] run variant through os-release

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this allows getting the pretty variant string from os-release if it was not overridden via kcm-about-distrorc CHANGELOG: About

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52141. ognarb added a comment. - Use list of actions - Text don't go under buttons now - Fix some warning in the testcase Sidebar.qml @mart That do you recommand me to use for the icons instead of ToolButton? I tried to do it with Kirigami.Icon

D19187: unbreak help button activation by not double-resetting the view

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY when sidepanel clickedSlot gets called it issues clicked() and that causes a reset of the

D19180: map powerdevil daemon to product

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY powerdevil didn't let users report bugs ever since the kf5 port and this only got fixed in D19162

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#415929 , @zzag wrote: > What about kstyle? Is it okay? kstyle uses entirely different shadows, even more so compared to the original values for kdecoration. Should it not be that way? REPOSITORY R31

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY [copy-pasted from T10500 :] Problems with the

D19188: only enable the module help button if the module actually has help

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the module help button specifically launches the help for DocPath set in the desktop file of the KCM, previously the code however

D19096: Improvements for long label items in Application Dashboard

ndavis added a comment. +1 from me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a reviewer: VDG. vpilo added inline comments. INLINE COMMENTS > ListItemBase.qml:315 > +menuItem.text = i18n("Play all audio via this device"); > +menuItem.icon = "audio-on" // or "audio-ready" // or > "audio-speakers-symbolic" > +

D19181: [about-distro] run logo lookup via osrelease

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY new preference: - kcm-about-distrorc - os-release - hardcoded `start-here-kde` this removes the need to duplicate the

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo updated this revision to Diff 52146. vpilo added a comment. - Review comments - Add icons REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19014?vs=51895=52146 BRANCH vpilo/switchStreamsToDevice (branched from master) REVISION

Plasma Sprint 2019 in València

Hi, In the meeting yesterday we discussed having a sprint this spring. Alejandro (CC) offered having it in Slimbook premises in València and suggested few dates. I included the Sundays, but we could configure the days before and after as we'd like) https://framadate.org/hpjHDLgRAcodBau4 Please

D19179: Use PointingHand when hovering links in Label

leinir created this revision. leinir added reviewers: ngraham, apol, mart, Kirigami. leinir added a project: Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch simply adds the behaviour usually

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 125 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/125/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 09:43:03 + Build duration: 36 min and counting JUnit Tests Name: projectroot

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Feb 2019 09:43:16 + Build duration: 3 min 4 sec and counting JUnit Tests Name:

D19148: Make shadow sizes linear

zzag added a comment. What about kstyle? Is it okay? REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,