KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/18/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 06:20:02 + Build duration: 4 min 27 sec and counting

D19148: Make shadow sizes linear

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8bfe474ac585: Make shadow sizes linear (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52421&id=52424 REVISION DETAIL https://phabrica

D19148: Make shadow sizes linear

ndavis added a comment. TBH, I can't tell a difference between the old KStyle shadows and the new ones. Maybe I should have just left them as they were or maybe I should increase the opacity, but at least the numbers look pretty. ¯\_(ツ)_/¯ REPOSITORY R31 Breeze BRANCH shadow-sizes (bran

D19148: Make shadow sizes linear

ndavis updated this revision to Diff 52421. ndavis added a comment. Update kstyle and increase size of kdecoration ambient shadows to 1/2 of directional shadows. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52107&id=52421 BRANCH shadow-sizes (b

D19148: Make shadow sizes linear

rooty added a comment. I don't see a difference either REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19148: Make shadow sizes linear

ndavis added a comment. This is directional (64 size, 100% opacity) and ambient (1000 size, 100% opacity). F6632129: Screenshot_20190223_194638.png F6632131: Screenshot_20190223_194651.png REPOSITORY R31 Bre

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#418158 , @zzag wrote: > In D19148#418083 , @ndavis wrote: > > > @zzag Is the only difference between the ambient and directional shadow the Y axis offset? If so, why

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

apol added inline comments. INLINE COMMENTS > Task.qml:370 > toolTipDelegate.virtualDesktopParent = > Qt.binding(function() { > -return model.VirtualDesktop != undefined ? > model.VirtualDesktop : 0; > +return (model.VirtualDe

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52411. ognarb added a comment. - Fix typo in doc - Code refactorization REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52214&id=52411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18716 AF

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52409. rooty added a comment. Missed a comma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52408&id=52409 BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 AFFECTED FILES

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 52408. rooty added a comment. Tidy up comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52088&id=52408 BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 AFFECTED FILE

D19077: Redesign the theme preview window

rooty added a comment. In D19077#417814 , @ngraham wrote: > > I'm not thrilled by the need to introduce new warnings in order to implement a hack. It's all a pretty stinky code smell, to be honest. :) Maybe @davidedmundson has some

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

thiago added a comment. The patch is innocuous. I don't see *how* it can solve anything, though, because I don;'t know what DrKonqu::cleanup does. The commit message is nonsense. This problem has nothing to do with D-Bus. That's a red herring, because the QDBusConnection thread only exi

D19036: [notifications] Lift up notification content if one line of body text droops

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Tested it and it looks good to me. REPOSITORY R120 Plasma Workspace BRANCH lift-up-noto (branched from master) REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma,

D19148: Make shadow sizes linear

zzag added a comment. In D19148#418083 , @ndavis wrote: > @zzag Is the only difference between the ambient and directional shadow the Y axis offset? If so, why do we have two shadows if they don't work differently? Well, no, that's not th

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

Fuchs added a comment. One minor nitpick: if it is on all virtual desktops there is no text shown, maybe some "is on all virtual desktops" or so would be nice, for consistency. But it might entirely be that it didn't do that before either, at least the code looks like it. Also this would

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

Fuchs added a comment. Yep, that works here, even with groups spanning multiple desktops. Thanks for the quick fix! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19257 To: hein, #plasma Cc: Fuchs, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesli

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:404572 REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D19259 AFFECTED FILES libtask

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:404706 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D19257 AFFECTED FILES applets/t

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Pingy-ping, bumpy-bump. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19148: Make shadow sizes linear

ndavis added a comment. @zzag Is the only difference between the ambient and directional shadow the Y axis offset? REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraha

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. In D19014#417906 , @vpilo wrote: > @ngraham If a new icon should be made, who could do it and how does the request process go? #VDG can hook you up. File a bug in Breeze | I

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

ossi added subscribers: thiago, dfaure. ossi added a comment. the patch definitely looks like a hack, but i'll leave the final judgment on that to thiago. kcrash closes all file descriptors to make the crashed process appear "as gone as possible" to anyone who might have wanted to talk t

D19247: Replace outdated FindX11_XCB copy with ECM and imported targets

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19247 AFFECTED FILES kcms/touchpad/cmake/modules/F

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/17/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 23 Feb 2019 07:38:35 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [..

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. @ngraham If a new icon should be made, who could do it and how does the request process go? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca, #vdg Cc: ngraham, plasma-devel, jraleigh,

D19011: Thunderbolt KCM and KDED module

knambiar added a comment. > How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized? > > "Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings remembered

D19244: Remove outdated FindGLIB2 copy

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This is provided by ECM nowadays, with proper imported targets. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL