D19577: [sddm-theme/lock screen] Fix "unable to assign [undefined] error

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch fixes the "Unable to assign [undefined] to QColor" and "Unable to assign [undefined] to int" errors that occur in

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty requested changes to this revision. rooty added a comment. This revision now requires changes to proceed. I really hate to be a bore but without the switch to PropertyAnimation that annoying bug (that you might not be able to notice but I am) keeps rearing its ugly head. REPOSITORY

D19566: [OSD] Fix animation stutter

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9a7de4e02399: [OSD] Fix animation stutter (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19566?vs=53286=53329 REVISION DETAIL

D19434: Change entry of Endpoint UI

andersonbruce updated this revision to Diff 53328. andersonbruce added a comment. - Add validator for Endpoint Port field REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19434?vs=52875=53328 BRANCH EndPointUIChange REVISION

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

ngraham accepted this revision. ngraham added a comment. This looks and feels great to me! A huge improvement IMO. And the code looks good. I'd also like a pressed state for these buttons too, but since the lack of them is a pre-existing issue, we can do that in another patch. :)

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53325. filipf added a comment. fix comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53322=53325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 AFFECTED FILES

D17249: Preserve screen colour doesn't work as expected

This revision was automatically updated to reflect the committed changes. Closed by commit R885:1e2a920633d7: Preserve screen colour doesnt work as expected (authored by jsalatas). REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

ngraham added inline comments. INLINE COMMENTS > LogoutButton.qml:34 > +circleVisiblity: activeFocus || containsMouse > +circleOpacity: 0.15 // circles are always visible > opacity: activeFocus || containsMouse ? 1 : 0.5 This comment doesn't seem accurate anymore. REPOSITORY

D19011: Thunderbolt KCM and KDED module

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks good to me now! Nice job. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts,

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 53323. dvratil added a comment. - Wording: Trust this Device/Revoke Trust button labels REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52775=53323 BRANCH arcpatch-D19011 REVISION DETAIL

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53322. filipf added a comment. go back to using opacityanimator REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53321=53322 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53321. filipf added a comment. Circles in the logout screen are only visible if the option is selected or hovered over REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53089=53321 BRANCH master

D19510: [Logout screen] Fix label opacity failing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:076671638f1d: [Logout screen] Fix label opacity failing (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53317=53320

D19510: [Logout screen] Fix label opacity failing

filipf updated this revision to Diff 53317. filipf added a comment. Add space between = and 1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53316=53317 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 AFFECTED

D19510: [Logout screen] Fix label opacity failing

ngraham added inline comments. INLINE COMMENTS > LogoutButton.qml:34 > opacity: activeFocus || containsMouse ? 1 : 0.5 > +labelRendering: opacity !=1 ? Text.QtRendering : Text.NativeRendering // > Remove once we've solved Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 > (KDE bug:

D19510: [Logout screen] Fix label opacity failing

filipf added a comment. @ngraham to further minimize the use of QtRendering I've added code so that it's used only when opacity is not 1. Is that okay? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 To: filipf, #plasma, ngraham,

D19510: [Logout screen] Fix label opacity failing

filipf updated this revision to Diff 53316. filipf added a comment. Use QtRendering only when opacity is not 1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19510?vs=53122=53316 BRANCH master REVISION DETAIL

D19417: [Web Browser] Use more appropriate panel icon and increase default size

This revision was automatically updated to reflect the committed changes. Closed by commit R114:47a8dd784daf: [Web Browser] Use more appropriate panel icon and increase default size (authored by iostapenko, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

ngraham updated this revision to Diff 53310. ngraham marked an inline comment as done. ngraham added a comment. Restart the timer when resizing is still ongoing so we can reduce the timer interval and update faster once resizing is done REPOSITORY R114 Plasma Addons CHANGES SINCE LAST

D19569: ActionTextField: Properly place actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:90693762ce26: ActionTextField: Properly place actions (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19569?vs=53287=53309 REVISION DETAIL

D19572: [kcolorschemeditor] Don't re-add existing tab

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This keeps it from unexpectedly changing tabs as you change any values. BUG: 393282

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:224-225 > > +onWidthChanged: imageReloadTimer.start() > +onHeightChanged: imageReloadTimer.start() > + Maybe restart is better, you can resize more than a second, so it'll wait a timer interval

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 53304. broulik added a comment. This revision is now accepted and ready to land. - Refactor to use proper `QAbstractListModel` for colors - Fix current scheme index following as you filter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19417: Panel icon & layout change of webbrowser applet

iostapenko added a comment. Ilya Ostapenko ostapenko.public at gmail.com REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19417 To: iostapenko, ematirov, #plasma, broulik Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

ngraham updated this revision to Diff 53302. ngraham added a comment. Set `sourceSize` in a timer so we don't continuously reload the image while the widget is being resized REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19550?vs=53249=53302 BRANCH

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53290. broulik added a comment. - Add efi, uefi, bios as keywords so the KCM can be found this way through KRunner REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19560?vs=53279=53290 REVISION DETAIL

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

ngraham accepted this revision as: VDG. ngraham added a comment. Never mind, it's already gone. UI looks good to me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19560 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

ngraham added a comment. Not sure we need the restart icon in the checkbox label. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19560 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19569: ActionTextField: Properly place actions

apol added a comment. New: F6663212: action-button-good.png Old: F6663211: action-button-bad.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19569 To: apol, #kirigami Cc:

D19569: ActionTextField: Properly place actions

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Since it was adopted I got a tiny button for the action, make better anchors use to fix this. TEST

D19417: Panel icon & layout change of webbrowser applet

ngraham added a comment. Thanks for this patch! Can you provide your full name and email address so we can land it with correct authorship information? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19417 To: iostapenko, ematirov, #plasma, broulik Cc:

D19566: [OSD] Fix animation stutter

rooty added a comment. How's that? It actually reminds me of the notification widget with these changes in place REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To: rooty, #plasma, #vdg, davidedmundson,

D19566: [OSD] Fix animation stutter

rooty updated this revision to Diff 53286. rooty added a comment. Remove unused animation code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19566?vs=53277=53286 BRANCH osd-effect-fix (branched from master) REVISION DETAIL

D19566: [OSD] Fix animation stutter

rooty added a comment. > plasma-workspace/shell/osd.cpp > > It also seems kscreen has a copy of thhis OSD which also needs fixing, and please also make sure the lockscreen doesn't break as it also embeds an OSD item. It won't affect the lock screen. (The lock screen was never

D17249: Preserve screen colour doesn't work as expected

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Seems sensible, thanks. REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D17249 To: jsalatas, #plasma, martinkostolny, broulik Cc: broulik,

D19566: [OSD] Fix animation stutter

broulik added a comment. > There don't seem to be any other instances of it being used? plasma-workspace/shell/osd.cpp It also seems kscreen has a copy of thhis OSD which also needs fixing, and please also make sure the lockscreen doesn't break as it also embeds an OSD item. >

D19566: [OSD] Fix animation stutter

rooty added a comment. In D19566#425896 , @broulik wrote: > That removes the "slowly fade out feature of the OSD", please then also remove all uses of that property There don't seem to be any other instances of it being used? >

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

broulik added inline comments. INLINE COMMENTS > main.qml:189 > fillMode: plasmoid.configuration.fillMode > +sourceSize.width: main.width > +sourceSize.height: main.height Note that this will cause the image to be reloaded everytime the size

D19566: [OSD] Fix animation stutter

abetts added a comment. +1 on visuals REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To: rooty, #plasma, #vdg, davidedmundson, ngraham Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2,

D19566: [OSD] Fix animation stutter

broulik added a comment. Also, the Animation is now also entirely unused as the opacity of the window is no longer changed? Please clean this up. REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To:

D19566: [OSD] Fix animation stutter

broulik added a comment. That removes the "slowly fade out feature of the OSD", please then also remove all uses of that property REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To: rooty, #plasma,

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The wording looks good to me! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19562 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel,

D19566: [OSD] Fix animation stutter

ngraham accepted this revision. ngraham added a comment. Land in 5.15 and merge to master, please! REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 To: rooty, #plasma, #vdg, davidedmundson, ngraham Cc:

D19561: Don't crash if the fwupd error is null

leinir added a comment. In D19561#425879 , @apol wrote: > Cool, thanks! remember to land in 5.15. Will do! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19561 To: leinir,

D19561: Don't crash if the fwupd error is null

apol accepted this revision. apol added a comment. Cool, thanks! remember to land in 5.15. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19561 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh,

D11352: [RFC] Auto ordered systray

ngraham added a comment. @pitel, I'm sorry this has been sitting for so long! We'd like to land this but it no longer merges cleanly on master. Can you rebase it please? REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To:

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53279. broulik edited the test plan for this revision. broulik added a comment. - Simplify, totally didn't realize the "impl" was just a UI subclass, just access its controls directly from the kcm class - Add "Restart Now" button to message widget -

D19566: [OSD] Fix animation stutter

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH osd-effect-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D19566 AFFECTED FILES

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53267. broulik retitled this revision from "[Desktop Sessions KCM] Add Reboot to BIOS/UEFI checkbox" to "[Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox". broulik added a comment. - Change wording to "restarted" instead of rebooted and talk

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

broulik updated this revision to Diff 53265. broulik added a comment. Use "restarted" instead of rebooted, just saw that we use the former now :) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19562?vs=53262=53265 REVISION DETAIL

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the flag to reboot into BIOS/UEFI setup is set, show a hint on the logout screen. For

D19561: Don't crash if the fwupd error is null

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY I got a

D19560: [Desktop Sessions KCM] Add Reboot to BIOS/UEFI checkbox

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This sets a logind flag that tells the system to boot into the BIOS/UEFI setup screen on