D19947: systray: show a small animation on the icons when activated

apol added a comment. In D19947#438122 , @anthonyfieroni wrote: > Can we spy mouse click (in C++ side if needed) before it's propagated to applet? I tried to do it and failed, it's not that I enjoy complex solutions... REPOSITORY

D20055: Fixed initial size and content width of Activity Settings KCM

tigrang added a comment. Before: https://i.imgur.com/KEHZK7S.png After with only minSize set: https://i.imgur.com/XJ63Hzn.png After with minSize + col span change: https://i.imgur.com/1EYeUOx.png The alignment of the last screenshot may not be desirable so please check that.

D20055: Fixed initial size and content width of Activity Settings KCM

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY Tab contents are added when KActivities::Consumer::serviceStatusChanged signal is fired which happens after the layout is set.

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb updated this revision to Diff 54823. faridb marked 4 inline comments as done. faridb added a comment. - [Task Manager] Enable ability to mute tasks by default - [Task Manager] Change wording in config ui REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20051: Do not try to set shadows for panels if theme does not provide elements

kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Older Plasma themes, which are still offered also for current Plasma 5 e.g. from

D19915: [Mnemonic Handling] Replace only first occurrence

This revision was automatically updated to reflect the committed changes. Closed by commit R169:96d0d35d2935: [Mnemonic Handling] Replace only first occurrence (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19915?vs=54413=54808

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54797. filipf added a comment. Don't break the slideshow wallpaper by putting everything in a form layout REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54790=54797 BRANCH fix-hor-alignment

D20014: Update URLs to use https

This revision was automatically updated to reflect the committed changes. Closed by commit R134:428f4171c494: Update URLs to use https (authored by vkrause). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20014?vs=54654=54795 REVISION DETAIL

D20048: [color-wallpaper] Align with the master FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch aligns the color wallpaper plugin's options with the FormLayout above it by making use of twinFormLayouts. REPOSITORY

[kio-extras] [Bug 370594] smb cannot create file with a :

https://bugs.kde.org/show_bug.cgi?id=370594 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #3 from

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 54790. filipf added a comment. lose the unecessary QtQuick.Controls 1 import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54554=54790 BRANCH fix-hor-alignment (branched from master) REVISION

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

filipf added a comment. If there's no objections I'll land this tomorrow night so we can keep working on fixing the plugins. I've also thought a bit more about this, and I suppose another approach would be for the master FormLayout here to also adjust itself based on the content of the

D19947: systray: show a small animation on the icons when activated

anthonyfieroni added a comment. In D19947#438052 , @apol wrote: > In D19947#438003 , @davidedmundson wrote: > > > It's subtle but I quite like it. > > > \o/ > > > It feels a bit

D19947: systray: show a small animation on the icons when activated

apol updated this revision to Diff 54779. apol added a comment. Unrelated change. Bad phabricator. *hits phab's nose with a newspaper* REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19947?vs=54778=54779 BRANCH master REVISION DETAIL

D20043: digitalclock: have it display a context menu onPressAndHold

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See D20042 TEST PLAN Showed it REPOSITORY R120 Plasma Workspace

D19947: systray: show a small animation on the icons when activated

apol updated this revision to Diff 54778. apol added a comment. Show a context menu onPressAndHold See 20042 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19947?vs=54500=54778 BRANCH master REVISION DETAIL

D19947: systray: show a small animation on the icons when activated

apol added a comment. In D19947#438003 , @davidedmundson wrote: > It's subtle but I quite like it. \o/ > It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click. Agreed, but here the bug is that

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.xml:99 > I'd have this on by default. +1 for having it on by default > ConfigAppearance.qml:72 > > +RowLayout { > +// Indent the option as it depends on the previous one Putting the option in the

D19976: [about-distro] OSRelease to collect "extra" keys

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e65bcdc90719: [about-distro] OSRelease to collect extra keys (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19976?vs=54561=54773

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#437985 , @apol wrote: > Overall this makes sense to me, this assumes though that there will never be a file ending with `:digit`, is that something we can live with? Judging from

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd updated this revision to Diff 54774. arrowd marked an inline comment as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=49633=54774 BRANCH cursor REVISION DETAIL

D19975: [about-distro] pimpl OSRelease privates

This revision was automatically updated to reflect the committed changes. Closed by commit R102:620be5cd4dea: [about-distro] pimpl OSRelease privates (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19975?vs=54560=54772 REVISION

D19947: systray: show a small animation on the icons when activated

davidedmundson added a comment. It's subtle but I quite like it. It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click. INLINE COMMENTS > PlasmoidItem.qml:43 > if (applet && mouse.button === Qt.LeftButton) { > applet.expanded =

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

apol added a comment. Overall this makes sense to me, this assumes though that there will never be a file ending with `:digit`, is that something we can live with? INLINE COMMENTS > urlinfo.h:68 > + */ > +line = match.captured(1).toUInt(); > +column =

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Monthly bump. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19947: systray: show a small animation on the icons when activated

apol added a comment. Use akregator for example, or the virtual keyboard enable/disable thing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20027: Fix initial width/height in KCMs that use qml

This revision was automatically updated to reflect the committed changes. Closed by commit R102:43bfb812df95: Fix initial width/height in KCMs that use qml (authored by tigrang, committed by apol). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D18579: Rework Sensor Browser

zzag added a comment. > Fix code style In general, the coding style situation in KSysGuard is a bit sad. I personally can't trace any distinct coding style, it's basically a mix of every potential coding style. We should probably run clang-format and clang-tidy over it some time

D20035: Set autofocus to child KPluginSelector on UI load

ngraham added inline comments. INLINE COMMENTS > kcm.cpp:89 > +// m_pluginSelector->setFocus() did not work. I dont know why. > +QTimer::singleShot(0, m_pluginSelector, SLOT(setFocus())); > } I'm not thrilled about this workaround. Any chance you can figure out why

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#437715 , @dfaure wrote: > ... > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this