D20081: Add readme explaining how kwallet-pam works

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D20081 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, jraleigh, GB_2,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. Just throwing out another possible solution: the PlasmaComponents Highlight thingy: F6747233: Screenshot_20190403_005556.png F6747232: Screenshot_20190403_005453.png Might be

D20081: Add readme explaining how kwallet-pam works

davidedmundson added a comment. addressed comments REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D20081 To: davidedmundson, #plasma Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D20081: Add readme explaining how kwallet-pam works

davidedmundson updated this revision to Diff 55320. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. update REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20081?vs=54940=55320 BRANCH master REVISION

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. In D19873#442385 , @hein wrote: > Looks solid to me. Is your concern re vertical spacing still valid? Thanks for having a look. Vertical spacing in wallpaper plugins is now OK, but unfortunately the spacing is

D20198: Don't lose list position after installing KNS cursor themes

apol added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:466 > +const CursorTheme *theme = selectedIndex().isValid() ? > m_proxyModel->theme(selectedIndex()) : nullptr; > +if(theme) { > +QString currentTheme = theme->name(); This reads weird: how

D20218: Don't hardcode default kwallet path

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. ... wow REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D20218 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, jraleigh,

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf added a comment. In D19822#442584 , @ngraham wrote: > Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 55319. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. updates REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19389?vs=53111=55319 BRANCH master REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. Hmm, while the red highlight effect is pretty and distinctive, typically we don't telegraph what will happen when clicked using an item's hover effect. Though it's more boring and conventional, I would recommend using the typical effect. :) REPOSITORY R119 Plasma

D20218: Don't hardcode default kwallet path

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This allows a user to install to a different prefix and have kwallet_pam

D20217: Remove kwallet4 support

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Kwallet5 migrates the old wallet and kdelibs4 code can connect to the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. About the icon issue, IconItem by default uses the icon theme overlay from the Plasma theme, Kirigami.Icon will use the regular Plasma icons. That's kind of tricky - with Breeze we could totally make them match, but other Plasma themes would have issues. A long

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

faridb added a comment. The highlight effect provided by `PlasmaCore.IconItem` is only visible when used with dark or colourful icons: F6746966: Mute5.gif F6746965: Mute4.gif I also tried reducing the

D20213: [kcolorschemeeditor] Use config path instead of searching again

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `m_schemeName` is the translated scheme name which may not match the file name. Since the

D20205: initialize the kcolorscheme at the first app start

hein added a comment. Or the QPA could look at the LnF in the first place instead of kdeglobals? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D20205 To: mart, #plasma Cc: hein, davidedmundson, plasma-devel, jraleigh, GB_2,

D20205: initialize the kcolorscheme at the first app start

davidedmundson added a comment. The analysis makes sense, I don't understand why this is the correct fix. Colours aren't the only thing lookandfeel syncs to kdeglobals when set. Is it correct that all of them have a fallback to loading a second config? If they do, why does the lnf kcm

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added subscribers: rooty, filipf, abetts, ndavis. GB_2 added a comment. In D20144#441802 , @ngraham wrote: > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them?

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

hein added a comment. Looks solid to me. Is your concern re vertical spacing still valid? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham, mart Cc: hein, davidre, mart, abetts, plasma-devel, jraleigh,

D20198: Don't lose list position after installing KNS cursor themes

ngraham added a comment. Why do we need this do-it-once helper function? INLINE COMMENTS > kcmcursortheme.cpp:466 > +const CursorTheme *theme = selectedIndex().isValid() ? > m_proxyModel->theme(selectedIndex()) : nullptr; > +if(theme) { > +QString

D19077: Redesign the theme preview window

mart added a comment. In D19077#422017 , @filipf wrote: > @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the value is deprecated. The one suggested for

D20205: initialize the kcolorscheme at the first app start

mart updated this revision to Diff 55286. mart added a comment. - revert mistake REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20205?vs=55285=55286 BRANCH phab/initializeColors REVISION DETAIL

D20205: initialize the kcolorscheme at the first app start

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when an app starts when there isn't a kdeglobals yet, it reads from the color theme defined in the look

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf added a comment. I think it would be good if someone from #plasma could have a look if this is okay, I did do a lot of modifications. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55283. filipf added a comment. . REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=55282=55283 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19873 AFFECTED FILES

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55282. filipf added a comment. git... REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=55281=55282 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL https://phabricator.kde.org/D19873

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

filipf updated this revision to Diff 55281. filipf added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54797=55281 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL https://phabricator.kde.org/D19873

D20048: [color-wallpaper] Align with the master FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b40dabdc27e4: [color-wallpaper] Align with the master FormLayout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20048?vs=54791=55279

D19077: Redesign the theme preview window

filipf added a comment. In D19077#442288 , @GB_2 wrote: > I like B too. > BTW, can "Background:" and the background selection button be centered like in a form layout? Sure, we could see if that would look better. Since I know you've

D19077: Redesign the theme preview window

GB_2 added a comment. I like B too. BTW, can "Background:" and the background selection button be centered like in a form layout? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2,

D19077: Redesign the theme preview window

filipf added a comment. In D19077#442281 , @GB_2 wrote: > Ping I've been putting this off because we couldn't quite reach consensus on the general layout. Putting it to a vote again: A) simplistic F6745779: image.png

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. In D19829#432852 , @i.Dark_Templar wrote: > Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it

D19077: Redesign the theme preview window

GB_2 added a comment. Ping REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D20203: desktoppackage: add "panelMask" property for Panel.qml

kossebau added a comment. Needs D20202 . From what I understood, the property "containment" is expected to exist for a "views/Panel.qml" root item, at least by the panelview.cpp code. So I would hope the same could be said about the "panelMask"

Plasma 5.15.4.1

A Breeze update to fix the Qt 4 theme http://download.kde.org/stable/plasma/5.15.4/breeze-5.15.4.1.tar.xz sha256 9a95fb9c5be7c84164d3ce337d15cad57cdd495fe84e1da8487a463d69293497 http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/breeze/5.15.4_to_5.15.4.1/changes_report.html

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

filipf resigned from this revision. filipf added a comment. Highlight color is nice, but in my tests I really like having red for the muting because it gets the point across that a disabling action will be triggered. Therefore the code I have now is: `color: mouseArea.containsMouse?

D20204: Fix always full rect blur mask for panels ignoring shape from Plasma themes

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Plasma themes might define non-full-rect shapes for panels (e.g. round borders for panels

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55277. atulbi added a comment. - Code Cleanup and resolved unexpected behaviour REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55251=55277 BRANCH X11Libinput REVISION DETAIL

D20201: Fix build with Qt 4

This revision was automatically updated to reflect the committed changes. Closed by commit R31:386d3b8ed1e0: Fix build with Qt 4 (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20201?vs=55273=55276 REVISION DETAIL

D20203: desktoppackage: add "panelMask" property for Panel.qml

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Allows the panel code from plasmashell to know the shape of the panel, as useful when

D20201: Fix build with Qt 4

zzag updated this revision to Diff 55273. zzag added a comment. merghe paths REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20201?vs=55271=55273 BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D20201 AFFECTED FILES

D20201: Fix build with Qt 4

zzag added inline comments. INLINE COMMENTS > fvogt wrote in breezewindowmanager.cpp:904 > Please add that to the already existing `#if` above. Well, for better readability I suggest to keep them both separate. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20201 To:

D20201: Fix build with Qt 4

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > breezewindowmanager.cpp:904 > > +#if BREEZE_USE_KDE4 > +const QPoint native = position; Please add that to the already existing `#if` above.

D20201: Fix build with Qt 4

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R31 Breeze BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D20201 AFFECTED FILES

Plasma 5.15.4

Plasma 5.15.4 is now released https://www.kde.org/announcements/plasma-5.15.4.php

D20155: [SpinBox] Improve mouse wheel behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8f4ac7abc600: [SpinBox] Improve mouse wheel behavior (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/13/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 10:22:40 + Build duration: 27 min and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/18/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 10:22:53 + Build duration: 25 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/16/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 10:19:42 + Build duration: 9 min 28 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/13/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 10:19:42 + Build duration: 4 min 46 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Apr 2019 09:50:41 + Build duration: 6 min 43 sec and counting CONSOLE OUTPUT

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#442125 , @hein wrote: > I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :) one important thing, it should be

D20198: Don't lose list position after installing KNS cursor themes

leinir created this revision. leinir added reviewers: Plasma, ngraham. leinir added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY When installing a new cursor theme from KNewStuff, the current theme would become

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 184 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/184/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 09:50:40 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein added a comment. I'd say let's go with Kirigami.Icon for now then, and recolor the icon to the highlight color on hover. @faridb could you take a stab at that? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham,

D19857: [DownloadJob] Report total size only if known

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Additionally, the `bytesReceived > totalAmount` case is currently not handled at all, but I'm not sure whether that's something for `KJob` or here. INLINE COMMENTS >

D18979: foldermodel: store information about screen used

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dcb4c158b414: foldermodel: store information about screen used (authored by McPain, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: CI system maintainability

On Sat, Mar 30, 2019 at 10:46 PM Volker Krause wrote: > > On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > > I fear that a mandatory reviews would add too juch strain on smaller > > > teams. If there's just one person with an

D18979: foldermodel: store information about screen used

hein added a comment. I checked the database and it looks like you don't have a developer account yet, so I'll land this patch for you. If you keep submitting patches, feel free to apply for a developer account via identity.kde.org at some point :) REPOSITORY R119 Plasma Desktop REVISION

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#439167 , @hein wrote: > I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Got to Know a lot about how X works with input handling. XD I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#437687 , @filipf wrote: > I still think we should make it configurable. We'd want to be able to avoid situations with parents or a newbies going something like: "I was watching/listening to X and your darn Linux

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#437684 , @faridb wrote: > In D19822#437680 , @ngraham wrote: > > > Also, it would be nice if you also work on making the volume indicators smaller and always in the

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mart added a comment. In D19822#439297 , @hein wrote: > A possible improvement to make here is to make the indicator visually react to hover by recoloring the icon, to teach that it's seperately interactive and will do something different than

D18979: foldermodel: store information about screen used

McPain added a comment. In D18979#441799 , @hein wrote: > Thanks! Do you need help landing this? Any instructions about "how to commit an accepted revision?" REPOSITORY R119 Plasma Desktop REVISION DETAIL