D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56268. GB_2 added a comment. Try to fix diff REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56266=56268 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077

D19077: Redesign the theme preview window

2019-04-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's do it. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg,

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 added a comment. In D19077#442323 , @mart wrote: > In D19077#422017 , @filipf wrote: > > > @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r",

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56266. GB_2 added a comment. Prevent deprecation warning REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52351=56266 BRANCH arcpatch-D19077 REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works and makes sense to me, but I'm not as familiar with the `user-manager` codbease and would appreciate a #plasma review too, in case

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56265. GB_2 added a comment. Remove monochrome icon REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20564?vs=56264=56265 BRANCH change-default-user-avatar (branched from master) REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ok, the problem is that now the default user icon doesn't work with a dark theme. I think we should just provide it in `breeze-icons`, so it is the default user icon that also gets selected when you click `Clear Avatar`. REPOSITORY R128 User Manager REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D20536 TEST PLAN Open the avatar gallery.

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-14 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. These are notifications that aren't shown by default, right? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D20492 To: meven, #plasma, broulik, ngraham, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. I like having it in the context menu. Putting it in the expanded pop-up I'm less sure about, because the icon isn't as recognizable and maybe we might be cluttering the view up too much? REPOSITORY R120 Plasma Workspace REVISION

D20562: Use (better) path to libICE when doing check_library_exists.

2019-04-14 Thread Adriaan de Groot
adridg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. adridg requested review of this revision. REVISION SUMMARY Using just "ICE" means that -lICE gets passed to the linker for this test, and *that* might not be in the default linker path.

D20561: [analog-clock] Render hand also smooth during animation

2019-04-14 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:74ccb591c484: [analog-clock] Render hand also smooth during animation (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20561: [analog-clock] Render hand also smooth during animation

2019-04-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. @davidedmundson Thanks for review, will then also apply to all copies of the logic. REPOSITORY R120 Plasma Workspace BRANCH removeclckhandnonsmoothanimation REVISION DETAIL https://phabricator.kde.org/D20561 To: kossebau, #plasma, davidedmundson Cc:

D20561: [analog-clock] Render hand also smooth during animation

2019-04-14 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Due to a bug SvgItem had effectively ignoring the value of the smooth property and acted as

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Méven Car
meven added a comment. The energy info kcm would need some attention though. kcmshell5 kcm_energyinfo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Méven Car
meven updated this revision to Diff 56236. meven marked 2 inline comments as done. meven added a comment. Capitalization REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56235=56236 BRANCH arcpatch-D20533 REVISION DETAIL

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > apol wrote in batterymonitor.qml:106 > Typo? kcm_energyinfo vs kcms_energyinfo Thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma, ngraham,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Méven Car
meven updated this revision to Diff 56235. meven added a comment. Typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56183=56235 BRANCH arcpatch-D20533 REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES

D20522: Don't load the KSharedConfig instance on every read

2019-04-14 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R116:4408af0c: Dont load the KSharedConfig instance on every read (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

2019-04-14 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > batterymonitor.qml:106 > +readonly property var kcm_energyinfo: ["kcm_energyinfo.desktop"] > +readonly property bool kcmEnergyInformationAuthorized: > KCMShell.authorize(kcms_energyinfo).length > 0 > + Typo? kcm_energyinfo vs

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Port the KCM to the new GriedView KCM design. F6771665: Improved Plymouth Boot Splash Screen KCM

D18419: Adjust some KCMs to implement new Appearance section layout

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet.

2019-04-14 Thread Méven Car
meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D20533 AFFECTED FILES