D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 59241. avaldes added a comment. Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the following image F6349860: screenshot.png

D16425: Added new Suspend then Hibernate option

abalaji added inline comments. INLINE COMMENTS > avaldes wrote in suspendsessionconfig.cpp:45 > something like this? > > : ActionConfig(parent), > m_suspendThenHibernateEnabled(nullptr) Yeah exactly. So a subtle detail of C++ constructors is any data members which are not primitive

D21610: Redesign Advanced tab

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nice. Looks like this layout includes some empty whitespace on the bottom though. Open it in `kcmshell` and reduce the window height: F6873598:

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59232. filipf added a comment. update comment REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59231=59232 BRANCH redesign-sddm-advanced-tab (branched from master) REVISION DETAIL

D16425: Added new Suspend then Hibernate option

avaldes added inline comments. INLINE COMMENTS > abalaji wrote in suspendsessionconfig.cpp:45 > Move this to the initializer something like this? : ActionConfig(parent), m_suspendThenHibernateEnabled(nullptr) REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59231. filipf added a comment. reduce height of vertical spacers REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59212=59231 BRANCH redesign-sddm-advanced-tab (branched from master)

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

filipf added a comment. Thanks for the quick review everyone :) In D21614#474950 , @veqz wrote: > Looks better to me. > > Though wouldn't it be even better if it was even a point larger? They way we set it up now is that there is

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R120:928201c550eb: [sddm-theme] Fix fontsize of virtual keyboard ToolButton (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

ngraham added a comment. In D21614#474950 , @veqz wrote: > Looks better to me. > > Though wouldn't it be even better if it was even a point larger? In fact I think most of our text looks better at 11 pt font, but that's a somewhat

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

veqz accepted this revision. veqz added a comment. Looks better to me. Though wouldn't it be even better if it was even a point larger? REPOSITORY R120 Plasma Workspace BRANCH fix-virtualkeyboard-button-size (branched from master) REVISION DETAIL

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

ngraham accepted this revision. ngraham added a comment. Whoops! REPOSITORY R120 Plasma Workspace BRANCH fix-virtualkeyboard-button-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D21614 To: filipf, #vdg, hein, veqz, ngraham Cc: ngraham, veqz, plasma-devel,

D21614: [sddm-theme] Fix fontsize of virtual keyboard ToolButton

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY When we updated the fonts in the sddm-theme, we bumped the default size from 9pt to 10pt. We missed adding the relevant code to the

D18007: [SDDM theme] Use the biggest wallpaper resolution

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9734166ce48: [SDDM theme] Use the biggest wallpaper resolution (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18007?vs=59159=59228

D21611: [sddm-theme] Set source size for wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4280e7715fa4: [sddm-theme] Set source size for wallpaper (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21611?vs=59215=59225

D21610: Redesign Advanced tab

abetts added a comment. +1 on visuals REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21610 To: filipf, ngraham, #vdg, davidedmundson Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21609: Add "Safe Landing" wallpaper

ngraham added a comment. Done in https://cgit.kde.org/plasma-workspace-wallpapers.git/commit/?id=eb0306a872778f3ab4aa644ee6da021f327fdba9 REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D21609 To: ngraham, #vdg, ndavis Cc: filipf, plasma-devel, LeGast00n,

D21609: Add "Safe Landing" wallpaper

ngraham added a comment. Nice work, it looks nearly identical even when zoomed in super close, and there is no perceptible difference when viewed at typical sizes. I'll update it. Thanks! REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D21609 To: ngraham,

D21610: Redesign Advanced tab

ngraham added a comment. In D21610#474842 , @filipf wrote: > The spacing between sections seems too big, I need to reduce it so that it matches the one in Kirigami's FormLayout. `QSpacerItem` works well for this, and you can customize

D21610: Redesign Advanced tab

filipf planned changes to this revision. filipf added a comment. The spacing between sections seems too big, I need to reduce it so that it matches the one in Kirigami's FormLayout. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21610 To:

D21611: [sddm-theme] Set source size for wallpaper

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch sets the source size for wallpapers used in the login screen to screen size. The goal is to save resources. REPOSITORY

D21609: Add "Safe Landing" wallpaper

filipf added a comment. I got the JPEG down to 4 MiB via some online tool, looks the same to me. What do you think? F6872104: kde_full_comp-compressor.jpg REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D21609

D21609: Add "Safe Landing" wallpaper

ngraham added a comment. This was the best the author could do, and I didn't want to monkey with it since I'm not exactly an expert at image size optimization. Are you any good at this? The original PNG is at https://www.dropbox.com/s/zq1kqi20sik4gb8/kde_full_comp.png?dl=0 REPOSITORY

D21609: Add "Safe Landing" wallpaper

filipf added a comment. Err wait, can we compress this even more? 8MB is still a lot. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D21609 To: ngraham, #vdg, ndavis Cc: filipf, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D21609: Add "Safe Landing" wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R131:0ec606da0de9: Add Safe Landing wallpaper (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21609?vs=59213=59214 REVISION DETAIL

D21609: Add "Safe Landing" wallpaper

ngraham updated this revision to Diff 59213. ngraham edited the summary of this revision. ngraham added a comment. Return to the author's original CC-BY-SA-4.0 license since that's better for images REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE

D21610: Redesign Advanced tab

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch redesigns and modernizes the Advanced tab of SDDM's KCM. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH

D21609: Add "Safe Landing" wallpaper

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adds the Safe Landing wallpaper from our recent wallpaper competition:

D21605: Don't give up if no results arrive after 500ms

fvogt marked 2 inline comments as done. fvogt added inline comments. INLINE COMMENTS > broulik wrote in sourcesmodel.h:93 > more like a flags thing :), also `TODO Plasma 6` this way round pls Done differently now. It's not like the added function would've been useful to call from the outside

D21605: Don't give up if no results arrive after 500ms

fvogt updated this revision to Diff 59204. fvogt added a comment. Code duplication is better than polluting the API. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21605?vs=59201=59204 BRANCH Plasma/5.12 REVISION DETAIL

D21593: [showdesktop] Reduce the maximum panel icon size

ngraham added a comment. In D21593#474639 , @ndavis wrote: > I couldn't figure out how to make the widget get the icon from the desktop theme IIRC you have to make it use a PlasmaComponents SVGItem instead of an IconItem (but a #plasma

D21605: Don't give up if no results arrive after 500ms

broulik added a comment. Does that by chance also fix the dictionary runner which does network queries that take a while? INLINE COMMENTS > sourcesmodel.h:93 > + * Clears the model content and resets the runner context, i.e. no new > items appear. > + * Plasma 6 TODO: Replace this

D21605: Don't give up if no results arrive after 500ms

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Currently it resets the entire context if no results appear after 500ms, which means no new results

D21593: [showdesktop] Reduce the maximum panel icon size

ndavis added a comment. In D21593#474637 , @ngraham wrote: > Did the approach of twiddling with the icons not work? I couldn't figure out how to make the widget get the icon from the desktop theme, but I thought the showdesktop and

D21593: [showdesktop] Reduce the maximum panel icon size

ngraham added a comment. Did the approach of twiddling with the icons not work? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21593 To: ndavis, #vdg, #plasma Cc: ngraham, broulik, rikmills, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen,

D21596: [CompactRepresentation] Glow on hover

This revision was automatically updated to reflect the committed changes. Closed by commit R97:445e7203ac99: [CompactRepresentation] Glow on hover (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21596?vs=59180=59186 REVISION DETAIL

D21595: [CompactRepresentation] Glow on hover

This revision was automatically updated to reflect the committed changes. Closed by commit R116:dc37c655aaf7: [CompactRepresentation] Glow on hover (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D21593: [showdesktop] Reduce the maximum panel icon size

ndavis updated this revision to Diff 59181. ndavis added a comment. Add changes to minimizeall as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21593?vs=59175=59181 BRANCH show-desktop-icon (branched from master) REVISION DETAIL

D21596: [CompactRepresentation] Glow on hover

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D21596 To: broulik, #plasma, drosca, #vdg, ndavis Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh,

D21596: [CompactRepresentation] Glow on hover

broulik created this revision. broulik added reviewers: Plasma, drosca, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN pretty trivial, could go into 5.16 REPOSITORY R97 Bluedevil REVISION DETAIL

D21594: Allow media controls and tabs runner in incognito mode for Firefox 67

This revision was automatically updated to reflect the committed changes. Closed by commit R856:e7c353c7f437: Allow media controls and tabs runner in incognito mode for Firefox 67 (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D21595: [CompactRepresentation] Glow on hover

broulik created this revision. broulik added reviewers: Plasma, jgrulich, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. broulik requested review of this revision. TEST PLAN pretty trivial, could go into 5.16

D21593: [showdesktop] Reduce the maximum panel icon size

ndavis added a comment. In D21593#474501 , @rikmills wrote: > This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a

D21593: [showdesktop] Reduce the maximum panel icon size

ndavis added a comment. In D21593#474503 , @broulik wrote: > While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The `iconSizeHints` is there for a

D21593: [showdesktop] Reduce the maximum panel icon size

broulik added a comment. While I'm all for making the show desktop icon stick out less I don't think randomly limiting the size of one particular applet is a good approach. The `iconSizeHints` is there for a reason, defining the maximum size of icons in the panel. REPOSITORY R119 Plasma

D21593: [showdesktop] Reduce the maximum panel icon size

rikmills added a comment. This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this. REPOSITORY R119 Plasma Desktop REVISION

D21594: Allow media controls and tabs runner in incognito mode for Firefox 67

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In Firefox 67 it gained an option to disable extensions in incognito mode similar to how

D21593: [showdesktop] Reduce the maximum panel icon size

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The current size of the showdesktop widget is much larger than it needs to be. This patch

D21569: [Notifications] Don't alter top margin of ThumbnailStrip

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fa74ee535d13: [Notifications] Dont alter top margin of ThumbnailStrip (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21591: Panel: Use bitwise operators on flags

davidedmundson abandoned this revision. davidedmundson added a comment. heh, thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21591 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D21591: Panel: Use bitwise operators on flags

broulik added a comment. `git pull` https://cgit.kde.org/plasma-workspace.git/commit/?id=f6258fa4ec69243fd638251eafeeb10af5e8c66e :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21591 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n,

D21591: Panel: Use bitwise operators on flags

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ! is only for booleans REPOSITORY R120 Plasma Workspace REVISION DETAIL