KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 31 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/31/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Jun 2019 05:00:51 + Build duration: 3 min 19 sec and counting CONSOLE OUTPUT

D21758: ksmserver: Drop internal loading of alternative window managers

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ksmserver's loading of other window manager relies on files in

D21757: [ksmserver] Drop multi X screen support

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We don't support multi X screen anymore in the rest of plasma. Cleans up a

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. Thanks for looking into this :D Past self obviously still had to read the style guide and tried not to change header files. I took your commit cc640cea as an example to resize the

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick updated this revision to Diff 59627. croick marked 5 inline comments as done. croick added a comment. - Fix code style. - Save state of the debug button in a member variable. - Resize the dialog after inserting/removing the debug button. REPOSITORY R871 DrKonqi CHANGES SINCE

D17007: Do hash and hex name based output hashes

romangg updated this revision to Diff 59625. romangg added a comment. Rebase on master. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17007?vs=57751=59625 BRANCH hashOutputNameHash REVISION DETAIL https://phabricator.kde.org/D17007 AFFECTED

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Yeah, only certain people have commit rights. If you stick around for a while and keep submitting good patches, you can become one of those people too. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze,

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis,

D21639: Remove background from scrollbars when hovering on them

This revision was automatically updated to reflect the committed changes. Closed by commit R98:71a9a1f203df: Remove background from scrollbars when hovering on them (authored by mthw, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21639?vs=59614=59616#toc

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. In D21639#478268 , @mthw wrote: > I tried to land this patch but I got this error: > > fatal: remote error: service not enabled: /breeze-gtk > Usage Exception: Push failed! Fix the error and run "arc land"

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I tried to land this patch but I got this error: fatal: remote error: service not enabled: /breeze-gtk Usage Exception: Push failed! Fix the error and run "arc land" again. Could you help me with this? > Very nice first patch. May it be the first of

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Very nice first patch. May it be the first of many! If you'd like an idea for a follow-up patch, here's an idea: make the handles of the non-disappearing scrollbars gray instead blue when unhovered, and make the track only appear on hover, matching the ones in

D21639: Remove background from scrollbars when hovering on them

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, looks perfect now! REPOSITORY R98 Breeze for Gtk BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phabricator.kde.org/D21639 To:

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59614. mthw added a comment. Formating REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59613=59614 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59613. mthw added a comment. Sliders are now grey, and when hovered blue and bigger. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59383=59613 BRANCH breeze-gtk-scrollbar-no-background (branched from

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. I think I see the problem. By making the default color turquoise, the scrollbar is now always turquoise. If we can't perfectly match the Dolphin/QWidgets style where it's gray when inactive and turquoise when active, hovered, or clicked, I think we should leave it

D21748: Replace the excludeRange mode setting when already available

fvogt added a comment. Untested, but looks good. Seems to apply to Plasma/5.12 as well. REPOSITORY R119 Plasma Desktop BRANCH bshah/fix-font-kcm REVISION DETAIL https://phabricator.kde.org/D21748 To: bshah, fvogt, ngraham Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh,

D21748: Replace the excludeRange mode setting when already available

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, it works! REPOSITORY R119 Plasma Desktop BRANCH bshah/fix-font-kcm REVISION DETAIL https://phabricator.kde.org/D21748 To: bshah, fvogt, ngraham Cc: ngraham, plasma-devel,

D21748: Replace the excludeRange mode setting when already available

bshah created this revision. bshah added a reviewer: fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Instead of appending a new entry. BUG: 244857 BUG: 408415 TEST PLAN - remove fonts.conf -

D21747: drop the solid runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ec9709fdd2c0: drop the solid runner (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21747?vs=59599=59600 REVISION DETAIL

D21747: drop the solid runner

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - hasn't been installed for years and no one missed it - not actually ported - using tech we

D21566: Improve label for Disk Monitor widget

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. The panel now is really bad though because the text uses more space than the arrows and the size is probably not accounting for that: before the spacing was largely garbage

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59597. apol added a comment. addressed suggested changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59529=59597 BRANCH apol/startkde REVISION DETAIL https://phabricator.kde.org/D21725 AFFECTED

D21725: Use a native application for starting plasma

apol marked 6 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in startplasma.cpp:82 > Should we also check for executable permission? We don't now and it's not required. I'd aim at not changes in behaviour. > broulik wrote in startplasma.cpp:241 > Would it

D21566: Improve label for Disk Monitor widget

abetts added a comment. +1 on visuals REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21566 To: ngraham, #plasma, #vdg Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

There's this bug report that is potentially related, without any of the plasma protocols involved (AFAIK): https://bugreports.qt.io/browse/QTBUG-76324 Aleix On Tue, Jun 11, 2019 at 3:57 PM Aleix Pol wrote: > > It already has the patch there. > > Here's a full log. >

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

It already has the patch there. Here's a full log. https://phabricator.kde.org/P400 On Tue, Jun 11, 2019 at 1:29 PM Johan Helsing wrote: > > Hi Aleix, > > zero in xdg_toplevel.set_*_size just means the client doesn't care about the > size > > From xdg-shell.xml: > > > If never set, or a value

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

Hi Aleix, zero in xdg_toplevel.set_*_size just means the client doesn't care about the size >From xdg-shell.xml: > If never set, or a value of zero in the request, means that the > client has no expected minimum size in the given dimension. > As a result, a client wishing to reset the minimum

D21112: Support message response and reply callbacks

broulik added a comment. It works just fine in Firefox 67 here. Maybe the documentation is outdated? browser.runtime.sendMessage({foo: "bar"}, callback) works just fine REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21112 To: broulik,

D21566: Improve label for Disk Monitor widget

ngraham added a comment. In the panel, it's not ideal for sure: F6883563: Screenshot_20190611_071207.png However this is a pre-existing bug; all of the monitors have a sub-optimal UI for displaying the legend when in a horizontal format.

D20223: Make disk monitor widget only show real devices by default

davidedmundson added inline comments. INLINE COMMENTS > ConfigGeneral.qml:43 > +if (match_disk) { > +var match_device = > childSource.match(/^disk%2F((sd|vd|hd)\w+)/i); > +if (match_device) { This needs nvme and mmcblk in the

D21745: show details examples in label itself instead of unexpected tooltip

ngraham added a comment. If it used a smaller font, that might help. Gwenview does this, by way of illustration: F6883528: Screenshot_20190611_063851.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21745 To: sitter,

D21552: Update default Samba log path

sitter added a comment. True true. I was thinking with the static path as fall back anyway, just the "extra" loveliness of trying to follow the configured path as a first choice. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D21552 To: ngraham, sitter, #plasma

D21552: Update default Samba log path

This revision was automatically updated to reflect the committed changes. Closed by commit R102:6243a402c926: Update default Samba log path (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21552?vs=59039=59594 REVISION DETAIL

D21552: Update default Samba log path

ngraham added a comment. In D21552#478070 , @sitter wrote: > https://github.com/samba-team/samba/blame/f33749fc84dacb164d1ac43f6bfcae7afcca34b3/packaging/Example/skeleton.tar looks to me like it has been that way for 21 years. I am inclined to

D21552: Update default Samba log path

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. https://github.com/samba-team/samba/blame/f33749fc84dacb164d1ac43f6bfcae7afcca34b3/packaging/Example/skeleton.tar looks to me like it has been that way for 21 years. I am inclined to think

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

I forgot to CC you: https://mail.kde.org/pipermail/plasma-devel/2019-June/098775.html This doesn't look very well: [1743961,992] -> xdg_toplevel@28.set_min_size(0, 0) [1743962,023] -> xdg_toplevel@28.set_max_size(0, 0) Aleix On Tue, Jun 11, 2019 at 9:29 AM Johan Helsing wrote: > > Hi Aleix,

Re: [orca-list] Accessibility in Plasmas new notification system

Hello, A quote from the blog... When an application sets a “default” action, the cursor changes to a pointing hand to indicate that the popup itself is clickable. This needs to be modified if the author wishes to improve the accessibility support. I think we are missing robust and very

Re: [orca-list] Accessibility in Plasmas new notification system

Hey Chrys. Regarding notifications, it should be pretty simple: 1. Give it ROLE_NOTIFICATION 2. Be sure it emits an object:state-changed:showing event 3. Be sure the displayed text is exposed via the accessible text interface, either on the notification itself or in the accessible children

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

Hi Aleix, I would try reproducing it with one of the Qt examples, try the ones in qtbase/examples/widgets for instance. Otherwise, WAYLAND_DEBUG logs might have some clues as to what's happening. Br, Johan Helsing From: Aleix Pol Sent: Monday, June 10, 2019

Re: Accessibility in Plasmas new notification system

Hello, ch...@linux-a11y.org, le jeu. 06 juin 2019 13:45:14 +0200, a ecrit: > maybe a nice side notice for you (and others). We currently work on an > accessibility HIG for KDE. > https://hig.kde.org/accessibility/index.html I have now added it to the list:

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/8/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 11 Jun 2019 10:33:16 + Build duration: 4 min 6 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 11 Jun 2019 10:33:23 + Build duration: 3 min 18 sec and counting CONSOLE OUTPUT

D21642: use even more resizing

This revision was automatically updated to reflect the committed changes. Closed by commit R871:bf5d10ab0946: use even more resizing (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21642?vs=59326=59590 REVISION DETAIL

D11234: [DrKonqi] Show debug button when KDevelop session is running

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. addDebugger seems a bit much, no? Why don't you just have a m_debugButtonInBox member to track whether it is currently added or not? When it is already in the buttonBox running

D21745: show details examples in label itself instead of unexpected tooltip

sitter added a comment. F6883269: Screenshot_20190611_114039.png Doesn't look too hot. Suggestions welcome. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21745 To: sitter, ngraham, #vdg Cc: plasma-devel, LeGast00n,

D21745: show details examples in label itself instead of unexpected tooltip

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the previous UX wasn't good. the label contained a "link" highlight but that link was only a trigger to a tooltip. IOW it behaved

D21648: Ignore power management inhibition in battery critical timeout

This revision was automatically updated to reflect the committed changes. Closed by commit R122:82db1f446966: Ignore power management inhibition in battery critical timeout (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D21725: Use a native application for starting plasma

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in startplasma-wayland.cpp:41 > Indeed. When it's not registered, query > > "org.freedesktop.DBus", > "/org/freedesktop/DBus", > "org.freedesktop.DBus", > "ListActivatableNames" > > (unfortunately no Qt API for that)

D21743: Prefer document.title over sender.tab.title

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the media player is embedded in an iframe TEST PLAN Played a video that was in

D21725: Use a native application for starting plasma

broulik added inline comments. INLINE COMMENTS > fvogt wrote in startplasma-wayland.cpp:41 > AFAICT this won't work as expected: localed is only launched on demand, which > `isServiceRegistered` does not care about. Indeed. When it's not registered, query "org.freedesktop.DBus",