D21785: Don't track subsystem status

This revision was automatically updated to reflect the committed changes. Closed by commit R856:37f48b7e4fde: Don't track subsystem status (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21785?vs=59740&id=59776 REVISIO

D21785: Don't track subsystem status

broulik added a comment. I think in the options page we don't really have a choice since it's a separate page opened by the user when the extension is already running. If we ever do breaking changes in the extension script and need to check it, we can still reintroduce something. REPOSITO

D21794: Style the session selector to be more Breeze

filipf added inline comments. INLINE COMMENTS > SessionButton.qml:51 > +itemDelegate.label: QQC.Label { > +height: contentHeight * 1.2 > +verticalAlignment: Text.AlignVCenter Also, do we need this? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21794: Style the session selector to be more Breeze

filipf added a comment. Awesome, the look of that menu has been a thorn in my side! Code needs some modifications, but it looks great. Can you also apply this patch to KeyboardButton.qml as we've got another QQC menu there? INLINE COMMENTS > SessionButton.qml:48 > +frame: R

D21794: Style the session selector to be more Breeze

apol added a comment. It would be useful if you provide a screenshot of the result so people can assess the change properly. INLINE COMMENTS > SessionButton.qml:48 > +frame: Rectangle { > +color: "#fcfcfc" > +} You're hard-coding colors, this will bre

D21794: Style the session selector to be more Breeze

cblack created this revision. cblack added reviewers: VDG, filipf. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The session selector's menu is now styled to resemble the Breeze theme rather than the default Q

D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

romangg added a comment. I added your diff to a task I created for tracking some improvements to KScreen. Please test out how lid open/closed configs behave with the new code on master branch. Also rebase on current master. Put the additional two fixes you did in separate diffs if t

D21110: On config read adjust outputs positions to global value changes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:2f26bf7fd758: On config read adjust outputs positions to global value changes (authored by romangg). REPOSITORY R104

D16997: [kcm] Expose interface to control output property retention

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:62837af06b2b: [kcm] Expose interface to control output property retention (authored by romangg). REPOSITORY R104 KSc

D16996: Add method to write retention to configuration control files

This revision was automatically updated to reflect the committed changes. Closed by commit R104:06b90b31068e: Add method to write retention to configuration control files (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=59721&id=5

D16995: Consider identical display models in ControlConfig

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:153e6e5fbafa: Consider identical display models in ControlConfig (authored by romangg). REPOSITORY R104 KScreen CHA

D16994: Split Control class into configurations and outputs control classes

This revision was automatically updated to reflect the committed changes. Closed by commit R104:18bc53a34016: Split Control class into configurations and outputs control classes (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=597

D16993: Add a common directory for functionality being used by kcm and daemon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ba9681bfd757: Add a common directory for functionality being used by kcm and daemon (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=5

D16992: Introduce secondary control channel of the KScreen daemon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:466c278f9bef: Introduce secondary control channel of the KScreen daemon (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=59715&id=5975

D16991: Introduce concept of global and individual output data retention

This revision was automatically updated to reflect the committed changes. Closed by commit R104:979e43f99be4: Introduce concept of global and individual output data retention (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16991?vs=59662&

D16990: [kded] Separate configuration storage path

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:a17ccc22c886: [kded] Separate configuration storage path (authored by romangg). REPOSITORY R104 KScreen CHANGES SIN

D16989: [kded] Introduce Config wrapper class

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:9e34fd814f90: [kded] Introduce Config wrapper class (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LA

D21785: Don't track subsystem status

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Indeed unused, but I wonder whether doing it explicitly in D21113 is prettier... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://p

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59752. apol marked an inline comment as done. apol added a comment. Address xrdb call as suggested by David REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59693&id=59752 BRANCH apol/startkde REVISION

D21725: Use a native application for starting plasma

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in startplasma.cpp:34 > old code killed ksplash when we showed a message Now we will return, which will get KSplash out of scope and kill the process upon destruction. See KillBeforeDeleter

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. So um, any chance we can move forward with this in some capacity? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein Cc: mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast

D21134: [Notifications] Tweak paddings

ngraham updated this revision to Diff 59743. ngraham marked an inline comment as done. ngraham added a comment. Fix RTL paddings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21134?vs=59741&id=59743 BRANCH arcpatch-D21134 REVISION DETAIL htt

D21134: [Notifications] Tweak paddings

ngraham marked 2 inline comments as done. ngraham added a comment. All right, I *think* I've addressed the review comments and implemented something as close to @alex-l's design as I can get it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To: ngra

D21725: Use a native application for starting plasma

davidedmundson added a comment. Two minor things and then this is good to go. INLINE COMMENTS > startplasma.cpp:34 > + > +void messageBox(const QString &text) > +{ old code killed ksplash when we showed a message > startplasma.cpp:123 > +const QString localerc(configDir + QLatin1String(

D21134: [Notifications] Tweak paddings

ngraham updated this revision to Diff 59741. ngraham added a comment. Address review comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21134?vs=59731&id=59741 BRANCH arcpatch-D21134 REVISION DETAIL https://phabricator.kde.org/D21134 AF

D21785: Don't track subsystem status

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY So far it was unused and we typically just read the user's preferences rather than checking what

D21112: Support message response and reply callbacks

broulik planned changes to this revision. broulik added a comment. Ok, I have an idea. `browser.runtime.sendMessage` (Firefox) returns a promise that is fulfilled when a reply is sent. Chrome instead uses a callback function in `chrome.runtime.sendMessage` I'm gonna rework the `sendMessag

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

kossebau created this revision. kossebau added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Removed in e914e6323277f7963334897410bd9b7f8341f2ed

D21134: [Notifications] Tweak paddings

ngraham updated this revision to Diff 59731. ngraham added a comment. Rebase in preparation for resuming work on this REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21134?vs=57885&id=59731 BRANCH arcpatch-D21134 REVISION DETAIL https://phabri

D21134: [Notifications] Tweak paddings

GB_2 added a comment. In D21134#478796 , @alex-l wrote: > Just a mockup but is this middle ground solution good enough? I absolutely love it! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To: ng

D21134: [Notifications] Tweak paddings

dos added a comment. In D21134#478796 , @alex-l wrote: > Just a mockup but is this middle ground solution good enough? Yeah, it looks much better than what's currently in 5.16. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D21743: Prefer document.title over sender.tab.title

This revision was automatically updated to reflect the committed changes. Closed by commit R856:01a8fa605459: Prefer document.title over sender.tab.title (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21743?vs=59580&id

D21779: Resolve X-Flatpak-RenamedFrom

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9258ef586324: [Notifications] Resolve X-Flatpak-RenamedFrom (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21779?vs=59725&id=59726

D21779: Resolve X-Flatpak-RenamedFrom

broulik updated this revision to Diff 59725. broulik added a comment. - Do it manually, thanks @sitter REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21779?vs=59713&id=59725 REVISION DETAIL https://phabricator.kde.org/D21779 AFFECTED FILES li

D21110: On config read adjust outputs positions to global value changes

romangg updated this revision to Diff 59723. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21110?vs=59671&id=59723 BRANCH 1controlAdjustPositions REVISION DETAIL https://phabricator.kde.org/D21110 AFFECTED FILES kded/output

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 59722. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=59670&id=59722 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp co

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 59721. romangg added a comment. Fix newline CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=59719&id=59721 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED FILES common/control.cpp common/control

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 59719. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=59669&id=59719 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED FILES common/control.cpp

D16995: Consider identical display models in ControlConfig

romangg updated this revision to Diff 59718. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16995?vs=59667&id=59718 BRANCH 1controlNameSpecific REVISION DETAIL https://phabricator.kde.org/D16995 AFFECTED FILES common/control

D16994: Split Control class into configurations and outputs control classes

romangg updated this revision to Diff 59717. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=59665&id=59717 BRANCH 1controlClass REVISION DETAIL https://phabricator.kde.org/D16994 AFFECTED FILES common/control.cpp

D16993: Add a common directory for functionality being used by kcm and daemon

romangg updated this revision to Diff 59716. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=59664&id=59716 BRANCH 1commonInterfacesWithClass REVISION DETAIL https://phabricator.kde.org/D16993 AFFECTED FILES common/c

D21779: Resolve X-Flatpak-RenamedFrom

sitter added a comment. if (!service) { const QString desktopId = desktopEntry + QLatin1String(".desktop"); const auto services = KServiceTypeTrader::self()->query(QStringLiteral("Application"), QStringLiteral("

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 59715. romangg added a comment. - Fix newline at end of files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=59714&id=59715 BRANCH 1controlRetention REVISION DETAIL https://phabricator.kde.org/D16992 AFFECTED FILES kded/CMakeLis

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 59714. romangg added a comment. - Root dictionary in control files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=59663&id=59714 BRANCH 1controlRetention REVISION DETAIL https://phabricator.kde.org/D16992 AFFECTED FILES kded/CMa

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. I leave the text as is for now. Let's discuss next week at Plasma Sprint. I would like to see that the last bits of QWidgets get removed in the KCM as well. This could be done together then. Also as I said earlier having retention control per output is too co

D21779: Resolve X-Flatpak-RenamedFrom

zzag added inline comments. INLINE COMMENTS > notification_p.h:53 > > +static KService::Ptr serviceForDesktopEntry(const QString &desktopEntry); > + A bit off topic: is there any point for making this method static? You could get away with making serviceForDesktopEntry function static in

D21779: Resolve X-Flatpak-RenamedFrom

broulik created this revision. broulik added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When an application got renamed by flatpak-builder without knowing it, it will still send

D17007: Do hash and hex name based output hashes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:5e1934de3bbb: Do hash and hex name based output hashes (authored by romangg). REPOSITORY R110 KScreen Library CHANG

D10750: wayland: Add support for zwp_linux_dmabuf

meven added a comment. In D10750#327333 , @zzag wrote: > Any update on this? I am wondering as well. This seems like good progress was already done and what is left is some test fixes and polish. I can only encourage @fredrik and good