Re: KInit - Current state and benchmarks

El dilluns, 17 de juny de 2019, a les 11:56:15 CEST, David Edmundson va escriure: > Results: > (Showing the median out of 5 runs on a mid range SSD desktop) Are we sure it's fair to assume people have SSD? our of the 4 laptops i own, only 2 have SSD. Do you think it's worth me trying in one of

D21860: Set a font for gtk applications in the fonts kcm

gikari planned changes to this revision. gikari added a comment. In D21860#481258 , @broulik wrote: > Messing with GTK settings INI files from various places is not a good idea imho. Also, this approach doesn't work on Wayland. Ideally, we had a

D21877: Hide tooltip when PrivateActionToolButton is pressed

cblack created this revision. cblack added reviewers: Plasma, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The tooltip used to remain even as the button was pressed, now it doesn't/shouldn't.

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481322 , @mthw wrote: > I would say the default theme in gtk: Adwaita Thank you! That theme does not have border at all! Hahhh)))

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481314 , @vzapod wrote: > In D21869#481305 , @mthw wrote: > > > Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481317 , @ngraham wrote: > Adding some before-and-after images to the Test Plan section would help since I'm still not totally sure what the issue actually is. There is no difference, I suppose. If the

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. Adding some before-and-after images to the Test Plan section would help since I'm still not totally sure what the issue actually is. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg Cc:

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481305 , @mthw wrote: > Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough. Do you know what border does? Or gtk 2 is to old for you?

D21869: Border for "separator_menu_item" should be 0

mthw accepted this revision. mthw added a comment. This revision is now accepted and ready to land. Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough. On the other hand, I only made one code change before, so I don't think, I

Re: KInit - Current state and benchmarks

Thanks for the very interesting and useful research! On Monday, 17 June 2019 11:56:15 CEST David Edmundson wrote: > From API.kde.org: > >Using kdeinit to launch KDE applications makes starting a typical KDE > >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) > Certainly

D21860: Set a font for gtk applications in the fonts kcm

broulik added a comment. Messing with GTK settings INI files from various places is not a good idea imho. Also, this approach doesn't work on Wayland. Ideally, we had a daemon that monitors all settings and applies them in a central place, so the settings knobs could be where they belong.

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. So when this lands I guess we need to remove the font option from the GTK KCM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21860: Set a font for gtk applications in the fonts kcm

ngraham added a comment. There is no visual change. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #vdg, #plasma Cc: abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. Also other themes have some other variants of separator-menu-item, for example https://git.enlightenment.org/themes/detourious.git/tree/gtk/detourious/gtk-2.0/menu.rc?id=43e66ceaf5ffdd6293bca110643aaad731afc285#n121 REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D21554: Allow setting fullscreen via MPRIS

This revision was automatically updated to reflect the committed changes. Closed by commit R856:23d978c0ee17: Allow setting fullscreen via MPRIS (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21554?vs=59049=59993#toc REPOSITORY R856 Plasma Browser Integration

D21869: [RFC] Change border for "separator_menu_item" line-h.png

ngraham added a comment. I don't know, sorry. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21869: [RFC] Change border for "separator_menu_item" line-h.png

vzapod added a comment. In D21869#481220 , @ngraham wrote: > "Edit Revision, which is on the sidebar in the top-right, or under the Actions hamburger menu in the top-right. I know how to do it. But really have you read

D21869: [RFC] Change border for "separator_menu_item" line-h.png

ngraham added reviewers: Breeze, mthw, gepardo, jackg. ngraham added a comment. Vlad is saying that this patch's description section needs a short explanation describing why the change is necessary. You can do this by clicking "Edit Revision, which is on the sidebar in the top-right, or

D21872: Translate keyboard layouts in sddm

ngraham added a comment. In D21872#481173 , @McPain wrote: > In D21872#481154 , @davidedmundson wrote: > > > It might be better to do it in > > > > XkbKeyboardBackend.cpp:184 in SDDM which is

D21856: [Task manager] Use consistent menu items for "pin/unpin" actions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:af9a794695c7: [Task manager] Use consistent menu items for pin/unpin actions (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21873: search lib paths for boltd for debian systems

This revision was automatically updated to reflect the committed changes. Closed by commit R1044:501110b1c9ea: search lib paths for boltd for debian systems (authored by sitter). REPOSITORY R1044 Plasma Thunderbolt Integration CHANGES SINCE LAST UPDATE

D21797: do not set a hardcoded minimum size

sitter added a comment. Oh, FWIW, I am not sure if defaulting to 16:9 on the report dialog is actually all that awesome, it seems to cause an exhaustive amount of empty space for the most part. Opinions welcome. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797

D21797: do not set a hardcoded minimum size

sitter updated this revision to Diff 59989. sitter added a comment. expand diff based on additional pondering - both dialogs now throw away their minimum size - the resize calls are gone too - instead we now calculate a 16:9 size based off of the sizeHint and resize to that (keeps

D19011: Thunderbolt KCM and KDED module

dvratil abandoned this revision. dvratil added a comment. The code has been moved to a standalone plasma-thunderbolt repository, passed through kde-review and will be included in Plasmas 5.17 release. Thanks everyone for your feedback and comments! REPOSITORY R119 Plasma Desktop

D21873: search lib paths for boltd for debian systems

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R1044 Plasma Thunderbolt Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D21873 To: sitter, dvratil Cc: plasma-devel, LeGast00n,

D21872: Translate keyboard layouts in sddm

McPain added a comment. In D21872#481154 , @davidedmundson wrote: > It might be better to do it in > > XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from. I don't see any matching files in sddm REPOSITORY R120

D21872: Translate keyboard layouts in sddm

davidedmundson added a comment. It might be better to do it in XkbKeyboardBackend.cpp:184 in SDDM which is where the model comes from. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 To: McPain, ngraham Cc: davidedmundson, plasma-devel,

D21873: search lib paths for boltd for debian systems

sitter created this revision. sitter added a reviewer: dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY on ubuntu 0.5 the path may be usr/lib/$archtriplet/boltd or usr/lib/bolt/boltd depending on the

D21872: Translate keyboard layouts in sddm

McPain added a comment. F6901033: изображение.png F6901031: изображение.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 To: McPain, ngraham Cc: plasma-devel, LeGast00n,

KInit - Current state and benchmarks

>From API.kde.org: >Using kdeinit to launch KDE applications makes starting a typical KDE >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) Certainly sounds like a good thing. ===The current State=== ==Plasma== * Apps launched from the plasma menu skip klauncher and

D21872: Translate keyboard layouts in sddm

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 AFFECTED FILES sddm-theme/KeyboardButton.qml To: McPain Cc:

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

sitter added a comment. I would actually note that the file should be `0_kde_settings.conf` (assuming/hoping sddm orders the configs) otherwise a user can manually create `best_config.conf` and get overridden by what was set in the KCM what with `k` being loaded after `b`. REPOSITORY

D21860: Set a font for gtk applications in the fonts kcm

abetts added a comment. How does this look? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #vdg, #plasma Cc: abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21797: do not set a hardcoded minimum size

sitter added a comment. In D21797#479670 , @cfeck wrote: > so its minimum size is its minimum with and its minimum height Sure, unless the Policy is Minimum/MinimumExpanding, which I think it would need to be in our case when wrapping is

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

fvogt added a comment. I argued in https://bugs.kde.org/show_bug.cgi?id=386241 that this is the wrong way. Any reason you implemented this anyway? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham,

D21347: [Night Light KCM] Display the kcm on X11 platform

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b60fffd0b1df: [Night Light KCM] Display the kcm on X11 platform (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21347?vs=58495=59980

D21346: [libcolorcorrect] Allow color correction on X

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e8ff23cfe81e: [libcolorcorrect] Allow color correction on X (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21346?vs=58494=59979

D21869: [RFC] Change border for "separator_menu_item" line-h.png

vzapod added a comment. Can you add it yourself? Or propose a name for me. Besides that you should understand that I know nothing about themes and pixmap engine. Can you tell me if all 0s are good thing? Should not it me something connected with line-h.png size? Can you say that 1, 1, 1, 1

D21869: [RFC] Change border for "separator_menu_item" line-h.png

zzag added a comment. Can you add some meaningful commit message? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,