D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481572 , @beischer wrote: > That doesn't look right to me? Maybe because TouchpadConfigContainer::kcmInit() is a no-op (first because the mode is Unset, so neither of the two if branches triggers, but even if

D21890: Simplify KSplash

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.cpp:51 > } > QFile outFile(QStringLiteral("/tmp/ksplash")); > outFile.open(QIODevice::WriteOnly | QIODevice::Append); Maybe this wouldn't be necessary

D21891: [wallpapers] Port away from deprecated function

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN No warning REPOSITORY R120 Plasma Workspace BRANCH davidedmundson/ksession

D21852: [interactiveconsole] Fix initial load selection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:15de7ceb3875: [interactiveconsole] Fix initial load selection (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21890: Simplify KSplash

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Forking and printing a PID gains nothing. The new startplasma script

D19011: Thunderbolt KCM and KDED module

ngraham added a subscriber: jriddell. ngraham added a comment. I guess you'll have to wait for 5.17 for that, unless @jriddell wants to oblige. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: jriddell, pino, zzag,

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. In D21884#481568 , @romangg wrote: > Ok, that would be even better. Only drawback is then that it shows the "wrong" interface in case libinput is used until a touchpad is plugged, but that's such an uncommon case that

D19011: Thunderbolt KCM and KDED module

asturmlechner added a comment. In D19011#480868 , @ngraham wrote: > and we should lobby distros to ship with the new repo/package. Provide a tarball and I'll gladly turn our git master ebuild into a release ebuild. ;) REPOSITORY R119

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481567 , @beischer wrote: > Roman, with this patch the box with 'No touchpad found' is shown under X11, too: > > F6907948: no_touchpad.png > > Since I'm not the

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. Roman, with this patch the box with 'No touchpad found' is shown under X11, too: F6907948: no_touchpad.png Since I'm not the author of the code my intention was to fix the bug with as little side effects as possible.

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. On Wayland it shows a message that no touchpad is connected. Would it be possible on X to determine if a to-be-connected touchpad would use libinput or Xlib (although the use case is pretty rare of a detechable touchpad)? REPOSITORY R119 Plasma Desktop BRANCH

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, so we show a backend that will do nothing instead? That doesn't sound like the right long term approach. Will do for backporting into stable. REPOSITORY R119

D21884: [Touchpad KCM] Do not crash in case there is no touchpad.

beischer created this revision. beischer added reviewers: ngraham, romangg, atulbi, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. beischer requested review of this revision. REVISION SUMMARY Fixes bug #4083250. REPOSITORY R119 Plasma Desktop BRANCH

D21829: Improved Touch support for Kickoff

davidedmundson added inline comments. INLINE COMMENTS > KickoffListView.qml:142 > +if (item.appView) { > +if (mouse.source == > Qt.MouseEventSynthesizedByQt) { > +positionChanged(mouse); why do we need this? >

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/24/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 16:50:35 + Build duration: 6 min 21 sec and counting JUnit Tests

D21883: give kpasswordlineedit strong focus

sitter abandoned this revision. sitter added a comment. Actually this is a bit daft. I'll have a look at changing KPasswordLineEdit instead. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21883 To: sitter Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

KDE CI: Plasma » libksysguard » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/stable-kf5-qt5%20SUSEQt5.12/18/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 16:49:51 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS

D21605: Don't give up if no results arrive after 500ms

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R112:c918c2840bcb: Dont give up if no results arrive after 500ms (authored by fvogt). REPOSITORY R112 Milou CHANGES

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/26/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 18 Jun 2019 16:50:37 + Build duration: 4 min 23 sec and counting JUnit Tests

KDE CI: Plasma » kwrited » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwrited/job/stable-kf5-qt5%20SUSEQt5.12/14/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 16:50:22 + Build duration: 3 min 47 sec and counting JUnit Tests Name:

D21883: give kpasswordlineedit strong focus

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY otherwise it can't get tabbed into using the keyboard. BUG: 398275 FIXED-IN: 5.16.2 CHANGELOG: The password input can now be

D21881: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:951551bc6d1a: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21881?vs=60020=60023#toc REPOSITORY R120

D21881: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Not a fan of treating the pid like a bool in conditionals, looks lovely other than that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21881 To:

D21852: [interactiveconsole] Fix initial load selection

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.16 please REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21852 To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel,

D21872: Translate keyboard layouts in sddm

pshinjo added a comment. In D21872#481400 , @davidedmundson wrote: > > These translations doesn't belong to sddm > > why do they belong here and not SDDM? Searching for the translation catalog name shows that it is managed by

D21881: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment

broulik created this revision. broulik added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is a similar situation we have with Flatpak when the desktop entry the application

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60018. steffenh added a comment. - Drag icon now follows the touch point - to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left REPOSITORY R119 Plasma

Plasma 5.16.1

Plasma 5.16.1 sources are now released and available to packagers with a few bug fixes from the last week. https://kde.org/announcements/plasma-5.16.1.php

D21877: Hide tooltip when PrivateActionToolButton is pressed

ngraham added subscribers: mart, ngraham. ngraham accepted this revision. ngraham added a reviewer: mart. ngraham added a comment. This revision is now accepted and ready to land. @mart? REPOSITORY R169 Kirigami BRANCH hide-tooltip-on-card-action-trigger (branched from master) REVISION

Re: KInit - Current state and benchmarks

> Are we sure it's fair to assume people have SSD? our of the 4 laptops i own, > only 2 have SSD. It's at least safe to assume it's the trend moving forward. > Do you think it's worth me trying in one of the two that don't have SSD? More data is normally a good thing. If you or anyone else

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/25/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 09:39:30 + Build duration: 22 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/25/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 18 Jun 2019 09:37:03 + Build duration: 14 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kwrited » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwrited/job/stable-kf5-qt5%20SUSEQt5.12/13/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 09:37:56 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Plasma » libksysguard » stable-kf5-qt5 SUSEQt5.12 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/stable-kf5-qt5%20SUSEQt5.12/17/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 09:38:31 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/23/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Jun 2019 09:37:03 + Build duration: 4 min 1 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/10/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Jun 2019 09:36:40 + Build duration: 3 min 33 sec and counting CONSOLE

D21872: Translate keyboard layouts in sddm

davidedmundson added a comment. > These translations doesn't belong to sddm why do they belong here and not SDDM? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 To: McPain, ngraham, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh,

D21872: Translate keyboard layouts in sddm

McPain added a comment. In D21872#481213 , @ngraham wrote: > In D21872#481173 , @McPain wrote: > > > In D21872#481154 , @davidedmundson wrote: > > > >

D21860: Set a font for gtk applications in the fonts kcm

nicolasfella added a comment. > but dependency on gtk API disturbs me. plasma-pa also depends on GSettings, so it's not unprecedented REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: nicolasfella, broulik, GB_2, abetts,

D21860: Set a font for gtk applications in the fonts kcm

broulik added a comment. In D21860#481346 , @gikari wrote: > However gsettings does, but dependency on gtk API disturbs me. I think that's only a problem if every KCM ends up depending on GTK. If it's a dedicated proxy service binary,