KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 179 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/179/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Jun 2019 03:27:48 + Build duration: 2 min 12 sec and counting CONSOLE OUTPUT [...truncated 130

D21915: Fix crash in the touchpad kded

aacid added a comment. The other question is if "enabled" was ever the correct atom to check for In my system the atoms names are libinput Send Events Mode Enabled libinput Send Events Mode Enabled Default libinput Send Events Modes Available libinput Left Handed Enabled Default

D21915: Fix crash in the touchpad kded

aacid updated this revision to Diff 60091. aacid added a comment. -mutable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21915?vs=60090=60091 BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21915 AFFECTED FILES

D21915: Fix crash in the touchpad kded

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY My libinput touchpad doesn't have an enabled atom so doing *m_atoms[QLatin1Literal("enabled")].data() and then using that

Re: Accessibility in Plasmas new notification system

On torsdag 6. juni 2019 13.55.49 CEST Samuel Thibault wrote: > Hello, > > ch...@linux-a11y.org, le jeu. 06 juin 2019 13:45:14 +0200, a ecrit: > > maybe a nice side notice for you (and others). We currently work on an > > accessibility HIG for KDE. > > https://hig.kde.org/accessibility/index.html

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham added inline comments. INLINE COMMENTS > broulik wrote in calculator.qml:42 > Maybe just fixing this to be `units.gridUnit` times some larger value could > fix the initial sizing I tried that earlier, but while it works for the expanded version when the widget is in the panel, it

Re: KInit - Current state and benchmarks

El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va escriure: > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i > > own, only 2 have SSD. > > It's at least safe to assume it's the trend moving forward. > > > Do you think it's worth me trying in one

D21811: [Calculator] Fix popup size and minimum size for expanded version

broulik added inline comments. INLINE COMMENTS > calculator.qml:42 > > width: units.gridSize * 3 > height: units.gridSize * 4 Maybe just fixing this to be `units.gridUnit` times some larger value could fix the initial sizing REPOSITORY R114 Plasma Addons REVISION DETAIL

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7127724309a: [Touchpad KCM] Do not crash in case there is no touchpad (authored by beischer, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21884?vs=60026=60077#toc

D21909: [Colors KCM] Assign properties in a binding

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Save the previous value in a variable outside the binding and then assign the new ones to ensure

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. Doing it! REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh,

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Nothing. Same will happen for example when users click on an event from the Holidays or Astronomical Events calendar plugins as there are no viewers for those events and KOrganizer can only open events provided by the PIM plugin. As far as I know, the agenda

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg accepted this revision. romangg added a comment. Yes, let's do that. Add a comment to the code that we fallback to evdev for now if no touchpad is connected and we want to show instead libinput in the future when the issues have been resolved. REPOSITORY R119 Plasma Desktop

D21905: [Digital Clock] Open KOrganizer with event details on click

ngraham added a comment. What happens when KOrganizer isn't installed? Also, what about the other clocks? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: dvratil, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Note that this depends on API that will be available first in KDE Frameworks 5.60, so this

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 60061. sitter added a comment. cleanup try 3 REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19612?vs=60060=60061 BRANCH webservice REVISION DETAIL https://phabricator.kde.org/D19612 AFFECTED FILES

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 60060. sitter added a comment. diff cleanup try 2 REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19612?vs=60059=60060 BRANCH webservice REVISION DETAIL https://phabricator.kde.org/D19612 AFFECTED FILES

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 60059. sitter added a comment. clean up diff maybe? REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19612?vs=60058=60059 BRANCH webservice REVISION DETAIL https://phabricator.kde.org/D19612 AFFECTED FILES

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 60058. sitter added a comment. - refactor - move clients to subdir - catch all exceptions - don't incorrectly init the static - cleanup includes - more tests and less asserts - litter-- - split commands - throw out a whole bunch of warnings

Re: KInit - Current state and benchmarks

On Tue, Jun 18, 2019 at 12:05 PM David Edmundson wrote: > > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i > > own, only 2 have SSD. > > It's at least safe to assume it's the trend moving forward. > > > Do you think it's worth me trying in one of the two that don't

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 34 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/34/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 19 Jun 2019 12:22:57 + Build duration: 7 min 6 sec and counting CONSOLE OUTPUT

D21895: print a warning when invoking the scripting API's sleep()

sitter added a comment. Legacy from Plasma1 I'd guess. We could make it noop and drop it for 6.x IMO, I'm not sure if we want to change behavior halfway though 5.x though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc:

D21895: print a warning when invoking the scripting API's sleep()

davidedmundson added a comment. Why does this even exist? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21829: Improved Touch support for Kickoff

steffenh added inline comments. INLINE COMMENTS > ngraham wrote in KickoffListView.qml:142 > Probably so click-and-hold doesn't trigger these behaviors when not using a > touchscreen. This is the Fix for Bug: 406361 In the appView the listView.currentItem will get open, but

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham accepted this revision. ngraham added a comment. Shall we land this now and refine the behavior later? REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma,

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. > 1. Controls not disabled > 2. "Two-finger-tap" radio buttons are missing their labels > 3. Middle-click label missing its radio buttons > > And then of course, unrelated to this patch or bug, is https://bugs.kde.org/show_bug.cgi?id=407464 Yes, thats

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481795 , @zzag wrote: > Pixbuf engine prints that warning because sum of top and bottom border is greater than the height of line-h.png. The most interesting part is that pixbuf engine tries to adjust borders,

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. @zzag Right now we have a critical lack of manpower for Breeze GTK, so any assistance in reviewing patches is greatly appreciated. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg,

D21869: Border for "separator_menu_item" should be 0

zzag added a comment. I don't like how this patch was reviewed. The underlying problem wasn't fully understood. If an application crashes, then the backtrace is required. I don't see it in the bug report. > (seq64:25899): WARNING **: 09:40:24.716: Invalid borders specified for theme

D21895: print a warning when invoking the scripting API's sleep()

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the sleep is implemented with a nested event loop which may result in segfaults when something in

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. I landed this in master only because I don't have 100% confidence in it because I don't fully understand the underlying issue. I tested it as working, but to me "tested, but don't fully understand the underlying issue" means master-only. Feel free to bug your

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481766 , @mthw wrote: > We can only affect what goes into Stable (5.16) and what goes into Trunk (master), we cannot tell Debian team what package versions they should use. But there is also debian

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481761 , @vzapod wrote: > In D21869#481760 , @mthw wrote: > > > Could this also land in Plasma/5.16? It's a crash fix after all. > > > Yeah, it should also land

D21890: Simplify KSplash

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bc35571901c: Simplify KSplash (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21890?vs=60032=60046 REVISION DETAIL

D21891: [wallpapers] Port away from deprecated function

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9d444358c291: [wallpapers] Port away from deprecated function (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21869: Border for "separator_menu_item" should be 0

vzapod added a comment. In D21869#481760 , @mthw wrote: > Could this also land in Plasma/5.16? It's a crash fix after all. Yeah, it should also land in Debian. And as fast as possible... For example I use Debian 10 with Gnome... Somebody

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. Could this also land in Plasma/5.16? It's a crash fix after all. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg, ngraham Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. Thanks again for the patch! May it be the first of many. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg, ngraham Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21869: Border for "separator_menu_item" should be 0

This revision was automatically updated to reflect the committed changes. Closed by commit R98:71eed8b3ad50: Border for separator_menu_item should be 0 (authored by vzapod, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. Thanks, that's what I was looking for. Please edit the Description section to add some of that information. For testing, I could not detect any regressions with a variety of GTK apps (gtk3-demo, Firefox, Inkscape, GIMP). REPOSITORY R98 Breeze for Gtk

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481734 , @ngraham wrote: > - A clear description of the problem to be solved, if this patch does not result in visual changes Sequencer64 crashes with the following message: (seq64:25899): WARNING

D21869: Border for "separator_menu_item" should be 0

ngraham added a comment. It's still not clear to me what this actually fixes. Can someone provide one of the following: - Before-and-after screenshots, if this patch results in visual changes - A clear description of the problem to be solved, if this patch does not result in

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. In D21884#481680 , @romangg wrote: > What does not look right to you there? Are the controls greyed out? 1. Controls not disabled 2. "Two-finger-tap" radio buttons are missing their labels 3.

D21829: Improved Touch support for Kickoff

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in KickoffListView.qml:142 > why do we need this? Probably so click-and-hold doesn't trigger these behaviors when not using a touchscreen. REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL