D10750: wayland: Add support for zwp_linux_dmabuf

2019-06-23 Thread Fredrik Höglund
fredrik added inline comments. INLINE COMMENTS > zzag wrote in abstract_egl_backend.cpp:427 > What's holding us from doing that? We would need to create a separate EGL image and a separate texture for each plane. The scene would need to bind each of those textures to separate texture binding

D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When an application got renamed by flatpak-builder without knowing it, it will still send

D22011: Add MenuSeparator

2019-06-23 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R858:6eb266c3d4fc: Add MenuSeparator (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22011?vs=60433=60528 REVISION

D21935: [devicenotifier] Hide plasmoid if no device is available

2019-06-23 Thread Nathaniel Graham
ngraham added a subscriber: mart. ngraham added a comment. @nicolasfella and I were discussing with someone else (@mart maybe?) redoing the System Tray configuration pages to collapse the General and Entries pages into a single list that displays Configure buttons for the configurable

D21954: Handle Gimp 2.10

2019-06-23 Thread Diego Marino
dmarino added a comment. [Mapping] Gimp-2.10=org.gimp.GIMP This is required to solve the same issue for the flatpak package. Is there a way to reconcile both workarounds? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

2019-06-23 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY `TaskGroupingProxyModel::requestToggleMaximized` now uses this to minimize and restore groups of windows

D21999: [WIP] Make highlights similar to Kickoff highlight

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. I guess we should just keep this revision closed due to `arc` sadness, and submit the final branch once it's all done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21999 To: ndavis, #breeze, #vdg, #plasma Cc: filipf, ngraham, plasma-devel,

D20908: RFC: Redesign QML applet configuration windows

2019-06-23 Thread Marco Martin
mart added a comment. In D20908#485103 , @filipf wrote: > Preview of a highlight style in line with what's being discussed in T11124 : > > F6927189: image.png > >

D21999: [WIP] Make highlights similar to Kickoff highlight

2019-06-23 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:b61b97dc6b5b: Make context menu highlight similar to Kickoff highlight (authored by ndavis, committed by mart).

D22039: Start sending download updates again when resuming a download

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:ae8fab32f84b: Start sending download updates again when resuming a download (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D22037: [Notifications] Don't show remaining time when job is paused

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:48da3382b2bf: [Notifications] Dont show remaining time when job is paused (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c26fd34c7d60: [Notifications] Make popup placement more resilient (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22048: [Notifications] Don't keep non-configurable notifications in history

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f6050b1740c: [Notifications] Dont keep non-configurable notifications in history (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22017: [Notifications] Let plasmashell be the only true owner of notification and job tracker services

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:52bec414aefa: [Notifications] Let plasmashell be the only true owner of notification and job… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22046: Make feedback-related strings accurate

2019-06-23 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:5ff03a6be245: Make feedback-related strings accurate (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22046?vs=60495=60515

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Kai Uwe Broulik
broulik updated this revision to Diff 60510. broulik added a comment. - Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22045?vs=60509=60510 REVISION DETAIL https://phabricator.kde.org/D22045 AFFECTED FILES

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Kai Uwe Broulik
broulik updated this revision to Diff 60509. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - get rid of `Qt.callLater` - Fix (work around) issue when dialog contents arent ready yet REPOSITORY R120 Plasma Workspace

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. Much better, but it still has one callLater which I don't like. Time for Dialog2! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22045 To: broulik, #plasma, #vdg, ngraham,

D21999: [WIP] Make highlights similar to Kickoff highlight

2019-06-23 Thread Nathaniel Graham
ngraham reopened this revision. ngraham added a comment. Not actually closed; Phab just failed to notice that this went to a WIP branch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21999 To: ndavis, #breeze, #vdg, #plasma Cc: filipf, ngraham, plasma-devel,

D10750: wayland: Add support for zwp_linux_dmabuf

2019-06-23 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:438-439 > +EGL_DMA_BUF_PLANE0_PITCH_EXT, EGLint(planes[0].stride), > +EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT, EGLint(planes[0].modifier & > 0x), > +EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT,

D21829: Improved Touch support for Kickoff

2019-06-23 Thread Marco Martin
mart added a comment. not entering in the code yet, i'm ok with it as a general UX behavior REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein, ngraham Cc: mart, sbergeron, davidedmundson, ngraham,

D10750: wayland: Add support for zwp_linux_dmabuf

2019-06-23 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:427 > + > +// FIXME: Add support for multi-planar images > +if (planes.count() != 1) What's holding us from doing that? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: romangg,

D22048: [Notifications] Don't keep non-configurable notifications in history

2019-06-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, if an app can't bother to set this stuff properly for itself, then it's either not very important or doesn't deserve to be in the history. Works perfectly. REPOSITORY R120 Plasma

D22048: [Notifications] Don't keep non-configurable notifications in history

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY If a notification isn't configurable (e.g. because the application doesn't set a

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. Stable branch please REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22045 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22045 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh,

D22046: Make feedback-related strings accurate

2019-06-23 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, nicolasfella, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Prior strings were inaccurate (I was the one who changed it, sorry about that)

D22045: [Notifications] Make popup placement more resilient

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The popup width is fixed, so don't rely on the actual dialog window width which might be

D21999: [WIP] Make highlights similar to Kickoff highlight

2019-06-23 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:df5ab1bfa328: Make context menu highlight similar to Kickoff highlight (authored by ndavis). CHANGED PRIOR TO COMMIT

D22035: Port FolderView to ContainmentLayoutManager plugin

2019-06-23 Thread Marco Martin
mart updated this revision to Diff 60493. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60461=60493 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035 AFFECTED FILES

D22035: Port FolderView to ContainmentLayoutManager plugin

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. Works perfectly with my testing on using both a pointing device and touchscreen. The touchscreen use case in particular is hugely improved. I'm not an expert on this code, but it looks pretty sane to me on read-through. INLINE COMMENTS > main.qml:322 > +/* >

D21991: Add X-KDE-ParentApp entries in metadata.desktop

2019-06-23 Thread Bhushan Shah
bshah abandoned this revision. bshah added a comment. I've reverted this change now and have come up with more nicer solution in kpackagetool5, will open PR for it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21991 To: bshah, apol, ngraham Cc: broulik,

D22044: Fix a Qml warning

2019-06-23 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R102:71dbbbeb64a1: Fix a Qml warning (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22044?vs=60486=60487 REVISION DETAIL

D22044: Fix a Qml warning

2019-06-23 Thread Méven Car
meven created this revision. meven added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Fix a bad reference REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car
meven updated this revision to Diff 60485. meven added a comment. Remove changes that will go to another review REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60484=60485 BRANCH fix-title-qml REVISION DETAIL

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car
meven updated this revision to Diff 60484. meven added a comment. Adjust font size REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60446=60484 BRANCH fix-title-qml REVISION DETAIL https://phabricator.kde.org/D22028 AFFECTED FILES

D10750: wayland: Add support for zwp_linux_dmabuf

2019-06-23 Thread Roman Gilg
romangg updated this revision to Diff 60482. romangg added a comment. Rebase Fredrik's dma-buf code on master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=29953=60482 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED

D22041: [Avatar Gallery] Increase minimum width

2019-06-23 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R128:82fe6ba3830b: [Avatar Gallery] Increase minimum width (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22041?vs=60473=60481 REVISION

D22041: [Avatar Gallery] Increase minimum width

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. Oh right, because they're wider now. REPOSITORY R128 User Manager BRANCH wider-avatar-gallery-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D22041 To: filipf, #vdg, ngraham, ndavis Cc: plasma-devel, LeGast00n, jraleigh,

D22041: [Avatar Gallery] Increase minimum width

2019-06-23 Thread Filip Fila
filipf added a comment. In D22041#485251 , @ngraham wrote: > Shipit! Stable branch please. I don't have an earlier copy now, but IIRC there were enough thumbnails in a row before, it's only when we added the new Konqi ones that the

D22041: [Avatar Gallery] Increase minimum width

2019-06-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! Stable branch please. REPOSITORY R128 User Manager BRANCH wider-avatar-gallery-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D22041 To:

D22041: [Avatar Gallery] Increase minimum width

2019-06-23 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY 3 entries now fit in a row instead of 2. REPOSITORY R128 User Manager BRANCH wider-avatar-gallery-by-default (branched from

D22035: Port FolderView to ContainmentLayoutManager plugin

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. +1 visually! I wonder if it might make sense to make the icons on the handle bigger even in desktop mode. They're awfully small, and bigger click targets can help desktop users, too. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22039: Start sending download updates again when resuming a download

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When there are no active downloads the update timer stops automatically but it was only

D22035: Port FolderView to ContainmentLayoutManager plugin

2019-06-23 Thread Marco Martin
mart added a comment. Before: F6927347: Screenshot_20190623_140805.png After: F6927342: Screenshot_20190623_140647.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22035

D22037: [Notifications] Don't show remaining time when job is paused

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Downloaded something, got a "3 minutes remaining", paused it, remaining time disappeared.

D21991: Add X-KDE-ParentApp entries in metadata.desktop

2019-06-23 Thread Kai Uwe Broulik
broulik reopened this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > metadata.desktop:150 > Icon=preferences-desktop-notification-bell > -X-KDE-ParentApp= > +X-KDE-ParentApp=org.kde.plasmashell > X-KDE-PluginInfo-Author=Kai Uwe

D22035: first prototype of port to the new C++ layout code

2019-06-23 Thread Marco Martin
mart updated this revision to Diff 60461. mart added a comment. - no automatic edit mode for now REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60460=60461 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035

D22035: first prototype of port to the new C++ layout code

2019-06-23 Thread Marco Martin
mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY sync edit mode bigger applet handles on touch interaction remove dead code folderViewLayer child of appletsLayout

D22034: Introcuce ContainmentLayoutManager QML plugin

2019-06-23 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY This QML plugin offers a reusable, C++ based framework to manage layout of items (mainly plasmoids but

D22011: Add MenuSeparator

2019-06-23 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. LGTM To be honest, I would expect this to be the actual logic and Kirigami.Separator just use MenuSeparator, but maybe it's something we can look into in the future. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH

D20908: RFC: Redesign QML applet configuration windows

2019-06-23 Thread Filip Fila
filipf added a comment. Preview of a highlight style in line with what's being discussed in T11124 : F6927189: image.png From a technical POV is it possible to reuse the widgets/tasks SVG here? REPOSITORY

D18920: Fix and update PCI module

2019-06-23 Thread Christoph Feck
cfeck added a comment. Would it be possible to commit the whitespace changes separately? They hide all the actual changes. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18920 To: konradr, #plasma, cfeck Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. Close! But the title sizes still appear to differ: F6927140: The bug-2019-06-23_13.03.08.webm REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22028 To: meven, mart, ngraham Cc: plasma-devel,

D19855: Fix bugzilla login page widgets tab order

2019-06-23 Thread Christoph Feck
cfeck added a comment. Is this fixed by https://phabricator.kde.org/D21894 ? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano, sitter, cfeck, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car
meven updated this revision to Diff 60446. meven added a comment. Remove lines that shouldn't have been included REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60442=60446 BRANCH fix-title-qml REVISION DETAIL

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-23 Thread Méven Car
meven created this revision. meven added reviewers: mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY - Set QWidget KCMs title font size to the same one as QML ones - Add content margin to QWidget

D21998: Batch MPRIS DBus property changes

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:8cacb9246b0d: Batch MPRIS DBus property changes (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21998?vs=60352=60437

D22011: Add MenuSeparator

2019-06-23 Thread Alexander Stippich
astippich updated this revision to Diff 60433. astippich added a comment. - remove unneeded height REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22011?vs=60391=60433 BRANCH menu_separator REVISION DETAIL

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

2019-06-23 Thread Nathaniel Graham
ngraham added a comment. It never makes sense to put a tooltip on the wrong control. The fact that you need to check "CPU Monitor" first to get the "Show CPUs separately" option to become enables id visually communicated by the fact that it's indented below the other checkbox. If

D21990: Don't propagate a title change if it didn't actually change

2019-06-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:97cd13a388f1: Dont propagate a title change if it didnt actually change (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D10747: Implement zwp_linux_dmabuf_v1

2019-06-23 Thread Roman Gilg
romangg updated this revision to Diff 60429. romangg added a comment. - Update protocol xml to wayland-protocols master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60366=60429 BRANCH dmaBuf REVISION DETAIL

D22021: Don't start ksmserver with lockscreen integration on wayland

2019-06-23 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3daa7bd2c58f: Dont start ksmserver with lockscreen integration on wayland (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22021: Don't start ksmserver with lockscreen integration on wayland

2019-06-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > startplasma.h:48 > bool startKDEInit(); > -bool startKSMServer(); > +bool startKSMServer(bool wayland); > Can you use some flags/enum here, `startKSMServer(false)` isn't very descript. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22020: Fix wayland-dev session

2019-06-23 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1cc0b27fb840: Fix wayland-dev session (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22020?vs=60424=60426 REVISION DETAIL

D22011: Add MenuSeparator

2019-06-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > apol wrote in MenuSeparator.qml:37 > It shouldn't need any height at all. Oh duh, I was thinking it was a Rectangle, but it's a Kirigami.Separator REPOSITORY R858

D22011: Add MenuSeparator

2019-06-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > ngraham wrote in MenuSeparator.qml:37 > @mart does this need to be multiplied by the device pixel ratio to account > for fractional scale factors? I forget. It shouldn't need any height at all. REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D22005: Accept local paths

2019-06-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > actionlist.cpp:256 > +if (resource.startsWith(QLatin1Char('/'))) { > +resource = QStringLiteral("file://") + resource; > +} if (QDir::isAbsolutePath(resource)) { resource = QUrl::fromLocalFile(resource); }

D22021: Don't start ksmserver with lockscreen integration on wayland

2019-06-23 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Fixes regression from the startkde C++ re-write which made ksmserver start the kscreenlocker in wayland

D22020: Fix wayland-dev session

2019-06-23 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY without dbus-run-session developer can't login into this session TEST PLAN now login works REPOSITORY

D21998: Batch MPRIS DBus property changes

2019-06-23 Thread Aleix Pol Gonzalez
apol added a comment. +1 LGTM REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21998 To: broulik, #plasma, fvogt Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D19389: Rewrite kworkspace logout, shutdown and suspend API

2019-06-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in sessionmanagement.cpp:95 > I don't see where it did KDisplayManager::isSwitchable() checks `CanMultiSession` on the session manager. and there's also `numReserve()` which seems to be hardcoded to `1` for more modern

D21995: Split ksmserver into a small application that handles startup and ksmserver

2019-06-23 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in startup.cpp:417 > watcher->deleteLater(); It's a QDbusServiceWatcher not a QDBusPendingCallWatcher it's parented to the job which will quit REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21995: Split ksmserver into a small application that handles startup and ksmserver

2019-06-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > server.h:56 > > + > #define SESSION_PREVIOUS_LOGOUT "saved at previous logout" ? > startup.cpp:417 > +connect(watcher, ::serviceRegistered, this, [=]() { > +emitResult(); > +}); watcher->deleteLater(); REPOSITORY R120 Plasma

D22017: [Notifications] Let plasmashell be the only true owner of notification and job tracker services

2019-06-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mvourlakos, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Register notification and job tracker services with "allow replacement" flag

D21995: Split ksmserver into a small application that handles startup and ksmserver

2019-06-23 Thread David Edmundson
davidedmundson updated this revision to Diff 60421. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=60345=60421 BRANCH davidedmundson/ksession REVISION DETAIL https://phabricator.kde.org/D21995

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Failing!

2019-06-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 23 Jun 2019 07:34:46 + Build duration: 30 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Failing!

2019-06-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Jun 2019 07:34:46 + Build duration: 3 min 19 sec and counting CONSOLE OUTPUT

D22014: Add a copy of FindKXB from kwin

2019-06-23 Thread Luca Beltrame
lbeltrame abandoned this revision. lbeltrame added a comment. Actually, those changes are not needed. The includes aren't used at all. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22014 To: lbeltrame, cgiboudeaux Cc:

D22014: Add a copy of FindKXB from kwin

2019-06-23 Thread Alexey Min
alexeymin added a comment. typo in title :) REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22014 To: lbeltrame, cgiboudeaux Cc: alexeymin, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22014: Add a copy of FindKXB from kwin

2019-06-23 Thread Luca Beltrame
lbeltrame created this revision. lbeltrame added a reviewer: cgiboudeaux. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lbeltrame requested review of this revision. REVISION SUMMARY 1a54c53bca82a28d77f379a6d5cb2e1a3be46fe5