D22084: Span wayland objects to lifespan of the QApplication

apol added inline comments. INLINE COMMENTS > zzag wrote in waylandintegration.cpp:125 > Is it safe to drop this line? What was the reasoning behind this change? Yes, note it's a QPointer now. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.

D22098: Don't keep requesting scans when wifi is disabled

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. apol requested review of this revision. REVISION SUMMARY I noticed when on the plane that we'd keep retrying non-stop. TEST PLAN

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ndavis added a comment. Agreed REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18571 To: ngraham, #vdg, #plasma, broulik, ndavis, mart Cc: mart, pino, davidedmundson, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himc

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham added a comment. We remain in a situation where the Colors KCM has this feature, but none of the others do. I really like having it as a hidden accelerator there, and I miss it in the other KCMs. I think we need to implement this everywhere, or remove it from the Colors KCM. But hone

D22028: Improve QWidget KCM and QML KCM consistency

ngraham added a comment. Gotcha, thanks! REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22028 To: meven, mart, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D22028: Improve QWidget KCM and QML KCM consistency

meven added a comment. In D22028#486409 , @ngraham wrote: > Could this be backported to the stable branch? It's a relative straightforward bugfix. Unfortunately no, it would cause a bug without the D20598

D22090: Fix a warning message

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2dbdc6c59168: Fix a warning message (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22090?vs=60645&id=60658 REVISION DETAIL https://pha

D10750: wayland: Add support for zwp_linux_dmabuf

romangg planned changes to this revision. romangg added a comment. Multi-plane support is needed. See @fredrik's inline comment on how to do that: > We would need to create a separate EGL image and a separate texture for each plane. > The scene would need to bind each of those texture

D10750: wayland: Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 60655. romangg added a comment. Refactor Bind the interface on abstract-egl level. Then we can remove the interface stubs throughout the stack. The interface is not created when EGL format extensions are not available or we don't use EGL.

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60654. romangg added a comment. - D-pointer DmaBufBuffer - Only allow one create request in any case - Params in private interface class - typedef for LinuxDmabufUnstableV1Interface - Small cleanup - Set buffer privates and delete impl on interfac

D22088: [Notifications] Ignore excess spam

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this behavior makes perfect sense. Tested and it works properly. Code looks good too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22088 To:

D22084: Span wayland objects to lifespan of the QApplication

zzag added a comment. Hmm, okay, I see what the problem is. The proposed patch seems to be reasonable, but I don't like the new object tree. We could fix this bug by introducing m_isTerminating, e.g. // In setupKWaylandIntegration. connect(qApp, &QCoreApplication::aboutToQuick,

D22090: Fix a warning message

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Fix warning messages such as : file:///home/$USER/kde/usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/KickoffItem.qml:142

D22084: Span wayland objects to lifespan of the QApplication

apol added a comment. +1 Really cool! this fixes the crash on closing plasmashell! REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22084 To: davidedmundson, #plasma Cc: apol, ngraham, anthonyfieroni, zzag, plasma-devel, LeGast00

D22079: Show an entry on the system tray indicator when a portal is needed

This revision was automatically updated to reflect the committed changes. Closed by commit R116:81cb0abfb815: Show an entry on the system tray indicator when a portal is needed (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22079?vs=60596&id=60644#toc REPOSITORY R11

Plasma 5.16.2

Plasma 5.16.2 is now released https://www.kde.org/announcements/plasma-5.16.2.php

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/11/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 25 Jun 2019 11:14:08 + Build duration: 31 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/25/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 11:14:14 + Build duration: 11 min and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/27/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 11:14:14 + Build duration: 5 min 17 sec and counting CONSOLE OUTPUT

D22077: [Colors KCM] Add title bar to preview delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b55653565be: [Colors KCM] Add title bar to preview delegate (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22077?vs=60592&id=60642#toc REPOSITORY R119 Plasma Desktop

D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

hoffmannrobert added a comment. I tested the new code: Tests 1-5 of the test plan behave like previously "without patch", in tests 6 and 7 the integrated laptop screen isn't reacitivated after opening. After adapting my changes to the new code, all tests work as described "with patch".

D22088: [Notifications] Ignore excess spam

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When multiple identical notifications are sent in quick succession, discard the request and let i

D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

hoffmannrobert updated this revision to Diff 60637. hoffmannrobert edited the summary of this revision. hoffmannrobert edited the test plan for this revision. hoffmannrobert added a comment. Rebase and adapt to new upstream code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://ph

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 10:13:42 + Build duration: 6 min 40 sec and counting JUnit Tests Name: (ro

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 10:13:43 + Build duration: 5 min 9 sec and counting CONSOLE OUTPUT [.

D22084: Span wayland objects to lifespan of the QApplication

ngraham added a comment. Confirmed that this fixes 372789 for my Wayland session! REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22084 To: davidedmundson, #plasma Cc: ngraham, anthonyfieroni, zzag, plasma-devel, LeGast00n, jralei

D22084: Span wayland objects to lifespan of the QApplication

davidedmundson added a comment. This powers the plugin backend behind KWindowSystem. That consists of static methods that can be invoked at any time. We can't change that API. Scoping WaylandIntegration would absolutely work but it then means putting guards over all the users of it. (w

D22028: Improve QWidget KCM and QML KCM consistency

ngraham added a comment. Could this be backported to the stable branch? It's a relative straightforward bugfix. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22028 To: meven, mart, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pit

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 67 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/67/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 06:32:01 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root)

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 122 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/122/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 11:13:51 + Build duration: 28 min and counting BUILD ARTIFACTS a

D22079: Show an entry on the system tray indicator when a portal is needed

ngraham added inline comments. INLINE COMMENTS > main.qml:61 > } > +plasmoid.setAction("showPortal", i18n("Open Network Login Page..."), > "preferences-system-network"); > + This icon has no monochrome version, so it will stick out in the system tray where other icons are gene

D22087: Build without foreach

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Did Plasma things REPOSITORY R120 Plasma Workspace BRANCH foreach REVISION DETAIL

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7c49e1498aab: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18322?vs=497

D22065: Introduce PluginManager

fvogt added inline comments. INLINE COMMENTS > pluginmanager.cpp:39 > + > +void PluginManager::init() > +{ Never called > pluginmanager.cpp:69 > + > +bool PluginManager::setPluginLoaded(const QString &subsystem, bool loaded) > +{ I'd change this to accept the an AbstractBrowserPlugin pointer i