D18920: Fix PCI module

konradr updated this revision to Diff 61562. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=61495&id=61562 REVISION DETAIL https://phabricator.kde.org/D18920 AFFECTED FILES Modules/pci/kpci_private.h To: konradr, #plasma, cfeck Cc: plasma-de

D22385: [mobile/wifi] Port settings to Kirigami Formlayout

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Hi Nicolas, thank you for your work on the mobile KCM. Since I'm not the author, but a student of mine is, I think I will leave your reviews for Nate and others as those are mostly

D22344: Expose some more settings in an Advanced dialog

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me now. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D22344 To: apol, #plasma, jgrulich Cc: aspotashe

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf added a comment. In D22191#493949 , @ngraham wrote: > In D22191#493928 , @filipf wrote: > > > In general we do need an additional message box which says sync successful or failed. And then in

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 60 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/60/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Jul 2019 02:48:45 + Build duration: 3 min 13 sec and counting CONSOLE OUTPUT [...tr

D22390: ksmserver/autostart: remove qstandardpaths queries

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Remember the autostart path instead of looking it up over and over. Depends on D22387

D22191: Implement syncing of theme preferences between SDDM and Plasma

ngraham added a subscriber: leinir. ngraham added a comment. In D22191#493928 , @filipf wrote: > In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed.

D21763: [kcms/ksmserver] Port to new kworkspace API

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4e2db5dc02a2: [kcms/ksmserver] Port to new kworkspace API (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21763?vs=59929&id=6155

D21995: Split ksmserver into a small application that handles startup and ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6bab1f518c50: Split ksmserver into a small application that handles startup and ksmserver (authored by bruns, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21995

D7820: man ioslave: spurious numbers included in clang(1) man page

ltoscano added a comment. Apologize for the long delay - I can't reproduce the issue with the current master. The mentioned structure of the clang man page seems to be the same (clang 8). Adding @mkoller too. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7

D9033: man ioslave: asserts trying to display pam(8)

ltoscano added a comment. Apologize for the long delay. It looks like that the fix still applies and works according the comment. I added @mkoller, the historical maintainer of kio-man, who can probably validate the change better than me, but let's try to push this for the upcoming KDE

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf added a comment. In general we do need an additional message box which says sync successful or failed. And then in the case of failure it should state what failed. But as far as I can tell the operations won't fail. They're all conditional on values being existent or not and if th

D22381: Add previous-/nextActivity methods

ivan added a comment. You are right, they are randomized. And, yes, that is what I meant on IRC - that redundancy due to keeping a sorted list will likely lead to future issues, but I see no other way if we want to be consistent regarding listing and switching. As it is required to

D22381: Add previous-/nextActivity methods

muesli added inline comments. INLINE COMMENTS > ivan wrote in Activities.cpp:218 > I don't like the fact that it constantly resorts the activities. > > The second problem is that ListActivities returns a list in one order, and > this traverses activities in another order. If this will work by n

D22385: [mobile/wifi] Port settings to Kirigami Formlayout

ngraham added a comment. Nice! Are the "Security" and "IP Settings" headers really necessary, I wonder? I bet the two sections would look just fine with some whitespace or a separator, and no header text. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phab

D22368: Formatting cleanup in PCI module

This revision was automatically updated to reflect the committed changes. Closed by commit R102:196d4aaa9cf6: Formatting cleanup in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22368?vs=61497&id=61533

D22385: [mobile/wifi] Port settings to Kirigami Formlayout

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Simplifies the code and makes it more consistent with other settings REPOSITORY R116

D18920: Fix PCI module

cfeck added inline comments. INLINE COMMENTS > kpci_private.h:48 > > +/* Following structurs MUST BE packed, otherwise variables will be mapped to > + wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are structure or structures? > kpci_private.h:49 > +/* Following struc

D22367: Update mail address in PCI module

This revision was automatically updated to reflect the committed changes. Closed by commit R102:96c18ee3cf63: Update Konrad's mail address in PCI module (authored by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22367?vs=61496&id=61531 REVISION D

D22381: Add previous-/nextActivity methods

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Activities.cpp:218 > +auto a = q->ListActivitiesWithInformation(); > +std::sort(a.begin(), a.end(), &infoLessThan); > + I don't like the fact that it cons

D22382: Add global shortcuts for switching to the previous/next activity

muesli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY We currently have a mouse-wheel action to switch to the previous/next desktop, but it wasn't possible to assign a global keyboard sh

D22344: Expose some more settings in an Advanced dialog

apol updated this revision to Diff 61520. apol added a comment. add loadConfig bits REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22344?vs=61510&id=61520 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22344 AFFEC

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 59 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/59/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Jul 2019 15:15:41 + Build duration: 2 min 46 sec and counting CONSOLE OUTPUT [...tr

D22326: fix API availability/version detection to not be terribly racey

This revision was automatically updated to reflect the committed changes. Closed by commit R871:e6a81b2d466b: fix API availability/version detection to not be terribly racey (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22326?vs=61514&id=61519#toc REPOSITORY R871

D22322: Store crash report automatically if shutting down

tcanabrava updated this revision to Diff 61518. tcanabrava added a comment. - Add pid information to the log files - Store only the last 10 files in the cache directory REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22322?vs=61371&id=61518 BRANCH store

D22344: Expose some more settings in an Advanced dialog

jgrulich added a comment. You still need to add following lines to the loadConfig() method, otherwise those properties won't be filled when editing an existing connection: m_tmpIpv4Setting.setDhcpHostname(ipv4Setting->dhcpHostname()); m_tmpIpv4Setting.setDhcpSendHostname(ipv4Setting

D22381: Add previous-/nextActivity methods

muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY These two methods can be used to switch to the previous/next activity in alphabetical order. They are

D22326: fix API availability/version detection to not be terribly racey

sitter updated this revision to Diff 61514. sitter added a comment. build fix REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22326?vs=61513&id=61514 BRANCH versioncheck REVISION DETAIL https://phabricator.kde.org/D22326 AFFECTED FILES src/CMakeList

D22326: fix API availability/version detection to not be terribly racey

sitter updated this revision to Diff 61513. sitter added a comment. use qprogressbar until a proper busyindicator becomes available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22326?vs=61343&id=61513 BRANCH versioncheck REVISION DETAIL https://phab

D22191: Implement syncing of theme preferences between SDDM and Plasma

ngraham added a comment. Overall this is very nice! I have some inline comments, and two macro design comments: 1. You need to handle failure conditions for the remove, mkpath, copy, chown etc. operations. Thede functions all return false if they fail, so you can find out easily enough.

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

sitter added a comment. Fair point but I don't want to throttle my music stream, I want to throttle the drkonqi api requests ;) Also, an IO throttle isn't always useful. e.g. for the stuff in D22326 I want control exactly how long the reply should take

D22344: Expose some more settings in an Advanced dialog

apol updated this revision to Diff 61510. apol added a comment. addressed comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22344?vs=61474&id=61510 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22344 AFFECT

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

broulik added a comment. Why not just use `tc` to throttle the network connection? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22376 To: sitter Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this is super duper handy when trying to test slow network connections as it makes every single api job take a minimum amount of tim

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

Marco I played with this but I didnt have any success, 1. I added a reload() function in AppletQuickItem : void AppletQuickItemPrivate::reload() { auto oldQmlObject = qmlObject; s_rootObjects.remove(oldQmlObject->rootContext()); init(); oldQmlObject->deleteLater(); } void AppletQ

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/29/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Jul 2019 10:37:33 + Build duration: 4 min 50 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/29/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Jul 2019 10:37:31 + Build duration: 4 min 4 sec and counting JUnit Tests Nam

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/3/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 10 Jul 2019 10:37:32 + Build duration: 2 min 14 sec and counting JUnit Tests

D22369: Update and add some device names in PCI module

konradr created this revision. konradr added reviewers: Plasma, cfeck. konradr added a project: Plasma. Herald added a subscriber: plasma-devel. konradr requested review of this revision. REVISION SUMMARY Update and add some device names in PCI module REPOSITORY R102 KInfoCenter REVISION DET

D22368: Formatting cleanup in PCI module

konradr created this revision. konradr added reviewers: Plasma, cfeck. konradr added a project: Plasma. Herald added a subscriber: plasma-devel. konradr requested review of this revision. REVISION SUMMARY Formatting cleanup in PCI module REPOSITORY R102 KInfoCenter REVISION DETAIL https://

D22367: Update mail address in PCI module

konradr created this revision. konradr added reviewers: Plasma, cfeck. konradr added a project: Plasma. Herald added a subscriber: plasma-devel. konradr requested review of this revision. REVISION SUMMARY Update my mail address in PCI module REPOSITORY R102 KInfoCenter REVISION DETAIL http

D18920: Fix PCI module

konradr updated this revision to Diff 61495. konradr retitled this revision from "Fix and update PCI module" to "Fix PCI module". konradr edited the summary of this revision. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=51397&id=61495 REVISION

D22344: Expose some more settings in an Advanced dialog

aspotashev added a comment. I think this UI is missing hints/tips about meaning of these options. Otherwise it would be unclear: - What is the meaning of dad-timeout = -1 - What is the meaning of dad-timeout = 0 - What happens if dhcp-send-hostname is true, but dhcp-hostname is empty

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c3c030d8b595: Fix creation of kdeglobals if /etc/xdg/kdeglobals present (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22238?vs=61069&id=61493 RE

D22341: [mobile/wifi] Port to SimpleKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b1e218b92a3b: [mobile/wifi] Port to SimpleKCM (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22341?vs=61410&id=