D22535: Make kimpanel a system tray applet

apol added a comment. +1 overall There's already several things in the system tray with a keyboard icon (all different keyboards! xD) F7048437: Screenshot_20190719_031028.png Maybe we could make something a bit more recognizable? REPOSITORY

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol updated this revision to Diff 62020. apol added a comment. Added the rest, it wasn't that much REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22540?vs=62007=62020 BRANCH pc3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D22540

D22457: Make it possible to show the QR of a network connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:8df1dcefa0a3: Make it possible to show the QR of a network connection (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D22306: Do not skip code launching application in application dashboard

luc4 added a comment. Hello! Thank you for your help! I can see the logs now. Unfortunately I cannot update my patch according to your notes. According to the logs I added, I do not see values that I wouldn't expect. Can you describe somehow how to reproduce the behavior you reported?

D22543: [LNF KCM] make it possible to close the preview

ognarb added a comment. I had the same problem today with qt 5.13.0, framework 5.59 and plasma 5.16.3. I switched to a tty to close system settings :/. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22543 To: ngraham, #plasma, apol Cc: ognarb, broulik,

D22543: [LNF KCM] make it possible to close the preview

ngraham added a comment. Alt-F4 works of course, but for me, without this patch none of the other methods of closing it work. Could it be a Qt regression? I notice that this patch is required on my Qt 5.13 machine, but in my Qt 5.12.3-using VM, the existing code works without this patch.

D22543: [LNF KCM] make it possible to close the preview

broulik added a comment. I'm confused. I can press Alt+F4 or just click the window or the close button just fine. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22543 To: ngraham, #plasma, apol Cc: broulik, plasma-devel,

D22513: Expose if we're still searching for more results

apol added inline comments. INLINE COMMENTS > broulik wrote in sourcesmodel.cpp:43 > From my testing this signal isn't realibly emitted, without D21606 > and some other fix. See also Bug 381835 > Are you sure this patch actually works? It works, it just

D22543: [LNF KCM] make it possible to close the preview

ngraham created this revision. ngraham added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The preview window doesn't respond to setting its visibility to false, so currently it

D22539: Fix broken guard that prevents styling sliders with negative values

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Setting the minimum to at least 0 was added to fix a crash, however it

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

cfeck added a comment. Oh, if the latter syntax also works, then you are right. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Used it as much extensibly as I knew how to REPOSITORY R112 Milou BRANCH pc3 (branched from master)

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol updated this revision to Diff 62007. apol added a comment. More into the Layout REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22540?vs=62006=62007 BRANCH pc3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D22540 AFFECTED

D22418: WIP [wayland] make automatic backend selection truly automatic

PureTryOut added a comment. @graesslin I'm not sure about compiling twice with different settings, but there is most definitely a use-case for this patch: mobile distros. For example postmarketOS (where Alexey and I are from) we tend to run KWin on either the fbdev or DRM backend.

D22535: Make kimpanel a system tray applet

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Original kimpanel is a very long widget with 3~6 icons. It takes a lot of space of panel. And the width changes when changing

D22306: Do not skip code launching application in application dashboard

luc4 updated this revision to Diff 61994. luc4 added a comment. Also reset the state variable during onPress. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22306?vs=61271=61994 REVISION DETAIL https://phabricator.kde.org/D22306 AFFECTED FILES

D22533: [KCM] Slightly imptove tab bar's integration with frame

ngraham created this revision. ngraham added reviewers: drosca, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We don't yet have a real QML tab widget (https://bugs.kde.org/show_bug.cgi?id=394296) so

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 61991. GB_2 added a comment. - use more bindings - set `sourceSize` on the thumbnail REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=60944=61991 BRANCH arcpatch-D20549 REVISION DETAIL

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497332 , @cfeck wrote: > Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. I don't

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61988. mart marked an inline comment as done. mart added a comment. - remove leftovers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61974=61988 BRANCH mart/newlayout REVISION DETAIL

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61987. mart marked an inline comment as done. mart added a comment. - set the item container directly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61976=61987 BRANCH mart/containmentlayoutmanager

D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

This revision was automatically updated to reflect the committed changes. Closed by commit R858:6103f2493816: [ComboBox] Set close policy to close on click outside instead of only outside… (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah ok, this works in my VM, so there must be something weird about how it's getting installed into `~/kde/usr` for my built-from-source stuff. Shipit! REPOSITORY R858 Qt Quick

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

filipf added a comment. Ping, I'm still seeing the issue with the other patch landed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22505: [SpinBox] Set renderType

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8927e90ac08f: [SpinBox] Set renderType (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22505?vs=61898=61983

D22517: kcms: translations: Make list separator translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:87da6e5d75cc: kcms: translations: Make list separator translatable (authored by aspotashev). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D9033: man ioslave: asserts trying to display pam(8)

This revision was automatically updated to reflect the committed changes. Closed by commit R320:87215e7ea765: man ioslave: asserts trying to display pam(8) (authored by marten, committed by ltoscano). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D22034: Introduce ContainmentLayoutManager QML plugin

davidedmundson added inline comments. INLINE COMMENTS > configoverlay.h:67 > +private: > +void setItemContainer(ItemContainer *container); > + Given ItemContainer instantiates this object (or a subclass therefore) can we make this public and call it from

D22035: Port FolderView to ContainmentLayoutManager plugin

davidedmundson added inline comments. INLINE COMMENTS > ConfigOverlay.qml:171 > +//print("saving..."); > +appletsLayout.save(); > +} why do we do it explicitly here, but backed by a timer for movement? > main.qml:346 > +

D21829: Improved Touch support for Kickoff

ngraham added a comment. @steffenh are you able to implement @hein's inline suggestions? I don't want this patch to get lost, it's good stuff. REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein, ngraham Cc:

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15341 To: smithjd, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22034: Introduce ContainmentLayoutManager QML plugin

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in itemcontainer.cpp:438 > If we want to use this in the panel/wherever we need ItemContainer to forward > the full min/preferred/max sizes (with margins added) and have the >

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61976. mart marked 3 inline comments as done. mart added a comment. - no manual parenting - move the reaction to size hints in layoutmanager REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61973=61976

D22505: [SpinBox] Set renderType

broulik added a comment. I want `NativeRendering` which Qt doesn't do by default. This patch is needed either way, be it `true` or that annoying workaround. If someone with shader knowledge could fix the native rendering shader that would be lovely, yes. REPOSITORY R858 Qt Quick Controls

D22505: [SpinBox] Set renderType

apol accepted this revision. apol added a comment. :shrug: well sounds like a fix upstream is due, either fixing nativerendering on non-integer scaling or just doing this everywhere. Also if it ever gets fixed we'll stay with this workaround until someone remembers to remove. REPOSITORY

D22505: [SpinBox] Set renderType

broulik added inline comments. INLINE COMMENTS > apol wrote in SpinBox.qml:69 > Should that be the case for every TextInput then? why's the SpinBox special? It should. It was already done for `ComboBox` and `TextField` but `SpinBox` got forgotten :) REPOSITORY R858 Qt Quick Controls 2:

D22514: Show if KRunner is still searching for more things

broulik added a comment. This overlaps the clear button: F7045212: Screenshot_20190718_143324.png You might want to set some additional padding on the TextField and use acutal icon size: var actionIconSize = Math.max(control.height * 0.8,

D22505: [SpinBox] Set renderType

apol added inline comments. INLINE COMMENTS > SpinBox.qml:69 > +// https://bugreports.qt.io/browse/QTBUG-67007 > +renderType: Screen.devicePixelRatio % 1 !== 0 ? Text.QtRendering : > Text.NativeRendering > + Should that be the case for every TextInput then? why's the SpinBox

D22513: Expose if we're still searching for more results

broulik added inline comments. INLINE COMMENTS > sourcesmodel.cpp:43 > this, SLOT(slotMatchesChanged(QList))); > +connect(m_manager, ::RunnerManager::queryFinished, > +this, [this] { From my testing this signal isn't realibly emitted, without D21606

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

cfeck added a comment. Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61974. mart added a comment. - use the locked editmodecondition REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61577=61974 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61973. mart added a comment. - better manage locked plasmoid logic REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61966=61973 BRANCH mart/containmentlayoutmanager REVISION DETAIL

D7820: man ioslave: spurious numbers included in clang(1) man page

mkoller requested changes to this revision. mkoller added a comment. This revision now requires changes to proceed. I think this was solved with bugfix to Bug Nr 335169 with commit 87d8ab4371149c84794f4e93d1f590f7bac5f327

D22034: Introduce ContainmentLayoutManager QML plugin

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in itemcontainer.cpp:370 > I may be wrong but I think if one would do > AppletsLayout { > > QtObject {} > > } > > that internal object wouldn't be parented and stay dangling otherwise? AFAIK, QML created objects don't use

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61966. mart marked 5 inline comments as done. mart added a comment. - singal when can't resize - make resize work with items that update hints while resizing - use setPosition and setSize where possible - make sure to connect to busy indicator - don't

D22034: Introduce ContainmentLayoutManager QML plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in abstractlayoutmanager.h:44 > I don't fully understand the split between AbstractLayoutManager and > GridLayoutManager when AbstractLayoutManager effectively enforces a grid by > having cell sizes. in the end it needed cell

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 61958. jbbgameich added a comment. Update comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=61930=61958 BRANCH arcpatch-D18860 REVISION DETAIL https://phabricator.kde.org/D18860

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

arrowd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY BUG: 408632 TEST PLAN `kioclient5 exec http://localhost:9000` now works correctly. REPOSITORY R126 KDE CLI Utilities BRANCH

D22522: Fix build, include QTime

This revision was automatically updated to reflect the committed changes. Closed by commit R119:18001c2926dc: Fix build, include QTime (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22522?vs=61952=61956 REVISION DETAIL

D22522: Fix build, include QTime

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The type is used, but was not directly included. Fixes build with Qt 5.13. REPOSITORY R119

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

broulik added a comment. `/proc` isn't disk io REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22506 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,