D22553: guard against plasmashell being properly dead and not showing the SNI

sitter added a comment. This actually sucks tremendously. Kai said he used that service because he primarily cared about the notification being pretty. BUUUT actually considering the StatusNotifierHost is hugely horrible. We'd have to check and watch StatusNotifierWatcher (kded)

D22634: Sync NumLock preference

ngraham added a comment. Yeah, you're steadily chewing through https://bugs.kde.org/buglist.cgi?bug_status=__open__=kcm_sddm_id=1645796=systemsettings :-) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22634 To: filipf, #plasma, ngraham,

D22634: Sync NumLock preference

filipf added a comment. Ah cool, there was a feature request. I have NumLock on by default so I'll also be making use of the feature :) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22634 To: filipf, #plasma, ngraham, davidedmundson Cc:

D22627: Add a GUI option for choosing the input method

filipf added a comment. Yeah an empty entry is bad UI but it works for the code since it ends up just grabbing the text from the combobox and writing it to the config file :P ... it was a quick solution I'll admit. The feature request was this, a much more straightforward idea:

D22634: Sync NumLock preference

This revision was automatically updated to reflect the committed changes. Closed by commit R123:7d51edcc094b: Sync NumLock preference (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22634?vs=62264=62349 REVISION

D22648: make handle follow arbitrary height of the drawer

camiloh updated this revision to Diff 62345. camiloh added a comment. now using root.parent instead of applicationWindow() REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62309=62345 BRANCH handle-follow-drawer (branched from master) REVISION

D22306: Do not skip code launching application in application dashboard

luc4 updated this revision to Diff 62338. luc4 added a comment. Removed volatile modifier, not probably useful in that context. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22306?vs=62170=62338 REVISION DETAIL https://phabricator.kde.org/D22306

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. In D12916#500367 , @davidedmundson wrote: > "does the task manager need attention simply because some different window needs attention"? There's an easy answer: We have a lot of users who rely on that. A lot

D21829: Improved Touch support for Kickoff

hein added a comment. In D21829#498921 , @steffenh wrote: > I have the last days looking at plasma-frameworks, but my knowledge of the working of plasma is close to zero, so I am afraid I'm not able to do this. Before we discuss

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. If that's how it worked in KDE 4 I think it could well qualify as a regression. Regardless of that, my personal take would be that the user entering and exiting the panel constitutes having explicitly acknowledged "needs attention" status and then ignoring it

D12916: Panel should not stop auto-hiding if a window wants attention

davidedmundson added a comment. @eike please also see my comments in the bug report for context. - The core part that's up for discussion is simply: "does the task manager need attention simply because some different window needs attention"? Semantically the scope of that

D12916: Panel should not stop auto-hiding if a window wants attention

michaelmoon added a comment. > would having to move your mouse over the panel and exiting again to hide it again work? Like it did in KDE4? Yeah that would work for me! Does that make the associated bug a regression? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22654: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R169:00ccd9019816: Fix typo (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22654?vs=62328=62334 REVISION DETAIL

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. I wonder if there's another fix we could attempt: Rather than permanently staying visible, would having to move your mouse over the panel and exiting again to hide it again work? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12916

D22648: make handle follow arbitrary height of the drawer

mart added inline comments. INLINE COMMENTS > OverlayDrawer.qml:210 > +if(root.height < applicationWindow().height) { > +margin = applicationWindow().height - root.height - > root.y + Units.smallSpacing; > +} applicationWindow() should be

D22654: Fix typo

jbbgameich updated this revision to Diff 62328. jbbgameich added a comment. Fix another occurence REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22654?vs=62324=62328 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22654 AFFECTED FILES

D12916: Panel should not stop auto-hiding if a window wants attention

michaelmoon added a comment. @hein thanks for your comments. Fwiw, the reason I use KDE in the first place is that it has //all// the options, and I can control my desktop experience to a significantly greater degree than any other DE I've tried so far - but there's just one option it

D22654: Fix typo

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY leftLargin -> leftMargin REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22654

D22564: [SwipeListItem] Take into account scrollbar visibility and form factor for handle and inline actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f8617ce137a6: [SwipeListItem] Take into account scrollbar visibility and form factor for… (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22564: [SwipeListItem] Take into account scrollbar visibility and form factor for handle and inline actions

ngraham updated this revision to Diff 62319. ngraham added a comment. - Make it work when using a Flickable too - Make the logic more generic - Handle RTL too REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22564?vs=62313=62319 BRANCH

D22652: Desktop scripting: support args

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dbd2cd472153: Desktop scripting: support args (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22652?vs=62312=62314 REVISION DETAIL

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. I don't like this. - I think it's option creep - The user would have to configure this for each of their Task Manager applets to make it pervasive (consider multiple monitors with multiple Task Managers) - It won't address other applets that may use the same

D22652: Desktop scripting: support args

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY support args in applet creation with an optional argument to containment::addWidget scripts not using

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

ngraham updated this revision to Diff 62313. ngraham added a comment. Make the scrollbar test work (thanks @mart) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22564?vs=62116=62313 BRANCH respect-scrollbar-visibility-for-swipelistitem (branched from

D22648: make handle follow arbitrary height of the drawer

camiloh updated this revision to Diff 62309. camiloh added a comment. take into consideration the y position Summary: if the drawer height prop has been set to a custom value, might as well the y position too, so take it into account to position the handle REPOSITORY R169 Kirigami

D22648: make handle follow arbitrary height of the drawer

camiloh created this revision. camiloh added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY If the height of the drawer is set to a different value from the applicationWindow height, then

D22630: Slow down the busy indicator's rotation speed

ngraham added a comment. Yup, See D22645 and D22646 . Turns out that they were already using a different duration, so with those patch landed, all the busy indicators will use the same rotational speed. REPOSITORY

D22627: Add a GUI option for choosing the input method

ngraham added a comment. In D22627#499798 , @filipf wrote: > In D22627#499699 , @ngraham wrote: > > > Also these hardcoded values make me feel a little leery. Is there a way we can programmatically

D22634: Sync NumLock preference

ngraham accepted this revision. ngraham added a comment. Nice. This is becoming a very useful feature rich in bug fixes. Shipit! REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sync-numlock (branched from master) REVISION DETAIL https://phabricator.kde.org/D22634 To: filipf,

D22641: Inject content script also into about:blank

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ed5982697c83: Inject content script also into about:blank (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D22642: Monitor entire document rather than the documentElement specifically

This revision was automatically updated to reflect the committed changes. Closed by commit R856:88f2da50b640: Monitor entire document rather than the documentElement specifically (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D22641: Inject content script also into about:blank

fvogt added a comment. An iframe without source, the things web devs come up with... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D22641 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22572: Remove scaling of iconsize unit for isMobile

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a89b2334f137: Remove scaling of iconsize unit for isMobile (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22572?vs=62086=62285 REVISION

D22642: Monitor entire document rather than the documentElement specifically

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Calling `document.write` will replace the entire `documentElement` with a new one,

D22613: kstart: Prevent crash when running without args

tasossahanidis marked an inline comment as done. tasossahanidis added a comment. Assuming I did everything correctly, it should be okay now. REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D22613 To: tasossahanidis, davidedmundson Cc: apol,

D22641: Inject content script also into about:blank

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A completely dynamically created `` might not have a source but default to `about:blank`

D22613: kstart: Prevent crash when running without args

tasossahanidis updated this revision to Diff 62282. tasossahanidis added a comment. kstart: Use isEmpty() REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22613?vs=62196=62282 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22613

D22035: Port FolderView to ContainmentLayoutManager plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager plugin (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22035?vs=61988=62269#toc REPOSITORY R119 Plasma Desktop

D22034: Introduce ContainmentLayoutManager QML plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f59aecbcfec6: Introduce ContainmentLayoutManager QML plugin (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61987=62268

D22634: Sync NumLock preference

filipf added a comment. Numlock in SDDM config files is documented here: https://github.com/sddm/sddm/blob/develop/data/man/sddm.conf.rst.in REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22634 To: filipf, #plasma, ngraham, davidedmundson

D22634: Sync NumLock preference

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY SDDM currently doesn't respect the user's choice on whether or not NumLock should be on or off by default. Fortunately there is a

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

broulik added a comment. I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might want to enable "Enhanced Media Controls" in settings. REVISION DETAIL https://phabricator.kde.org/D22631 To: rgeorgiev Cc:

D22632: Implement support for the "next" and "previous" actions in SoundCloud

broulik added a comment. -1 Site-specific workarounds are not in scope for this extension. REVISION DETAIL https://phabricator.kde.org/D22632 To: rgeorgiev Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22630: Slow down the busy indicator's rotation speed

broulik added a comment. Also, Plasma's `BusyIndicator` should maybe get the same treatment? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: broulik, cfeck, filipf, plasma-devel, cullmann,