D22874: Remove the ShellManager

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d754abbc4799: Remove the ShellManager (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22874?vs=62898=62957 REVISION DETAIL

D21815: [sddm-theme] Start moving from QQC1 to QQC2

ngraham added a comment. In D21815#490482 , @filipf wrote: > Might be better to just follow current style; updating it to the new one would be a quick review. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

davidedmundson updated this revision to Diff 62956. davidedmundson added a comment. update Updating D22885: Add global animation speed slider to workspace options KCM === GNU nano 4.3

D18920: Fix PCI module

This revision was automatically updated to reflect the committed changes. Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=61562=62955 REVISION DETAIL

D22369: Update and add some device names in PCI module

This revision was automatically updated to reflect the committed changes. Closed by commit R102:ed789f56fc69: Update and add some device names in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. In D22316#505466 , @ngraham wrote: > With this change, if I press the volume up and volume down key on my keyboard, feedback only plays every second or third time I hit the button (depending on how fast I press it).

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R98 Breeze for Gtk BRANCH gtk-320-318-merge (branched from master) REVISION DETAIL https://phabricator.kde.org/D22876 To: cblack, #plasma, ngraham Cc: ngraham,

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Introduce a new config entry into kdeglobals AnimationSpeed that will

D22533: [KCM] Slightly improve tab bar's integration with frame

ngraham added a comment. It's already in a comment above. :) REPOSITORY R115 Plasma Audio Volume Applet BRANCH slightly-better-tab-bar (branched from master) REVISION DETAIL https://phabricator.kde.org/D22533 To: ngraham, drosca, #vdg, filipf Cc: filipf, plasma-devel, LeGast00n,

D22533: [KCM] Slightly improve tab bar's integration with frame

This revision was automatically updated to reflect the committed changes. Closed by commit R115:941790a0e49d: [KCM] Slightly improve tab bars integration with frame (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Also notice that the current aspect doesn't look good nor consistent with the rest of Plasma. In my researches I found this: https://git.reviewboard.kde.org/r/121698/diff/1/#, which is a bit what I'm doing. I'll stop with this until an agreement is found. REPOSITORY

D22616: Remove phonon KCM

ngraham added a comment. @sitter can you post your patch with that? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c0ec75f7ce1: [kcms/nightcolor] Minor UI tweaks to the KCM (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22863?vs=62875=62946

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

ngraham added a comment. Hmm, this requires that the user makes the mental connection between "screens are mirrored" and "I'm delivering a presentation". Also, that mapping is not 100%; LibreOffice Impress even discourages using mirrored displays because when you use extended mode instead,

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. With this change, if I press the volume up and volume down key on my keyboard, feedback only plays every second or third time I hit the button (depending on how fast I press

D22882: [Energy] Improve signal-to-noise ratio of battery information

ngraham planned changes to this revision. ngraham added a comment. Ah OK. I had a feeling someone would complain and explain what all the extra info was for. I'll come up with some changes that preserve this information when it's relevant, and clean up the display. REPOSITORY R102

D22882: [Energy] Improve signal-to-noise ratio of battery information

kpiwowarski added a comment. Please don't remove that info, it's useful for me. F7135831: image.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22882 To: ngraham, #vdg, #plasma, broulik Cc: kpiwowarski, filipf,

D22882: [Energy] Improve signal-to-noise ratio of battery information

filipf added a comment. F7135822: image.png I check up on //Full Design// to track precise wear, and the //Capacity// is also pretty standard info and useful. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22882 To:

D22882: [Energy] Improve signal-to-noise ratio of battery information

filipf added a comment. I think what Capacity means is how worn out your battery has become. Yours can still take the full charge so it's at 100% (jealous). All this info is useful for me, for instance, because I have a shoddy battery and I check up on this data from time to time.

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. Hmm, if the existing menu is provided by Qt, changes might need to be made upstream. :/ I wonder if there's a way to inject new items into it though, without creating an entirely new one? Hopefully #plasma people should

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham updated this revision to Diff 62943. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22879?vs=62936=62943 BRANCH lnf-to-global (branched from

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham added a comment. I'd like to get some #plasma opinions on this, since it is a fairly user-visible change. REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global (branched from master) REVISION DETAIL https://phabricator.kde.org/D22879

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in KNSBackend.cpp:214 > I think we can use the icon `plugins` here. Submit a patch! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D22716 To: leinir, #discover_software_store, #vdg,

D22882: [Energy] Improve signal-to-noise ratio of battery information

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Battery information shows a lot of redundant and confusing information, making

D22783: Fix ambiguous "Current" label in energy information

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d5268f926798: Fix ambiguous Current label in energy information (authored by aloisw, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. I started to reimplement the menu. This is how it looked for me: F7135687: Screenshot_20190801_223211.png this is how a new menu would look like (some items and shortcuts are missing): F7135723: shot.png

D22742: Show about distro KCM in System Settings' System Administration category

This revision was automatically updated to reflect the committed changes. Closed by commit R102:09598972736b: Show about distro KCM in System Settings System Administration category (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22742?vs=62560=62940#toc REPOSITORY

D22728: Provide a link to KInfoCenter

ngraham abandoned this revision. ngraham added a comment. Did D22742 instead. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22728 To: ngraham, #plasma, #vdg Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n,

D22879: Rename "Look and Feel" KCM to "Global Theme"

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. We should probably also change the name in the KDE Store and Look and Feel Explorer. INLINE COMMENTS > metadata.desktop:2 > [Desktop Entry] > -Comment=Test Look and Feel

D20972: [sidebar] Make search field not glued to the separator

filipf updated this revision to Diff 62938. filipf added a comment. use 2px instead of 1px of padding REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20972?vs=62937=62938 BRANCH sidebarview-padding-nitpick (branched from master) REVISION DETAIL

D20972: [sidebar] Make search field not glued to the separator

ngraham added a comment. Well it's all about making sure the top, bottom, and right paddings are identical. If Discover's search field also needs adjustment, that's fine. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D20972 To: filipf, #vdg, ngraham,

D20972: [sidebar] Make search field not glued to the separator

filipf added a comment. @ngraham I forgot about RTL, my bad. I ended up using the margins approach because adding an Item also added row layout's inherent spacing which ended up in too big of a margin. And when compared with Discover, it turns out the margin needs to be only 1px,

D20972: [sidebar] Make search field not glued to the separator

filipf added a comment. 2px looks better to me as well, let's add 1px more to the margin in Discover then? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D20972 To: filipf, #vdg, ngraham, davidedmundson Cc: abetts, davidedmundson, plasma-devel, LeGast00n,

D20972: [sidebar] Make search field not glued to the separator

ngraham added a comment. Cool. But trying this out... are you sure 1 is enough? To my eyes, 2 looks better: F7135618: Screenshot_20190801_144149.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D20972 To:

D20972: [sidebar] Make search field not glued to the separator

filipf updated this revision to Diff 62937. filipf added a comment. watch out for RTL REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20972?vs=57408=62937 BRANCH sidebarview-padding-nitpick (branched from master) REVISION DETAIL

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham updated this revision to Diff 62936. ngraham added a comment. Make "look and feel" a description rather than a product name REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22879?vs=62925=62936 BRANCH lnf-to-global (branched from master)

D22871: Use better Workspace Behavior KCM title and icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber bfe...@protonmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22075: [Notifications] Swap configure and clear buttons in full representation header

ngraham added a comment. In retrospect, while this makes it consistent with what's below it, it's now inconsistent with all the other system tray pop-ups, which put their Settings button all the way over to the right. Hmm. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22871: Use better Workspace Behavior KCM title and icon

ngraham accepted this revision. ngraham added a comment. Ah right. Okay, this is fine then. REPOSITORY R119 Plasma Desktop BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg,

D22871: Use better Workspace Behavior KCM title and icon

GB_2 updated this revision to Diff 62933. GB_2 added a comment. Drop word "the" in descriptions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62930=62933 BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from

D22871: Use better Workspace Behavior KCM title and icon

GB_2 added a comment. In D22871#505360 , @ngraham wrote: > If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in

D22871: Use better Workspace Behavior KCM title and icon

ngraham added a comment. If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me. REPOSITORY R119

D22871: Use better Workspace Behavior KCM title and icon

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message. INLINE COMMENTS > index.docbook:28 > > -This is a module to

D19947: systray: show a small animation on the icons when activated

filipf added a comment. The effect doesn't always work for me. F7135314: systrayclick-2019-08-01_21.59.41 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19947_1 REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma,

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in plasma-themes.knsrc:42 > > The KDE Store category name should probably be updated too. > > You mean here? What does this actually do? I mean in the actual store online :-) REPOSITORY R119 Plasma Desktop BRANCH

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham added a subscriber: leinir. ngraham added inline comments. INLINE COMMENTS > plasma-themes.knsrc:42 > ProvidersUrl=https://download.kde.org/ocs/providers.xml > Categories=Plasma Theme > StandardResource=tmp > The KDE Store category name should probably be updated too. You mean here?

D22880: Rename "Plasma Theme" to "Plasma Style"

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. The KDE Store category name should probably be updated too. REPOSITORY R119 Plasma Desktop BRANCH plasma-theme-to-plasma-style (branched from master) REVISION DETAIL

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 updated this revision to Diff 62930. GB_2 added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Use name "General Behavior" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62892=62930

D19947: systray: show a small animation on the icons when activated

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19947_1 REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma, ngraham Cc: filipf, broulik, anthonyfieroni,

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 added a comment. In D22871#505311 , @ngraham wrote: > Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all. I'll name it

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

https://bugs.kde.org/show_bug.cgi?id=374311 Nate Graham changed: What|Removed |Added Resolution|UPSTREAM|DUPLICATE --- Comment #6 from Nate Graham ---

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better. REPOSITORY R120 Plasma Workspace BRANCH notification-count-no-overflow (branched from master) REVISION DETAIL https://phabricator.kde.org/D22878 To: filipf, broulik,

D22871: Use better Global Workspace Behavior KCM title and icon

ngraham added a comment. Hmm, seems a little bit long to me. Maybe just, "Global Behavior"? Or even just, "General"? It's already in a section with the word "Behavior" in it, after all. Also, does the docbook need to be updated? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22851: [SplitterProxy] Don't manually mapToGlobal

hpereiradacosta added a comment. Thanks for the fix ! Oxygen needs the same patch. Will you also push it there ? Hugo REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22851 To: broulik, #plasma, hpereiradacosta, davidedmundson Cc: plasma-devel, LeGast00n,

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This implements one of the changes decided upon in T11314

D22879: Rename "Look and Feel" KCM to "Global Theme"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This implements one of the changes decided upon in T11314

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

filipf updated this revision to Diff 62923. filipf added a comment. better code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22878?vs=62911=62923 BRANCH notification-count-no-overflow (branched from master) REVISION DETAIL

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

broulik added inline comments. INLINE COMMENTS > CompactRepresentation.qml:97 > anchors.centerIn: parent > -width: Math.round(Math.min(parent.width, parent.height) * 0.75) > +width: text.length > 1 ? Math.round(Math.min(parent.width, > parent.height) * 0.67)

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

davidedmundson added a comment. > but it doesn't make sense to me that Splash Screen will be in Appearance, while Login Screen (SDDM) will be in Startup and Shutdown. The problem that needs resolving there is SDDM KCM also does autologin and configuring UIDs to list. So you have a

D18417: Adjust and remove some top-level categories to implement new Appearance section layout

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b4bd5b465511: Adjust and remove some top-level categories to implement new Appearance section… (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18417?vs=49966=62922#toc

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c9f7aaa0765c: Rename Desktop Behavior category to Workspace Behavior (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:09a64755e18d: Move KCMs in Workspace Theme to more appropriate locations (authored by ngraham). REPOSITORY R119

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

filipf accepted this revision. filipf added a comment. In D18419#505221 , @ngraham wrote: > In D18419#505214 , @filipf wrote: > > > +1 regarding the //Cursor Theme// and //Plasma Theme//, but it

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

ngraham updated this revision to Diff 62916. ngraham added a comment. Don't change "Plasma Theme" string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18419?vs=62914=62916 REVISION DETAIL https://phabricator.kde.org/D18419 AFFECTED FILES

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

ngraham updated this revision to Diff 62914. ngraham retitled this revision from "Move KCMs in "Workspace Theme" up one level" to "Move KCMs in "Workspace Theme" to more appropriate locations". ngraham added a comment. Put the splash screen KCM in {Startup and Shutdown} REPOSITORY R119

D18419: Move KCMs in "Workspace Theme" up one level

ngraham added a comment. In D18419#505214 , @filipf wrote: > +1 regarding the //Cursor Theme// and //Plasma Theme//, but it doesn't make sense to me that //Splash Screen// will be in **Appearance**, while //Login Screen (SDDM)// will be in

D18419: Move KCMs in "Workspace Theme" up one level

filipf added a comment. +1 regarding the //Cursor Theme// and //Plasma Theme//, but it doesn't make sense to me that //Splash Screen// will be in **Appearance**, while //Login Screen (SDDM)// will be in **Startup and Shutdown**. I'd put //Splash Screen// into **Startup and Shutdown**,

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a99c14d1eac9: Consistently use Units.toolTipDelay instead of hardcoded values (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D17464: [Timer applet] Minor fixes for the applet

gepardo added a comment. Ping @davidedmundson REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY When the notification count is in double digits, the numbers can overflow the icons which is meant to contain them. This patch

D22874: Remove the ShellManager

bshah accepted this revision. bshah added a comment. Please also remove loader.qml from shell packages I guess. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22874 To: apol, #plasma, davidedmundson, bshah Cc: bshah, davidedmundson,

D18419: Move KCMs in "Workspace Theme" up one level

ngraham updated this revision to Diff 62909. ngraham retitled this revision from "Adjust some KCMs to implement new Appearance section layout" to "Move KCMs in "Workspace Theme" up one level". ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson resigned from this revision. davidedmundson added a comment. My opinion on top-down "lets shuffle things" remains the same. However, I am happy to approve iterative changes. I can see how this is a prerequisite to renaming "Workspace Theme" which seems to make sense, given

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

ngraham added a comment. Not being an expert in this code or familiar with the history here, it would be helpful if you added a bit more information to the Description section. Specifically, why this split existed in the first place, the function it once served, why it's no longer necessary

D22874: Remove the ShellManager

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. The desktop loader has been broken since before 5.0, I think it's a classic example of building something too early. We can always revert if we find a usage later. Go

D22845: [GTK3] Convert all colors to use GTK color definitions

filipf added a comment. This is going to be fantastic, agreed on splitting up the patch. "There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)" - this should also be a separate patch REPOSITORY R98 Breeze for Gtk

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

filipf added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > There are some technical terms that should stay "technical," "color > temperature" is one of those. I think using the technical term here is fine. IIRC f.lux tried to simplify this by adding a bunch of descriptors

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack added a comment. In D22845#505092 , @ngraham wrote: > Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch. Closing this to

D22876: [Breeze-GTK] Merge gtk320 and gtk318 into gtk3

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GTK 3.20 and GTK 3.18 are now merged into a single GTK 3.0 directory. This will reduce work needed

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, I agree. REPOSITORY R124 System Settings BRANCH rename-desktop-behavior-category-to-workspace-behavior (branched from master) REVISION DETAIL

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R258:894f6706afef: Improve the look of the Plymouth Boot Splash Screen KCM UI (authored by GB_2). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 62899. GB_2 added a comment. Clean up debug messages REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=62050=62899 BRANCH arcpatch-D20549 REVISION DETAIL https://phabricator.kde.org/D20549 AFFECTED FILES

D22874: Remove the ShellManager

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We had an overly complex and in practice unexploited system to detect which shell to use, This patch

D22845: [GTK3] Convert all colors to use GTK color definitions

ngraham added a comment. Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22845 To: cblack, #vdg,

D22869: [Converter Runner] Support fractional units

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6f1cadb5882c: [Converter Runner] Support fractional units (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22869?vs=62887=62896

D22869: [Converter Runner] Support fractional units

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OMG, this is great stuff! Works great, and code looks sane. I couldn't find any regressions in my testing. Next, the real trick will be to combine this with calculation support so

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:118 > "Night Color" is the name of the feature itself; you can't truncate it to > save a few words. I think it also needs to keep its capitalization. > > If you're looking to change the string, I would focus on the word >

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in main.qml:118 > Agreed. "Night Color" is the name of the feature itself; you can't truncate it to save a few words. I think it also needs to keep its capitalization. If you're looking to change the string, I would focus on the word

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol Cc: nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

GB_2 added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > but it depends on how you look at it. "Night color temperature" might be a > better string. As it speaks about color temperature and not temperature of > "Night Color." Agreed. REPOSITORY R119 Plasma Desktop BRANCH

D22872: Rename "Desktop Behavior" category to "Workspace Behavior"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Desktop" to users means the desktop folder, so use a more appropriate name for this category. TEST

D22871: Use better Global Workspace Behavior KCM title and icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Consistently call the KCM "Global Workspace Behavior" and use `preferences-desktop` as the icon

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > zzag wrote in main.qml:118 > Just my 2 cents: you can simplify this string to "Night temperature." Not > sure whether translators will like this change though. but it depends on how you look at it. "Night color temperature" might be a better

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > romangg wrote in main.qml:118 > I would leave it with the capital C since it's part of the name. Just my 2 cents: you can simplify this string to "Night temperature." Not sure whether translators will like this change though. REPOSITORY R119

[System Tray]

Hi, recently I was fixing two bugs related to SystemTray (in review: https://phabricator.kde.org/D22804, https://phabricator.kde.org/D22767). I noticed that code is highly coupled and "fragile" with some unclear references like: item.parent.parent.attrbute etc. Items are imperatively assigned to

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d90e82ef7c19: [Kicker/Kickoff] Use better Remove from Favorites icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22861?vs=62869=62888

D22868: Revamp Kirigami.AboutPage

leinir accepted this revision. leinir added a comment. While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D [1] to someone who's tried to fix that bit

D22869: [Converter Runner] Support fractional units

broulik created this revision. broulik added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 409216 FIXED-IN: 5.17.0 CHANGELOG: Converter runner can now convert

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 To: hein, #frameworks, mart Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol,

D22817: Port KRunner to Plasma Components 3

broulik added a comment. > To add the clear button, maybe you can use Kirigami.SearchField instead? Not sure if that can do Plasma styling? INLINE COMMENTS > apol wrote in RunCommand.qml:56 > The button's height is by default really big and krunner then looks rather > comical. > Here

  1   2   >