D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham added a comment. @davidedmundson and/or @drosca, are you good with this new approach? REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca, davidedmundson, ngraham Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n,

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better! REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca, davidedmundson, ngraham Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel,

D22844: [kcm-colors] Export colorscheme to GTK color definitions

ngraham added a comment. Nice, it works every time now! I'm not super thrilled about all the code duplication, though. Can't this live in just one place? If not here, then maybe in plasma-framework? INLINE COMMENTS > .gitignore:1 > +.vscode Unrelated to this patch; please remove from the

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63010. cblack added a comment. Fix WM colors on first go round REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63009=63010 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63009. cblack added a comment. Colors are now applied from the active colorscheme every time REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63001=63009 BRANCH kcm-colors-gtk (branched from master)

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 63008. kezik added a comment. I talked with 4-5 people and they all said that giving real time feedback in the slider is useless and bad, so here's that, the feedback is given on mouse release, and every problem is automatically solved. If you want

D17464: [Timer applet] Minor fixes for the applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM, but let's wait for @davidedmundson. REPOSITORY R114 Plasma Addons BRANCH arcpatch-D17464 REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt,

D22844: [kcm-colors] Export colorscheme to GTK color definitions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks, it works much better now. I'm really impressed with this, and it's very cool to be able to see GTK3 apps respecting the system color scheme: F7143222:

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63001. cblack added a comment. Make GTK colors its own KRDB flag REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62859=63001 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Very cool idea. However I'm not seeing it work. No matter how many times I change the color scheme, the .css files never get created. It doesn't work after a reboot either.

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Me too, but please wait for a #plasma person to approve or reject. :) REPOSITORY R124 System Settings BRANCH

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. That is good enough IMO, but if anyone knows how to fix this, then please do :-) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n,

D22880: Rename "Plasma Theme" to "Plasma Style"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5b7a43d2ad8d: Rename Plasma Theme to Plasma Style (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22880?vs=62927=62999 REVISION

D22881: [GTK3] Give checkboxes and radiobuttons a pressed appearance

This revision was automatically updated to reflect the committed changes. Closed by commit R98:e5f17d318a5e: [GTK3] Give checkboxes and radiobuttons a pressed appearance (authored by cblack, committed by ngraham). Herald added a project: Plasma. Herald added a subscriber: plasma-devel.

D22901: Make alphabetic categorization of the "All Applications" section optional

This revision was automatically updated to reflect the committed changes. Closed by commit R119:258545f996cf: Make alphabetic categorization of the All Applications section optional (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22876: Merge gtk320 and gtk318 into gtk3

This revision was automatically updated to reflect the committed changes. Closed by commit R98:fdd2df48b37e: Merge gtk320 and gtk318 into gtk3 (authored by cblack, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22876?vs=62906=62991#toc REPOSITORY R98 Breeze for

D22901: Make alphabetic categorization of the "All Applications" section optional

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's much nicer. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22901 To: hein, #plasma, davidedmundson, tcanabrava Cc:

D22901: Make alphabetic categorization of the "All Applications" section optional

hein created this revision. hein added reviewers: Plasma, davidedmundson, tcanabrava. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Introduces a new prop and turns it off by default. Also rewrites the initial "all applications" data gathering

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

broulik planned changes to this revision. broulik added a comment. Good idea, will do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22857 To: broulik, #plasma, #vdg Cc: dfaure, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

ngraham added a comment. All right, makes sense. I might suggest a little UI re-work now that we have two DnD-related checkboxes next to each other: Do not Disturb mode: [ ] Enable when screens are mirrored [ ] Show critical notifications REPOSITORY R119

D22899: [SplitterProxy] Don't manually mapToGlobal

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The constructor of QMouseEvent actually expects windowPos and/or screenPos but

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

broulik added a subscriber: dfaure. broulik added a comment. Sure, but in the non-mirrored case notifications popping up won't really be a problem as you will have your desktop with notifications alongside your notes on the laptop in front of you with just the presentation on the projector.

D22803: Improved OSD behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R104:43a6204349a7: Improved OSD behavior (authored by broulik). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22803?vs=62726=62985 REVISION DETAIL

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. It's worth noting that this patch as-is also breaks the Dashboard UI ("All Applications" no longer shows content), so this revert wasn't just about implementation details but also actively broke upstream. I'm writing an alternative patch now. REPOSITORY R119

D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd027ce844ed: [applets/notifications] Try to not have the notification count numbers overflow… (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22803: Improved OSD behavior

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great for me. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22803 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Ah so it does. I think that's the most important case to cover, so tentative +1 from me. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

filipf added a comment. If it would be draining to do now, we can leave that menu at QQC1 and add a note pointing to a bug report? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: filipf, ngraham, broulik, #vdg,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added a comment. In D22896#505835 , @ngraham wrote: > Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. It does that. Making it close when clicking anywhere

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: ngraham, broulik, #vdg,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

broulik added a comment. "Only issue", I think that's quite a severe regression? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg Cc: broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7141216: System Settings Sidebar QQC2 Port.png Only issue

D22893: introduce the Defaults group for panel values

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when plasma is starting up, there are no panel views yet this means that if a thickness (or other

D22868: Revamp Kirigami.AboutPage

hein added a comment. I'll remove that part of the patch later tonight and talk Marco into fixing it differently. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella,

D22868: Revamp Kirigami.AboutPage

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This breaks the display of main actions on mobile REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart,

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

zzag added inline comments. INLINE COMMENTS > filipf wrote in main.qml:118 > I think using the technical term here is fine. IIRC f.lux tried to simplify > this by adding a bunch of descriptors which compared a particular temperature > value or even range to a lighting condition, e.g. one

D22890: Add new class AllAppsModel that gives us a list of installed Apps

tcanabrava updated this revision to Diff 62965. tcanabrava added a comment. - Add copyright information and docs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22890?vs=62964=62965 BRANCH allAppsModel REVISION DETAIL

D22890: Add new class AllAppsModel that gives us a list of installed Apps

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY The idea is to replace the rootModel.allAppsModel with this in the future, right now it's a way to not break the rootModel

D22885: Add global animation speed slider to workspace options KCM

broulik added a comment. Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means *faster* instead of "half the speed" as reading that line would suggest REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma Cc:

D18180: Fix layout issues in the AboutPage personDelegate component

leinir abandoned this revision. leinir added a comment. Irrelevantisified by D22868 :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18180 To: leinir, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos,

D22888: Prefer categories with the query string visible in results

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This logic was present in the old model and keeps e.g. Baloo file search results from getting

D22316: Avoid garbling the sound if the volume slider is moved fast

anthonyfieroni added a comment. updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198 REPOSITORY R115 Plasma Audio

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

anthonyfieroni added a comment. Since we have 4 values on right / left, 0 should be the default one, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas,