Re: [System Tray]

On Thu, Aug 1, 2019 at 10:30 AM Konrad Materka wrote: > > Hi, > > recently I was fixing two bugs related to SystemTray (in review: > https://phabricator.kde.org/D22804, > https://phabricator.kde.org/D22767). I noticed that code is highly > coupled and "fragile" with some unclear references like:

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 160 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/160/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 05 Aug 2019 02:57:44 + Build duration: 32 min and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 159 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/159/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 05 Aug 2019 02:45:33 + Build duration: 5 min 56 sec and counting CONSOLE OUTPUT

D22844: [kcm-colors] Export colorscheme to GTK color definitions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks very much. This is excellent work, and I'm impressed. The feature works perfectly and the code structure and implementation makes sense to me. I think people are really going to

D22934: [KCM] Improve text for "lock after wake" feature

This revision was automatically updated to reflect the committed changes. Closed by commit R133:9cca999319b3: [KCM] Improve text for lock after wake feature (authored by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22934?vs=63086=63087

D22911: Improve the look of the Lock Screen KCM UI

ngraham added a comment. Noticed one more change I'd like to make while screenshotting it for next week's blog post. See D22934 . REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D22911 To: GB_2, #plasma, #vdg, ngraham Cc:

D22934: [KCM] Improve text for "lock after wake" feature

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The word "resume" is a technical term that's only clear when suspending is mentioned in

D22911: Improve the look of the Lock Screen KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R133:bf5040930785: Improve the look of the Lock Screen KCM UI (authored by GB_2). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63079=63083 REVISION

D22908: avoid qml warnings when controlRoot is not set

ngraham added subscribers: mart, ngraham. ngraham accepted this revision. ngraham added reviewers: mart, Plasma. ngraham added a comment. This revision is now accepted and ready to land. @mart, does this look correct to you? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION

D22880: Rename "Plasma Theme" to "Plasma Style"

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in kcm_desktoptheme.desktop:41 > You forgot to change the name here too. Oops, sorry! Fixed in 2bedabd96d37c48a67a80dcc48f3368b1e9713ef

D22911: Improve the look of the Lock Screen KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Nice work. REPOSITORY R133 KScreenLocker BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D22911 To: GB_2, #plasma,

D22911: Improve the look of the Lock Screen KCM UI

GB_2 updated this revision to Diff 63079. GB_2 added a comment. Correct ki18ncp comment REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63078=63079 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22911: Improve the look of the Lock Screen KCM UI

GB_2 updated this revision to Diff 63078. GB_2 added a comment. Address comments REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22911?vs=63030=63078 BRANCH improved-lock-screen-kcm-ui (branched from master) REVISION DETAIL

D22742: Show about distro KCM in System Settings' System Administration category

ngraham added a comment. File a bug on KInfoCenter :) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22742 To: ngraham, #vdg, #plasma, filipf, GB_2 Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22911: Improve the look of the Lock Screen KCM UI

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in kcm.ui:49 > Ok, I just followed the style from D21610 > , if it's wrong then it needs to be > corrected ther too. That was kind of an exception for just that item because it's written as a

D22911: Improve the look of the Lock Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in kcm.ui:49 > Capitalize Automatically Ok, I just followed the style from D21610 , if it's wrong then it needs to be corrected ther too. > ngraham wrote in kcm.ui:78 > While we're at it, I might

D22742: Show about distro KCM in System Settings' System Administration category

KonqiDragon added a comment. Can add a GPU information in **Hardware**? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22742 To: ngraham, #vdg, #plasma, filipf, GB_2 Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D22911: Improve the look of the Lock Screen KCM UI

ngraham added a comment. A good future improvement would be to change "mins" and "secs" in the spinboxes to "minutes" and "seconds". INLINE COMMENTS > kcm.ui:49 > > -Lock screen automatically after: > +automatically after: > Capitalize

D22929: Bring back and install System Administration category

This revision was automatically updated to reflect the committed changes. Closed by commit R124:fa5ca1189c95: Bring back and install System Administration category (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22929?vs=63071=63075#toc REPOSITORY R124 System

D22929: Bring back and install System Administration category

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY D22742 added the info KCM to the System Administration

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

zzag added a comment. I'll land this patch in 24h if there are no objections from #plasma . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22923 To: zzag, #plasma, #vdg, GB_2, ngraham Cc: plasma-devel, LeGast00n,

D22924: [Night Color KCM] Don't show advanced controls for constant mode

zzag added a comment. I'll land this patch in 24h if there are no objections from #plasma . REPOSITORY R119 Plasma Desktop BRANCH rename-manual-to-constant REVISION DETAIL https://phabricator.kde.org/D22924 To: zzag, #plasma, #vdg, GB_2,

D22925: Fix POTD doesn't update

guoyunhe added a comment. In D22925#506462 , @ngraham wrote: > Have you tested to make sure this doesn't break other providers? I need several days to test because it only change once a day... (changing local time won't work) REPOSITORY

D22925: Fix POTD doesn't update

ngraham added a comment. Have you tested to make sure this doesn't break other providers? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22925 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Hello, I'm not a Plasma expert, but I tried to investigate the situation a bit in Qt and plasma-framework. My understanding is that the notes applet is using TextArea from QtQuick.Controls 1. TextArea 1 creates an edit menu inside Qt, probably the one defined in

D22925: Fix POTD doesn't update

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Previous patch for Unsplash Wallpapers changed the identifier format. So we can not simply detect whether an identifier contains

D22924: [Night Color KCM] Don't show advanced controls for constant mode

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The user can only change the color temperature when the constant mode is selected. Therefore, it

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Both the Night Color (KDE Plasma) and the Night Light (GNOME Shell) have so called "Manual" mode. In