D22814: Remove colon (:) prefix when looking up dictionary word

wbauer added a comment. Can this be pushed to the 5.12 branch as well, please? It's broken in 5.12.8 as well (https://bugs.kde.org/390776 was actually reported against 5.12.1), the patch applies cleanly and does fix the problem. REPOSITORY R114 Plasma Addons REVISION DETAIL

KDE CI: Plasma » sddm-kcm » kf5-qt5 SUSEQt5.12 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/sddm-kcm/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 03:13:43 + Build duration: 10 min and counting CONSOLE OUTPUT Started by an SCM

D22981: Minor code improvements

filipf updated this revision to Diff 63250. filipf added a comment. also show debug output if scaling DPI is not found REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22981?vs=63249=63250 BRANCH minor-code-improvements (branched

D22981: Minor code improvements

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY - more debugging - more comments - for two buttons emit toggled instead of clicked regarding changed - add authorship info

D12916: Panel should not stop auto-hiding if a window wants attention

ngraham added a comment. Is there a conclusion here, or a plan of attack for @michaelmoon to revise the patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12916 To: michaelmoon, ngraham, hein Cc: hein, ngraham, davidedmundson, plasma-devel, LeGast00n,

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. Thanks, looks like it was a lot of work! It all seems to work well. Could you update the title and summary so they reflect what's in the patch now? I'll let #plasma folks take over the review now. REPOSITORY R114 Plasma

D22774: Add a button to the notes applet to clear formatting

luc4 updated this revision to Diff 63248. luc4 added a comment. I updated the TextArea element to QtQuickControls 2 (this may not be necessary) and I added a menu with a look more consistent with the rest of Plasma. The menu includes the same actions we had before: undo, redo, copy, cut,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks Roman! This is really excellent overall. A big improvement over the current one . Nevertheless I think we can make it even better and I have some UI review comments:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63242. camiloh added a comment. remove todo line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63241=63242 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#507797 , @ngraham wrote: > Pretty sweet! > > 1. Any chance you'd be interested in implementing the combined scaling/font DPI design we discussed at the sprint, as detailed in D22468#496149

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63241. camiloh added a comment. Correct possible undefined result pointed out by Aleix REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63240=63241 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added inline comments. INLINE COMMENTS > camiloh wrote in ActionToolBar.qml:184 > I think it then gets marked as visible = true You were right, I have now fixed it. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22974 To: camiloh, #kirigami, mart Cc:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63240. camiloh marked an inline comment as done. camiloh added a comment. further changes to make components work with new Kirigami.Action based on QQC2.Action, and proposed solution to draw the PrivateActionToolButton REPOSITORY R169 Kirigami CHANGES

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. Pretty sweet! 1. Any chance you'd be interested in implementing the combined scaling/font DPI design we discussed at the sprint, as detailed in D22468#496149 ? 2. How does one test this? After building kscreen and

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

GB_2 added a comment. In D22977#507716 , @ngraham wrote: > Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

This revision was automatically updated to reflect the committed changes. Closed by commit R119:91ec99d32e90: Make the Notifications KCM category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg updated this revision to Diff 63234. romangg added a comment. - Add back global scale writing legacy code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=63232=63234 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh marked 2 inline comments as done. camiloh added a comment. I have worked on the duplicating icons, by not using the contentItem to draw the icons and label, and instead use the style implementation. The only thing missing would be the dropdown icon for actions with submenus, I'm

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#506807 , @GB_2 wrote: > The `icons` folder can be deleted since it's not used anymore I think. True, thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg updated this revision to Diff 63232. romangg added a comment. - Remove icons folder REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=63231=63232 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468 AFFECTED FILES

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg updated this revision to Diff 63231. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=61910=63231 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1dd57d909165: Implement zwp_linux_dmabuf_v1 (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST

D10750: [wayland] Add support for zwp_linux_dmabuf

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R108:6613327a9c3e: [wayland] Add support for zwp_linux_dmabuf (authored by romangg). REPOSITORY R108 KWin CHANGES SINCE

[Breeze] [Bug 367696] breeze dark: konsole icon is barely visible

https://bugs.kde.org/show_bug.cgi?id=367696 Patrick Silva changed: What|Removed |Added Attachment #100722|close tab button almost |barely visible Konsole icon

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Once all is said and done we should really make an actual Kirigami component that has these visual settings by default so we don't need to adjust it in 10 places if we ever decide to

[Breeze] [Bug 367696] breeze dark: konsole icon is barely visible

https://bugs.kde.org/show_bug.cgi?id=367696 Patrick Silva changed: What|Removed |Added Version|5.15.2 |5.16.4 --- Comment #5 from Patrick Silva ---

D22977: Make the Notifications KCM category headers look consistent with other Kirigami lists

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7172863: Consistent Notifications KCM Category Headers.png

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 63225. romangg added a comment. Rebase on master. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=61915=63225 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 63224. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=61912=63224 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D22976: Fix compilation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0c4ec1c4af05: Fix compilation (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22976?vs=63222=63223 REVISION DETAIL

D22976: Fix compilation

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without this patch, plasma-workspace fails to compile for me with the following error: In

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

apol added a comment. WRT the two icons, maybe it would make sense to populate only the bits we want instead of using the action property? i.e. we can keep a kirigamiAction property for now. This patch is far too big as is already. I would even suggest doing the Kirigami.Action rebase first

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh created this revision. camiloh added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY The ideal is to be able to add regular qqc2 actions to the actiontoolbar, pageheaders,

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

akozlovskiy added a comment. @hein, ping? REPOSITORY R119 Plasma Desktop BRANCH kickoff-appview-remember-previous-category (branched from master) REVISION DETAIL https://phabricator.kde.org/D22866 To: akozlovskiy, #plasma, ngraham, hein Cc: plasma-devel, LeGast00n, jraleigh,

D22971: GTK3 - Fix menu port to colordefs

This revision was automatically updated to reflect the committed changes. Closed by commit R98:28292c7cfe55: GTK3 - Fix menu port to colordefs (authored by cblack, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D22971: GTK3 - Fix menu port to colordefs

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY In D22877 , some git spaghetti caused some work on

D22971: GTK3 - Fix menu port to colordefs

cblack updated this revision to Diff 63212. cblack added a comment. Forgot about you there making the menus look chonkier than they should REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22971?vs=63211=63212 BRANCH fix-menu (branched from master)

D22844: [kcm-colors] Export colorscheme to GTK color definitions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2de7c94402b0: [kcm-colors] Export colorscheme to GTK color definitions (authored by cblack, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22877: Convert colors into GTK colordefs

This revision was automatically updated to reflect the committed changes. Closed by commit R98:7bcd2d2ecbfa: Convert colors into GTK colordefs (authored by ngraham). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST

D22970: Wayland: config update code cleanup

romangg updated this revision to Diff 63208. romangg added a comment. - Remove unused gone signal REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22970?vs=63202=63208 BRANCH moreCleanupWaylandBackend REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

broulik accepted this revision. broulik added a comment. Good job! REPOSITORY R119 Plasma Desktop BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.kde.org/D22844 To: cblack, #plasma, ngraham, broulik Cc: ahiemstra, ngraham, davidre, broulik,

D22966: Wayland: backend code cleanup

romangg added inline comments. INLINE COMMENTS > zzag wrote in waylandconfig.h:73 > If libkscreen follows the Frameworks or the Kdelibs coding style, then > `WaylandOutput` and `*` have to be separated by a space. See source code of > Qt for more examples. > > Qt Coding Style and Frameworks

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

ngraham added a comment. Hey, that works great! REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg, ngraham Cc: filipf, ngraham,

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63207. cblack added a comment. Fix the rebase shenanigans REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63196=63207 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22970: Wayland: config update code cleanup

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In WaylandConfig getting the current config also always updates it. Improve the code of that.

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63196. cblack added a comment. Rebasing shenanigans, pt 3. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63188=63196 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63188. cblack added a comment. Rebase properly now? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63187=63188 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22966: Wayland: backend code cleanup

zzag added inline comments. INLINE COMMENTS > waylandconfig.h:73 > > -QMap outputMap() const; > If libkscreen follows the Frameworks or the Kdelibs coding style, then `WaylandOutput` and `*` have to be separated by a space. See source code of Qt for more examples. Qt Coding Style and

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63187. cblack added a comment. Update to match master. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63185=63187 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22967: Let KDBusService deal with the replace option

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Depends on D22946 TEST PLAN Replaced my plasmashell and krunner

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63185. cblack added a comment. Fix GtkColors flag REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63123=63185 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22945: Fix --replace option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:8e61f49cc292: Fix --replace option (authored by apol). CHANGED PRIOR TO COMMIT

D22844: [kcm-colors] Export colorscheme to GTK color definitions

ahiemstra added a comment. Just a small thing I noticed when scrolling through the patch. INLINE COMMENTS > krdb.h:31 > + KRdbExportGtkTheme= 0x0010, // Export KDE's widget style to Gtk if > possible > + KRdbExportGtkColors = 0x0012// Export KDE's colors to Gtk if >

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:19d09d1ef958: Kirigami.Icon: Fix loading bigger images when source is a URL (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22966: Wayland: backend code cleanup

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Modernize code, make it more readable, throw away unused code. TEST PLAN Compiles, runs.

D22888: Prefer categories with the query string visible in results

This revision was automatically updated to reflect the committed changes. Closed by commit R112:aa9e1d6c3f15: Prefer categories with the query string visible in results (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22888?vs=62959=63181

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63180. GB_2 added a comment. Close menu when clicking anywhere in the window. Most likely not the best solution. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=62976=63180 BRANCH

D22899: [SplitterProxy] Don't manually mapToGlobal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R113:47459c65df41: [SplitterProxy] Dont manually mapToGlobal (authored by broulik). REPOSITORY R113 Oxygen Theme

D22851: [SplitterProxy] Don't manually mapToGlobal

This revision was automatically updated to reflect the committed changes. Closed by commit R31:f16961c3eb4c: [SplitterProxy] Dont manually mapToGlobal (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22851?vs=62841=63173 REVISION DETAIL

D22961: [Microphone Indicator] Don't show if there are no microphones

This revision was automatically updated to reflect the committed changes. Closed by commit R115:e4cd6f30eb4f: [Microphone Indicator] Dont show if there are no microphones (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63172. apol added a comment. Remove unneeded code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63167=63172 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES src/icon.cpp

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in icon.cpp:424 > What happens if you leave `format` `nullptr`, does it guess? yes, it seems to work. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22952 To: apol,

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:412 > +{ > +reply->deleteLater(); > +if (!reply) { Move this after the `!reply` check > icon.cpp:424 > +const QString filename = reply->url().fileName(); > +if (!m_loadedImage.load(reply, >

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63167. apol added a comment. Also fix a memory leak REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63153=63167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES

D22924: [Night Color KCM] Don't show advanced controls for constant mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf1009cf1973: [Night Color KCM] Dont show advanced controls for constant mode (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22923: [Night Color KCM] Rename "Manual" mode to "Constant"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:68c51ae798da: [Night Color KCM] Rename Manual mode to Constant (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22923?vs=63059=63165

D22893: introduce the Defaults group for panel values

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9fa4d9417ca0: introduce the Defaults group for panel values (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22893?vs=62973=63161

Meeting minutes for week 32

Sorry for delayed notes nicofee: * released KDE Connect 1.3.5 * Did mostly Android stuff besides that * fixed KStars build on binary factory, needs more work to be usable * fixed Konversation build on Binary Factory, also needs more work to be usable * Diff 22943 "Don't build TrayIcon on

D22893: introduce the Defaults group for panel values

mart added inline comments. INLINE COMMENTS > apol wrote in panel.cpp:249 > Doesn't restore need calling now? No. Before was setting the config key, and then called restore to actually sync the internal panel status with the new config. Now is setting directly the panel status, so restore

D22961: [Microphone Indicator] Don't show if there are no microphones

broulik created this revision. broulik added reviewers: Plasma, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY If there are no microphones, even if there are recording streams, there's

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:406 > +m_networkReply = qnam->get(request); > +connect(m_networkReply.data(), ::finished, this, > [this](){handleFinished(m_networkReply); }); > } Just noticed, doesn't the `m_networkReply` leak? It's not deleted in