D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

meven added a comment. > To further reduce the confusion, the battery's degradation lavel is relocated to the Battery section. I don't think that is necessary. What is confusing in a degradation value in an energy section ? It is clearly an energy degradation value. If we want to

D23152: [energy kcm] Display Vendor and model

meven added a comment. In D23152#514689 , @ngraham wrote: > Mmm. I still think these properties would fit in the existing Battery section better. They're all properties of the battery, so I don't see why it wouldn't work to put them

D23284: Add keyboard control for ProceedDialog buttons

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Return/Enter triggers the OK button Escape triggers the Cancel button

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 343 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/343/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 20 Aug 2019 03:08:11 + Build duration: 17 min and counting CONSOLE OUTPUT [...truncated

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

ngraham added a reviewer: VDG. ngraham added a comment. Adding #VDG for comment on the above ^^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23279 To: ngraham, mart, #plasma, #vdg Cc: davidedmundson, plasma-devel,

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, the session switcher screen suffes from a few UX problems: - There's a fake

D23250: Only display old and new versions when both are available

This revision was automatically updated to reflect the committed changes. Closed by commit R134:1eeacce841d1: Only display old and new versions when both are available (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

ngraham added a comment. In D23279#514843 , @davidedmundson wrote: > With this patch how would someone create the first new session? With Kickoff/kicker/dash/Krunner > Switch User, which goes directly to the session management screen.

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

davidedmundson added a comment. With this patch how would someone create the first new session? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23279 To: ngraham, mart, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The code clearly intended for the Switch User button to only be visible when there was

D21524: Keep existing configurations' strings               

GB_2 added a comment. Ping. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D21524 To: gikari, apol, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a subscriber: mart. GB_2 added a comment. @mart can you help here? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405956 F7262289: System Settings Sidebar Show Intro Page Button.png

D23257: Allow for easier syncing of Plasma font

filipf added a comment. In D23257#514619 , @ngraham wrote: > Does anything bad happen if the users uses this with a version of SDDM that doesn't support it yet, or does the new item in the config file just get ignored? Still runs for me

D23152: [energy kcm] Display Vendor and model

ngraham added a comment. Mmm. I still think these properties would fit in the existing Battery section better. They're all properties of the battery, so I don't see why it wouldn't work to put them there. REPOSITORY R102 KInfoCenter REVISION DETAIL

D23250: Try to fix i18n() timing error in version strings

ngraham updated this revision to Diff 64064. ngraham added a comment. Yeah, that seems to work too REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23250?vs=64005=64064 BRANCH try-to-fix-i18n-timing-error (branched from master) REVISION

D22882: [Energy] Improve signal-to-noise ratio of battery information

ngraham abandoned this revision. ngraham added a comment. Abandoned in favor of D23270 and D23271 . REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22882 To: ngraham, #vdg, #plasma,

D23271: [Battery Monitor] Call battery capacity "degredation" for better clarity

ngraham created this revision. ngraham added reviewers: VDG, broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Companion patch to D23270 The same logic

D23270: [Energy] Use but battery capacity info in battery section and call it "degradation"

ngraham created this revision. ngraham added reviewers: meven, broulik, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Alternative to D22882 . Our use of

D22896: Port System Settings sidebar to QQC2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R124:b42479962795: Port System Settings sidebar to QQC2 (authored by GB_2). REPOSITORY R124 System Settings CHANGES

D23257: Allow for easier syncing of Plasma font

ngraham added a comment. Does anything bad happen if the users uses this with a version of SDDM that doesn't support it yet, or does the new item in the config file just get ignored? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23257 To:

D23188: Fix supported OS attributes for api.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c67827d4274f: Fix supported OS attributes for api.kde.org (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23188?vs=63822=64058 REVISION

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 64057. GB_2 added a comment. Move `setActionMenuVisible` to the `Private` class REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63968=64057 BRANCH arcpatch-D22896 REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

ngraham added a comment. Please keep in mind that @davidedmundson is 1000 times more technically skilled than I so if our advice is ever in conflict, you should listen to him rather than me. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To:

D21860: Set a font for gtk applications in the fonts kcm

gikari added a comment. In D21860#514564 , @davidedmundson wrote: > > But it was recomended to me to make the daemon as the patch > > Discussed where? > > I'm curious of the long term plans and how this fits in with krdb which does most

D23261: Add option to discourage reporting bugs

sitter added a comment. Whatever happened to m_iconName? Code looks sound. INLINE COMMENTS > main.cpp:225 > +// For automatically restarted services, do nothing in case no > interaction is allowed > +if (!forceDialog && !interactionAllowed && restarted) { > +return 0;

D22896: Port System Settings sidebar to QQC2

broulik accepted this revision. broulik added a comment. Fix it, then shipit! INLINE COMMENTS > broulik wrote in SidebarMode.h:107 > Move this to the `Private` class This isnt addressed REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2,

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added a comment. > But it was recomended to me to make the daemon as the patch Discussed where? I'm curious of the long term plans and how this fits in with krdb which does most other syncing. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added inline comments. INLINE COMMENTS > gikari wrote in CMakeLists.txt:20 > Xml comes from gtk configuration daemon I'm currently working on, whose > source code is currently here . > But it was recomended to me to make the daemon as

D21860: Set a font for gtk applications in the fonts kcm

gikari added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:20 > We have this exporting of KINIT_DBUS_INTERFACES_DIR from the library rather > than just hardcoding /usr/share/dbus/interfaces/ so that packagers can do > whatever weird stuff packagers do where things

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 342 - Still Failing!

CI breakage is by me pushing a change that depends on a change I pushed to kcoreaddons. I don't think there's a real problem to fix once CI all syncs up. David

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 342 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/342/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 19 Aug 2019 15:18:05 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT

D23267: Fix log categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98d3b607ee35: Fix log categories file (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64049=64050 REVISION DETAIL

D23267: Fix log categories file

meven updated this revision to Diff 64049. meven added a comment. Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64047=64049 BRANCH arcpatch-D23267 REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FILES

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 341 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/341/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 19 Aug 2019 15:04:17 + Build duration: 2 min 11 sec and counting CONSOLE OUTPUT

D23260: [Battery plasmoid] do not show vendor and product, always show battery details

This revision was automatically updated to reflect the committed changes. Closed by commit R120:df2469e7d238: [Battery plasmoid] do not show vendor and product, always show battery details (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23267: Fix log categories file

meven updated this revision to Diff 64047. meven added a comment. Do not touch ksmserver line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64046=64047 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED

D23267: Fix log categories file

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED

D23261: Add option to discourage reporting bugs

davidedmundson added a comment. Makes sense to me. There are situations with no useful backtraces and users can't install them, but it's nice to have some feedback than just a window completely disappearing. ++ REPOSITORY R871 DrKonqi REVISION DETAIL

D23260: [Battery plasmoid] do not show vendor and product, always show battery details

ngraham accepted this revision. ngraham added a comment. Much better, thanks. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23260 To: meven, #vdg, #plasma, broulik, ngraham Cc: ngraham, alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23253: [Notifications] Don't allow popup to obscure things in corners

ngraham added a comment. In D23253#514284 , @broulik wrote: > Not a fan. I'm open to suggestions regarding how to solve the issue mentioned in the Summary section as well as reported by a user in

D23261: Add option to discourage reporting bugs

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is for vendors and environments that don't want to allow their users to report bugs

Re: plasma* akademy bofs

I put in a placeholder, but we do need to discuss what topics we need and assign them into 1 hour discussions. David

D23125: fix bridge master:slave mapping by-name

sitter updated this revision to Diff 64036. sitter added a comment. drop more extra spaces -.- REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=64035=64036 BRANCH master REVISION DETAIL

D23125: fix bridge master:slave mapping by-name

sitter updated this revision to Diff 64035. sitter added a comment. drop excess spaces REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23125?vs=64034=64035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23125

D23125: fix bridge master:slave mapping by-name

sitter updated this revision to Diff 64034. sitter retitled this revision from "fix bridge/team/bond master:slave mapping by-name" to "fix bridge master:slave mapping by-name". sitter edited the summary of this revision. sitter added a comment. apply change to bond and team set id at

D23260: [Battery plasmoid] do not show vendor and product, always show battery details

meven added a subscriber: alexde. meven added a comment. In D23260#514394 , @broulik wrote: > Thanks Thank you for catching my screw up and being an attentive maintainer. @alexde I have kept the capacity in the end as I could not

D23260: [Battery plasmoid] do not show vendor and product, always show battery details

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23260 To: meven, #vdg, #plasma, broulik Cc: plasma-devel, LeGast00n,

D23237: Do not display vendor, Product and capacity in network plasmoid

meven abandoned this revision. meven added a comment. Abandoned in favor of D23260 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23237 To: meven, ngraham, #plasma, broulik, #vdg, filipf Cc: pkloc, alexde, apol,

D23260: [Battery plasmoid] do not show vendor and product, always show battery details

meven created this revision. meven added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Retry after D23237 Vendor and Product will be shown

D23152: [energy kcm] Display Vendor and model

meven added a comment. @broulik is it the right path to add those information coming from Solide::Device to the BatteryModel that mostly wraps Solid::Battery ? Am I missing a simple way to expand the BatteryModel to add the two fields Vendor and Product ? REPOSITORY R102 KInfoCenter

D23237: Do not display vendor, Product and capacity in network plasmoid

meven added a comment. In D23237#514328 , @pkloc wrote: > Is this information really that cluttering to mandate removal? Sure, vendor and model may be too "advanced" but remaining capacity is an useful hint. My intention is by no means

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 340 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/340/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 19 Aug 2019 10:59:30 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

Re: plasma* akademy bofs

David was kind enough to get us set up for Tuesday https://community.kde.org/Akademy/2019/Tuesday On Tue, Aug 13, 2019 at 5:29 PM Harald Sitter wrote: > > halo > > when shall we do plasma bofs? > last year we had 4 slots on Monday. do we want more? or less? a > different day perhaps? > > 9:30,

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:20 > set(klauncher_xml ${KINIT_DBUS_INTERFACES_DIR}/kf5_org.kde.KLauncher.xml) > +set(kdegtkconfigd_xml

D23198: Skip mime type check only for files on network mounts

davidedmundson added a comment. > True, but then that implies that KFileItem::isSlow() which has the same code is flawed in the same way. It is. We have ironic lockups there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma,

D23257: Allow for easier syncing of Plasma font

filipf added a comment. In D23257#514320 , @davidedmundson wrote: > Either SDDM code should deserialize the font (so that the italics and sizes and such work) This is much better than just setting the font family, I pushed a change in

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 339 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/339/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 19 Aug 2019 09:52:59 + Build duration: 6 min 55 sec and counting CONSOLE OUTPUT

D23185: [libtaskmanager] Port to lighter KProcessList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:83ca6de8fcd7: [libtaskmanager] Port to lighter KProcessList (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23237: Do not display vendor, Product and capacity in network plasmoid

pkloc added a comment. Is this information really that cluttering to mandate removal? Sure, vendor and model may be too "advanced" but remaining capacity is an useful hint. I always liked this sort of stuff when coming from Windows. I would argue that capacity counts as "state".

D23250: Try to fix i18n() timing error in version strings

apol added a comment. Doesn't the visible addition solve it already? We can keep the i18n() call, it will fail in this case but since it's not visible it isn't a big problem anyway. @pino it's just not available in brief occasions when loading updates. REPOSITORY R134 Discover

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In D23237#514325 , @broulik wrote: > It literally says in the commit message that this will be moved exactly there. I definitely need more coffee, sorry. O:-) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23237: Do not display vendor, Product and capacity in network plasmoid

broulik added a comment. It literally says in the commit message that this will be moved exactly there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23237 To: meven, ngraham, #plasma, broulik, #vdg, filipf Cc: alexde, apol, plasma-devel, LeGast00n,

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In which GUI do I find "Vendor" and "Model" now? There's the "Energy Information" in KInfocenter, which has a section "manufacturer" (in screenshot "Herstller"), but only lists the serial number. Maby it could go there? F7259918: Screenshot_20190819_105414.png

D23257: Allow for easier syncing of Plasma font

davidedmundson added a comment. We have a mixture of two things. Here we have a serialised QFont stored as font=Lato,11,-1,5,50,0,0,0,0,0,Regular using these magic methods: QDataStream ::operator<<(QDataStream , const QFont ) That tell other code how to turn a QFont

D23237: Do not display vendor, Product and capacity in network plasmoid

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. You cannot remove those from the dataengine, which is "Public API", there might be other users of that. Instead, remove them from the battery monitor UI. And while at it maybe show the

D23257: Allow for easier syncing of Plasma font

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Currently the user needs to have a fonts replacment file in /.config/conf.d/ if they want to sync their Plasma font with SDDM.

D23237: Do not display vendor, Product and capacity in network plasmoid

meven added a comment. In D23237#514287 , @meven wrote: > In D23237#514154 , @apol wrote: > > > LGTM but the title looks wrong, this isn't the network plasmoid. > > > Fixed Sorry it is

D23237: Do not display vendor, Product and capacity in network plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8e8441146aa8: Do not display vendor, Product and capacity in network plasmoid (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23237: Do not display vendor, Product and capacity in network plasmoid

meven added a comment. In D23237#514154 , @apol wrote: > LGTM but the title looks wrong, this isn't the network plasmoid. Fixed I didn't except that to be that consensual ;) REPOSITORY R120 Plasma Workspace BRANCH master

D23253: [Notifications] Don't allow popup to obscure things in corners

broulik added a comment. Not a fan. F7259717: Screenshot_20190819_085603.png INLINE COMMENTS > Globals.qml:230 > if (popupLocation & Qt.AlignBottom) { > -y += screenRect.height; > +y += screenRect.height -

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. In D23242#514239 , @hein wrote: > Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user