D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr closed this revision. spstarr added a comment. Merged into master, Plasma/5.16. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma, ngraham, kossebau Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr added a comment. In D23307#516304 , @kossebau wrote: > Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable. Sure thing, ill do in morning REPOSITORY R120 Plasma

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64265. apol added a comment. positioning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64264=64265 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES

D22513: Expose if we're still searching for more results

apol added inline comments. INLINE COMMENTS > broulik wrote in sourcesmodel.h:45 > In the new model it is "querying". Should we unify this? Well that querying property renders this patch irrelevant. See D22514 . REPOSITORY R112 Milou BRANCH master

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64264. apol added a comment. Use the new querying property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=61925=64264 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514

D22514: Show if KRunner is still searching for more things

ngraham added a comment. In D22514#512182 , @aspotashev wrote: > In D22514#502062 , @apol wrote: > > > Please review D22540 so I can offer a better solution for

D23330: Make manual control compatible with redshift >= 1.12

vermeeren added a comment. In D23330#516238 , @ngraham wrote: > Is `redshift -P -O` fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12. I checked and this is not the

D23330: Make manual control compatible with redshift >= 1.12

vermeeren updated this revision to Diff 64263. vermeeren added a comment. Only add -P option for redshift >= 1.12, avoids breaking redshift < 1.12. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23330?vs=64249=64263 REVISION DETAIL https://phabricator.kde.org/D23330 AFFECTED

D23307: [weather] [envcan] Add additional current condition icon mappings

kossebau accepted this revision. kossebau added a comment. Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma, ngraham,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack updated this revision to Diff 64261. cblack added a comment. Unscrew indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=64260=64261 BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 AFFECTED

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack updated this revision to Diff 64260. cblack added a comment. Add font.pointSize: config.fontSize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=63936=64260 BRANCH arcpatch-D21815 REVISION DETAIL

D23330: Make manual control compatible with redshift >= 1.12

ngraham added a comment. Is `redshift -P -O` fully backwards-compatible with older versions of redshift? If not, then this will just break everyone not using >=1.12. REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D23330 To: vermeeren,

D23330: Make manual control compatible with redshift >= 1.12

vermeeren added a comment. I am not sure how the version scheme will work now that this plasmoid is officially part of KDE, but once this is merged the version should definitely be bumped as this is a critical issue preventing use of manual mode. See also:

D23330: Make manual control compatible with redshift >= 1.12

vermeeren created this revision. vermeeren added a reviewer: martinkostolny. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vermeeren requested review of this revision. REVISION SUMMARY BUG: 395641 Redshift version >= 1.12 requires the -P option to clear the

D23328: Exclude other desktop file from AppStream metadata generation

mak added a comment. I didn't test this, but I wrote the code which will handle this and it works in other cases ;-) My comment was to confirm that the commit does indeed what you intend it to do, according to the spec and code. REPOSITORY R124 System Settings REVISION DETAIL

D23328: Exclude other desktop file from AppStream metadata generation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R124:7f8d58958df9: Exclude other desktop file from AppStream metadata generation (authored by ngraham). REPOSITORY R124

D23328: Exclude other desktop file from AppStream metadata generation

ngraham added a comment. In D23328#516191 , @mak wrote: > Effect is `kdesystemsettings.desktop` not being shown in any software center. > LGTM Thanks! How are you testing this? REPOSITORY R124 System Settings REVISION DETAIL

D23328: Exclude other desktop file from AppStream metadata generation

mak added a comment. Effect is `kdesystemsettings.desktop` not being shown in any software center. LGTM REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23328 To: ngraham, kossebau, apol, mak Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23306: Add AppStream metadata file

ngraham added a comment. All right, hopefully the third time's the charm: D23328 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23306 To: ngraham, apol, mak, #plasma Cc: kossebau, plasma-devel, LeGast00n,

D23328: Exclude other desktop file from AppStream metadata generation

ngraham created this revision. ngraham added reviewers: kossebau, apol, mak. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY See discussion in https://phabricator.kde.org/D23306#516172 REPOSITORY R124 System

D23325: Use non-deprecated .metainfo.xml filename extension

This revision was automatically updated to reflect the committed changes. Closed by commit R124:16a43f64532b: Use non-deprecated .metainfo.xml filename extension (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23325?vs=64243=64244#toc REPOSITORY R124 System

D23325: Use non-deprecated .metainfo.xml filename extension

ngraham updated this revision to Diff 64243. ngraham added a comment. You assume far too much competance on my part :) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23325?vs=64240=64243 BRANCH appdata-to-metainfo (branched from Plasma/5.16)

D23306: Add AppStream metadata file

mak added a comment. In D23306#515666 , @kossebau wrote: > In D23306#515662 , @mak wrote: > > > In D23306#515616 , @kossebau wrote: > > > > > Thanks!

D23325: Use non-deprecated .metainfo.xml filename extension

kossebau added a comment. I assume you also change the cmake install command in app/CMakeLists.txt in the final patch, though :) REPOSITORY R124 System Settings BRANCH appdata-to-metainfo (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D23325 To: ngraham,

D23306: Add AppStream metadata file

ngraham added a comment. In D23306#516094 , @kossebau wrote: > @ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix: > > > While desktop-application

D23325: Use non-deprecated .metainfo.xml filename extension

ngraham created this revision. ngraham added reviewers: kossebau, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Recommended by

D23324: Show progress for PackageKit update fetching

ngraham added a comment. And finally, it would be nice to display the text + progress indicator in the center of the view, not at the very top. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D23324 To: apol, ngraham Cc: plasma-devel, LeGast00n,

D23324: Show progress for PackageKit update fetching

ngraham added a comment. Also hide the placeholder icon while the progress indicator is visible so this doesn't happen: F7267868: Screenshot_20190821_113828.png REPOSITORY R134 Discover Software Store REVISION DETAIL

D23324: Show progress for PackageKit update fetching

apol updated this revision to Diff 64238. apol added a comment. Lose the BusyIndicator REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23324?vs=64237=64238 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23324 AFFECTED

D23324: Show progress for PackageKit update fetching

apol created this revision. apol added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It takes longtime on some distros, so we better show some information about how it's evolving. TEST

D23306: Add AppStream metadata file

kossebau added a comment. @ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix: > While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

ngraham updated this revision to Diff 64229. ngraham added a comment. Adjust to the fact that the Switch user button is always visible now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23283?vs=64226=64229 BRANCH revamp-session-switching-ux

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

ngraham updated this revision to Diff 64226. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23283?vs=64088=64226 BRANCH revamp-session-switching-ux REVISION DETAIL https://phabricator.kde.org/D23283 AFFECTED

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de409edb4900: [Lock screen] Always show Switch User button regardless of whether fake… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23306: Add AppStream metadata file

kossebau added a comment. Hi @mak, so seems we appdata content creators are still unsure what to do, allow me to put the last question of last night again to your attention: In D23306#515666 , @kossebau wrote: > In D23306#515662

D23320: Tell AppStream generators not to index Klipper .desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d753fa01679d: Tell AppStream generators not to index Klipper .desktop files (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23306: Add AppStream metadata file

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b249a3d4e76e: Add AppStream metadata file (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64221=64222 REVISION DETAIL

D23306: Add AppStream metadata file

ngraham updated this revision to Diff 64221. ngraham marked an inline comment as done. ngraham added a comment. Remove unnecessary X-AppStream-Ignore property REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64171=64221 BRANCH

D23306: Add AppStream metadata file

kossebau added inline comments. INLINE COMMENTS > kdesystemsettings.desktop:163 > X-DBUS-ServiceName=org.kde.systemsettings > +# Otherwise Discover and other software centers show two System Settings > entries > +X-AppStream-Ignore=true For what I understood from "No. A launchable tag always

D23320: Tell AppStream generators not to index Klipper .desktop files

ngraham created this revision. ngraham added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Same deal as D23306 . We need to tell AppStream

D23049: Add Kirigami ListSectionHeader component

GB_2 updated this revision to Diff 64217. GB_2 added a comment. Improve look REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23049?vs=63662=64217 BRANCH arcpatch-D23049 REVISION DETAIL https://phabricator.kde.org/D23049 AFFECTED FILES Mainpage.dox

D23319: Add dark theme icons

This revision was automatically updated to reflect the committed changes. Closed by commit R856:6a6e3ac78efb: Add dark theme icons (authored by ndavis). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23319?vs=64213=64214 REVISION DETAIL

D23319: Add dark theme icons

ndavis created this revision. ndavis added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Dark theme icons for Firefox REPOSITORY R856 Plasma Browser Integration BRANCH pbi-icons

D23318: Add dark theme in the extension popup

This revision was automatically updated to reflect the committed changes. Closed by commit R856:02ea1012348d: Add dark theme in the extension popup (authored by ognarb). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23318?vs=64209=64210

D23318: Add dark theme in the extension popup

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY R856 Plasma Browser Integration BRANCH darkTheme (branched from master) REVISION DETAIL https://phabricator.kde.org/D23318 To: ognarb, broulik Cc: broulik,

D23318: Add dark theme in the extension popup

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. TEST PLAN Tested in firefox REPOSITORY R856 Plasma Browser Integration BRANCH darkTheme (branched from master) REVISION DETAIL

D23292: Make update page labels consistent with topUpdateComp

MrPepe added a comment. Weird, I actually updated my git config before comitting. Will pay attention to it next time. Thanks for landing it! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D23292 To: MrPepe, #discover_software_store, ngraham Cc:

D23126: Add browser action for status reporting

This revision was automatically updated to reflect the committed changes. Closed by commit R856:4356d9306990: Add browser action for status reporting (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23126?vs=63707=64207#toc REPOSITORY R856 Plasma Browser

D22513: Expose if we're still searching for more results

broulik added inline comments. INLINE COMMENTS > sourcesmodel.h:45 > Q_PROPERTY(QIcon runnerIcon READ runnerIcon NOTIFY runnerChanged) > +Q_PROPERTY(bool isActive READ isActive NOTIFY isActiveChanged) > In the new model it is "querying". Should we unify this? REPOSITORY R112 Milou

D23049: Add Kirigami ListSectionHeader component

ngraham added a comment. After living with this for a bit, I feel like maybe the following UI changes might be good to make the effect a bit more subtle: - Reduce the opacity of the gray background bit so the header doesn't feel like "a hole in the view" - Experiment with removing or

D23317: Change icon colors, add disabled icons

This revision was automatically updated to reflect the committed changes. Closed by commit R856:78ef72d5ba5b: Change icon colors, add disabled icons (authored by ndavis). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23317?vs=64201=64202

D23317: Change icon colors, add disabled icons

broulik added a comment. shipit! REPOSITORY R856 Plasma Browser Integration BRANCH pbi-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23317 To: ndavis, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23317: Change icon colors, add disabled icons

ndavis updated this revision to Diff 64201. ndavis added a comment. rename svgs REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23317?vs=64200=64201 BRANCH pbi-icons (branched from master) REVISION DETAIL

D23317: Change icon colors, add disabled icons

ndavis updated this revision to Diff 64200. ndavis added a comment. undo rename REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23317?vs=64199=64200 BRANCH pbi-icons (branched from master) REVISION DETAIL

D23317: Change icon colors, add disabled icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R856 Plasma Browser Integration BRANCH pbi-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23317 To: ndavis, broulik Cc: plasma-devel,

D23317: Change icon colors, add disabled icons

ndavis created this revision. ndavis added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REPOSITORY R856 Plasma Browser Integration BRANCH pbi-icons (branched from master) REVISION DETAIL

D23122: Enable enhanced media controls by default

This revision was automatically updated to reflect the committed changes. Closed by commit R856:d4ab4e922404: Enable enhanced media controls by default (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23056: RFC: Don't auto-restart KRunner when crashed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1315ea0d3707: Dont auto-restart KRunner when crashed (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23056?vs=63437=64193 REVISION

D23294: [Notifications] Bring back dismissed progress in case of crash

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5806f4969604: [Notifications] Bring back dismissed progress in case of crash (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23305: Add plugin showing nvidia GPU load stats

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R111 KSysguard Library BRANCH plugins2 REVISION DETAIL https://phabricator.kde.org/D23305 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, LeGast00n,

D23296: Simplify rendering of raised toolbuttons with menu

ndavis added a comment. Let's abandon it for now. We can always come back if we change our minds. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23296 To: hpereiradacosta, #breeze, ndavis Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64189. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64155=64189 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #39 from Stefan Schmid --- Since I switched to "dbus-broker" the error did not occur any more. -- You are receiving this mail because: You are the assignee for the bug.

D23287: Create a plugin framework for processes

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Just a few small things I came across when working on the network plugin. INLINE COMMENTS > extended_process_list.cpp:82 > +for (auto plugin: pluginObjects) { > +

D23126: Add browser action for status reporting

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. For the png problem it was because I had a navbar with the same color. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23126 To: broulik,

D23056: RFC: Don't auto-restart KRunner when crashed

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > which might have been what David was referring to Yeah, it was. I'd like us to find a way to make that behaviour choosing explicit not inferred from restart

D23126: Add browser action for status reporting

ognarb added a comment. Tested in Firefox: The PNG is not displayed. I'm not a fan of using string as enum value (portStatus). INLINE COMMENTS > action_popup.css:22 > + > +section { > +padding: 1em; Not used > ognarb wrote in action_popup.css:32 > Why it is empty? Or maybe

D23296: Simplify rendering of raised toolbuttons with menu

hpereiradacosta added a comment. In D23296#515696 , @ndavis wrote: > Hmm. I was thinking about using the button background of the dropdown menu for something like this mockup: F7265921: Screenshot_20190820_203213.png