D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

ngraham added a comment. Lovely contribution! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

This revision was automatically updated to reflect the committed changes. Closed by commit R114:37e9c5a62883: In the note applet, always paste without formatting by default. Add an action… (authored by luc4, committed by ngraham). CHANGED PRIOR TO COMMIT

D21273: Add support for newer linux kernel power_supply API

luc4 added a comment. Ping. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23795: HiDPI icon in buttons and menus

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Only enable sharp icons in toolbar widgets and menus. Process list and sensor graphs are in different repo. REPOSITORY R106

D23794: HiDPI icon pixmap

GB_2 added a comment. Please add subscribers and reviewers next time. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23794 To: guoyunhe, #plasma Cc: GB_2, #plasma, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel,

D23794: HiDPI icon pixmap

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Return HiDPI icon pixmap, so the icon in process list is sharp in HiDPI display. REPOSITORY R111 KSysguard Library BRANCH

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7331506: Kicker⁄Kickoff Context Menu Items Icons and Correct Capitalizations.png

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. BTW: if by 2200 UTC none of the two solutions mentioned above (continuation lines, or single long lines) is implemented, I will revert the majority of a798e78d477e (leaving only the .pot

D23784: Remove custom content item from ActionMenu separator

This revision was automatically updated to reflect the committed changes. Closed by commit R169:01fe807d9950: Remove custom content item from ActionMenu separator (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23784?vs=65647=65653

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527719 , @romangg wrote: > In D23783#527582 , @pino wrote: > > > It's a normal QML function ... > > > If it's just a QML function why is it a problem to `+` some

D23783: [kcm] Fix i18n output file name and split texts

romangg added a comment. In D23783#527582 , @pino wrote: > It's a normal QML function ... If it's just a QML function why is it a problem to `+` some strings when providing them as an argument? REPOSITORY R104 KScreen REVISION DETAIL

D23151: Implement Web Share API through Purpose

broulik updated this revision to Diff 65650. broulik added a comment. - Register navigator.share only if host supports it - Use custom event instead of `window.postMessage` - Drop unused KNotifications dependency REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 planned changes to this revision. GB_2 added a comment. I'll try to work more on this in the future. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n,

D23784: Remove custom content item from ActionMenu separator

ahiemstra added inline comments. INLINE COMMENTS > apol wrote in ActionsMenu.qml:32 > I don't think the Component {} wrapping is necessary. You are right, it is not needed. I have also removed it from itemDelegate. REPOSITORY R169 Kirigami BRANCH menu_separator REVISION DETAIL

D23785: Rename activities context menu item in task manager to "Show in Activities"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b411c132d77b: Rename activities context menu item in task manager to Show in Activities (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg created this revision. kishoreg added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY This patch removes some spacing which was making the 'switch users' button get slightly

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

kishoreg added a comment. The problem is that the original patch was changing the maximum range of the sliders for application streams and microphones as well. This seemed a bit counter-intuitive, as for example capping the volumes of both the speaker and the music player at 15% would lead

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

ngraham added a comment. Doesn't this kind of defeat the purpose of the original change? If you can easily override the maximum volume that you've deliberately set, then what's the point? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23768 To:

D23784: Remove custom content item from ActionMenu separator

apol added a comment. Other than that, LGTM +1 INLINE COMMENTS > ActionsMenu.qml:32 > property Component itemDelegate: Component {ActionMenuItem {}} > -property Component separatorDelegate: Component { > -Controls.MenuSeparator { > -contentItem: Rectangle { > -

D23783: [kcm] Fix i18n output file name and split texts

zzag added a comment. In D23783#527562 , @pino wrote: > Please do not split the messages just for sake of column width. > > What about just removing the `+` to concatenate the strings, and just use normal continuation, i.e.: > > text:

D23783: [kcm] Fix i18n output file name and split texts

victorr added a comment. When I built the package, I made lines like this text: i18n("Are you sure you want to disable all outputs? "\n "This might render the device unusable.") text: i18n("New global scale applied. "\n "Change will come

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

victorr added a comment. Need to add dependency kf5kdelibs4support-devel in CMakeLists.txt Without this dependency, the assembly crashes with an error. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: yurchor, victorr,

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527600 , @romangg wrote: > diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml > index 2e61aa5..191daf3 100644 > --- a/kcm/package/contents/ui/main.qml > +++

D23783: [kcm] Fix i18n output file name and split texts

romangg added a comment. diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml index 2e61aa5..191daf3 100644 --- a/kcm/package/contents/ui/main.qml +++ b/kcm/package/contents/ui/main.qml @@ -41,8 +41,8 @@ KCM.SimpleKCM {

D23785: Rename activities context menu item in taska manager to "Show in Activities"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Sync with change in D23779 . TEST PLAN Open the context menu

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527581 , @romangg wrote: > In D23783#527579 , @pino wrote: > > > Which macro? > > > `i18n(...)` or "function"? It's a normal QML function ... REPOSITORY

D23783: [kcm] Fix i18n output file name and split texts

romangg added a comment. In D23783#527579 , @pino wrote: > Which macro? `i18n(...)` or "function"? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23783 To: romangg, #plasma, victorr, yurchor Cc: pino,

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527575 , @romangg wrote: > In D23783#527562 , @pino wrote: > > > Please do not split the messages just for sake of column width. > > > If there is a better

D23783: [kcm] Fix i18n output file name and split texts

romangg added a comment. In D23783#527562 , @pino wrote: > Please do not split the messages just for sake of column width. If there is a better solution than splitting text with a `+` while still respecting the line chars limit I will

D23784: Remove custom content item from ActionMenu separator

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Since MenuSeparator is properly styled by QQC2 Desktop Style these days, there

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. Please do not split the messages just for sake of column width. What about just removing the `+` to concatenate the strings, and just use normal continuation, i.e.: text: i18n("Are you sure you want to disable all outputs? " "This might render

D23783: [kcm] Fix i18n output file name and split texts

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a798e78d477e: [kcm] Fix i18n output file name and split texts (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23783?vs=65636=65638 REVISION

D23783: [kcm] Fix i18n output file name and split texts

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R104 KScreen BRANCH fixI18n REVISION DETAIL https://phabricator.kde.org/D23783 To: romangg, #plasma, victorr, yurchor Cc: plasma-devel, LeGast00n,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. @victorr @yurchor see D23783 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: yurchor, victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos,

D23783: [kcm] Fix i18n output file name and split texts

romangg created this revision. romangg added reviewers: Plasma, victorr, yurchor. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The output file name must be kcm_kscreen.po for translators to pick it up and

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

yurchor added a comment. In D22468#526517 , @romangg wrote: > In D22468#526465 , @ngraham wrote: > > > Like so: > > `xi18n("@info", "the first 100 charactersthe next 100 charactersand so on");`