KDE CI: Plasma » ksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Sep 2019 03:37:19 + Build duration: 55 min and counting CONSOLE OUTPUT [...truncated 820

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/11/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 18 Sep 2019 03:36:40 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham accepted this revision. ngraham added a comment. This is really excellent work. Let's get it in before 5.17 branches. INLINE COMMENTS > Menu.qml:33 > +} > +MenuItem { > +iconName: "edit-copy" Add icon > Menu.qml:41 > +} > +MenuItem { > +iconName:

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66353. cblack added a comment. Background color of icons grid now uses view background color again REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66346=66353 BRANCH modernization (branched from master)

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66351. apol added a comment. Include a provider for plasmashell REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66342=66351 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED

D24036: Fix the last fix of the max y-range computation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. You good now? REPOSITORY R102 KInfoCenter BRANCH ymax_again (branched from master) REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg, ngraham Cc: plasma-devel,

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Should sort case-insensitively, so this doesn't happen: F7372225: Screenshot_20190917_173807.png Also I still think the view background color for the scrollview would be good to bring back, so we don't have 100% of the UI

D24038: Improve output enablement recovery and config write

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Remember or calculate position and mode size after an output has been enabled again.

D24021: Delay load on output add/remove

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7efeabc5b4ac: Delay load on output add/remove (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24021?vs=66287=66348#toc REPOSITORY R104 KScreen CHANGES SINCE LAST

D24037: Add enforced mode size getter

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Introduce little helper to API, which gives back either the current mode size or if no current

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack added a comment. In D23712#533514 , @ngraham wrote: > I'm not sure it's working Should be working now REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 66346. cblack added a comment. Fix sorting, remove hardcoded icons REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=66180=66346 BRANCH modernization (branched from master) REVISION DETAIL

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66344. alexde added a comment. The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ... REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66343=66344

D24036: Fix the last fix of the max y-range computation

alexde added a comment. This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend. Regards REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg,

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66343. alexde added a comment. Add range check for index variable REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66340=66343 BRANCH ymax_again (branched from master) REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66342. apol marked an inline comment as done. apol added a comment. Don't use "telemetry" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66298=66342 BRANCH master REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > aspotashev wrote in feedback.cpp:41 > "telemetry" is also ambiguous. These are also telemetries: > > 1. Ksysguard daemon, > 2. GPS and altitude measurements being received from a UAV. He was suggesting moving

D24036: Fix the last fix of the max y-range computation

alexde added a comment. In D24036#533557 , @ngraham wrote: > I still get: > > file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined >

D24036: Fix the last fix of the max y-range computation

ngraham added a comment. I still get: file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError:

D24036: Fix the last fix of the max y-range computation

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The last fixed was not correct. This version should serve better. REPOSITORY R102

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d360c5bc83ec: [Icons-Only Task Manager] Only show progress indicator for apps that are running (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. I'm not sure it's working: F7370579: Screenshot_20190917_140415.png REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg,

D24033: Add Meta+Space as a default shortcut to activate KRunner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4000bd5db5f4: Add Meta+Space as a default shortcut to activate KRunner (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24033: Add Meta+Space as a default shortcut to activate KRunner

ngraham added a comment. In D24033#533505 , @romangg wrote: > I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications. >

D24033: Add Meta+Space as a default shortcut to activate KRunner

GB_2 added a comment. In D24033#533505 , @romangg wrote: > I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications. > >

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack added a comment. In D23712#532224 , @ngraham wrote: > Awesome. > > Didn't the main icon grid used to have a white background? I kind of liked that. Speaking of the icon grid, I'm somehow only not noticing that it's not sorted in any

D24033: Add Meta+Space as a default shortcut to activate KRunner

romangg added a comment. I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications. REPOSITORY R120 Plasma Workspace BRANCH meta-space-for-krunner (branched from

D24033: Add Meta+Space as a default shortcut to activate KRunner

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1, but I'm curious what others have to say. I definitely agree that Meta should be for global shortcuts and global desktop shell related shortcuts in particular. REPOSITORY R120 Plasma

D23798: Polish Displays KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R104:d0dc9a7a1c1e: Polish Displays KCM UI (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66328=66329 REVISION DETAIL

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66328. ngraham marked an inline comment as done. ngraham added a comment. Address final review comment REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66303=66328 BRANCH clean-up-ui (branched from master)

D24033: Add Meta+Space as a default shortcut to activate KRunner

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY There are two proposed justifications for this change: - In general, VDG would like to

D23798: Polish Displays KCM UI

romangg accepted this revision. romangg added inline comments. INLINE COMMENTS > Panel.qml:44 > Layout.alignment: Qt.AlignHCenter > -opacity: count > 1 ? 1 : 0 > +visible: count > 1 ? 1 : 0 > `visible: count > 1` REPOSITORY R104 KScreen BRANCH clean-up-ui

D24011: Provide a telemetrics kcm module for Plasma

aspotashev added inline comments. INLINE COMMENTS > ngraham wrote in feedback.cpp:41 > I would avoid using the word "Telemetry". It has negative connotations. Maybe > "Feedback" instead. "telemetry" is also ambiguous. These are also telemetries: 1. Ksysguard daemon, 2. GPS and altitude

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 66322. apol added a comment. Use KDE's server REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=66273=66322 BRANCH arcpatch-D5961_1 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c87d90645dab: When asked to switch sessions, jump to session creation if theres nothing to… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24029: Fix maximum y-value-range computation

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e45efe059ca9: Fix maximum y-value-range computation (authored by alexde, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D24029: Fix maximum y-value-range computation

alexde created this revision. alexde added reviewers: VDG, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY Rounding to the next 10 did not work if the maximum value was something like y_max =

D23821: Clean up a few deprecated headers, and make dependencies more explicit

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6529788d5e07: Clean up a few deprecated headers, and make dependencies more explicit (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23821?vs=65727=66314#toc REPOSITORY

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8e63d4509267: Make renderDialGroove() area match the maximum renderDialContents() area (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis updated this revision to Diff 66312. ndavis added a comment. Remove extra declaration of `first` REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24008?vs=66264=66312 BRANCH dial1 (branched from master) REVISION DETAIL

D23798: Polish Displays KCM UI

GB_2 added a comment. In D23798#533361 , @ngraham wrote: > Thanks! Needs final approval from @romangg or someone else from #KWin before landing. Of course. REPOSITORY R104 KScreen BRANCH

D23798: Polish Displays KCM UI

ngraham added a comment. Thanks! Needs final approval from @romangg or someone else from #KWin before landing. REPOSITORY R104 KScreen BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham,

D23798: Polish Displays KCM UI

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. UI LGTM! REPOSITORY R104 KScreen BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin, GB_2 Cc: filipf,

D24005: Show a new version string description for updates where the old and new versions are identical

This revision was automatically updated to reflect the committed changes. Closed by commit R134:482e2b4038f8: Show a new version string description for updates where the old and new… (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24005: Show a new version string description for updates where the old and new versions are identical

ngraham updated this revision to Diff 66306. ngraham added a comment. Add a happy little comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24005?vs=66305=66306 BRANCH new-version-string-presentation (branched from master) REVISION

D24005: Show a new version string description for updates where the old and new versions are identical

ngraham updated this revision to Diff 66305. ngraham added a comment. Use only a single string REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24005?vs=66257=66305 BRANCH new-version-string-presentation (branched from master) REVISION

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66303. ngraham added a comment. Unify name and caption between desktop file and kaboutdata REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66302=66303 BRANCH clean-up-ui (branched from master) REVISION

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in Panel.qml:90 > "Output" is a bit too technical I think, and"Monitor" doesn't cover the case > of projectors. Personally I like "Display" but I'm open to being convinced > otherwise. +1 for display REPOSITORY R104 KScreen

D23798: Polish Displays KCM UI

ngraham added inline comments. INLINE COMMENTS > romangg wrote in Panel.qml:77 > Options below does not only affect the currently shown output above but all > outputs in the current configuration. I don't think this is clear anymore > with only the horizontal line. I think the fact that the

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66302. ngraham added a comment. Make visualization width smarter so it matches the layout's width better REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66301=66302 BRANCH clean-up-ui (branched from master)

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66301. ngraham marked 3 inline comments as done. ngraham added a comment. Address all outstanding review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66269=66301 BRANCH clean-up-ui (branched from

D24011: Provide a telemetrics kcm module for Plasma

ngraham added a comment. If this KCM is purely for Plasma, then we kind of have a problem, because we're putting the global switch in it, but it also has to show Plasma-specific stuff. If you change the text that says "We make Plasma for you" into "We make software for you", then the

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. Hey @ngraham, I introduced many of your points to the proposal. Here's some thoughts on the rest: > Apps that collect information I don't think we can do this, at least not right now, easily. Non-Plasma products (dolphin, krita) will need to have their own KCM

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol added a comment. > Shouldn't these be in Kirigami, then? Let's see what it ends up looking like, we've already moved half this patch to plasma-workspace. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5961 To: apol, #plasma, vkrause Cc:

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66298. apol added a comment. Improve how we display plasma settings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66292=66298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011

D5961: PoC: Generic adoption of KUserFeedback for Discover

ngraham added a comment. This doesn't build for me: [ 82%] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasmauserfeedback.cpp.o In file included from /home/nate/kde/build/discover/discover/plasmauserfeedback.cpp:4:

D11352: [RFC] Auto ordered systray

kmaterka added a comment. Sorry for interrupting this late in the review. I like the idea of consistent ordering very much, I even planned to implement this myself :) I have few comments: In D11352#227354 , @Pitel wrote: > - [...] remove

D24011: Provide a telemetrics kcm module for Plasma

ngraham added a comment. Also it would be nice if the screenshot depicting the current UI lived in the Test Plan section (and got updatd that with each iteration) so it doesn't get buried in the comment thread. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

ngraham added a comment. After opening the KCM for the first time, the checkbox is checked. I thought we were going to make this opt-in? If so, it needs to be **unchecked** by default. For the message, I would phrase it like this: > We make Plasma for you. You can help us improve

D5961: PoC: Generic adoption of KUserFeedback for Discover

ngraham added a comment. After opening the KCM for the first time, the checkbox is checked. I thought we were going to make this opt-in? If so, it needs to be **unchecked** by default. For the message, I would phrase it like this: > We make Plasma for you. You can help us improve

D24011: Provide a telemetrics kcm module for Plasma

davidedmundson added a comment. I think the hard part of the design is conveying that the top option is a global killswitch that will affect all kuserfeedback apps, whilst the bottom combo is the setting for all plasma things. Maybe some flat groupboxes, so it's Global settings

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This isn't ready yet without, at a minimum, the UI change I requested for the list view. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66292. apol added a comment. Copyrights REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66291=66292 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES CMakeLists.txt

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66291. apol added a comment. Include the policy, KUserfeedback decides the setting default, polishing. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66272=66291 BRANCH master REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

bcooksley added a comment. Please ensure that the KCM links to https://kde.org/privacypolicy-apps.php. It would also be appreciated if those implementing or modifying Telemetry in their applications read this first as well. Where you need to state what the KCM is for, it would be

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. F7368902: Screenshot_20190917_142756.png Screenshot, I thought I'd uploaded it already. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause Cc: davidedmundson,

D24011: Provide a telemetrics kcm module for Plasma

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in feedback.cpp:16 > Is including kdeglobals here deliberate? > > KUserFeedback won't read it..but maybe it makes sense? This setting needs to be read by every Plasma component, these can

D24011: Provide a telemetrics kcm module for Plasma

davidedmundson added a comment. Probably could do with a screenshot as I expect this will need quite thorough UI iterations to get the wording spot on. INLINE COMMENTS > feedback.cpp:16 > +, > m_globalConfig(KSharedConfig::openConfig(QStringLiteral("KDE/UserFeedback.conf"), >

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/3/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 20:02:12 + Build duration: 6 min 16 sec and counting JUnit Tests

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. In D24011#533038 , @broulik wrote: > Should we make it already a "Privacy" KCM just in case? No, I don't think this will undermine our users' privacy. If it did, I (we?) wouldn't be adding telemetry at all. This

D23257: Allow for easier syncing of Plasma font

davidedmundson added a comment. Makes sense REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24021: Delay load on output add/remove

romangg created this revision. romangg added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In order to give the KScreen daemon time to update the config settings after an output

D23578: Before requesting a scan, check the time threshold

meven added inline comments. INLINE COMMENTS > jgrulich wrote in handler.cpp:552 > This timer never gets deleted. timer will be one of the value of hash m_wirelessScanRetryTimer, which are cleaned line 516. I could be missing a delete there though such as `delete

D5961: PoC: Generic adoption of KUserFeedback for Discover

vkrause added a comment. +1 INLINE COMMENTS > DiscoverWindow.qml:71 > +surveyInterval: 30 > +feedbackServer: "http://localhost:8083/; > +encouragementInterval: 30 https://telemetry.kde.org/ REPOSITORY R134 Discover Software Store REVISION DETAIL

D23798: Polish Displays KCM UI

romangg added inline comments. INLINE COMMENTS > Panel.qml:77 > -Kirigami.FormData.label: i18n("Arrangement settings") > -} > Options below does not only affect the currently shown output above but all outputs in the current configuration. I don't think this is clear

D24011: Provide a telemetrics kcm module for Plasma

vkrause added a comment. In D24011#533038 , @broulik wrote: > Should we make it already a "Privacy" KCM just in case? I'm not convinced about that. "Privacy" is not something you need to enable (it's on by default), and it's not

D24011: Provide a telemetrics kcm module for Plasma

ognarb added inline comments. INLINE COMMENTS > main.qml:46 > +wrapMode: Text.WordWrap > +text: i18n("We make Plasma for you. You can help us improve it > by contributing information on how you use it. This allows us to make > sure we focus on things that matter to you.

D23798: Polish Displays KCM UI

romangg added inline comments. INLINE COMMENTS > Output.qml:48 > +width: model.size.width / screen.relativeFactor / 2 > +height: model.size.height / screen.relativeFactor / 2 > You can't change these parameters here. Afterwards the positioning will be broken. You can multiply the

D23798: Polish Displays KCM UI

romangg added a comment. In D23798#532979 , @ndavis wrote: > The orientation toolbuttons seem oversized. That's an issue with Kirigami styling as in my opinion with many other white space inconsistencies when looking at FormLayouts. What

D23578: Before requesting a scan, check the time threshold

jgrulich added inline comments. INLINE COMMENTS > main.qml:77 > id: handler > -onWirelessScanTimerEnabled: { > -if (enabled) { I wonder whether the timer in the applet itself should be running if we fail to scan, I think it should be stopped when we fail and

D23798: Polish Displays KCM UI

romangg added a comment. In D23798#532963 , @ngraham wrote: > Need a hand with the `TODO:` in main.qml. With can't be really fixed since the config and by that the output model is received asynchronously later on and to my knowledge the

D24011: Provide a telemetrics kcm module for Plasma

broulik added a comment. Should we make it already a "Privacy" KCM just in case? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eed2d620cbd5: Consistent virtual desktop numbering between Switch Window popup and taskbar (authored by marten). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24009: RFC: Make Breeze Dark darker

anthonyfieroni added a comment. I'm using it from 5.1 and it's great because it's not so dark, -1 from me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n,