D24276: Add text to speech functionality to klipper.

whiting updated this revision to Diff 66980. whiting added a comment. - Add speech synthesis engine selection combobox to general klipper settings page. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24276?vs=66978=66980 BRANCH speech

D24276: Add text to speech functionality to klipper.

whiting created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. whiting requested review of this revision. REVISION SUMMARY Add action with global shortcut to speak text selection and another to speak clipboard contents. Add another action to stop

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. Does it work if you use an absolute path to the library? Go to `$BUILDROOT/color-reload-module/libcolorreload-gtk-module.so` and run `gedit --gtk-module $PWD/libcolorreload-gtk-module.so` REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added a comment. $ gedit --gtk-module colorreload-gtk-module Gtk-Message: 17:44:24.968: Failed to load module "colorreload-gtk-module" What am I doing wrong? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack,

D24161: Make KCM look more like applet

ngraham added a comment. Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port devices, show the port chooser combobox instead of the name of the current port, in both

D24161: Make KCM look more like applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:608e9e6fe793: Make KCM look more like applet (authored by sefaeyeoglu, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The title is somewhat self explanatory. TEST PLAN `gtk-app-here --gtk-module

D24269: [krunner] Port old style connect

davidedmundson updated this revision to Diff 66964. davidedmundson added a comment. keep order REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24269?vs=66963=66964 REVISION DETAIL https://phabricator.kde.org/D24269 AFFECTED FILES

D24269: [krunner] Port old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24268: [libtaskmanager] Port to new connect syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY UniqueConnection I dropped as we disconnect the old source model above

D24267: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method

davidedmundson updated this revision to Diff 66961. davidedmundson added a comment. asdfasd REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24267?vs=66960=66961 BRANCH origin-master (branched from master) REVISION DETAIL

D24267: [soliduiserver] Port deprecated KPasswordDialog::setPixmap method

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN None REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

dfaure closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24255 To: dfaure, apol, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D24265: support global edit mode

ngraham added inline comments. INLINE COMMENTS > ToolBoxButton.qml:286 > +icon.height: units.iconSizes.smallMedium > +onClicked: qAction.trigger() > +} Locking the widgets while in edit mode doesn't update the menu item, so it's possible to end up in

D24264: edit mode action and dbus

ngraham added a comment. I wonder if the widget resize handles should become visible all the time when in edit mode. Otherwise nothing visually changes with the widgets on the desktop, and it might not be obvious enough that you can change them. REPOSITORY R120 Plasma Workspace REVISION

D24260: [Style KCM] Don't explicitly reload KWin's configuration

broulik added a comment. > You could probably make a compelling case that this one thing doesn't matter It doesn't matter because we don't signal KWin when we change the style, only when changing the "effects" settings (toolbar style, show icons on buttons and in menus), so the pixel

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66959. mthw marked an inline comment as done. mthw added a comment. > Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:56 > +if (powermanagementDisabled) { > +return i18n("Battery and Brightness") > +} You can probably just return `plasmoid.title` in the default case. Also, what's the reason for not showing

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. In D24070#538806 , @mthw wrote: > Like this? Don't we need to return something when "remainingTime <= 0"? No, because in this case it just doesn't show a subtitle, which I think is fine. REPOSITORY R120 Plasma

D21815: [sddm-theme] Start moving from QQC1 to QQC2

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66958. mthw added a comment. Like this? Don't we need to return something when "remainingTime <= 0"? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66487=66958 BRANCH master REVISION DETAIL

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. From what I can tell, the problem with `remainingTime` being 0 sometimes is a pre-existing bug that the current code is hiding fairly well by not showing the string that uses

D24265: support global edit mode

mart added a comment. yes, it's completely ortogonal to that one REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D24265: support global edit mode

GB_2 added a comment. Nice! I guess D23951 is still relevant? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24264: edit mode action and dbus

davidedmundson added inline comments. INLINE COMMENTS > appletslayout.cpp:100 > connect(m_window, ::activeChanged, this, [this]() { > -if (!m_window->isActive()) { > +if (!qApp->focusWindow()) { > setEditMode(false); But we only evaluate this

D24265: support global edit mode

mart added a comment. still has the problem of long press not working with the folderview layout (stolen events) will look into that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Is there still something that needs to be fixed, or can this go in? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

mart added a comment. F7447783: vokoscreen-2019-09-27_17-03-51.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24265: support global edit mode

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY desktop and panel toolboxes are only visible in "edit mode" edit mode can be triggered by - long

D13243: Add checkbox that can show virtual streams in the applet.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane enough to me. Even though it's a new esoteric option, it does seem useful for certain use cases and it's buried in a config window that almost nobody will ever see, so I think

D24264: edit mode action and dbus

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY edit mode menu action edit mode dbus property for systemsettings containmentlayoutmanager goes out of

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66952. sefaeyeoglu added a comment. Change behaviour of configuration. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66951=66952 BRANCH arcpatch-D13243 REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66951. sefaeyeoglu added a comment. Put checkbox into own category REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66926=66951 BRANCH arcpatch-D13243 REVISION DETAIL

D24260: [Style KCM] Don't explicitly reload KWin's configuration

davidedmundson added a comment. I had a look through kwin and kdecoration There's 5 or so things that fetch things from qstyle directly, but nothing seems to cache the value, with the exception of: effects/startupfeedback/startupfeedback.cpp:cursorSize =

D13243: Add checkbox that can show virtual streams in the applet.

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigGeneral.qml:89 > + > +QQC2.CheckBox { > +id: showRealDevicesOnly This isn't a feedback-related item so it shouldn't be in the Feedback

D24260: [Style KCM] Don't explicitly reload KWin's configuration

ngraham added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24260 To: broulik, #plasma, #kwin Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D24260: [Style KCM] Don't explicitly reload KWin's configuration

broulik created this revision. broulik added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ways only done for changes to the "effects", not the actual widget style, but: -

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66945. sefaeyeoglu added a comment. Align mute button centered with slider REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66943=66945 BRANCH feat-applet-ux REVISION DETAIL

D24258: Forward error message from backend to ui

ngraham added a comment. Heh, if that's a more accurate error message, I as a user would still have no clue what do to about it... REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24258 To: nicolasfella, #plasma, #kwin Cc: ngraham, broulik, plasma-devel, LeGast00n,

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66943. sefaeyeoglu added a comment. Fix wrong display name of default-device button REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66920=66943 BRANCH feat-applet-ux REVISION DETAIL

D24161: Make KCM look more like applet

GB_2 added a comment. I'd also align the mute button with the slider, like in the applet. INLINE COMMENTS > DeviceListItem.qml:89 > +Button { > +text: i18n("Default device") > +icon.name: "favorite" "Default Device" REPOSITORY R115

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ff0ac9ab879d: Fix clipping and use a real ScrollView for the Display Configuration KCM screen… (authored by GB_2). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24258: Forward error message from backend to ui

broulik added a comment. Maybe at least show "Failed to contact screen management service: $msg" REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24258 To: nicolasfella, #plasma, #kwin Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24258: Forward error message from backend to ui

nicolasfella created this revision. nicolasfella added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Saying that no backend was found is not accurate when there was a different

D24208: [Notifications] Dodge Plasma dialogs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc0c125479d4: [Notifications] Dodge Plasma dialogs (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24208?vs=66793=66940 REVISION

D24208: [Notifications] Dodge Plasma dialogs

mart accepted this revision. mart added a comment. this may be good in both .17 and master, then to see if is possible, only in master to actually move the notivications out of the way REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24208 To: broulik,

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 27 Sep 2019 08:44:13 + Build duration: 2 min 1 sec and counting JUnit Tests Name:

D24208: [Notifications] Dodge Plasma dialogs

mart added a comment. In D24208#538239 , @ngraham wrote: > This works great! > > Instead of temporarily hiding the pop-ups, maybe it should appear above the dialog? Not a huge deal though. > > 5.17 branch? would make sense...

D23675: [Folder View] Don't query file information if tooltips are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b636aa1a9ab3: [Folder View] Dont query file information if tooltips are disabled (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: ddcutil in Plasma Powerdevil

Hey Jonathan, Unfortunately I did not test it for a long time (last time was around 5.15), and don't really have the possibility now because I'm away from home. *If I remember correctly,* back then I had a few instances when the startup of plasma (during the splashscreen) was quite longer due to