D24454: Include an emoji picker

davidedmundson added a comment. > Why isn't it managing to send the paste data to klipper before quitting? How? 1. We announce "I have some new data" to X. 2. Then klipper sees that, then asks for the data 3. Then (via X) we get that request and send the data. It would

D24601: [mobile/wifi] Use network name as title for settings page

apol added inline comments. INLINE COMMENTS > ConnectionItemDelegate.qml:114 > onTriggered: { > -kcm.push("NetworkSettings.qml", {path: ConnectionPath}) > +kcm.push("NetworkSettings.qml", {path: ConnectionPath, name: > ItemUniqueName}) >

D24591: Set preview to correct device size

ngraham added a comment. This fixes the issue for the preview image of the currently-viewed theme, but not for the thumbnail images: F7583056: Screenshot_20191012_201015.png REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION

D24454: Include an emoji picker

ngraham added a comment. In D24454#545543 , @apol wrote: > Fix on wayland (and x11?) > > Don't ever close the process, leave it on background Hmm, that seems kind of like a sledgehammer solution to the problem. Why isn't it managing

D24603: Port away from deprecated KDELibs4Support

ahmadsamir added a comment. F7582001: kmenuedit-vs-dolphin-settings-dialog.png Looking at kmenuedit and dolphin settings dialog, the margin and spacing look comparable, so those setContentMargins and setSpacing calls aren't needed any more.

D24603: Port away from deprecated KDELibs4Support

ahmadsamir created this revision. ahmadsamir added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY kmenuedit seems to work, adding new submenus and items REPOSITORY R103 KMenu Editor

D24601: [mobile/wifi] Use network name as title for settings page

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Otherwise we have "configure wifi networks" twice in the top bar REPOSITORY R116

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. Ping! REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

GB_2 added a comment. In D24533#544784 , @filipf wrote: > This sort of a style, the line is right next to the title. > > F7567596: image.png Hmm, I think that would be too inconsistent again.

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

filipf added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:69 > Now that you added a RowLayout, this could go inside it rather than being > positioned with anchors It seems to me like this whole file can be rewritten with layouts (as opposed to using anchors).

D24283: Add clang format file

cullmann added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > s/coding/coding style/ Fixed that in D24568 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann,

D24011: Provide a telemetrics kcm module for Plasma

davidedmundson added a comment. Actually on or just the config saying it was on? Please upload your ~/.config/KDE/UserFeedback.conf to a bug report. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause, ngraham Cc: GB_2,

D24580: Fix minor EBN issues

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f9355ee60637: Fix minor EBN issues (authored by yurchor). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24580?vs=67760=67791 REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

GB_2 added a comment. I have updated two PCs and on both telemetry was on by default... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause, ngraham Cc: GB_2, aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik,

D24454: Include an emoji picker

apol added a comment. In D24454#545964 , @hein wrote: > If I understand right, the emoji workflow this implements is via copy-paste, it can't directly insert into the text fields via the IME bus. Do you have a plan for that? It has the

D24503: Integrate the normal keyboard layout switcher

apol added a comment. I don't claim to solve the whole problem, it's just a step forward. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24580: Fix minor EBN issues

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24580 To: yurchor, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

GB_2 added a comment. BTW, it would also be nice to have click and hold on the panel to open the panel controller toolbox :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:292 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} This should probably be changed to "Finish Customizing Layout" to match the current menu entry.

D24264: edit mode action and dbus

GB_2 added a comment. It still leaves the edit mode when closing a panel controller toolbox. REPOSITORY R120 Plasma Workspace BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma, #vdg, ngraham Cc: GB_2, ngraham, davidedmundson, plasma-devel,

D24591: Set preview to correct device size

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QQuickImage::sourceSize is in device pixels for pixmap images.

D24265: support global edit mode

GB_2 added a comment. This works very well now except for the vertical desktop toolbox. I don't think being able to have a vertical toolbar is practical, you can't really read the button labels and it's also glitching around when switching between horizontal and vertical mode. I think just

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added inline comments. INLINE COMMENTS > main.qml:27 > +import org.kde.kcm 1.1 as KCM > +import Qt.labs.platform 1.1 > + Is this actually used? Also, because it's not installed by default it shows an error. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24283: Add clang format file

davidedmundson abandoned this revision. davidedmundson added a comment. Lets do all this discussion on D24568 However, as this CC's the plasma team I would urge people again to follow up on that thread as I do intend on running it across all plasma

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

hein added a comment. Ping @gpark, are you available to resume work on this too? There's a growing amount of interest which means more dev hands to aid the effort. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: davideichelsdoerfer,

D24454: Include an emoji picker

hein added a comment. If I understand right, the emoji workflow this implements is via copy-paste, it can't directly insert into the text fields via the IME bus. Do you have a plan for that? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol,

D24503: Integrate the normal keyboard layout switcher

hein added a comment. It's a small part of the work Geon Park did in his GSoC project to refactor kimpanel and our input sources management in general, but in a more merge-friendly format. The former sadly never got any review attention because the patch was too big, so maybe this is

D24580: Fix minor EBN issues

yurchor created this revision. yurchor added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Include duplication, no newline at the end of file and missing argument to the i18n() call TEST