D24945: [ksmserver] Signal session management state to kwin directly

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in org.kde.KWin.Session.xml:7 > There was a third option I considered. Have N methods > > startSave > startQuit > saveCancelled > > and then make the state change an implicit part of the invokable action we > need to do on

D24953: [applets/weather] Use unit description from KUnitConversion

iasensio created this revision. iasensio added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision. REVISION SUMMARY Use unit description directly from KUnitConversion instead of making a new string. This

D24952: Add mmHg to pressure options in weather applet

iasensio created this revision. iasensio added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision. REVISION SUMMARY Add millimeters of mercury (mmHg) to pressure options in weather applet, which is a common

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in org.kde.KWin.Session.xml:7 > It also advocates for use of {sv} in your spec which is inherently string > based. > > I'm happy to use ints, as long as we then don't get into that trap of saying; > "now we have an

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in org.kde.KWin.Session.xml:7 > Here it recommends using uint for such things: > https://dbus.freedesktop.org/doc/dbus-api-design.html#interface-files It also advocates for use of {sv} in your spec which is inherently string

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

fvogt added a comment. In D24947#554005 , @meven wrote: > In D24947#554001 , @fvogt wrote: > > > IMO it's a good thing to have KRunner as application in the menu anyway > > > It was not in the

D24786: [GTK3] Add styles for libhandy widgets

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I guess it doesn't matter that much right now. REPOSITORY R98 Breeze for Gtk BRANCH hdy-styles (branched from master) REVISION DETAIL https://phabricator.kde.org/D24786 To: cblack,

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven added a comment. In D24947#554001 , @fvogt wrote: > IMO it's a good thing to have KRunner as application in the menu anyway It was not in the application menu before With this change (and without NoDisplay) it will be displayed.

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. IMO it's a good think to have KRunner as application in the menu anyway REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24947 To: meven,

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven created this revision. meven added reviewers: fvogt, apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Redo of D24857 afetr

D24945: [ksmserver] Signal session management state to kwin directly

apol added a comment. Looks good to me overall. It's better to use dbus. INLINE COMMENTS > org.kde.KWin.Session.xml:7 > + > + > + Here it recommends using uint for such things: https://dbus.freedesktop.org/doc/dbus-api-design.html#interface-files REPOSITORY

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68755. crossi added a comment. qml style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68748=68755 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > It's likely we'll encounter that ComboBox breakage at other places. we do :) https://cgit.kde.org/kscreen.git/tree/kcm/package/contents/ui/Panel.qml?id=7811411c6425dd52bcd732a5910d177fee4a89d2#n42 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Style wise, functions come before children objects. Other than that looks good to me. Through Kai comments, the question also becomes, wouldn't it be better to fix the root cause? It's likely we'll encounter that ComboBox breakage at other places. REPOSITORY

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553958 , @broulik wrote: > > Ah somehow I thought we had a third more "clever" case of currentIndex moving. > > Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :(

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > Ah somehow I thought we had a third more "clever" case of currentIndex moving. Heh, yea, there's also some more elaborate "change index while moving the mouse" going on :( So best hack would be to have a c++ thing that sets the property without going

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson updated this revision to Diff 68751. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24945?vs=68750=68751 BRANCH origin-master (branched from master) REVISION DETAIL

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Kwin had to have two ICE connections in order to track state indepdendently

D24916: KCM style : fix combobox that weren't updated after user made change

crossi updated this revision to Diff 68748. crossi added a comment. refactor code into a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24916?vs=68670=68748 REVISION DETAIL https://phabricator.kde.org/D24916 AFFECTED FILES

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553919 , @broulik wrote: > > AFAICT it won't be pretty though. :-) > > I think it's pretty straightforward > 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. > AFAICT it won't be pretty though. :-) I think it's pretty straightforward 1.) the delegate must not explicitly set a `currentIndex` because Qt does it for us, see D18299 2.) the wheel handler must be changed to call

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. In D24916#553886 , @broulik wrote: > Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... Good point... What about fixing that? AFAICT it won't be pretty

D24917: KCM Style port to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmstyle.cpp:317 > + > +m_model->setSelectedStyle(m_settings->widgetStyle()); > That line and the metaenum wrangling could likely be factored out somehow

D24853: [DigitalClock] Fix layout and QML warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82cfabd0a5c8: [DigitalClock] Fix layout and QML warnings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68743=68745

D24916: KCM style : fix combobox that weren't updated after user made change

broulik added a comment. Hm I think qqc2-desktop-style breaks the binding on `currentIndex`, otherwise this would not be neccessary... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel,

D24916: KCM style : fix combobox that weren't updated after user made change

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > EffectSettingsPopup.qml:72 > +onMainToolBarStyleChanged: { > +mainToolBarStyleCombo.currentIndex = >

D24853: [DigitalClock] Fix layout and QML warnings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24853 To: kmaterka, #plasma, #plasma_workspaces, ngraham Cc: ngraham,

D24942: Require and use the new NewStuffQuick Button component

ngraham added a comment. Nice. However it doesn't seem to work for me. If I install a theme using the dialog, it doesn't show up in the Global Themes KCM. Could it because of a typo (`changedEntryes.count()`) ? I've filed a bunch of bug reports regarding polishing the dialog itself:

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka updated this revision to Diff 68743. kmaterka added a comment. Remove hardcoded margins, these are not needed anymore. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68524=68743 BRANCH master REVISION DETAIL

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:58 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` I just copied values form the original Rectangle. I will remove it entirely, probably it's not needed anymore. REPOSITORY

D24846: Port kcm icons to kconfigxt

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in main.cpp:141 > Does this `KIconTheme` instance need caching? I recall creating those parses > a tonne of files and directories and is quite

D24942: Require and use the new NewStuffQuick Button component

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This removes the need for the custom hack for spawning a dialog, and is intended to function as a sample for how to implement this

D24934: [notifications] Center no notification text on mobile

mart added a comment. I'm fine with it, however... there must be a bug somewhere in the shell, because the whole notification applet is supposed to be invisible when there are none, i have to investigate into that REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24810: Ensure defintion of XDG_DATA_DIRS

adridg added inline comments. INLINE COMMENTS > dfaure wrote in startplasma.cpp:197 > Wait, where does /usr/local/etc/xdg come from? > https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html > says the default is only /etc/xdg. On FreeBSD (other BSD's, too), `/etc` is for

Plasma 5.18 Kickoff Meeting Wednesday 14:00UTC/19500CET

Let's have a Plasma 5.18 Kickoff meeting on Wednesday evening. Remember the clocks go back as you wake up on Sunday. 14:00UTC/GMT/British Isles and 15:00CET Meet in #plasma:kde.org Matrix room or #plasma freenode IRC channel Things to discuss and confirm: Review successes and failures of 5.17

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

mibofra added a comment. I've updated the diff! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24940 To: mibofra, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

mibofra updated this revision to Diff 68739. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24940?vs=68729=68739 REVISION DETAIL https://phabricator.kde.org/D24940 AFFECTED FILES libs/models/networkmodelitem.cpp To: mibofra,

D24856: Add a .desktop file to ksplashqml

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ksplashqml.desktop.cmake:8 > +X-DBUS-StartupType=Unique > +X-DBUS-ServiceName=org.kde.ksplashqml > +X-KDE-StartupNotify=false I think X-DBUS-* may not be necessary here. > ngraham wrote in

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68738. meven added a comment. Rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68737=68738 BRANCH arcpatch-D24856_1 REVISION DETAIL https://phabricator.kde.org/D24856 AFFECTED

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68737. meven added a comment. Add GenericName REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68520=68737 BRANCH arcpatch-D24856_1 REVISION DETAIL https://phabricator.kde.org/D24856 AFFECTED FILES

D24925: KCM KSplash port to ManagedConfigModule

crossi updated this revision to Diff 68734. crossi added a comment. Remove unnecessary override REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68699=68734 REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

broulik added a comment. That new time zone view lacks any form of keyboard navigation. I cannot use arrow keys to navigate it and neither can I hit space to toggle a checkbox. It also lacks a frame around its content area like the text field has. REPOSITORY R120 Plasma Workspace

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 68733. guoyunhe added a comment. Merge kmaterka's patch D24853 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68345=68733 BRANCH master REVISION DETAIL

D24810: Ensure defintion of XDG_DATA_DIRS

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please make sure the first line of the commit log says CONFIG and not DATA, too (the phab title still says DATA). INLINE COMMENTS > startplasma.cpp:197 > +if

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68732. tcberner edited the summary of this revision. tcberner added a comment. Update commit message in diff. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68731=68732 BRANCH master REVISION

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68731. tcberner added a comment. Fix comment and commit message. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68379=68731 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24810