D24068: docs: add contributing guide

romangg updated this revision to Diff 69020. romangg added a comment. Fix typo REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24068?vs=68918=69020 BRANCH contributing-guide REVISION DETAIL https://phabricator.kde.org/D24068 AFFECTED FILES

D25064: docs: add contributing guide

romangg updated this revision to Diff 69019. romangg added a comment. Fix typo REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25064?vs=69018=69019 BRANCH contributing-guide REVISION DETAIL https://phabricator.kde.org/D25064 AFFECTED FILES

D25064: docs: add contributing guide

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds a document providing information on how to contribute to libkscreen and additionally

D25043: [ResultDelegate] Use theme.disabledColor

filipf added a comment. In D25043#556268 , @ndavis wrote: > In D25043#555976 , @filipf wrote: > > > Not a fan of this for 2 reasons: > > > > - we have no control over color schemes; they might

D25062: fix(kded): read rotated output size

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY When adjusting positions on config read respect the rotation value on reading in the output

Plasma 5.17.2

Plasma 5.17.2 sources are now available for download https://kde.org/announcements/plasma-5.17.2.php

D25043: [ResultDelegate] Use theme.disabledColor

ndavis added a comment. In D25043#555976 , @filipf wrote: > Not a fan of this for 2 reasons: > > - we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 205 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/205/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:58:26 + Build duration: 1 hr 50 min and counting CONSOLE OUTPUT

D24985: [wallpapers/image] Seed random number generator

ngraham added a comment. Landed this on the 5.17 branch just now to make sure it gets in for Plasma 5.17.2. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24985 To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, apol, anthonyfieroni, plasma-devel,

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

ngraham added a comment. Landed this on the 5.17 branch just now to make sure it gets in for Plasma 5.17.2. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, plasma-devel, LeGast00n,

D24986: [wallpapers/image] Randomise new batches of images in the slideshow

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9dca7d6cd44c: [wallpapers/image] Randomise new batches of images in the slideshow (authored by davidedmundson, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24985: [wallpapers/image] Seed random number generator

This revision was automatically updated to reflect the committed changes. Closed by commit R120:868a6a9f6254: [wallpapers/image] Seed random number generator (authored by davidedmundson, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/41/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:56:34 + Build duration: 1 hr 21 min and counting CONSOLE OUTPUT

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. It occurs to me that we'll need a kconf update script to turn the desktop toolbox back on for all the legions of people who turned off via this setting that I'm removing here, or else the new global edit mode won't work for them. REPOSITORY R119 Plasma Desktop

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/54/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 17:58:24 + Build duration: 54 min and counting CONSOLE OUTPUT

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham created this revision. ngraham added reviewers: mart, GB_2, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY With the new global edit mode, both of the options on the Tweaks page become

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/17/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 17:56:39 + Build duration: 21 min and counting CONSOLE OUTPUT

D25053: Don't show "Customize Layout..." menu item in panel context menu

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with

D24985: [wallpapers/image] Seed random number generator

davidre accepted this revision. davidre added a comment. I think this is fine. Imo we can address the comments on master REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24985 To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, apol,

D25027: feat(kcm): zoom preview automatically

ngraham added inline comments. INLINE COMMENTS > romangg wrote in Screen.qml:67 > Yea, I ignore the row for now. We can think about a different position for > the button later on. I think it should be in one of the corners like it used > to be. Why not remove the Row in this revision? You

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68987. meven marked an inline comment as done. meven added a comment. ksplashqml is not a dbus service REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68738=68987 BRANCH arcpatch-D24856_2 REVISION

D25027: feat(kcm): zoom preview automatically

romangg added inline comments. INLINE COMMENTS > ngraham wrote in Screen.qml:67 > You don't need a Row here anymore because it now only contains one item; > instead you can just position the Identify button manually. Yea, I ignore the row for now. We can think about a different position for

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.12 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:18:04 + Build duration: 14 min and counting Cobertura Report Project

KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 SUSEQt5.12 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20SUSEQt5.12/23/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:18:02 + Build duration: 10 min and counting Cobertura Report

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 17:18:07 + Build duration: 10 min and counting

KDE CI: Plasma » discover » stable-kf5-qt5 SUSEQt5.12 - Build # 109 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/stable-kf5-qt5%20SUSEQt5.12/109/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 17:17:58 + Build duration: 7 min 14 sec and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/42/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 29 Oct 2019 17:17:55 + Build duration: 4 min 33 sec and counting

D24855: Rename "Close Edit Mode" tooltip to just "Close"

GB_2 updated this revision to Diff 68986. GB_2 added a comment. "Close" -> "Finish Customizing Layout" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24855?vs=68514=68986 BRANCH arcpatch-D24855 REVISION DETAIL

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

This revision was automatically updated to reflect the committed changes. Closed by commit R119:88bce0e49c7e: Hide Lock Widgets button from panel edit mode toolbar (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24162?vs=68476=68985

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f9a664cfd898: Only show Unlock Widgets in the UI, not Lock Widgets (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68510=68984

D25027: feat(kcm): zoom preview automatically

ngraham added inline comments. INLINE COMMENTS > Screen.qml:67 > > Row { > z: 90 You don't need a Row here anymore because it now only contains one item; instead you can just position the Identify button manually. REPOSITORY R104 KScreen REVISION DETAIL

D25048: Expose libkworkspace SessionManagement class to QML

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It was written with properties and signals intended for direct QML use.

D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY When a user tries to set operation mode to "Times", the Apply button remains enabled after it's been

D24734: [KCM] remove the page indicator dots

ngraham abandoned this revision. ngraham added a comment. I guess this isn't very popular. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24942: Require and use the new NewStuffQuick Button component

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, that fixes the issue. This works quite well now. Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)

D25045: kimpanel: don't crash when ibus is already loaded

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to replace the current engine if we already have an acceptable one set. Otherwise it confuses Qt and it asserts in Qt. 7

D25043: [ResultDelegate] Use theme.disabledColor

filipf added a comment. In D25043#556015 , @davidedmundson wrote: > @kbroulik we should try to wait if there is an ongoing discussion. > > > I have the latest package installed in KDE Neon Dev Unstable, does it need to be compiled instead

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 212 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/212/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:30:57 + Build duration: 3 hr 2 min and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 207 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/207/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:30:49 + Build duration: 3 hr 0 min and counting BUILD ARTIFACTS

D25043: [ResultDelegate] Use theme.disabledColor

davidedmundson added a comment. @kbroulik we should try to wait if there is an ongoing discussion. > I have the latest package installed in KDE Neon Dev Unstable, does it need to be compiled instead for some very recent change? Yes, there's a partner patch adding a disabledText role

D24917: KCM Style port to KConfigXT

crossi updated this revision to Diff 68978. crossi added a comment. Move some duplicated code to a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68671=68978 REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES

D25043: [ResultDelegate] Use theme.disabledColor

filipf added a comment. In D25043#555980 , @broulik wrote: > > in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: > > Make sure your plasma-framework is up to date I have the

D25043: [ResultDelegate] Use theme.disabledColor

This revision was automatically updated to reflect the committed changes. Closed by commit R112:eed4eb1ed5a1: [ResultDelegate] Use theme.disabledColor (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25043?vs=68970=68976 REVISION DETAIL

D25043: [ResultDelegate] Use theme.disabledColor

broulik added a comment. > in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: Make sure your plasma-framework is up to date > - it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is

D25043: [ResultDelegate] Use theme.disabledColor

filipf added a comment. Not a fan of this for 2 reasons: - we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: F7685168:

D25043: [ResultDelegate] Use theme.disabledColor

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yes please! I hate this opacity hack. (it's fewer nodes in the scene graph too!) REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D25043 To:

D25043: [ResultDelegate] Use theme.disabledColor

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes text more readable on dark backgrounds by not changing the text `opacity`. Subtext

D24688: [KCM] Disallow dropping screen outside of reachable area

romangg added a comment. See D25027 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24688 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25002: disable bug report when there are signs of an update

sitter updated this revision to Diff 68966. sitter added a comment. typo-- REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25002?vs=68965=68966 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25002 AFFECTED FILES src/backtracewidget.cpp

D25002: disable bug report when there are signs of an update

sitter updated this revision to Diff 68965. sitter added a comment. switch from list to bool since we don't actually use the list anyway REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25002?vs=68878=68965 BRANCH master REVISION DETAIL

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 211 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/211/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 10:29:40 + Build duration: 31 min and counting CONSOLE OUTPUT Started by an

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 206 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/206/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 10:29:40 + Build duration: 31 min and counting CONSOLE OUTPUT

D24865: [SystemTray] Support for AttentionIcon

kmaterka added inline comments. INLINE COMMENTS > broulik wrote in systemtray.cpp:354 > I think you don't need any of that. If you convert it to a `QIcon` which it > is not, it will return a default-constructed (null) `QIcon` You are of course correct, check will work without this. I wanted to

D25042: Rename cmake project to KActivityManagerd, remove unused option

meven created this revision. meven added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY KACTIVITIES_LIBRARY_ONLY is used only in kactiviy library. REPOSITORY R161 KActivity Manager Service

D24942: Require and use the new NewStuffQuick Button component

leinir updated this revision to Diff 68958. leinir added a comment. Together with the change in D25041 this makes the model reloading work (without that patch, it simply fails quietly as the signal forwarding fails). If wanted, we could also use the

D24865: [SystemTray] Support for AttentionIcon

broulik added inline comments. INLINE COMMENTS > systemtray.cpp:354 > +{ > +if (!value.isValid() || value.isNull() || !value.canConvert()) { > +return false; I think you don't need any of that. If you convert it to a `QIcon` which it is not, it will return a default-constructed

D24997: [Lock & Login Screens] Don't use a black shadow with black text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d029fb058cff: [Lock Screen] Dont use black shadows with black text (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE