D24720: [applets/systemtray] Rewrite popups with layouts

meven added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:21 > +import QtQuick 2.13 > +import QtQuick.Layouts 1.13 > + You effectively bumped the runtime dependency of plasma-framework to Qt 5.13. Did we need to ? Would 5.12 suffice ? Or was it just time to start using Qt 5.13.

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 08 Nov 2019 04:43:27 + Build duration: 20 min and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 115 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/115/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Nov 2019 04:43:27 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed:

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69422. apol edited the summary of this revision. apol added a comment. simplify connect REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69421=69422 BRANCH apol/iconthreading REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69421. apol added a comment. Update commit text REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69420=69421 BRANCH apol/iconthreading REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69420. apol added a comment. Simplify the multithread situation with updatePolish REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69372=69420 BRANCH apol/iconthreading REVISION DETAIL

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The filename of the main script is hard-coded to ui/main.qml, so setting X-Plasma-MainScript is pointless.

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 07 Nov 2019 15:40:09 + Build duration: 3 hr 57 min and counting CONSOLE OUTPUT

D25020: fix: create control files only when needed

davidedmundson added inline comments. INLINE COMMENTS > control.cpp:224 > { > -const QString dir = dirPath() % QStringLiteral("outputs/"); > -if (!QDir().mkpath(dir)) { > -return QString(); > -} > -return dir % hash; > +return Control::dirPath() %

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/4/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 07 Nov 2019 15:40:07 + Build duration: 3 hr 54 min and counting CONSOLE OUTPUT

D25196: Perform KNS searches from the Featured page again

ngraham updated this revision to Diff 69407. ngraham edited the summary of this revision. ngraham added a comment. Update comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25196?vs=69396=69407 BRANCH

D25196: Perform KNS searches from the Featured page again

ngraham marked an inline comment as done. ngraham added a comment. Sure, master only is fine. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25196 To: ngraham, apol, #discover_software_store Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25196: Perform KNS searches from the Featured page again

apol added a comment. How about we target master for this? INLINE COMMENTS > KNSBackend.cpp:507 > return stream; > -} else if ((m_hasApplications && !filter.category) // If there is no > category defined, we are searching in the root, and should include only > application

D25185: Icon: solve threading issue on when the source is http

davidedmundson added a comment. Certainly doing all this inside updatePaintNode was wrong. So, concept wise ++ I don't understand the mutex, the main point of the patch is so that we only do network stuff on the main thread. During updatePaintNode the GUI thread is explicitly locked.

D25147: Remove gtkrc-2.0 legacy settings

This revision was automatically updated to reflect the committed changes. Closed by commit R99:308342b16f0a: Remove gtkrc-2.0 legacy settings (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D25198: KCM Colors : port color scheme state management to KConfigXT

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25198 AFFECTED

D25196: Perform KNS searches from the Featured page again

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We previously disabled this in https://bugs.kde.org/show_bug.cgi?id=399503

D25191: replace bespoke xkb geometry parser with xkb

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the bespoke parser was a horrendous drain on the build time of plasma-desktop due to recursive

D24893: [Lock Screen] Add option to hide clock when idle

This revision was automatically updated to reflect the committed changes. Closed by commit R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when idle (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24893?vs=68622=69386

D25185: Icon: solve threading issue on when the source is http

apol added a comment. In D25185#559486 , @anthonyfieroni wrote: > Can we just use queued connection, it'll avoid mutex weirdness. Well, no. In fact, m_source is being accessed too unguarded from the different threads. REPOSITORY R169

D25062: fix(kded): read rotated output size

gmassullo added a comment. I tested this patch on Plasma 5.17.2 [1] and it fixes Screens overlapping after screen lock I would like to give a comment about the following KDE bugreports, even if they may be not related: I am not yet sure,

D25176: Add a displayHint property to Action

leinir added inline comments. INLINE COMMENTS > broulik wrote in Action.qml:124 > Isn't it more like a "no preference" value? > Also, please document the default value You're right, NoPreference would probably be more linguistically correct... i was more thinking along the lines of, if the

D25176: Add a displayHint property to Action

broulik added inline comments. INLINE COMMENTS > leinir wrote in Action.qml:124 > Might be nice to have a DisplayHint.NoHint value, to make it more explicit > what that 0 means Isn't it more like a "no preference" value? Also, please document the default value REPOSITORY R169 Kirigami

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

broulik added inline comments. INLINE COMMENTS > ActionToolBar.qml:111 > +visible: details.visibleActions.indexOf(modelData) != -1 > + && (modelData.visible !== undefined && > modelData.visible) > + Shouldn't this be modelData.visible === undefined ||

D25176: Add a displayHint property to Action

leinir added inline comments. INLINE COMMENTS > Action.qml:124 > + */ > +property int displayHint: 0 > + Might be nice to have a DisplayHint.NoHint value, to make it more explicit what that 0 means REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25176 To:

D25185: Icon: solve threading issue on when the source is http

anthonyfieroni added a comment. Can we just use queued connection, it'll avoid mutex weirdness. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25185 To: apol, #kirigami, mart Cc: anthonyfieroni, bcooksley, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,