KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/24/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 09 Nov 2019 04:38:15 + Build duration: 22 min and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/6/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 09 Nov 2019 04:38:15 + Build duration: 20 min and counting CONSOLE OUTPUT

D25227: Document Kirigami.Theme Better

zanny created this revision. zanny added a project: Documentation. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. zanny requested review of this revision. REVISION SUMMARY Working on a tertiary project I ran into how Kirigami.Theme has depreciated colors that aren't

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 09 Nov 2019 02:37:36 + Build duration: 51 sec and counting

KDE CI: Plasma » plasma-sdk » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-sdk/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Nov 2019 02:35:51 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncated 623 lines

D25222: [Lock Screen] Fix album art binding loop

broulik added a comment. Painted size depends on the aspect ratio of the loaded image. I think it should just be hard-coded to some icon size or grid unit rather than depend on the highly dynamic font rendering (which governs its size effectively as it's the layout's size) REPOSITORY R120

D25223: Avoid side effects during menu initialization

kmaterka added a comment. The problem was with: m_menu->setVisible(m_visible); setters/getters should not have side effects or any logic, but this method has. Detached menu stayed as top level window and rendered itself. VLC has a bug, each systray menu update creates new QMen

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. In D24843#560188 , @kmaterka wrote: > In D24843#560023 , @broulik wrote: > > > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every t

D25223: Avoid side effects during menu initialization

kmaterka updated this revision to Diff 69489. kmaterka added a comment. Final version, ready for review. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25223?vs=69484&id=69489 BRANCH master REVISION DETAIL https://pha

D25180: [GTK3/Firefox] Fix scrollbar click region

This revision was automatically updated to reflect the committed changes. Closed by commit R98:be9775281fa9: [GTK3/Firefox] Fix scrollbar click region (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25180?vs=69364&id=69488#toc REPOSITORY R98 Breeze for Gtk CHANGES

D25223: Avoid side effects during menu initialization

kmaterka added a comment. Too soon, it is still not finished. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB

D25223: Avoid side effects during menu initialization

kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Setting some attributes, like visible, enabled, etc has side effects. Do

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69483. davidre added a comment. update application for migration based on the one I did for spectacle REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69279&id=69483 BRANCH globalaccel (branched from mast

D25222: [Lock Screen] Fix album art binding loop

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Album art was patched in 5.16.5 to use PreserveAspectFit, but the code for sourceSize was still applying the width and the height of

D25196: Perform KNS searches from the Featured page again

This revision was automatically updated to reflect the committed changes. Closed by commit R134:11d79794b58e: Perform KNS searches from the Featured page again (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25196?vs=69407

D25198: KCM Colors : port color scheme state management to KConfigXT

crossi added a comment. In D25198#559853 , @broulik wrote: > Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them

D25024: Use the same avatar size in lock, login and logout screens

filipf added a comment. friendly ping REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25024 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zr

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69468. crossi added a comment. missed that one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69467&id=69468 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED FILES kcms/style/kcmstyle.cpp

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi updated this revision to Diff 69467. crossi added a comment. make access to selectedStyle more consistent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25220?vs=69466&id=69467 REVISION DETAIL https://phabricator.kde.org/D25220 AFFECTED FI

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25220 AFFE

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. In D24843#560023 , @broulik wrote: > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: > F77483

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

ahiemstra updated this revision to Diff 69463. ahiemstra added a comment. - Fix showing actions with visible property undefined REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25177?vs=69359&id=69463 BRANCH actiontoolbar_icononly REVISION DETAIL https

D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > broulik wrote in ActionToolBar.qml:111 > Shouldn't this be > > modelData.visible === undefined || modelData.visible > > i.e. have the action show if `visible` is not defined You are right, fixed.

D25176: Add a displayHint property to Action

ahiemstra marked 3 inline comments as done. ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in Action.qml:124 > You're right, NoPreference would probably be more linguistically correct... i > was more thinking along the lines of, if the default means there is no > preferred hint

D25176: Add a displayHint property to Action

ahiemstra updated this revision to Diff 69462. ahiemstra added a comment. - Add and use DisplayHint.NoPreference value for displayHint default REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25176?vs=69358&id=69462 BRANCH action_displayhint REVISION DET

D25191: replace bespoke xkb geometry parser with xkb

ngraham added a comment. Oh so much faster now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25191 To: sitter, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

broulik added a comment. This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: F7748305: Screenshot_20191108_151344.png (note the th

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:8aba24da397c: [applets/weather] Reduce label minimum width to accommodate narrow vertical… (authored by ngraham). REPO

D25191: replace bespoke xkb geometry parser with xkb

sitter updated this revision to Diff 69441. sitter added a comment. fix tooltip scaling to show keys at 2.5 times their original size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69437&id=69441 BRANCH master REVISION DETAIL https://p

D25191: replace bespoke xkb geometry parser with xkb

sitter updated this revision to Diff 69437. sitter added a comment. install bin, drop ki18n as link target (not used at this time) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25191?vs=69388&id=69437 BRANCH master REVISION DETAIL https://phab

D25212: Move the shortcut management in the settings object

ervin updated this revision to Diff 69435. ervin added a comment. Remove stale updateState() function REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25212?vs=69433&id=69435 REVISION DETAIL https://phabricator.kde.org/D25212 AFFECTED FILES CMakeL

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/5/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 08 Nov 2019 12:16:23 + Build duration: 4 min 16 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/23/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 08 Nov 2019 12:16:23 + Build duration: 3 min 21 sec and counting CONSOLE OUTPUT [...tr

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandedRepresentation.qml:21 > It is a requirement to still work on Qt5.12 for the next release. Well > spotted Meven. > > I'll adjust this. Should have checked that, thanks David and Meven :) REPOSITORY R120 Plasma Wo

D25212: Move the shortcut management in the settings object

ervin created this revision. ervin added reviewers: Plasma, davidedmundson, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This uses the new KPropertySkeletonItem facility to allow proper integra

Re: KDE CI: Plasma » plasma-sdk » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Failing!

Urgh, I caused this. Will fix. Thanks CI.

D24720: [applets/systemtray] Rewrite popups with layouts

davidedmundson added a comment. (nice patch btw, I love layouts) INLINE COMMENTS > filipf wrote in ExpandedRepresentation.qml:21 > I just used the imports provided in the Qt documentation. Feel free to bump > it down to 5.12 or even the original 5.1. It is a requirement to still work on Qt5

KDE CI: Plasma » plasma-sdk » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-sdk/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Nov 2019 10:41:41 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT [...truncated 622

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added inline comments. INLINE COMMENTS > meven wrote in ExpandedRepresentation.qml:21 > You effectively bumped the runtime dependency of plasma-framework to Qt 5.13. > Did we need to ? Would 5.12 suffice ? > Or was it just time to start using Qt 5.13. I just used the imports provided in t

D25205: Remove pointless QDBusServiceWatcher

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KActivitymanagerd's ksmserver has a QDBusServiceWatcher in order to recreat

D25027: feat(kcm): zoom preview automatically

davidedmundson added a comment. Other that Nate's sensible comment, +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25027 To: romangg, #plasma Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25062: fix(kded): read rotated output size

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't follow why this bug was only newly introduced, but this does seem to make sense. REPOSITORY R104 KScreen BRANCH fix-rotated-output-read REVISION DETAIL https

D25198: KCM Colors : port color scheme state management to KConfigXT

ervin added a comment. In D25198#559853 , @broulik wrote: > Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them

D25198: KCM Colors : port color scheme state management to KConfigXT

broulik added a comment. Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25020: fix: create control files only when needed

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in control.cpp:224 > who would now makes this folder? > > ControlConfig has a line to do so, but ControlOutput does not. > > I can't see a line in config.cpp (though I'm not 100% sure where > ControlOutput is currently used)