D26056: [dataengine/geolocation] Add logging category

meven updated this revision to Diff 71704. meven added a comment. Add logging category REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26056?vs=71686=71704 BRANCH arcpatch-D26056 REVISION DETAIL https://phabricator.kde.org/D26056 AFFECTED

D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY QMultiHash::insertMulti is deprecated REPOSITORY R111 KSysguard Library BRANCH remove_qmultihash_insertmulti (branched from

D26039: [Plasma Style KCM] Add search filter

ndavis added inline comments. INLINE COMMENTS > main.qml:106 > +{text: i18n("Dark Themes"), filter: > Private.FilterProxyModel.DarkThemes}, > +{text: i18n("Themes following color scheme"), filter: > Private.FilterProxyModel.ThemesFollowingColors} > +

D25539: feat(kcm): add revert timer

ndavis added a comment. In D25539#579057 , @ngraham wrote: > IIRC macOS's equivalent to this KCM uses instant apply (everything in macOS is instant apply) and they have a modal dialog with a revert timer in it. But I believe it's only shown

D25539: feat(kcm): add revert timer

ngraham added a comment. IIRC macOS's equivalent to this KCM uses instant apply (everything in macOS is instant apply) and they have a modal dialog with a revert timer in it. But I believe it's only shown when you change the screen; it isn't shown for anything else. REPOSITORY R104

D25539: feat(kcm): add revert timer

romangg added a comment. In D25539#579054 , @ngraham wrote: > I'm torn. In principle I agree that this is a great improvement to help people avoid blowing themselves up while testing settings. However I'm not convinced that the patch's current

D25539: feat(kcm): add revert timer

ngraham added a comment. I'm torn. In principle I agree that this is a great improvement to help people avoid blowing themselves up while testing settings. However I'm not convinced that the patch's current form strikes the right balance between achieving that goal and not annoying the user

D22684: [Klipper] Fix clipboard history management

ngraham added a comment. Thanks for the fix! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: GB_2, davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D22684: [Klipper] Fix clipboard history management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:423308f854c4: [Klipper] Fix clipboard history management (authored by pdabrowski, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22684: [Klipper] Fix clipboard history management

ngraham added a comment. David acked this in person at the meeting. Landing it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: GB_2, davidre, plasma-devel, LeGast00n,

D26042: Captive portal notification improvements

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Being in an airport right now myself (as is Harald, I imagine), I'm able to test this immediately. :) Works great, shipit, and sorry for introducing this regression when I made the

D22176: Rework system tray settings

ngraham added inline comments. INLINE COMMENTS > ConfigGeneral.qml:101 > +enabled: !showAllCheckBox.checked > +model: isPlasmoid ? [i18n("Auto"), i18n("Shown"), > i18n("Hidden"), i18n("Disabled")] : [i18n("Auto"), i18n("Shown"), > i18n("Hidden")] > +

D26041: Move applet configuration to KCM

ngraham added a comment. Lovely. Works great, and much better UI. I have just a few UI and code suggestions: INLINE COMMENTS > ConfigurationDialog.qml:23 > +import QtQuick.Dialogs 1.2 > +import QtQuick.Controls 2.5 as QtControls > +import org.kde.kirigami 2.5 as Kirigami `as QQC2` >

D25976: Use a default non-administrator user Type for new users in model

This revision was automatically updated to reflect the committed changes. Closed by commit R128:2471fa7d252d: Use a default non-administrator user Type for new users in model (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D25976: Use a default non-administrator user Type for new users in model

meven updated this revision to Diff 71692. meven added a comment. Simplify code REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25976?vs=71568=71692 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25976 AFFECTED FILES

D26056: [dataengine/geolocalisation] clean debug traces

meven added a comment. In D26056#578988 , @davidedmundson wrote: > if we're going to fix qDebug, lets fix the qDebug and move to categorized logging > > // qDebug() << "gpsd not found"; > > > seems like an important warning

D26056: [dataengine/geolocalisation] clean debug traces

davidedmundson added a comment. if we're going to fix qDebug, lets fix the qDebug and move to categorized logging // qDebug() << "gpsd not found"; seems like an important warning REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26056 To: meven,

D25539: feat(kcm): add revert timer

ndavis added a comment. In D25539#578688 , @romangg wrote: > In D25539#578624 , @liushuyu wrote: > > > Any other suggestions for this patch? > > > From a UX perspective the general question is

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

bport updated this revision to Diff 71688. bport added a comment. Post diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26051?vs=71687=71688 REVISION DETAIL https://phabricator.kde.org/D26051 AFFECTED FILES

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

bport updated this revision to Diff 71687. bport added a comment. Take in consideration apol feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26051?vs=71680=71687 REVISION DETAIL https://phabricator.kde.org/D26051 AFFECTED FILES

D26048: KCM Notification port to ManagedConfigModule

meven resigned from this revision. meven added a comment. This revision now requires review to proceed. Another "primary" reviewer would be more adequat REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26048 To: crossi, #plasma, ervin, bport, mart,

D26047: Expose KConfig settings to allow registration in KCM Notification

meven resigned from this revision. meven added a comment. This revision now requires review to proceed. Someone else should valide this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson,

D26052: KCM Cursor Theme : Use ManagedConfigModule

meven resigned from this revision. meven added a comment. This revision now requires review to proceed. Looks good to me Someone from Plasma will be a better reviewer REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26052 To: bport, #plasma, ervin, crossi

D26056: [dataengine/geolocalisation] clean debug traces

meven created this revision. meven added reviewers: apol, Plasma, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26056

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

apol added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:458 > } > -m_themeModel->addTheme(list.join(QLatin1Char('/'))); > + > m_themeModel->addTheme(QString("/%1").arg(list.join(QLatin1Char('/'; >

D26052: KCM Cursor Theme : Use ManagedConfigModule

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Use ManagedConfigModule instead of ConfigModule to remove uneeded code REPOSITORY

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. TEST PLAN Install a theme through GHNS, and check if you can delete it / change cursor size (if

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven created this revision. meven added reviewers: KWin, crossi, ervin, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 kcm_nightcolor Checked all settings reacts correctly to the restore defaults

D26048: KCM Notification port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Require D26046 and D26047

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Konrad Materka changed: What|Removed |Added CC||mate...@gmail.com --- Comment #41 from Konrad

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY For KCM Notification, allow to register the generated

D26045: Add immutability to KCM Icons

bport created this revision. bport added reviewers: Plasma, ervin, ngraham, crossi, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Add immutability to KCM Icons, disable theme delegate and not the whole

D24847: KCM Icons fix theme selected when we hit delete theme

bport updated this revision to Diff 71669. bport added a comment. Update code to take in consideration change done in D24826 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24847?vs=71128=71669 REVISION DETAIL

D24846: Port kcm icons to kconfigxt

bport updated this revision to Diff 71668. bport added a comment. Add theme to kconfigXT REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24846?vs=71127=71668 REVISION DETAIL https://phabricator.kde.org/D24846 AFFECTED FILES

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Alexander Fieroch changed: What|Removed |Added Version|5.12.5 |5.17.4 Platform|Archlinux

D22684: [Klipper] Fix clipboard history management

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: GB_2, davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D25580: [System Tray] Unified data model for System Tray items

trmdi added a comment. Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

zachus added a comment. is there a server out there to run it against? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25961 To: leinir Cc: zachus, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26042: Captive portal notification improvements

jgrulich updated this revision to Diff 71660. jgrulich added a comment. : - Notification might be already closed REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26042?vs=71659=71660 BRANCH captive-portal-improvements REVISION

D26042: Captive portal notification improvements

jgrulich created this revision. jgrulich added reviewers: ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Do not duplicate captive portal notifications and close them when we are no longer

D22176: Rework system tray settings

kmaterka added a comment. D25580 pushed, @nicolasfella, can you rebase? In addition, as we are basically removing categories, you need to remove: - `shownCategories` from `main.qml` - `categoryShown` from `AbstractItem.qml` -

D25580: [System Tray] Unified data model for System Tray items

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d2fa8e6b812: [System Tray] Unified data model for System Tray items (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26041: Move applet configuration to KCM

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY It doesn't make sense to have additional applet configuration, especially when the configuration is not related only to the

D26035: battery: Improve the brightness responsiveness

broulik added a comment. `PlasmaComponents` 3 `Slider` doesn't react to wheel events, which must be fixed before this can go in. INLINE COMMENTS > PopupDialog.qml:48 > - > -keyboardBrightnessSlider.valueChanged.connect(function() { > -batterymonitor.keyboardBrightness =

D25539: feat(kcm): add revert timer

romangg added a comment. In D25539#578624 , @liushuyu wrote: > Any other suggestions for this patch? From a UX perspective the general question is if a revert timer makes sense when we have already the "Apply" action. As previously said

D26039: [Plasma Style KCM] Add search filter

davidre created this revision. davidre added reviewers: Plasma, VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Addsm the ability to filter themes by name by typing in the search line or whether

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe added a comment. CPU/IO Plasma widgets work pretty well in HiDPI screen. It should be solved if we make it a QML component, reusing the part from Plasma widgets. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23831 To: guoyunhe, #plasma Cc:

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71650. trmdi added a comment. - Use QString type for the dbus screenId parameters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71649=71650 BRANCH add-otherShellHelper (branched from master)