D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added inline comments. INLINE COMMENTS > shellcorona.h:94 > +// plasmashellCorona's value > +QRegion _availableScreenRegion(int id) const; > +QRect _availableScreenRect(int id) const; maybe concerning naming, plasmaAvailableScreenRegion would be better > shellcorona.h:95

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71980. trmdi added a comment. - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into add-otherShellHelper - Just rename the screenId parameter of test() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71979. trmdi added a comment. - Use screenName instead of id in setAvailableScreenRect/Region() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71802=71979 BRANCH add-otherShellHelper (branched from

D26069: Fix usage of deprecated QSet/QList methods

This revision was automatically updated to reflect the committed changes. Closed by commit R134:34d68d4ec5a5: Fix usage of deprecated QSet/QList methods (authored by alexeymin). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham commandeered this revision. ngraham edited reviewers, added: hallas; removed: ngraham. ngraham added a comment. Done in D26139 . REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: ngraham, #vdg, #breeze, abetts,

D26147: Kickoff computer tab : don't display filepath for places in description

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much clearer. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26147 To: meven, ngraham, #plasma, #vdg Cc: plasma-devel, LeGast00n,

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#581178 , @trmdi wrote: > In D25807#581161 , @mvourlakos wrote: > > > In D25807#581126 , @trmdi wrote: > > > > >

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#581161 , @mvourlakos wrote: > In D25807#581126 , @trmdi wrote: > > > @mvourlakos > > Latte can guard that the order of screens within Latte is synced with

D26149: Change krunner calculator to display significant digits

lukjp created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lukjp requested review of this revision. REVISION SUMMARY Change the qalculate krunner module to print only significant digits instead of an interval as this is sometimes unreadable. BUG:

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#581126 , @trmdi wrote: > @mvourlakos > Latte can guard that the order of screens within Latte is synced with plasmashell right? Because I see this:

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

This revision was automatically updated to reflect the committed changes. Closed by commit R31:288c3b85f16c: Revert Revert Reduce the indicator arrow size for press-and-hold menus in… (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. In D26121#581070 , @ngraham wrote: > Nice, I think this makes sense. Now Kickoff's Computer tab needs the same treatment or else the paths are oddly inconsistent. In another diff, the patch is very simple : D26147

D26147: Kickoff computer tab : don't display filepath for places in description

meven created this revision. meven added reviewers: ngraham, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The path of places is not very informative to users Follow the path of D26121

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. @mvourlakos Latte can guard that the order of screens are the same with plasmashell right? Because I see this: https://github.com/KDE/latte-dock/blob/master/app/screenpool.cpp REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807

D26124: Add byte display option in Network Monitor plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d21cb2e7a95b: Add byte display option in Network Monitor plasmoid (authored by gvgeo, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26124: Add byte display option in Network Monitor plasmoid

ngraham added a comment. Lovely contribution, thanks very much! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26124 To: gvgeo, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26052: KCM Cursor Theme : Use ManagedConfigModule

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Maybe next you can figure out what causes this bizarre behavior: F7828232: demo-2019-12-21_09.54.54.webm REPOSITORY R119 Plasma Desktop REVISION

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

filipf added a comment. In D21978#581032 , @GB_2 wrote: > Can you please try to further investigate this? I already tried finding some other solution, but this is the best I can do unfortunately. I just run a local copy of Kickoff with

D26045: Add immutability to KCM Icons

ngraham added a comment. Needs a rebase REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport, #plasma, ervin, ngraham, crossi, meven Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#578640 , @davidedmundson wrote: > The problem is that on wayland (and to some extent x11 is racey) the order of screens within QApplication::screens might not be in sync across processes. Is it possible

D26052: KCM Cursor Theme : Use ManagedConfigModule

bport updated this revision to Diff 71958. bport added a comment. Call ManagedConfiModule load/save/defaults parent method REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26052?vs=71681=71958 REVISION DETAIL https://phabricator.kde.org/D26052

D26121: Kicker/RecentDocument display file path as decoration

ngraham added a comment. Nice, I think this makes sense. Now Kickoff's Computer tab needs the same treatment or else the paths are oddly inconsistent. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL https://phabricator.kde.org/D26121 To: meven, #vdg, #plasma,

D26045: Add immutability to KCM Icons

bport added inline comments. INLINE COMMENTS > bport wrote in main.qml:55 > Problem with this solution it will disable also icon size components, and we > don't want that, if you have a nicer solution my bad missread indeed view.enabled do what I want REPOSITORY R119 Plasma Desktop

D26045: Add immutability to KCM Icons

bport updated this revision to Diff 71957. bport added a comment. Take in consideration broulik feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26045?vs=71672=71957 REVISION DETAIL https://phabricator.kde.org/D26045 AFFECTED FILES

D24846: Port kcm icons to kconfigxt

bport updated this revision to Diff 71956. bport added a comment. Remone unused include REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24846?vs=71668=71956 REVISION DETAIL https://phabricator.kde.org/D24846 AFFECTED FILES

D25915: Don't set a new palette if the application has a custom color scheme set

This revision was automatically updated to reflect the committed changes. Closed by commit R135:69b756e274cb: Dont set a new palette if the application has a custom color scheme set (authored by davidre). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D26078: Ship plasma-logo in repo

This revision was automatically updated to reflect the committed changes. Closed by commit R124:957c5cf9e44e: Ship plasma-logo in repo (authored by davidre). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26078?vs=71763=71952 REVISION DETAIL

D26121: Kicker/RecentDocument display file path as decoration

meven updated this revision to Diff 71950. meven added a comment. Use KFilePlacesModel to improve display of history REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71893=71950 BRANCH arcpatch-D26121 REVISION DETAIL

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

GB_2 added a comment. Can you please try to further investigate this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D26045: Add immutability to KCM Icons

bport added inline comments. INLINE COMMENTS > broulik wrote in main.qml:38 > Why this change? my bad, need to keep the downloaded stuff there > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Problem with

D26142: KCM Icons: Fix bug (https://bugs.kde.org/show_bug.cgi?id=415129), need to remove leading slash

bport created this revision. bport added reviewers: Plasma, ngraham, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. TEST PLAN Try installing using plasma-changeicons executable (used by discover) and from discover

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

ndavis added a comment. After D26139 was reopened, there was some discussion about the reason it was reverted and the problems it introduced. It is possible that an icon could partially cover this arrow, but it seemed uncommon enough that ignoring the

D26139: Revert "Revert "Reduce the indicator arrow size for press-and-hold menus in QToolButtons""

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This reverts commit c9aa535863e09bf736b1fb64c182b93530780c5d

D26124: Add byte display option in Network Monitor plasmoid

gvgeo updated this revision to Diff 71926. gvgeo added a comment. Correct label of displayUnits in xml. Add values to displayUints options. Correct copyright message. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26124?vs=71921=71926 BRANCH