D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have not been landed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham,

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. This change fails to build from source on FreeBSD due to missing headers in Frameworks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham, plasma-devel,

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 05:50:00 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 05:49:40 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/51/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 05:49:38 + Build duration: 17 min and counting JUnit Tests

KDE CI: Plasma » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 05:49:39 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20SUSEQt5.12/84/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 05:49:38 + Build duration: 3 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 34 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 05:49:59 + Build duration: 2 min 18 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 664 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/664/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 04:56:54 + Build duration: 8 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 395 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/395/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 02:25:24 + Build duration: 3 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 394 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/394/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 01:36:54 + Build duration: 3 min 17 sec and counting CONSOLE OUTPUT

D26681: [TabBox] Thumbnail Grid window switcher

This revision was automatically updated to reflect the committed changes. Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26681?vs=73648=73675 REVISION

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 393 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/393/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 00:36:23 + Build duration: 3 min 51 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 392 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/392/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 00:30:39 + Build duration: 5 min 34 sec and counting CONSOLE OUTPUT

D26570: Improve Plasma user feedback introspection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:35dcbd3dd89c: Improve Plasma user feedback introspection (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73641=73674 REVISION

D26681: [TabBox] Thumbnail Grid window switcher

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Zren wrote in main.qml:183 > Uhg, I was using `width: parent.height` and `height: parent.height` but > changed it when cleaning it up. I must've not staged all the

D26698: [widgetexplorer] Fix animate in animation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh never mind, I see it now. Quite subtle! Nice fix. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26698 To: davidedmundson, #plasma,

D26699: [widgetexplorer] Animate column moves

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much nicer. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26699 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

D26698: [widgetexplorer] Fix animate in animation

ngraham added a comment. Hmm, I don't notice a difference before and after this patch. Maybe I'm not noticing the original problem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26698 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n,

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham added a comment. I don't know of any netbooks shorter with screens shorter than 600px, which is why I chose 600. Also, the window is resizable to be smaller. Is there a better way? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To:

D26699: [widgetexplorer] Animate column moves

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Search for something in the second column Now it doesn't jump REPOSITORY R119

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

davidedmundson added a comment. Ok, but why minimum? We still have a few reports of people on weird tiny netbooks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26698: [widgetexplorer] Fix animate in animation

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The animation in comes in from offscreen on the left. "to: 0" was

D26655: show a thin separator between view and scrollbar

ndavis added a comment. I noticed that when hovering on the scrollbar border, while the view area is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for Breeze) instead of blue. Moving the mouse just slightly more to the right turns the scrollbar handle blue.

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R130:3a6508dd350b: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem (authored by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 377653 FIXED-IN: 5.18.0 TEST PLAN Before: F7884930: Before.png

D26631: [kstyle] Update blur region even if Breeze has no X11 support

This revision was automatically updated to reflect the committed changes. Closed by commit R31:e1710bd6808b: [kstyle] Update blur region even if Breeze has no X11 support (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26631?vs=73430=73656

D26655: show a thin separator between view and scrollbar

ndavis added a comment. In D26655#595033 , @mart wrote: > moving the points half a pixel in renderArrow seems to fix it, but it may have sideeffects for arrows used in other places.. Indeed, it would. I already made the arrows pixel

D26681: [TabBox] Thumbnail Grid window switcher

Zren updated this revision to Diff 73648. Zren edited the summary of this revision. Zren added a comment. Fix implicitWidth error by using Layout.min/maxWidth. Scale captionRow.spacing by dpi. Take into account the close button is 30x30. Use a ColumnLayout for thumbnailGridItems instead

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 15 Jan 2020 19:02:45 + Build duration: 18 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 SUSEQt5.12 - Build # 83 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20SUSEQt5.12/83/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Jan 2020 19:02:19 + Build duration: 50 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 85 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Jan 2020 19:02:17 + Build duration: 51 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/50/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 15 Jan 2020 19:02:19 + Build duration: 37 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Jan 2020 19:02:45 + Build duration: 25 sec and counting CONSOLE OUTPUT Started by

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/50/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 15 Jan 2020 19:02:19 + Build duration: 44 sec and counting CONSOLE OUTPUT Started by an

D26655: show a thin separator between view and scrollbar

mart added a comment. In D26655#595022 , @hpereiradacosta wrote: > Confirmed that the centering is fixed. Now the arrow seem to have moved vertically (for vertical scrollbars) by half a pixel, which is probably a consequence of the 20->21, and

D26688: WIP: [Night Color] Display time when the next transition will start

zzag added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.qml:57 > The bigger todo is hardcoded 6500K ? 6500K is the neutral screen color temperature. Although I don't think that I follow you. Do you recommend not to hardcode this constant? > ngraham wrote in main.qml:59 >

D26655: show a thin separator between view and scrollbar

This revision was automatically updated to reflect the committed changes. Closed by commit R31:df1340617147: show a thin separator between view and scrollbar (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26655?vs=73642=73646 REVISION

D26681: [TabBox] Thumbnail Grid window switcher

Zren added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:183 > you can use Layout.preferredWidth > > One shouldn't specifiy a width/height from an item inside a layout Uhg, I was using `width: parent.height` and `height: parent.height` but changed it when cleaning it up.

D26655: show a thin separator between view and scrollbar

hpereiradacosta accepted this revision. hpereiradacosta added a comment. Confirmed that the centering is fixed. Now the arrow seem to have moved vertically (for vertical scrollbars) by half a pixel, which is probably a consequence of the 20->21, and make them look somewhat thicker due to

D26609: [kstyle] Port to KWindowSystem shadows API

zzag marked an inline comment as done. zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in oxygenshadowhelper.cpp:291 > I don't understand what this line is trying to do I presume that it acted as a sub-surface test, in either case we don't need it. REPOSITORY R113 Oxygen

D26609: [kstyle] Port to KWindowSystem shadows API

zzag updated this revision to Diff 73644. zzag added a comment. - Drop sub-surface check - Don't use obsolete QWidget::isTopLevel() REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26609?vs=73351=73644 REVISION DETAIL

D26475: [kstyle] Port to KWindowSystem shadows API

zzag updated this revision to Diff 73643. zzag added a comment. - Drop sub-surface test - Don't use obsolete QWidget::isTopLevel() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26475?vs=73349=73643 REVISION DETAIL https://phabricator.kde.org/D26475

D26655: show a thin separator between view and scrollbar

mart added a comment. now everything is centered. for some reasons (i didn't fully understand that) the option->rect of scrollBarInternalSubControlRect was influenced by the previous calls of it, if i just substract. now using absolute values for the rect, it always returns the proper

D26655: show a thin separator between view and scrollbar

mart updated this revision to Diff 73642. mart added a comment. - fix arrows too REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26655?vs=73639=73642 BRANCH arcpatch-D26655 REVISION DETAIL https://phabricator.kde.org/D26655 AFFECTED FILES

D26570: Improve Plasma user feedback introspection

ngraham added a comment. Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching

D26570: Improve Plasma user feedback introspection

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in feedback.cpp:41 > where do you use this? It's used by `std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...` > davidedmundson wrote in feedback.cpp:109 > This doesn't look right. > > With 2 async processes, the

D26570: Improve Plasma user feedback introspection

davidedmundson added a comment. Quite a clever solution. I like the general idea. One major comment at the bottom, rest aren't important. INLINE COMMENTS > feedback.cpp:41 > + > +inline void swap(QJsonValueRef v1, QJsonValueRef v2) > +{ where do you use this? > feedback.cpp:109 > +

D26570: Improve Plasma user feedback introspection

apol updated this revision to Diff 73641. apol added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73315=73641 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. yeah thanks ! Now, it turns out that the arrows are still ill-aligned (with respect to the handle). Maybe they use the full width for rendering ? REPOSITORY R31 Breeze BRANCH arcpatch-D26655 REVISION DETAIL https://phabricator.kde.org/D26655 To:

D26525: Fix wallpaper destination path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2212a9af156b: Fix wallpaper destination path (authored by trmdi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26525?vs=73217=73640#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 663 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/663/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 Jan 2020 17:05:07 + Build duration: 5 min 21 sec and counting CONSOLE OUTPUT

D26655: show a thin separator between view and scrollbar

mart updated this revision to Diff 73639. mart added a comment. - Revert "center scrollbars" - align by growing scrollbar REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26655?vs=73636=73639 BRANCH arcpatch-D26655 REVISION DETAIL

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

This revision was automatically updated to reflect the committed changes. Closed by commit R119:442c43b3ca98: Switch the Plasma Desktop KCMs to using KNewStuffQuick (authored by leinir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26688: WIP: [Night Color] Display time when the next transition will start

ngraham added inline comments. INLINE COMMENTS > main.qml:59 > +// TODO: Show a better message... > +return i18n("Night Color is not active, the next transition > will occur at %1", > + >

D26525: Fix wallpaper destination path

ngraham accepted this revision. ngraham added a comment. Yep, go ahead. REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi, #plasma, mart, ngraham Cc: mart, plasma-devel, LeGast00n,

D26686: Remove scrollbar related workarounds from list delegates

ngraham added a comment. Will we still need the `LayoutMirroring.enabled ?` logic to account for when using an RTL language where the scrollbar is on the left side? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26686 To: ahiemstra,

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. Alignment again: so you increased the width of the groove rather than increasing the width of the scrollbar. This indeed fixes the alignment of the handle (and groove), but now the scrollbar arrows are off centered. (for the same reason), with both the

D26609: [kstyle] Port to KWindowSystem shadows API

davidedmundson added inline comments. INLINE COMMENTS > oxygenshadowhelper.cpp:291 > #if OXYGEN_HAVE_KWAYLAND > -if( widget->windowHandle()->parent() ) return false; > -if( !_shadowManager || !_shmPool ) return false; > - > -const bool isDockWidget(

D26655: show a thin separator between view and scrollbar

mart updated this revision to Diff 73636. mart added a comment. - center scrollbars REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26655?vs=73603=73636 BRANCH arcpatch-D26655 REVISION DETAIL https://phabricator.kde.org/D26655 AFFECTED FILES

D26655: show a thin separator between view and scrollbar

mart marked 2 inline comments as done. mart added a comment. comments should be adressed REPOSITORY R31 Breeze BRANCH arcpatch-D26655 REVISION DETAIL https://phabricator.kde.org/D26655 To: mart, #plasma, #breeze, #vdg, ngraham Cc: ndavis, ahiemstra, hpereiradacosta, mthw,

D26525: Fix wallpaper destination path

trmdi added a comment. Ping. Could I land this now? REPOSITORY R120 Plasma Workspace BRANCH fix-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D26525 To: trmdi, #plasma, mart, ngraham Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Strings can't be changed during the beta. There really isn't a rush for this, is there? It's a pretty minor thing. I want it too, but it's more important to get it right than to get it in earlier. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26685: Make the scrollbar always thick

This revision was automatically updated to reflect the committed changes. Closed by commit R31:6694eb7a9e80: Make the scrollbar always thick (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26685?vs=73604=73635 REVISION DETAIL

D26655: show a thin separator between view and scrollbar

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:6570 > + > +_helper->renderScrollBarBorder( painter, separatorRect, > _helper->alphaColor( option->palette.color( QPalette::WindowText ), 0.1 )); > + Another thing: Color role should be QPalette::Text rather than

D26655: show a thin separator between view and scrollbar

ndavis added a comment. +1 to this change. INLINE COMMENTS > breezestyle.cpp:6567 > +Qt::AlignLeft, > +QSize(1, option->rect.height()), > option->rect); > +} Use PenWidth::Frame instead of hardcoding 1.

D26688: WIP: [Night Color] Display time when the next transition will start

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:57 > +if (monitor.operationMode != Monitor.ConstantMode) { > +if (monitor.currentTemperature == 6500) { > +// TODO: Show a better message... The bigger todo is hardcoded 6500K ? REPOSITORY

D26658: WIP: fix(kwayland): stall tablet config change

romangg updated this revision to Diff 73630. romangg added a comment. - Init tablet before starting KWayland timer Further analysis showed that the issue is that for some reason the d-bus call to tablet mode properties is blocking for over one second. That in return leads to the

D26586: [SystemTray] Rework system tray settings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2bfeb160bad: [SystemTray] Rework system tray settings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73504=73629

D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.h:36 > No purpose, therefore can I just delete it? Yes, I don't see why one would want `~Class() override = default` in a header file. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

ngraham added a comment. Push it! Push it real good! :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart Cc: ahiemstra, mart, meven, nicolasfella,

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. Hi again Marco, since you mentionned centering in plasmoids in the other commits, in fact here also the centering is wrong, with the added separator. Probably the offset is the one pixel you take for the separator. Can you double check ? (this appears true

D26654: support mobile mode scrollbar

This revision was automatically updated to reflect the committed changes. Closed by commit R858:471213f74a40: support mobile mode scrollbar (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26654?vs=73626=73627

D26654: support mobile mode scrollbar

mart updated this revision to Diff 73626. mart added a comment. - Merge branch 'master' into phab/mobilescrollbar - consider the frame paddings for the scrollbar REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26583: [Application Style] Add GTK Application Style Page

gikari added inline comments. INLINE COMMENTS > zzag wrote in gtkthemesmodel.h:36 > Whar's the purpose of this destructor? No purpose, therefore can I just delete it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26583 To: gikari, #vdg, broulik, #plasma,

D26593: Remove GTK KCM

ngraham closed this revision. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26593 To: gikari, mart Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D26689: [MPRIS Data Engine] Refactor to reduce code duplication

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `addPlayer` and `playerUpdated` effectively do the same, so merge the two implementations.

D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gtkthemesmodel.h:36 > +GtkThemesModel(QObject *parent = nullptr); > +~GtkThemesModel() override = default; > + Whar's the purpose of this destructor? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26583

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#594840 , @ngraham wrote: > Maybe we can land it early in the 5.19 cycle? Do we really have to? That would delay this by additional 5 months., which is really unfortunate since work (a very slow work but

D26583: [Application Style] Add GTK Application Style Page

This revision was automatically updated to reflect the committed changes. Closed by commit R119:268c5ced8ec2: [Application Style] Add GTK Application Style Page (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73536=73624

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. @broulik I'm leery of landing this for 5.18 since today is the last day for string changes. Maybe we can land it early in the 5.19 cycle? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis,

D26571: Provide information about how we are using KUserFeedback

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:b893a9bb940c: Provide information about how we are using KUserFeedback (authored by apol). REPOSITORY R134 Discover

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

ngraham added a comment. Don't worry about it. :) REPOSITORY R119 Plasma Desktop BRANCH config (branched from master) REVISION DETAIL https://phabricator.kde.org/D26660 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26655: show a thin separator between view and scrollbar

ngraham added a comment. In D26655#594415 , @hpereiradacosta wrote: > For the record, you were around for the original commit that made the scrollbar thiner (https://phabricator.kde.org/D9792) Heh, how embarrassing. I do remember that

D26037: feat(kded): add orientation sensor

This revision was automatically updated to reflect the committed changes. Closed by commit R104:8032881459d1: feat(kded): add orientation sensor (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26037?vs=73185=73619 REVISION DETAIL

D26038: feat(kcm): add option for auto rotation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:039337cd3b1a: feat(kcm): add option for auto rotation (authored by romangg). Herald added a project: Plasma. Herald

D26684: [Notifications KCM] Add docbook for new KCM

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26684 To: broulik, #documentation, yurchor Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n,

D26684: [Notifications KCM] Add docbook for new KCM

broulik updated this revision to Diff 73618. broulik added a comment. - Fix wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26684?vs=73600=73618 REVISION DETAIL https://phabricator.kde.org/D26684 AFFECTED FILES

D26681: [TabBox] Thumbnail Grid window switcher

zzag added inline comments. INLINE COMMENTS > main.qml:1 > +/ > + KWin - the KDE window manager Bad file permissions. Needs to be 644. > main.qml:74-76 > +var c = Math.min(thumbnailGridView.count, >

D26681: [TabBox] Thumbnail Grid window switcher

davidedmundson added inline comments. INLINE COMMENTS > main.qml:231 > + > +// This doesn't work, nor does keyboard input work on any other > tabbox skin (KDE 5.7.4) > +// It does work in the preview however. GridView has it's own input handling you

D26681: [TabBox] Thumbnail Grid window switcher

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in main.qml:183 > This must be `width: parent.height`. implicitWidth is a read-only property. > WIthout this change the qml file won't load. you can use Layout.preferredWidth One shouldn't specifiy a width/height from an

D26681: [TabBox] Thumbnail Grid window switcher

romangg requested changes to this revision. romangg added a reviewer: Plasma. romangg added a comment. This revision now requires changes to proceed. Nice. Let's fix these few issues and get it merged before tomorrow. Other small issues can be fixed in beta phase. INLINE COMMENTS >

D26688: WIP: [Night Color] Display time when the next transition will start

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Currently the applet displays "Night Color is active (%screen color temperature% K)" all the time

D26392: Add option to easily configure and start a hotspot

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e55e45d8794: Add option to easily configure and start a hotspot (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D26392: Add option to easily configure and start a hotspot

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R116 Plasma Network Management Applet BRANCH hotspot REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg, apol Cc: meven, cblack,

D26392: Add option to easily configure and start a hotspot

jgrulich updated this revision to Diff 73614. jgrulich marked an inline comment as done. jgrulich added a comment. - Code improvements REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26392?vs=73437=73614 BRANCH hotspot REVISION

D26684: [Notifications KCM] Add docbook for new KCM

yurchor added a comment. Thanks for fixing this minor typo. INLINE COMMENTS > index.docbook:132 > +Keep popup open during progress > +Whether the popup should remain visible for the > entire duration of the progress or automatically hide. It will always shown > again when

D26392: Add option to easily configure and start a hotspot

apol added a comment. Patch looks good to me overall. +1 INLINE COMMENTS > handler.cpp:615 > + > +QVariantMap options; > +options.insert(QLatin1String("persist"), QLatin1String("volatile")); I'd prefer the initializer list syntax `const QVariantMap options = {

D26680: [kcms/feedback] Implement setRepresentsDefaults

davidedmundson added inline comments. INLINE COMMENTS > meven wrote in feedback.cpp:43 > nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well. > 1 saves a connect, > 2 make setRepresesentsDefault and setNeedsSave close in the file sorry I missed your comment. I'll make

D26679: [kcms/feedback] Fix default button not showing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e1324b0f5457: [kcms/feedback] Fix default button not showing (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

  1   2   >