KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 54 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/54/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 07 Feb 2020 07:38:14 + Build duration: 2 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/31/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 07 Feb 2020 07:38:15 + Build duration: 2 min 32 sec and counting CONSOLE OUTPUT

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. @broulik ping. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27079: Don't escape search text in search page title

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. @apol ping. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27203: Don't try to open files we can't figure out where they are

2020-02-06 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Been using it for a few days, no regressions. Opening sftp:///localhost/.../somefile.text twice, doesn't

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75144. cblack added a comment. Swap in gridUnit instead of largeSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75143=75144 BRANCH media-plasmoid-relayout (branched from master) REVISION

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75143. cblack added a comment. Remove extraneous print REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75142=75143 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75142. cblack added a comment. Add license headers to two new QML files REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75141=75142 BRANCH media-plasmoid-relayout (branched from master) REVISION

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75141. cblack added a comment. Move source selector to bottom of column, hide by default REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75140=75141 BRANCH media-plasmoid-relayout (branched from

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75140. cblack marked 7 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75138=75140 BRANCH media-plasmoid-relayout (branched from

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack marked an inline comment as done. cblack added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:145-148 > Do you have a source for this claim? From what I know blur merely blurs the > actual item texture which is rendered, no the raw image source?

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

2020-02-06 Thread Carson Black
cblack updated this revision to Diff 75138. cblack added a comment. Cache data from the MPRIS sources REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75077=75138 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Manuel Jesús de la Fuente
manueljlin added a comment. I think 1.4 looks too small REPOSITORY R169 Kirigami BRANCH smaller-and-more-left-padded-page-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D27198 To: ngraham, #vdg, #kirigami, manueljlin, mart Cc: alexde, ahiemstra,

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Alex Debus
alexde added a comment. In D27198#607110 , @ngraham wrote: > I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas: When looking at the screenshots, 1.4

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas: F8088947: Screenshot_20200206_133946.png F8088944: Screenshot_20200206_133906.png

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 40 - Still unstable!

2020-02-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 20:21:36 + Build duration: 1 min 48 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Fixed!

2020-02-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 20:21:36 + Build duration: 1 min 0 sec and counting

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 39 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 20:10:19 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 20:10:22 + Build duration: 44 sec and counting CONSOLE OUTPUT

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Alex Debus
alexde added a comment. Looks way better, thanks Nate! Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how would it looke like with 1.40 instead of 1.50? Would it be too small? Would you like attach another screenshot please? :-) REPOSITORY R169 Kirigami

D26992: [SystemTray] Use unified data model everywhere

2020-02-06 Thread Konrad Materka
kmaterka updated this revision to Diff 75134. kmaterka added a comment. Rebase, only D27088 left REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74805=75134 BRANCH master REVISION DETAIL

D27199: [WIP][Applet]Update layout based on T10470

2020-02-06 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. gvgeo requested review of this revision. REVISION SUMMARY Need help/ideas: Have a

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 75127. ngraham marked an inline comment as done. ngraham added a comment. Use `gridUnit` to match the page margins correctly (it's the same width anyway) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > TitlesPageHeader.qml:37 > right: parent.right > -leftMargin: Units.largeSpacing > +leftMargin: Units.largeSpacing * 2 > } Shouldn't this be Units.gridUnit if you actually want to match the default

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Manuel Jesús de la Fuente
manueljlin accepted this revision. manueljlin added a comment. This revision is now accepted and ready to land. Looks significantly better in my opinion REPOSITORY R169 Kirigami BRANCH smaller-and-more-left-padded-page-titles (branched from master) REVISION DETAIL

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

2020-02-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Kirigami, manueljlin. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Level 1 headings are humongous. The degree of humongousness is maybe a bit

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. In D27189#606970 , @niccolove wrote: > > The reason why the text is now pushed over is because you added the new `PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. If anything the reverse

D27183: Port Application Page's form layout to Kirigami FormLayout

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:40742348cf05: Port Application Pages form layout to Kirigami FormLayout (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D27183: Port Application Page's form layout to Kirigami FormLayout

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. Looks like the elision issue could be an issue in FormLayout itself. I'll follow up. REPOSITORY R134 Discover Software Store BRANCH port-to-formlayout (branched from master) REVISION DETAIL https://phabricator.kde.org/D27183 To: ngraham, #vdg,

D27184: Use real Kirigami Separators instead of blue rectangles

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:3978c1de9b47: Use real Kirigami Separators instead of blue rectangles (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. In D27189#606914 , @ngraham wrote: > Yeah, so you'll want to submit a plasma-frameworks patch which includes the new SVG and mark this as depending on it. Okay > The reason why the text is now pushed over

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. @trmdi I don't really agree with your idea of always using a fixed size rectangle, sorry. :) INLINE COMMENTS > trmdi wrote in ToolTipInstance.qml:100 > Could it be zero here? Because `Text` lines already has its own padding, > isn't it? Depends on the font; you

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-06 Thread Tranter Madi
trmdi added a comment. Any other objection? REPOSITORY R119 Plasma Desktop BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D27149 To: trmdi, #plasma, #vdg, ndavis Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n,

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:79 > If we do that, then the size of the preview/album art area can get very > short, which I don't think is desirable. I think it still looks acceptable, not tool short. This is the worst case: F8088588:

D27088: [SystemTray] Implement sorting in the model

2020-02-06 Thread Konrad Materka
kmaterka updated this revision to Diff 75112. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27088?vs=74837=75112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27088 AFFECTED FILES

D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-06 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a79f80ed79ae: [SystemTray] Bunch of fixes and improvements in QML (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27085: [SystemTray] Bunch of fixes and improvements in QML

2020-02-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks sane to me. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D27085 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson,

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:100 > +ColumnLayout { > +spacing: units.smallSpacing > + Could it be zero here? Because `Text` lines already has its own padding, isn't it? > ngraham wrote in ToolTipInstance.qml:79 > If we do that, then

D27138: [Applet] Display device name when there is than one device

2020-02-06 Thread Noah Davis
ndavis added a comment. no objections :) REPOSITORY R115 Plasma Audio Volume Applet BRANCH devicesCount (branched from master) REVISION DETAIL https://phabricator.kde.org/D27138 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ndavis, cgiboudeaux, broulik, plasma-devel, Orage,

D27138: [Applet] Display device name when there is than one device

2020-02-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:1b737cfe6613: [Applet] Display device name when there is than one device (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Yeah, so you'll want to submit a plasma-frameworks patch which includes the new SVG and mark this as depending on it. The reason why the text is now pushed over is because

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > trmdi wrote in ToolTipInstance.qml:79 > Should we make the height `const` like this too? e.g. make it a golden > rectangle? > F8088397: image.png > > Otherwise, the size of the tooltip may be not consistent

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 75109. ngraham marked 7 inline comments as done. ngraham added a comment. Re-add spacing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27182?vs=75078=75109 BRANCH clean-up-tooltip-code (branched from master)

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. Actually it looks like there's nothing to fix in PC3. `smallMedium` is already the default size, and all the overrides in this patch are because we want to use non-default sizes in certain contexts. INLINE COMMENTS > trmdi wrote in ToolTipInstance.qml:79 > How do

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:79 > +// This number controls the overall size of the window tooltips > +Layout.maximumWidth: units.gridUnit * 17 > +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0 How do you choose the number 17?

Re: Dropping KRDB

2020-02-06 Thread David Edmundson
As an end goal +++. It's difficult to read currently. Also it's invoked on startup in kcminit 0 which allows everything down. I would like to see this done by moving pieces out gradually until there's nothing left rather than dropping it as a single action and then trying to recover what's

D27194: Remove human avatars

2020-02-06 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R128:80ac93fa2b48: Remove human avatars (authored by ndavis). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment. In D27194#606893 , @ngraham wrote: > In D27194#606892 , @ndavis wrote: > > > Alright fine, we should add more, but that shouldn't be a blocker for this patch. I simply can't

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. No problem, I can fix it in PC3. REPOSITORY R119 Plasma Desktop BRANCH clean-up-tooltip-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D27182 To: ngraham, #plasma, #vdg, ndavis Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n,

D27194: Remove human avatars

2020-02-06 Thread David Edmundson
davidedmundson added a comment. From a technical POV, pics get copied when selected, so you can do whatever without any user breakage. I don't have opinions on the actual change. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27194 To: ndavis, #vdg Cc:

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ndavis wrote in ToolTipInstance.qml:151 > I suppose it depends on whether or not you think PC3 toolbuttons should > reflect the look and size of Qt Widget toolbar buttons by default. Toolbar > buttons in Qt widgets use 22px icons (equivalent to

D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. In D27194#606892 , @ndavis wrote: > Alright fine, we should add more, but that shouldn't be a blocker for this patch. I simply can't get a replacement avatar right now and replacements could be added at any time.

D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment. Alright fine, we should add more, but that shouldn't be a blocker for this patch. I simply can't get a replacement avatar right now and replacements could be added at any time. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27194 To:

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Tranter Madi
trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:39 > > -spacing: units.smallSpacing > - Why do you remove all `spacing`? This increases lots of wasted space which is not good at least on small screens like 1366x768. > ToolTipInstance.qml:79 > +// This number

D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. See also my comment in T9910: Revisit user avatar gallery images : > In particular, we should add more nature, animal, abstract, technology, vehicular, and sports imagery. Normal people love this stuff--two of the most popular

D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. In D27194#606882 , @ndavis wrote: > In D27194#606877 , @ngraham wrote: > > > Wouldn't it be better to get better ones? We already removed a ton last year. If we keep on

D27194: Remove human avatars

2020-02-06 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D27194#606877 , @ngraham wrote: > Wouldn't it be better to get better ones? We already removed a ton last year. If we keep on removing stuff, we'll eventually end up with nothing but Konqis. As a counterpoint

D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis added a comment. In D27194#606877 , @ngraham wrote: > Wouldn't it be better to get better ones? We already removed a ton last year. If we keep on removing stuff, we'll eventually end up with nothing but Konqis. Sure, but we don't

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R122:57ba878cdd61: Improve the behaviour of the power button on mobile (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27193?vs=75106=75107

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 75106. apol added a comment. address documentation, connect REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27193?vs=75102=75106 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27193 AFFECTED FILES

D27194: Remove human avatars

2020-02-06 Thread Nathaniel Graham
ngraham added a comment. Wouldn't it be better to get better ones? We already removed a ton last year. If we keep on removing stuff, we'll eventually end up with nothing but Konqis. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27194 To: ndavis, #vdg Cc:

D27194: Remove human avatars

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. +1 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D27194 To: ndavis, #vdg Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D27194: Remove human avatars

2020-02-06 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY There were some complaints about the female avatar and during a discussion in the VDG channel, someone

Plasma 5.18 LTS tars ready to package

2020-02-06 Thread Jonathan Riddell
Tars are ready for packaging. To be released on Tuesday.

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Bhushan Shah
bshah added a comment. > he said he'll figure it out. (I have plan on how to handle that). REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D27193 To: apol, #plasma, bshah, broulik Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage,

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol added a comment. > Regarding this behavior, it will not always be desirable to do that, especially if user interaction is still happening, e.g. listening to music, having an active USB connection (because it'll close) for copying files or doing something over ssh, etc. I mentioned

D27191: [KSplash KCM] Fix ghns button label

2020-02-06 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. No objections for porting to Plasma stable branch from the Ukrainian team. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27191 To: broulik, #plasma,

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Luca Weiss
z3ntu added a comment. > On Mobile, if the power button is pressed for short time, suspend to Ram as requested by Bhushan. Regarding this behavior, it will not always be desirable to do that, especially if user interaction is still happening, e.g. listening to music, having an active

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/2/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 12:57:26 + Build duration: 13 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 30 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/30/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 06 Feb 2020 12:50:50 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 53 - Failure!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/53/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Feb 2020 12:50:53 + Build duration: 7 min 39 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Still Failing!

2020-02-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/3/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 06 Feb 2020 12:50:43 + Build duration: 4 min 44 sec and counting CONSOLE

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > handlebuttonevents.cpp:79 > +accel->setGlobalShortcut(globalAction, Qt::Key_PowerDown); > +connect(globalAction, SIGNAL(triggered(bool)), >

D27193: Improve the behaviour of the power button on mobile

2020-02-06 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY On Mobile, if the power button is pressed for short time, suspend to Ram as requested by Bhushan.

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Noah Davis
ndavis added a comment. In D27189#606790 , @niccolove wrote: > ... The svg should be created (in a different patch, I thought?) I just realized this is plasma-workspace, not plasma-framework. My bad. REPOSITORY R120 Plasma Workspace

D27191: [KSplash KCM] Fix ghns button label

2020-02-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, yurchor, kde-i18n-doc. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 417224 FIXED-IN: 5.18.0 TEST PLAN I want this in 5.18, can I have

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove added a comment. In D27189#606788 , @ndavis wrote: > .+1 to this idea. I noticed that the separator on the left is less dark. I'm not necessarily opposed to that, but is it intentional? Also, where is toparea.svg? I don't see it in

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Noah Davis
ndavis added a comment. .+1 to this idea. I noticed that the separator on the left is less dark. I'm not necessarily opposed to that, but is it intentional? Also, where is toparea.svg? I don't see it in `breeze/widgets/` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

2020-02-06 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH topbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D27189 AFFECTED FILES

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-02-06 Thread Cyril Rossi
crossi created this revision. crossi added reviewers: Plasma, ervin, broulik, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY App-specific notifications' behavior are now managed with KConfigXT.

D27155: libnotificationmanager : add app-specific kconfig settings

2020-02-06 Thread Cyril Rossi
crossi updated this revision to Diff 75090. crossi added a comment. Remove specific default values, will rely on shipped settings. Fix comment at EOL that makes the entry not read. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27182: [applets/taskmanager] Clean up Tooltip code

2020-02-06 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > broulik wrote in ToolTipInstance.qml:151 > Can we please get this fixed in `PlasmaComponents3` - this is being set all > over the place, so clearly a bug in the component itself. I suppose it depends on whether or not you think PC3 toolbuttons