D27262: Reduce blank space inside header

2020-02-08 Thread Tranter Madi
trmdi created this revision. trmdi added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Make the tooltip as compact as possible. This is also consistent with texts inside playerControlRow

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Tranter Madi
trmdi updated this revision to Diff 75287. trmdi added a comment. - Remove the redundant line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75286&id=75287 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://p

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM! @broulik, are you happy with this now? REPOSITORY R119 Plasma Desktop BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D27149 To: trmdi, #plasma, #vdg, ndavis, ngraham Cc: n

D27149: Scroll the truncated song/artist text when long hovering over it

2020-02-08 Thread Tranter Madi
trmdi updated this revision to Diff 75286. trmdi added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27149?vs=75026&id=75286 BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/

D27261: [Folder view] Fix binding loop on width

2020-02-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This fixes the binding loop and replaces a complicated bit of code with something much simpler.

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still unstable!

2020-02-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/33/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 08 Feb 2020 22:58:45 + Build duration: 26 min and counting JUnit Tests Na

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 56 - Still Failing!

2020-02-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/56/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Feb 2020 22:58:45 + Build duration: 56 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Failing!

2020-02-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/32/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 08 Feb 2020 21:02:12 + Build duration: 56 min and counting CONSOLE OUTPUT

D27257: [Applet]Move toolbar to the bottom

2020-02-08 Thread Nathaniel Graham
ngraham added a comment. While you're at it, can you center the `disabledMessage` label and make it a disabled Level 3 heading? See D27219 . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo,

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c5a6ba369c4e: Center placeholder texts in system tray popups (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27219?vs=75258&id=75284

D27260: [applets/systemtray] Set pin button's size correctly

2020-02-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Depends on D27221 REPOSITORY R120 Plasma Workspace BRANCH

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 55 - Still Failing!

2020-02-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/55/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 08 Feb 2020 21:02:11 + Build duration: 1 min 53 sec and counting CONSOLE OUTPUT

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread David Edmundson
davidedmundson added a comment. From a code pov. +1 I don't have an opinion on the UI change, but if vdg approve, ship it REPOSITORY R120 Plasma Workspace BRANCH centered-placeholder-texts (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D27219 To: ngraham,

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:76ccc090: sddm-theme: Use non-deprecated KDEInstallDirs variable (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27241?vs=752

D27199: [WIP][Applet]Update layout based on T10470

2020-02-08 Thread George Vogiatzis
gvgeo updated this revision to Diff 75280. gvgeo added a comment. Fixed hiding function of the separator. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75150&id=75280 BRANCH layout (branched from master) REVISION DETAI

D27257: [Applet]Move toolbar to the bottom

2020-02-08 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. gvgeo requested review of this revision. REVISION SUMMARY Based on T10470

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Noah Davis
ndavis added a comment. Now it's unable to apply the patch because a commit it uses isn't present in my local git repo. Even if I create another branch based on D27221 and then fetch the patch with `--nobranch`, I get the same error. REPOSITORY R119 Pl

D27061: replace samba module with data that works

2020-02-08 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R102:f1768f7b3ab9: replace samba module with data that works (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27061?vs=75170&id=75272#toc REPOSITORY R102 KInfoCenter CHANGES

D27061: replace samba module with data that works

2020-02-08 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm happy with the model. As for 5.18. I would normally be super against, but if it really didn't work before, then there's no point blindly following the rules if the u

D27135: Add PagePoolAction to QRC file

2020-02-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c94988a6dc37: Add PagePoolAction to QRC file (authored by masonm, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27135?vs=74940&id=75262 RE

D27251: Relicense to LGPL-2.0-or-later

2020-02-08 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Request to Marco to relicense both files to the license LGPL-2.0-or-later, which

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 75258. ngraham marked an inline comment as done. ngraham added a comment. Fill, don't center REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27219?vs=75184&id=75258 BRANCH centered-placeholder-texts (branched

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Nathaniel Graham
ngraham added a comment. Try adding `--skip-dependencies`. It's probably getting confused by the dependent patch for a different repo. REPOSITORY R119 Plasma Desktop BRANCH smallMedium-playback-toolbuttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D27222 To:

D27250: Add PagePoolAction to QRC file

2020-02-08 Thread Mason McParlane
masonm created this revision. masonm added a reviewer: VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. masonm requested review of this revision. REVISION SUMMARY Missing PagePoolAction causes crash on static builds. Resubmission of https://phabricator.kde.org/D2

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > FullRepresentation.qml:41 > PlasmaExtras.Heading { > +anchors.centerIn: parent > +horizontalAlignment: Text.AlignHCenter Why not fill given you set the text alignment REPOSITORY R120 Plasma Workspace BRANCH center

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.13 - Build # 3 - Still Failing!

2020-02-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.13/3/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 08 Feb 2020 14:31:48 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an absolute path (si

D27078: Drag-and-drop files at the right coordinates

2020-02-08 Thread Painless Roaster
painlessroaster updated this revision to Diff 75238. painlessroaster added a comment. fix unnecessary/unintentional whitespace change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27078?vs=74819&id=75238 REVISION DETAIL https://phabricator.kde.org/D27078 AFFECTED FILES contai

D27237: [Background Finder] Create a valid invocation token

2020-02-08 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY According to Qt docs, QUuid() creates a null UUID object. TEST PLAN N/A, plasmashell is very unstable wi

D27219: Center placeholder texts in system tray popups

2020-02-08 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Visually, LGTM REPOSITORY R120 Plasma Workspace BRANCH centered-placeholder-texts (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D27219 To: ngraham, #vdg, #

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-08 Thread Noah Davis
ndavis added a comment. Arc's cherry picking fails when this patch tries to cherry pick from my arcpatch-D27221 branch. REPOSITORY R119 Plasma Desktop BRANCH smallMedium-playback-toolbuttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D27222 To: ngraham, #vdg,

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ae855e0dcbc: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26582?vs=73

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car
meven added a comment. Let's be safe and targe 5.19 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachu

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-02-08 Thread Méven Car
meven added a comment. 5.18 or not ? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka