D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76200. gvgeo edited the test plan for this revision. gvgeo added a comment. Changed comment. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76173=76200 BRANCH scrollbars (branched from

D27579: Remove attempt to start long gone baloo_file_cleaner

This revision was automatically updated to reflect the committed changes. Closed by commit R119:616a99165eda: Remove attempt to start long gone baloo_file_cleaner (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27579?vs=76181=76199

D27577: [KCM]Fix content below scrollbars

gvgeo added inline comments. INLINE COMMENTS > Advanced.qml:33 > +// TODO Fix contentview width, and Remove policy. > +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff > > What if there's too many devices? No matter how many devices there are, column is always a column. > It doesn't

D27590: Calculate needsSave on checkbox toggle not on change

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27590 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, Orage, LeGast00n,

D27577: [KCM]Fix content below scrollbars

apol added inline comments. INLINE COMMENTS > Advanced.qml:33 > +// TODO Fix contentview width, and Remove policy. > +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff > What if there's too many devices? It doesn't sound like a good solution to hide the ScrollBar forever. Also what

D27590: Calculate needsSave on checkbox toggle not on change

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we will trigger it during load, which is wasteful. But worse

D26035: battery: Improve the brightness responsiveness

frenzie added inline comments. INLINE COMMENTS > PopupDialog.qml:73 > KeyNavigation.backtab: batteryList > +stepSize: batterymonitor.maximumScreenBrightness/100 > + Because it's artificially limited to 100 positions, this change makes it impossible to set a value by

D27581: Use K_PLUGIN_CLASS_WITH_JSON

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's a bit niver than the factory thing TEST PLAN builds, kcm opens REPOSITORY

D27426: [KRDB] Rename GTK colours to be exported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fffb352cfa1e: [KRDB] Rename GTK colours to be exported (authored by cblack). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27426?vs=75752=76185 REVISION

D27425: [GTK3] Rename colour definitions

This revision was automatically updated to reflect the committed changes. Closed by commit R98:dca25cb44b37: [GTK3] Rename colour definitions (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27425?vs=75751=76184 REVISION DETAIL

D27579: Remove attempt to start long gone baloo_file_cleaner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please REPOSITORY R119 Plasma Desktop BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D27579 To: bruns, #baloo, ngraham Cc: plasma-devel,

D27574: Remove bold formatting of device name

ngraham added a comment. +1 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D27574 To: nicolasfella, #plasma, drosca, davidedmundson Cc: ngraham, broulik, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26992: [SystemTray] Use unified data model everywhere

ngraham added a comment. My bad, your patch actually fixes a pre-existing visual bug. :) That accounts for the change. +1 visually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham,

D27579: Remove attempt to start long gone baloo_file_cleaner

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The standalone index cleaner has been replaced almost 5 years by functionality implemented in

D27570: [applets/systemtray] Clip ListView in config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:193c89a4a0cf: [applets/systemtray] Clip ListView in config (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27570?vs=76165=76180#toc REPOSITORY R120 Plasma

D27574: Remove bold formatting of device name

nicolasfella updated this revision to Diff 76178. nicolasfella added a comment. - Simplify REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27574?vs=76169=76178 BRANCH nobold REVISION DETAIL https://phabricator.kde.org/D27574 AFFECTED FILES

D27570: [applets/systemtray] Clip ListView in config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R120 Plasma Workspace BRANCH clip REVISION DETAIL https://phabricator.kde.org/D27570 To: nicolasfella, #plasma, ngraham Cc: ngraham, plasma-devel, Orage,

D27577: [KCM]Fix content below scrollbars

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set content to use available space. BUG:416331 BUG:417447 TEST PLAN Open audio

D27576: Kill Runner: Move config keys to new file

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The config keys/sorting enum have been moved to a new file, before

D27565: Hide configure action in Info center mode

broulik added a comment. In D27565#615851 , @broulik wrote: > Wouldnt it be better to just hide the `configure` action when it's created? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27565 To: ngraham,

D27565: Hide configure action in Info center mode

broulik added a comment. Wouldnt it be better to just hide the `configure` action where it's created? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27565 To: ngraham, #plasma, mart Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27574: Remove bold formatting of device name

broulik added a comment. It uses plain text so a device named "phone" doesn't mess with the layout REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D27574 To: nicolasfella, #plasma, drosca, davidedmundson Cc: broulik, pino, plasma-devel, Orage, LeGast00n,

D27572: [kcm] Drop 'Enable bluetooth integration' setting

broulik added a comment. +1 Iirc the plasmoid is loaded regardless of that setting anyway? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D27572 To: nicolasfella, #plasma, drosca Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27574: Remove bold formatting of device name

pino added inline comments. INLINE COMMENTS > devicedetails.cpp:117 > { > -m_ui->remoteName->setText(QStringLiteral("%1").arg(name)); > +m_ui->remoteName->setText(QStringLiteral("%1").arg(name)); > } then you can simply remove the string+arg... REPOSITORY R97 Bluedevil REVISION

D27574: Remove bold formatting of device name

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY D27543 set the label

D27572: [kcm] Drop 'Enable bluetooth integration' setting

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It controls whether the bluedevil kded module is loaded. I don't see any

D27570: [applets/systemtray] Clip ListView in config

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content will overflow the frame when scrolling REPOSITORY R120 Plasma

D27561: [kcm/activities] Clip ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dba3d5670275: [kcm/activities] Clip ListView (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27561?vs=76134=76163 REVISION

D27559: [kcm/baloo] Clip ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0ec354f7d269: [kcm/baloo] Clip ListView (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27559?vs=76132=76164 REVISION DETAIL

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76149. alex marked an inline comment as done. alex added a comment. Revert moving of config keys from commit "Remove duplicate function calls, move config keys to new file" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27563: [mobile/wifi] Use ScrollViewKCM

nicolasfella added a comment. In D27563#615561 , @ngraham wrote: > What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of

D27555: Add a category for kde-only and gnome-only apps

nicolasfella added a comment. In D27555#615587 , @ngraham wrote: > I used to think this was really important but am less sure now. I don't feel the need to push for it, but nonetheless Aleix is right that it's pretty common user request--not

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, wait for @broulik review REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To:

D27518: Only enable the "Help" button if khelpcenter is available

ahmadsamir added a comment. openHelp() will need to be changed, because the "application=" part of the url will be "systemsettings" (QCoreApplication::applicationName()), which would open the handbook of systemsettings instead of e.g. /kcontrol/fonts/index.html. Is the API for the

D27556: HiDPI pixmap

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > anthonyfieroni wrote in AuthDialog.cpp:108 > You wanna use `devicePixelRatioF` right? Fixed thanks! REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27556

D27556: HiDPI pixmap

guoyunhe updated this revision to Diff 76146. guoyunhe marked 2 inline comments as done. guoyunhe added a comment. Change devicePixelRatio() to devicePixelRatioF() REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27556?vs=76145=76146

D27556: HiDPI pixmap

anthonyfieroni added inline comments. INLINE COMMENTS > AuthDialog.cpp:108 > > +const qreal dpr = devicePixelRatio(); > + You wanna use `devicePixelRatioF` right? REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27556 To: guoyunhe, #plasma

D27556: HiDPI pixmap

guoyunhe marked 2 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > apol wrote in AuthDialog.cpp:108 > You should get the dpr from the window, not the qApp. Different screens will > have different dprs. Fixed. Getting it from widget now. > apol wrote in

D27556: HiDPI pixmap

guoyunhe updated this revision to Diff 76145. guoyunhe added a comment. Get DPR from widget instead of app REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27556?vs=76128=76145 BRANCH master REVISION DETAIL