D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76597. trmdi added a comment. Small fix. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=76596=76597 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27458

D27458: Set a better position for Krunner in wayland

trmdi updated this revision to Diff 76596. trmdi added a comment. Never show before position is set REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27458?vs=75883=76596 BRANCH arcpatch-D27458 (branched from master) REVISION DETAIL

D27669: WIP: [kstyle] Tools area

ngraham added a comment. In D27669#619230 , @hpereiradacosta wrote: > Overall, this is good stuff I think (although we should also discuss whether this should be part of breeze or rather a next-gen theme). We discussed that in T12488

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Yeah, that's fine. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Kirigami in applet? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27669: WIP: [kstyle] Tools area

hpereiradacosta added a comment. Overall, this is good stuff I think (although we should also discuss whether this should be part of breeze or rather a next-gen theme). Still: right now it crashes all applications (here at least) when you unlock toolbars, move them to a different

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being approximated here, so why not use the real thing? :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich,

D27669: WIP: [kstyle] Tools area

ndavis added a subscriber: hpereiradacosta. ndavis added a comment. Adding Hugo as a subscriber since he might have some advice. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: hpereiradacosta, gvgeo, ngraham, manueljlin,

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76592. cblack added a comment. Transition from window active <-> inactive, TODO: read from kdecoration config REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76590=76592 BRANCH cblack/toolsarea REVISION DETAIL

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76590. cblack added a comment. Properly draw menubar borders REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76586=76590 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Looking pretty great. The appearance of the Tools Area itself is good in all KDE apps tested. Visually, I only see a few remaining issues: There's no line under the titlebar in windows without a Tools Area: F8135611: Screenshot_20200227_151538.png

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76586. cblack added a comment. Update tools area manager on colourscheme change REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76585=76586 BRANCH cblack/toolsarea REVISION DETAIL

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76585. cblack added a comment. Don't draw border when you shouldn't draw tools area REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76582=76585 BRANCH cblack/toolsarea REVISION DETAIL

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b2e4ddaa01a: [applets/taskmanager] Show PA-related features even when audio indicators are… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76582. cblack added a comment. Recompute toolbars after adding a widget REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76581=76582 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76581. cblack added a comment. Draw separator line REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76568=76581 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Good stuff. REPOSITORY R119 Plasma Desktop BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684

D25324: Display a warning, if xsettingsd is not found

eszlari added a comment. In D25324#563373 , @gikari wrote: > In D25324#563347 , @eszlari wrote: > > > But seems, this only applies to dependencies checked by find_package(). > > > I'm

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27711: [Applet]Use gridLayout for details

gvgeo created this revision. gvgeo added reviewers: Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use gridLayout for repeater in DetailsText. Now right mouse menu(copy) opens on

D27199: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27697: WIP: Added top area to notification header

niccolove updated this revision to Diff 76571. niccolove added a comment. Fixed margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76543=76571 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76568. cblack added a comment. Don't do tools area on dialog windows REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76564=76568 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76564. cblack added a comment. Improvements to toolbar heuristics REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76560=76564 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt planned changes to this revision. fvogt added a comment. I need some input on how to express `HAVE_QTWEBENGINEWIDGETS` with this. Currently it would fail to build if `Qt5WebEngineWidgets` is installed but `Qt5WebChannel` isn't. REPOSITORY R111 KSysguard Library REVISION DETAIL

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76560. cblack added a comment. Increase padding of toolbar REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76559=76560 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76559. cblack added a comment. Fix bad heuristic REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76558=76559 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76558. cblack added a comment. Improve toolbar heuristics REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76552=76558 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R124:0be65944f311: If KHelpCenter isnt available fallback to opening doc at docs.kde.org (authored by ahmadsamir). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D27700: Add an autotest for ActionToolBar

ahiemstra added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:86 > Maybe pass different COMMAND to the same add_custom_command? As is it reads > like you're declaring the command several times. > > See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html Good

D27700: Add an autotest for ActionToolBar

ahiemstra updated this revision to Diff 76556. ahiemstra added a comment. - Don't use multiple commands to achieve what one can also do REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27700?vs=76539=76556 BRANCH actiontoolbar_test REVISION DETAIL

D27697: WIP: Added top area to notification header

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Also please `Math.round` when you divide sizes INLINE COMMENTS > NotificationItem.qml:114 > > -NotificationHeader { > -id: notificationHeading > -

D14562: Introduce Theme.smallestFont

volkov updated this revision to Diff 76554. volkov added a comment. registered for 2.2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14562?vs=38964=76554 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14562 AFFECTED FILES

D27699: Replace qmltestrunner with a custom executable that effectively does the same

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6a0009b41047: Replace qmltestrunner with a custom executable that effectively does the same (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27199: [Applet]Update layout based on T10470

ngraham accepted this revision. ngraham added a comment. LGTM! Nice work. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D27199_2 REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham Cc: ngraham, plasma-devel,

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76551. cblack added a comment. Reload on colour scheme update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76510=76551 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76552. cblack added a comment. Drop qDebug() << REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76551=76552 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27554: reviews: expose the reviewed package version on the delegate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:d58668698f5f: reviews: expose the reviewed package version on the delegate (authored by apol). REPOSITORY R134

D27702: Block calls to org.kde.KSplash till it is registered

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a8299642d718: Block calls to org.kde.KSplash till it is registered (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27702: Block calls to org.kde.KSplash till it is registered

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY A recent update to startup made it too fast and hit a race with ksplash.

D27701: [ComboBox] Use transparent dimmer

broulik updated this revision to Diff 76546. broulik edited the test plan for this revision. broulik added a comment. - Clarify comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27701?vs=76545=76546 REVISION DETAIL

D27701: [ComboBox] Use transparent dimmer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When not using `dim` it breaks "click outside" for `ComboBox` when in a `ScrollView`. I

D27700: Change copy to binary to use a custom target that always runs

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:86 > make_directory > ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2/) > -add_custom_command(TARGET kirigamiplugin POST_BUILD > +add_custom_command(TARGET copy_to_bin POST_BUILD >

D27697: WIP: Added top area to notification header

niccolove updated this revision to Diff 76543. niccolove added a comment. Fix margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76533=76543 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 126 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/126/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 27 Feb 2020 13:12:38 + Build duration: 5 min 46 sec and counting JUnit Tests

D27697: WIP: Added top area to notification header

niccolove added a comment. Wait, are notifications ignoring dialog/background theme margins!? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 280 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/280/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 27 Feb 2020 13:12:38 + Build duration: 3 min 43 sec and counting JUnit Tests

D27679: [emojier] Set minimum window height and width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0247bf56954: [emojier] Set minimum window height and width (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27679?vs=76468=76541

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ervin added inline comments. INLINE COMMENTS > bport wrote in spellchecking.cpp:88 > Yes, or I can probably also use item like before, and that will be handled > for me That would create other issues I think (not fully sure TBH). Well in any case that's an extra level of indirection we don't

D27700: Change copy to binary to use a custom target that always runs

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds an inital test to test whether ActionToolBar does the right thing. It does

D27699: Replace qmltestrunner with a custom executable that effectively does the same

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY CI is currently failing due to LD_PRELOAD of the ASAN libraries failing for some

D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY PrivateActionToolButton behaves slightly different when setting showText to false

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:26f942fc335f: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. In D27650#618492 , @davidedmundson wrote: > Can I have your full name + email address please. Aleksei Nikiforov REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To:

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > ervin wrote in spellchecking.cpp:88 > Sure but still, the skeleton is expected to be already be in a "loaded" state > at that point, that's why it works for the items (otherwise a findItem > wouldn't be enough, it'd have to call readConfig on them

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ervin added inline comments. INLINE COMMENTS > bport wrote in spellchecking.cpp:88 > no load only do findItem for managed widget on the skeleton Sure but still, the skeleton is expected to be already be in a "loaded" state at that point, that's why it works for the items (otherwise a findItem

D27697: WIP: Added top area to notification header

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This is supposed to add a top area to floating notifications: (just a sec) The result is not correct: (just a sec)

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > ervin wrote in spellchecking.cpp:88 > Are you sure this is necessary? I'd expect KCModule::load() to call load() on > m_skeleton no load only do findItem for managed widget on the skeleton > ervin wrote in spellcheckingskeleton.cpp:51 > I have a

D27189: Created a top area based on widgets/toparea.svg

niccolove added inline comments. INLINE COMMENTS > mart wrote in ExpandedRepresentation.qml:48 > not in all places you will have access to a dialog. the magic correct values > should come from the toparea margins itself done to go well with the > correspoding background svg. > > in the end, i

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 76530. niccolove added a comment. Using new TopArea element from PlasmaComponents REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76529=76530 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 76529. niccolove added a comment. - Merge branch 'master' into topbar REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76374=76529 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

niccolove added a comment. Ok - I think I got it. I will try to create a generic PlasmaCore.TopArea element and use it here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: mart, ngraham, ndavis,

D27669: WIP: [kstyle] Tools area

gvgeo added a comment. Filelight works fine here. Kmag has some buttons with wrong color, but the toolbar row takes correct color. With breeze light when changing active window, color changing is not in sync with the titlebar. The timing is a little off, can get dizzy. REPOSITORY R31

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 76526. gvgeo edited the summary of this revision. gvgeo added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75906=76526 BRANCH arcpatch-D27199_2 REVISION DETAIL

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ervin wrote in spellchecking.cpp:55 > What about calling toSet() on those? Not overly efficient but would compress > a bit the resulting code. Alternatively,

D27689: Use correct connections for QQC2 controls

broulik added inline comments. INLINE COMMENTS > main.qml:223 > +onActivated: { > cA.modeStaged = currentIndex; > calcNeedsSave(); Change this to `index` (which is the signal argument). There's no guarantee that `currentIndex` will be

D27199: [Applet]Update layout based on T10470

manueljlin accepted this revision as: manueljlin. manueljlin added a comment. Looks good, let's wait for ngraham so he accepts as vdg REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D27199_2 REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg,