KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.13 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.13/30/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 21:39:11 + Build duration: 51 sec and counting

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.13/29/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 21:32:31 + Build duration: 1 min 13 sec and counting CONSOLE

KDE CI: Plasma » kactivitymanagerd » stable-kf5-qt5 FreeBSDQt5.13 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/stable-kf5-qt5%20FreeBSDQt5.13/28/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 20:37:51 + Build duration: 55 sec and counting CONSOLE OUTPUT

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76799. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=76798=76799 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES shell/desktopview.cpp shell/desktopview.h To: pdabrowski,

D26718: aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > desktopview.cpp:246 > > +bool DesktopView::handleKRunnerTextInput(QKeyEvent *e) { > +// allow only Shift and GroupSwitch modifiers TODO: code style: { REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. Is it? INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} Biggest number it can display? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27792: [Applet]Fix traffic monitor labels width

davidedmundson added inline comments. INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} what is this number about? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D26718: aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 76798. pdabrowski retitled this revision from "autostart KRunner with Plasma, aggregate text for KRunner in DesktopView" to "aggregate text for KRunner in DesktopView". pdabrowski edited the summary of this revision. pdabrowski added a comment.

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. @ngraham Is there a better way to fix this? In D27199#620730 , @jgrulich wrote: > Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. > > See picture below: > F8145280:

D27792: [Applet]Fix traffic monitor labels width

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use text metrics to set a proper space for labels. And remove unused plotter

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/57/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 19:23:53 + Build duration: 4 min 32 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 62 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/62/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 19:23:49 + Build duration: 3 min 20 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/38/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 19:23:47 + Build duration: 2 min 13 sec and counting JUnit Tests

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella marked 2 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in notification.cpp:333 > That codepath assumes we have a notifyrc nvm REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To:

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella updated this revision to Diff 76783. nicolasfella added a comment. - Combine codepaths REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27786?vs=76780=76783 BRANCH notiappname REVISION DETAIL https://phabricator.kde.org/D27786

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in notification.cpp:333 > How about adjusting this condition instead? That codepath assumes we have a notifyrc REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfella,

D27786: [notifications] Read appname from desktop file if no appname set

broulik added inline comments. INLINE COMMENTS > notification.cpp:333 > // This will have us show e.g. "Dr Konqi" instead of generic "Plasma > Desktop" > if (isDefaultEvent && !serviceName.isEmpty()) { > applicationName = serviceName; How about adjusting this

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Some applications, e.g. pamac, don't send an app_name, which is legal

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir added a comment. TODO: fix the font dialog to select the correct "Regular"-like style (I have a working patch but needs more work). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To: ahmadsamir, #plasma, davidedmundson Cc: plasma-devel,

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir updated this revision to Diff 76779. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Remove setNeedsSave(false) from load(), doesn't seem to be needed any more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY A "Regular" font will have an empty styleName e.g. "DejaVu Sans,12,-1,5,50,0,0,0,0,0" so that setBold(true) can

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Only nitpicking, otherwise it looks good to me. INLINE COMMENTS > l2tpauth.cpp:34 > +#include "nm-l2tp-service.h" > +#include "debug.h" > + This include doesn't seem to be used. >

D27782: expose IncludeUsage to QML api

mart updated this revision to Diff 76774. mart added a comment. - rename property to shownItems REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76768=76774 BRANCH phab/exposeusage REVISION DETAIL https://phabricator.kde.org/D27782

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. See picture below: F8145280: plasma-nm.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

This revision was automatically updated to reflect the committed changes. Closed by commit R116:803b17ad39ef: Rename L2TP IPsec Settings dialog from Advanced to IPsec (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27770: HiDPI improvement of left panel

guoyunhe abandoned this revision. guoyunhe marked an inline comment as done. guoyunhe added a comment. I think there can be better solution. Use Breeze icons in the left panel instead of rendering the emoji. Reference design in Telegram Desktop: F8145244: image.png

D27782: expose IncludeUsage to QML api

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in recentusagemodel.cpp:150 > we have QQmlParserStatus in this class, we probably want to use it. refresh() implementation already has a check on m_completed (which is set on componentCompleted) REPOSITORY R120 Plasma

D27782: expose IncludeUsage to QML api

davidedmundson added a comment. generally makes sense INLINE COMMENTS > recentusagemodel.cpp:150 > +emit usageChanged(); > +refresh(); > +} we have QQmlParserStatus in this class, we probably want to use it. > recentusagemodel.h:69 > Q_PROPERTY(int ordering READ ordering WRITE

D27783: Add new Account portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH account-portal REVISION DETAIL https://phabricator.kde.org/D27783

D27782: expose IncludeUsage to QML api

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY RecentUsageModel can list all aps and docs, only aps or only docs. make possible to control that from

D27721: globalaccel: allow sleep and hibernate keyboard shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R133:98da04c657a0: globalaccel: allow sleep and hibernate keyboard shortcuts (authored by bshah). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D27781: [Language KCM] Wrap the label text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2df03a51f97: [Language KCM] Wrap the label text (authored by PureTryOut, committed by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27629: [plasma-session] Load startup and shutdown on demand

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c34dfa97f3e: [plasma-session] Load startup and shutdown on demand (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27629?vs=76318=76765#toc REPOSITORY R120

D27781: [Language KCM] Wrap the label text

PureTryOut created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. PureTryOut requested review of this revision. REVISION SUMMARY This way the text doesn't get cut off the screen on at least the PinePhone TEST PLAN 1. Open the Language KCM on a small

monday meeting notes for 2/3/2020

David E: * Yet more preparing for the plasma-systemd branch. Moving some bits slowly to master * We found and fixed an existing race condition with ksplash * that's all going well * there's some libksysguard stuff on review for exposting process stuff in a more declarative way * as part of a

D27770: HiDPI improvement of left panel

davidedmundson added a comment. Is that diff up to date? Phab only shows me a QRect changing to a QRectF REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27770 To: guoyunhe, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n,

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

davidre added a comment. So the way forward I see as follows: Eventually we will move stuff out of KRDB to places where it also fits in sementically. Whenever an option is changed in the kcms which call runrdb currently these things can react to that by listening to the DBus signal which

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

davidedmundson added inline comments. INLINE COMMENTS > krdb.cpp:997 > +path = path.left(pos); > +if (!QFile::exists(path + "/libexec/breeze-gtk/color_gtk2_theme")) > + return; Instead of this, we probably want to export the KDE_INSTALL_FULL_LIBEXECDIR to C++ and use that.

D27770: HiDPI improvement of left panel

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > davidedmundson wrote in emojier.cpp:83 > this is broken Reverted REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27770 To: guoyunhe, #plasma, davidedmundson Cc:

D27770: HiDPI improvement of left panel

guoyunhe updated this revision to Diff 76758. guoyunhe added a comment. Fix size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27770?vs=76741=76758 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27770 AFFECTED FILES

D27776: focus email input line by default

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we already (re)set the focus on failed login attempt but neglected to do it when showing the page.

D27770: HiDPI improvement of left panel

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > emojier.cpp:83 > if (_size) { > *_size = size; > } this is broken REPOSITORY R119 Plasma Desktop REVISION

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R111:ba7f78716af6: Only link to Qt5WebChannel if Qt5WebEngineWidgets available (authored by fvogt). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt marked an inline comment as done. fvogt added inline comments. INLINE COMMENTS > lbeltrame wrote in CMakeLists.txt:86 > Should you add a message in case one of the two is not found? In that case `WEBENGINE_SCRIPTING_ENABLED` is `FALSE` and it'll print that `Scripting plugin support` is

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

lbeltrame added inline comments. INLINE COMMENTS > CMakeLists.txt:86 > +set(WEBENGINE_SCRIPTING_ENABLED FALSE) > +if(Qt5WebEngineWidgets_FOUND AND Qt5WebChannel_FOUND) > +set(WEBENGINE_SCRIPTING_ENABLED TRUE) Should you add a message in case one of the two is not found? REPOSITORY R111

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt updated this revision to Diff 76750. fvogt added a comment. This revision is now accepted and ready to land. Treat scripting as a feature instead REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27347?vs=75550=76750 BRANCH Plasma/5.18

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt added a comment. Currently `processui/scripting.cpp` has this: #if HAVE_QTWEBENGINEWIDGETS #include ... #endif So `Qt5WebEngineWidgets` without `Qt5WebChannel` will fail to build and `Qt5WebChannel` without `Qt5WebEngineWidgets` leads to scripting support

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#620470 , @gvgeo wrote: > IMO this is the wrong way to do these changes. > > 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be