KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 608 - Fixed!

2020-03-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/608/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Mar 2020 02:02:12 + Build duration: 44 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still Failing!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/7/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 07 Mar 2020 02:03:23 + Build duration: 30 min and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Still Failing!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/8/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 07 Mar 2020 02:03:22 + Build duration: 29 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 449 - Still unstable!

2020-03-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/449/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Mar 2020 02:02:13 + Build duration: 23 min and counting JUnit Tests Name: projectroot

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 607 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/607/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 07 Mar 2020 00:48:41 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated 2800

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 448 - Failure!

2020-03-06 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/448/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 07 Mar 2020 00:48:28 + Build duration: 5 min 34 sec and counting CONSOLE OUTPUT [...truncated

D27686: Fix connection to invalid signal

2020-03-06 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R124:ead61e26ab78: Fix connection to invalid signal (authored by aacid). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27686?vs=76498=77143 REVISION DETAIL

D26718: aggregate text for KRunner in DesktopView

2020-03-06 Thread Nathaniel Graham
ngraham added a comment. @davidedmundson stable branch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D26718: aggregate text for KRunner in DesktopView

2020-03-06 Thread Nathaniel Graham
ngraham added a comment. All right then. I guess it is a tricky problem. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n,

D27664: Improve layout and appearance of app details view

2020-03-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:9b0652d5c724: Improve layout and appearance of app details view (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D27663: Show tooltip with full URL for URL button with overridden text

2020-03-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c1475bfa1781: Show tooltip with full URL for URL button with overridden text (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27903: [applet/digital-clock] Show time zones in expanded representation too

2020-03-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now time zones are only shown in the tooltip, which is annoying since the tooltip

D27212: Have pullback toolbars on scrollable pages also for footers

2020-03-06 Thread Camilo Higuita
This revision was automatically updated to reflect the committed changes. Closed by commit R169:7712c75953c5: Have pullback toolbars on scrollable pages also for footers (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

Re: Plasma Sprint 2020 in Augsburg, Germany

2020-03-06 Thread Kai Uwe Broulik
Hi, I'm discussing this with the board right now. Stay tuned. Am 06.03.20 um 09:35 schrieb Konrad Materka: Hi, What is the chance of this event being cancelled due to coronavirus? I have to book tickets on advance, unfortunately flight is the most reasonable. -- Regards, Konrad Materka

D26992: [SystemTray] Use unified data model everywhere

2020-03-06 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > AbstractItem.qml:34 > property Item iconItem > property int /*PlasmaCore.Types.ItemStatus*/ status > +property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus Lets look at fixing in

D27895: use content_type as fallback in appchooser dialog

2020-03-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R838:58af54b91de9: use content_type as fallback in appchooser dialog (authored by sitter). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread David Redondo
davidre added a subscriber: davidedmundson. davidre added a comment. In D27892#623425 , @ngraham wrote: > +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread Nathaniel Graham
ngraham added a comment. +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would get this fix/change, not just Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre,

D27685: Remove extra top and bottom padding from dock widgets

2020-03-06 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. Oh I see now, like this, when unlocked: F8157256: Screenshot_20200306_064315.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27685 To: ngraham, #vdg,

D27685: Remove extra top and bottom padding from dock widgets

2020-03-06 Thread Nathaniel Graham
ngraham added a comment. Can you think of an example of where there would be? If there's content inside this margin, that seems wrong to me anyway. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27685 To: ngraham, #vdg, #breeze, cblack, ndavis Cc: plasma-devel,

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-06 Thread Nate Graham
On 3/6/20 12:55 AM, Kai Uwe Broulik wrote: Frameworks: === Looks like just Plasma Dialog in Plasma-Framework, for which I believe KWayland was turned into a Framework to begin with. Other: == - Spectacle - Yakuake - Latte Dock (presumably similar uses as plasmashell) Some of

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) Sorry, that was just for the initial version of this patch to allow for static inline variables to arrive at the first

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) That's too offensive. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze,

D27895: use content_type as fallback in appchooser dialog

2020-03-06 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY when there is no filename (e.g. for magnet uris) the dialog would show %1(I18NARGUMENTMISSING).

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread David Redondo
davidre added a comment. What happens is maybe more clear when using custom window shadows: F8154350: Screenshot_20200306_133119.PNG F8154374: Screenshot_20200306_133130.PNG F8154369:

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread David Redondo
davidre updated this revision to Diff 77094. davidre added a comment. set padding REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27892?vs=77092=77094 BRANCH shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D27892 AFFECTED

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

2020-03-06 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY For a quick tiled window we currently don't draw a border on the edges it is tiled to but we still draw a shadow. In a one screen

D27650: ItemContainer: disconnect signals in destructor

2020-03-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:8f0da90f18ff: ItemContainer: disconnect signals in destructor (authored by alnikiforov, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27650: ItemContainer: disconnect signals in destructor

2020-03-06 Thread David Edmundson
davidedmundson added a comment. Urgh, sorry. Thanks cfeck REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To: alnikiforov, ngraham, davidedmundson, mart Cc: cfeck, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27650: ItemContainer: disconnect signals in destructor

2020-03-06 Thread Christoph Feck
cfeck added a comment. If this is still needed, please commit and clarify the status of the referenced bug. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To: alnikiforov, ngraham, davidedmundson, mart Cc: cfeck, anthonyfieroni, plasma-devel, Orage,

D27886: Demote jump list actions to PossibleMatches

2020-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `HelperMatch` type was used to identify them in `run` but this also causes them to score way

D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

2020-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead of comparing the state of the action to the action name, compare it to the argument the

D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

2020-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to documentation [1] a menu item has a `target` attribute, which is "the parameter to

Re: Plasma Sprint 2020 in Augsburg, Germany

2020-03-06 Thread Konrad Materka
Hi, What is the chance of this event being cancelled due to coronavirus? I have to book tickets on advance, unfortunately flight is the most reasonable. -- Regards, Konrad Materka

D27155: libnotificationmanager : add app-specific kconfig settings

2020-03-06 Thread Cyril Rossi
crossi updated this revision to Diff 77068. crossi added a comment. rename group attribute to parentGroupName REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=76834=77068 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FILES

D27879: Degrade qCInfo to qCDebug

2020-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It just adds noise TEST PLAN 5.18 - No longer get a bunch of pointless messages about