D28065: Add missing types to qrc

2020-03-15 Thread Keith Zubot-Gephart
keithzg added a comment. Can confirm this solves my crash when trying to run on Android, which previous killed my app on startup if trying to use a `CardsListView`: LOGCAT: W quickgear: QQmlApplicationEngine failed to load component LOGCAT: W quickgear: qrc:/qml/main.qml:17:28:

D28034: [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77704. ngraham added a comment. Remove FIXME; it was fixed by an upstream change in D28033 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28034: [WIP] [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77703. ngraham added a comment. Make the password field align in the same way that the default expanded view content does REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28034?vs=77697=77703

D28037: [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77700. ngraham added a comment. Use consistent highlight animation durations REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28037?vs=77586=77700 BRANCH port-to-ExpandableListItem (branched from master) REVISION

D28035: [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77699. ngraham added a comment. Use consistent highlight animation durations REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=77584=77699 BRANCH port-to-ExpandableListItem (branched from master)

D28034: [WIP] [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77697. ngraham added a comment. Use consistent highlight animation durations REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28034?vs=77696=77697 BRANCH port-to-ExpandableListItem (branched

D28034: [WIP] [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 77696. ngraham added a comment. Adjust to API changes in D28033 ; now subtitle eliding works when the button is visible REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28066: Remove the STATIC_LIBRARY option to fix static builds

2020-03-15 Thread Charles Barto
bartoc created this revision. bartoc added a reviewer: Kirigami. bartoc added a project: Kirigami. Herald added a subscriber: plasma-devel. bartoc requested review of this revision. REVISION SUMMARY Previously static builds were broken because GenerateExportHeader used: get_property(type

D28065: Add missing types to qrc

2020-03-15 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH types REVISION DETAIL https://phabricator.kde.org/D28065 AFFECTED FILES kirigami.qrc

D28035: [Applet] Port to ExpandableListItem

2020-03-15 Thread Nathaniel Graham
ngraham added a comment. :D <3 <3 REPOSITORY R845 Plasma Vault BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D28035 To: ngraham, #vdg, #plasma, ivan Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28064: [applet/notes] Show a "remove" button on the button row

2020-03-15 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. makes sense to me REPOSITORY R114 Plasma Addons BRANCH show-remove-button-too (branched from master) REVISION DETAIL https://phabricator.kde.org/D28064 To: ngraham, #vdg, #plasma,

D28064: [applet/notes] Show a "remove" button on the button row

2020-03-15 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY I've personally observed various users struggle to remove a Sticky Note widget, and heard

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

2020-03-15 Thread Carson Black
cblack updated this revision to Diff 77684. cblack marked 7 inline comments as done. cblack added a comment. Edit inaccurate comment. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77683=77684 BRANCH media-plasmoid-relayout (branched

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

2020-03-15 Thread Carson Black
cblack updated this revision to Diff 77683. cblack added a comment. Don't refer to parents' width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75144=77683 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

2020-03-15 Thread Konrad Materka
kmaterka added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:261 > This advice doesn't seem to be applicable here, as the `implicitWidth` of the > ColumnLayout child isn't able to be mutated due to the fact that all of its > child items (text) have fixed

D27958: [SystemTray] Fix item size for very narrow panel

2020-03-15 Thread Konrad Materka
kmaterka added a comment. In D27958#627658 , @ngraham wrote: > After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened: > > F8176616:

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

2020-03-15 Thread Carson Black
cblack updated this revision to Diff 77681. cblack added a comment. Add X11 data to model REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77322=77681 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DETAIL

D28061: Reduce unneeded dependencies

2020-03-15 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 77678. apol added a comment. polish REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28061?vs=77677=77678 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 AFFECTED FILES

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Failure!

2020-03-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/64/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Mar 2020 19:54:06 + Build duration: 4 min 2 sec and counting CONSOLE OUTPUT [...truncated

D28061: Reduce unneeded dependencies

2020-03-15 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to translate a test app that is not even being installed. Make it a QGuiApplication so less

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 10 - Failure!

2020-03-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/10/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 15 Mar 2020 19:54:06 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.12 - Build # 135 - Failure!

2020-03-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.12/135/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Mar 2020 19:54:06 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT [...truncated 353

D27985: Include s_kcrashErrorMessage in our traces

2020-03-15 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77452=77676 REVISION DETAIL

D28024: [Baloo KCM] Expose "Index hidden" config setting

2020-03-15 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R119:491ce0f1d78f: [Baloo KCM] Expose Index hidden config setting (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28024?vs=77558=77662

D28054: Made window backgroun color lighter

2020-03-15 Thread Nathaniel Graham
ngraham added a comment. TBH, I don't really like it. I would be okay with lightening the window BG color a //little// bit, in preparation for the Tools Area being visibly darker, but I think this takes it a too far. The difference is super muted in the screenshots you show where there's a

D28059: Be more accurate in reporting the x86 CPU features solid detects

2020-03-15 Thread Allan Sandfeld Jensen
carewolf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carewolf requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D28059 AFFECTED FILES

D28057: Fix/Allow folderview popup mode icon and list icon size

2020-03-15 Thread Alexandre Pereira
pereira.alex created this revision. pereira.alex added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pereira.alex requested review of this revision. REVISION SUMMARY As reported in bug #418269, the icon size is only selectable in icon view

D28055: Fix on wayland activating minimized window will move window to current desktop

2020-03-15 Thread Alexandre Pereira
pereira.alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pereira.alex requested review of this revision. REVISION SUMMARY As reported on bug #417888, on wayland if a window is minimized on VD1 and clicked to activate on VD2, it will put

D28054: Made window backgroun color lighter

2020-03-15 Thread Filip Fila
filipf added a comment. I already prepared this sort of a patch while ago because I believe the Breeze color schemes should have more contrast in order to look more modern. I chose 243, 244, 245 as the new color though since I still wanted to keep it different from the view color.

D28054: Made window backgroun color lighter

2020-03-15 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This is a patch to discuss (not to be landed yet) the possibility of making the window color lighter. I feel like a lighter

D28053: Making the Animation Slider more granular

2020-03-15 Thread Alexandre Pereira
pereira.alex added reviewers: Plasma, VDG. pereira.alex added a comment. Trying to add the correct reviewers :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28053 To: pereira.alex, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28053: Making the Animation Slider more granular

2020-03-15 Thread Alexandre Pereira
pereira.alex added a comment. More info: as discussed here: https://www.reddit.com/r/kde/comments/fgwcou/tip_animation_speedslider/ Also, please, be gentle, this is the first time doing tasks on phabricator and using arcanist. If i am doing something wrong, please ELI5 REPOSITORY

D28053: Making the Animation Slider more granular

2020-03-15 Thread Alexandre Pereira
pereira.alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pereira.alex requested review of this revision. REVISION SUMMARY Between default animation speed and slower/faster, there is a huge change. Making the slider change from 0.5 instead of

D28035: [Applet] Port to ExpandableListItem

2020-03-15 Thread Ivan Čukić
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. I assume people tell you that you're awesome all the time, so I'm not going to ;) REPOSITORY R845 Plasma Vault BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL