KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/3/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 04 Apr 2020 04:53:18 + Build duration: 1 hr 2 min and counting JUnit Tests

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. And what about the idea to pass delegate to job constructor? At least it's better than current one. I'm pretty pedantic about duplicate code in plus it makes porting harder. REPOSITORY R119 Plasma Desktop REVISION DETAIL

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.14 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.14/3/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 04:53:17 + Build duration: 49 min and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.14 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.14/3/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Sat, 04 Apr 2020 04:53:16 + Build duration: 48 min and counting JUnit Tests Name:

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

harogaston added a comment. Sorry @ngraham I couldn't find who to assign as reviewer. I mean not anything that seemed appropriate. If you know who it would be great. Cheers! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28547 To: harogaston, ngraham Cc:

D28547: Add .kksrc extension to the file name when global shorcuts scheme is exported

harogaston created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. harogaston requested review of this revision. REVISION SUMMARY The "Global shortcuts" (keys) kcm plugin does not add a corresponding file extension to the explorted schemes, nevertheless

D28154: Add users KCM

cblack updated this revision to Diff 79250. cblack marked 2 inline comments as done. cblack added a comment. Address some more issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79248=79250 BRANCH arcpatch-D28154 REVISION DETAIL

D28154: Add users KCM

ngraham added a comment. In D28154#640943 , @cblack wrote: > Add parent category Now it shows up on the base level of navigation, rather than within the Account Details group where it currently lives. REPOSITORY R119 Plasma Desktop

D28154: Add users KCM

cblack updated this revision to Diff 79248. cblack added a comment. Trim file:// off of icon string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79245=79248 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154

D28154: Add users KCM

cblack updated this revision to Diff 79245. cblack added a comment. Add parent category REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79242=79245 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > cblack wrote in ChangePassword.qml:65 > that's basically what this does Well, it doesn't work for me. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi,

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > UserDetailsPage.qml:101 > +layer.enabled: user.faceValid > +layer.effect: OpacityMask { > +maskSource: Rectangle { Nice! How about an outline around the circle like we do in Kickoff?

D28544: RecentDocuments Runner: Cleanup and formatting

alex updated this revision to Diff 79244. alex added a comment. Change import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28544?vs=79243=79244 BRANCH recentdocuments_cleanup (branched from master) REVISION DETAIL

D28544: RecentDocuments Runner: Cleanup and formatting

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - Instead of early returning in the match method if the list of

D28154: Add users KCM

cblack updated this revision to Diff 79242. cblack marked 3 inline comments as done. cblack added a comment. Address issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79241=79242 BRANCH arcpatch-D28154 REVISION DETAIL

D28539: [Emoji panel] search when the user begins typing

ngraham added a comment. Yes, but hitting Ctrl+f and typing results in an instant search, while applying this patch and just typing results in a 3-second lag for me before the view switches and the search begons. It feels like I did something wrong rather than running into some kind of

D28539: [Emoji panel] search search when the user begins typing

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Fonts are slow... REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D28539 To: ngraham, apol, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n,

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Haven't tried yet, sorry. I'll give it another shot today. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28154: Add users KCM

cblack updated this revision to Diff 79241. cblack marked 3 inline comments as done. cblack added a comment. Improve deletion and creation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79240=79241 BRANCH arcpatch-D28154 REVISION DETAIL

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. @ngraham Did you manage to load the recoloration module into the GTK app by one or another way? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre,

D28154: Add users KCM

cblack updated this revision to Diff 79240. cblack added a comment. Drop anchors REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79236=79240 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > ngraham wrote in ChangePassword.qml:65 > hitting the return key on this field should effectively click the Create > button that's basically what this does REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154

D28154: Add users KCM

ngraham added a comment. Now it's this: "file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml" "Error loading QML file.\n257: Type ChangePassword unavailable\n31: Cannot assign to non-existent property \"anchors\"\n" REPOSITORY R119

D28517: Send notification when screencasting fails

cblack updated this revision to Diff 79237. cblack marked 6 inline comments as done. cblack added a comment. Better notification handling REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28517?vs=79147=79237 BRANCH

D28154: Add users KCM

cblack updated this revision to Diff 79236. cblack added a comment. Remove modal REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79184=79236 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28496: Hotfix for D28468 to fix broken variable refs

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1d777eef0b0b: Hotfix for D28468 to fix broken variable refs (authored by masonm). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28496?vs=79096=79235#toc REPOSITORY R169 Kirigami CHANGES

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So here's what I see in the system tray popup: F8213414: Screenshot_20200403_102113.png The toolbar doesn't touch the edges of its

D28281: Add options for OSD feedback

This revision was automatically updated to reflect the committed changes. Closed by commit R115:1df3476ced19: Add options for OSD feedback (authored by sgoth, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D28154: Add users KCM

ngraham added a comment. I think that broke the details page. Console spew says: QQmlComponent: Component is not ready "file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml" "Error loading QML file.\n257: Type ChangePassword

D27576: Kill Runner: Move config keys to new file

alex added a comment. Thanks!  And may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27576: Kill Runner: Move config keys to new file

alex updated this revision to Diff 79224. alex added a comment. Fix wrong username REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=78137=79224 BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 AFFECTED

D28539: [Emoji panel] search search when the user begins typing

ngraham created this revision. ngraham added reviewers: apol, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now you need to hit Ctrl + F to start searching. This patch additionally makes

D28026: further constrict line parsing of .so files

sitter updated this revision to Diff 79219. sitter added a comment. use other string REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28026?vs=77561=79219 BRANCH parse REVISION DETAIL https://phabricator.kde.org/D28026 AFFECTED FILES

D28026: further constrict line parsing of .so files

sitter added inline comments. INLINE COMMENTS > ahmadsamir wrote in backtraceparsergdb.cpp:75 > (Needs rebasing on master). > I'd move this and define "const bool file" in one place. Alas the code is garbage enough to read, I prefer the way I've written. REPOSITORY R871 DrKonqi REVISION

D27981: strip non printable characters from opengl dri info

This revision was automatically updated to reflect the committed changes. Closed by commit R102:a20ea703f659: strip non printable characters from opengl dri info (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27981?vs=77414=79217

D27980: make opengl module support multiple dri devices

This revision was automatically updated to reflect the committed changes. Closed by commit R102:72a09a3f2787: make opengl module support multiple dri devices (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27980?vs=79208=79216

D27982: use better strings for dri devices

This revision was automatically updated to reflect the committed changes. Closed by commit R102:b7d462e03ce9: use better strings for dri devices (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27982?vs=77417=79218#toc REPOSITORY R102 KInfoCenter CHANGES SINCE

D27980: make opengl module support multiple dri devices

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R102 KInfoCenter BRANCH multidri REVISION DETAIL https://phabricator.kde.org/D27980 To: sitter, apol Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n,

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 79208. sitter added a comment. - do however init the stat struct, its members are not initialized otherwise - streamline get_dri_device return - do not init l3 to nullptr inside the info loop. l3 is the entry for the infos, so simply leave it as-is

D28215: [RFC]: WIP: Make mobile broadband actually functional

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:63-67 > +checked: false > +onEnabledChanged: { > +if (!enabled) > +checked = false > +} This should work enabled: mobileDataCheckbox.enabled checked :

D28368: [krunner] Avoid (a third!) pointless config parse

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6dc04ef0adec: [krunner] Avoid a uneeded pointless config parse (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28366: [krunner] Don't set the position three times in a row

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2d372d3dfd1: [krunner] Dont set the position three times in a row (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28365: [krunner] Avoid (another) pointless config load on start

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1c48e351c646: [krunner] Avoid reparsing the config load on start (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28364: [krunner] Avoid a config pointless extra config load

This revision was automatically updated to reflect the committed changes. Closed by commit R120:23534a3b4f6e: [krunner] Avoid a config pointless extra config load (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R120:a8fb4ce827ab: [Klipper] Upate the klipper docbook after porting to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R120 Plasma Workspace BRANCH l-klipper-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D28534 To: ahmadsamir, #plasma, davidedmundson,

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > yurchor wrote in index.docbook:34 > Can you bump the date and version? > > Thanks in advance for your work. Done. Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

ahmadsamir updated this revision to Diff 79200. ahmadsamir added a comment. Bump date and version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28534?vs=79197=79200 BRANCH l-klipper-docs (branched from master) REVISION DETAIL

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

yurchor added inline comments. INLINE COMMENTS > index.docbook:34 > 2015-07-20 > Plasma 5.4 > Can you bump the date and version? Thanks in advance for your work. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28534 To: ahmadsamir, #plasma,

D28534: [Klipper] Upate the klipper docbook after porting to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, apol, broulik. Herald added projects: Plasma, Documentation. Herald added a subscriber: kde-doc-english. ahmadsamir requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH l-klipper-docs

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:625 > setting twice in a row? I'd skip setting a nullptr. Mh. I think that's to ensure l3 (which is passed into newItem) is null on >1 iteration. Indeed garbage though, I'll just pass in nullptr instead. REPOSITORY

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D28519#640339 , @apol wrote: > It could make sense for you to test that the names are properly parsed besides just making sure it starts. Done. REPOSITORY R103 KMenu Editor REVISION DETAIL

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R103:1e30c84ab32b: [KMenuEdit] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28519?vs=79188=79194

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan added a comment. Any news on this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To: wstephenson, #plasma, ivan, davidedmundson Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28383: Add PageRouter component

mart added inline comments. INLINE COMMENTS > PageRow.qml:60 > +// Private handle to columnView. > +property alias _columnView: columnView > + if is a publicly accessible property, it should be apublic and documented REPOSITORY R169 Kirigami REVISION DETAIL

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc added a comment. Can I get any more feedback on this? what do I have to do to get it merged? REVISION DETAIL https://phabricator.kde.org/D28066 To: bartoc, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 79188. ahmadsamir edited the test plan for this revision. ahmadsamir removed a subscriber: apol. ahmadsamir added a comment. Add proper test plan REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE