D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

ahmadsamir added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28575: Make headings of systray and applet merge

ngraham added a comment. Hmm, here's what I get when I apply this and then D28467 : F8216515: Screenshot_20200404_213411.png Other applets also seem to be affected: F8216520: Screenshot_20200404_213522.png

D27849: [applets/digital-clock] Remove the tooltip icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1a0835bee52: [applets/digital-clock] Remove the tooltip icon (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27849?vs=79370=79371

D27849: [applets/digital-clock] Remove the tooltip icon

ngraham updated this revision to Diff 79370. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27849?vs=76972=79370 BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f14afa945cea: [applet/taskmanager] Remove the launcher items tooltip icons (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28037: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79364. ngraham added a comment. Rebase REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28037?vs=77938=79364 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28239: Stop multiplying duration values

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f3bbc0ba0e34: Stop multiplying duration values (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE

D28238: Stop multiplying duration values

This revision was automatically updated to reflect the committed changes. Closed by commit R120:295870252434: Stop multiplying duration values (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28238?vs=78358=79362 REVISION DETAIL

D28576: Converted to page and added Heading

niccolove updated this revision to Diff 79347. niccolove added a comment. Fixed context menu REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79346=79347 BRANCH notification_page_heading (branched from master) REVISION DETAIL

D28576: Converted to page and added Heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY As per D28575 , converted the FullRepr to be a Page and added a PlasmoidHeading

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#640854 , @ngraham wrote: > So here's what I see in the system tray popup: F8213414: Screenshot_20200403_102113.png > > The toolbar doesn't touch the edges of its

D28575: Make headings of systray and applet merge

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY When the applet is a page with a plasmoidHeading as header, merge it with systray one. Screenshots incoming. The only

D28134: Add ColorUtils

cblack updated this revision to Diff 79333. cblack added a comment. Rewrite PendingValue to use QFuture REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79327=79333 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134

D28134: Add ColorUtils

cblack updated this revision to Diff 79327. cblack marked 2 inline comments as done. cblack added a comment. Address issues REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79097=79327 BRANCH cblack/colour-utils REVISION DETAIL

D27669: [kstyle] Tools area

ngraham added a comment. If we're going to consider the titlebar a part of the tools area, then it needs a separator line underneath it whether it's drawn on a Blender window or a Plasma config window The idea was always to draw a separator line under the bottom-most element of the Tools

D28134: Add ColorUtils

fvogt added inline comments. INLINE COMMENTS > colorutils.cpp:90 > +}); > +} > + If item is neither of those three, it would never call `pending->setValue` at all > colorutils.cpp:103 > + > +if (pending->value().isValid()) { > +

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79321. jjorge added a comment. - Follow ahiemstra suggestions : - cast to float directly - move 2 repeated lines to initAcpiBattery REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=77923=79321 BRANCH

D28383: Add PageRouter component

cblack updated this revision to Diff 79320. cblack marked an inline comment as done. cblack added a comment. Add documentation REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79082=79320 BRANCH cblack/pagerouter REVISION DETAIL

D27669: [kstyle] Tools area

cblack added a comment. In D27669#640491 , @ngraham wrote: > In D27669#640473 , @cblack wrote: > > > In D27669#639569 , @ngraham wrote: > > > > >

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#641165 , @dfaure wrote: > That wouldn't work either, you need to be able to choose between a Notification delegate, a Dialog delegate (which lives in a different library due to the QtWidgets

D28544: RecentDocuments Runner: Cleanup and formatting

alex added a comment. I didn't knew this patch existed and that it introduces coneptual changes. This is just a patch with smaller improvements/cleanup. Because of this I suggest waiting for your patch to be merged and than rebasing . REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. That wouldn't work either, you need to be able to choose between a Notification delegate, a Dialog delegate (which lives in a different library due to the QtWidgets dependency), and some more. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. OK, let's not keep things as they are. Because the best i can make without dedicated function is `new KIO::ApplicationLauncherJob(service, KIO::ApplicationLauncher::WITH_AUTO_ERROR_HANDLED_DELEGATE)` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. Regarding the recentdocument krunner, I have a patch to make it rely on kactivity data : D26111 . It has been waiting for review of a while. This patch will introduce a lot of conflict, but I am ok either way, if this one get

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. That would save only one line (the call to setUiDelegate). I prefer my earlier suggestion: job->setUiDelegate(new KNotificationJobUiDelegate(KJobUiDelegate::AutoErrorHandlingEnabled)); That one alone would save 2 lines ;) REPOSITORY R119 Plasma Desktop

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping @broulik REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 79263. gikari added a comment. - Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=78823=79263 BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072