KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 11 Apr 2020 04:03:50 + Build duration: 32 sec and counting CONSOLE OUTPUT

D28113: Fix initial loading of autostart program names

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Hi, sorry for the delay, this review skipped my attention. The patch looks good to me. REPOSITORY R119 Plasma Desktop BRANCH names (branched from master) REVISION DETAIL

D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > breezestyle.cpp:4474 > painter->fillRect(iconRect, > option->palette.brush(QPalette::Base)); > proxy()->drawItemPixmap(painter, iconRect, Qt::AlignCenter, >

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. If the code looks good to you, let's ship it. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. In D27972#645441 , @ngraham wrote: > It almost sounds like we need a "full manual control" mode where it's expected that the system tray applet or keyboard shortcut will be used to turn it on and off on demand.

D28072: [GTK Config] Apply color scheme to GTK3 applications

ndavis added a comment. Works for me. @ngraham, perhaps you forgot to restart `kded5`? I forgot that at first. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre,

D28730: Couple of 'trivial' fixes for broken code

ouwerkerk created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ouwerkerk requested review of this revision. REVISION SUMMARY Issues were found by running code with QT_QUICK_CONTROLS_MOBILE=1 - `Units` does not exist in SwipeListItem due to how

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 25 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/25/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 10 Apr 2020 19:02:57 + Build duration: 6 min 6 sec and counting BUILD ARTIFACTS

D28658: [krdb] Drop GTK2 colour exporting

cblack added inline comments. INLINE COMMENTS > gikari wrote in krdb.cpp:642 > Is this somewhat relevant to GTK? Pretty sure it's writing the xrdb there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28658 To: cblack, #plasma, ngraham, gikari, davidedmundson

D28688: Document Kirigami::Icon

cblack updated this revision to Diff 79787. cblack marked 10 inline comments as done. cblack added a comment. Address feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28688?vs=79744=79787 BRANCH cblack/document-icon (branched from master)

D28383: Add PageRouter component

cblack updated this revision to Diff 79785. cblack added a comment. Add bringToView and isCurrent REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79774=79785 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport updated this revision to Diff 79781. bport added a comment. Rename state probe to data and use them in KCM And fix defaultness of spellchecking inside data (default at loading without widget state) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28727: Use link rather than copy

davidre created this revision. davidre added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY I think linking the file is better because the file can change after changing

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham added a comment. It almost sounds like we need a "full manual control" mode where it's expected that the system tray applet or keyboard shortcut will be used to turn it on and off on demand. REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag,

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. I totally missed the D26688 request. And it proposes some great ideas. So just to update my mockup accordingly: As for the tray icon visibility (for the states above): - Manual mode: - disabled = F8230305:

D28383: Add PageRouter component

cblack updated this revision to Diff 79774. cblack added a comment. Fix bad image text REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79748=79774 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED FILES

D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

broulik created this revision. broulik added reviewers: Plasma, davidre, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's not done anywhere and breaks rendering the `ComboBox` on high dpi.

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. Maybe I should explain my motives and probably that would let us (including me) understand the goal better. I use Night Color only occasionally and I want to turn it on *manually*. And I like my tray clean. So I only need this icon when I have it manually

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79771. bport added a comment. - Factorize QML code - Rename isDefault to showDefaultIndicator REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=79499=79771 REVISION DETAIL

D28724: Fix build

ngraham created this revision. ngraham added reviewers: davidre, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Though for some reason it's not failing on the CI, plasma-integration is failing to

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 10 Apr 2020 14:59:58 + Build duration: 46 sec and counting CONSOLE OUTPUT

D28713: Return buffer to pipewire when returning early from recordFrame

This revision was automatically updated to reflect the committed changes. Closed by commit R838:3afcdb2adc00: Return buffer to pipewire when returning early from recordFrame (authored by cblack). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28705: Don't consider player gone when it only got temporarily added by us

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f48989b7936f: Dont consider player gone when it only got temporarily added by us (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

This revision was automatically updated to reflect the committed changes. Closed by commit R856:5a5369a0cb40: [Purpose Plugin] Detect cancelling the prompt more reliably (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28709: Implement executeScript for Firefox

fvogt added a comment. In D28709#645296 , @broulik wrote: > I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the

D28709: Implement executeScript for Firefox

broulik added a comment. So, back to my export function patch? :/ REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28709: Implement executeScript for Firefox

broulik added a comment. I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the style sheet... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Looks fragile, but I don't have a better idea either. https://bugreports.qt.io/browse/QTBUG-56761 sigh REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D28705: Don't consider player gone when it only got temporarily added by us

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In D28705#645038 , @broulik wrote: > Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

broulik updated this revision to Diff 79754. broulik added a comment. - Use `QMetaObject::invokeMethod` with lambda. It's older than I thought it was :) REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28719?vs=79753=79754 REVISION

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `aboutToHide` is emitted before an action is triggered and `activeAction()` is the action

D28709: Implement executeScript for Firefox

fvogt abandoned this revision. fvogt added a comment. https://bugzilla.mozilla.org/show_bug.cgi?id=1591983 :-( I guess spotify had `unsave-eval`, but not `unsafe-inline`, so this method just breaks different pages... Apparently it's possible to add a `script` element with

D28709: Implement executeScript for Firefox

broulik added a comment. Try https://open.spotify.com/browse/featured but I believe you can't play anything without an account. Maybe you could upload an ogg file to KDE nextcloud and try with that. REPOSITORY R856 Plasma Browser Integration BRANCH ffeval REVISION DETAIL