KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 04:22:07 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma » bluedevil » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 04:20:27 + Build duration: 25 min and counting CONSOLE OUTPUT [...truncated 159

D28034: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79981. ngraham added a comment. Use new `showDefaultActionButtonWhenBusy` option to allow disconnecting while a connection attempt is in progress REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. Fix binding loops: D28787 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28037: [Applet] Port to ExpandableListItem

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R97:be8c0f186a06: [Applet] Port to ExpandableListItem (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE

D28037: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79978. ngraham added a comment. Update required Frameworks version REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28037?vs=79364=79978 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28035: [Applet] Port to ExpandableListItem

This revision was automatically updated to reflect the committed changes. Closed by commit R845:b480831d5cf5: [Applet] Port to ExpandableListItem (authored by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=79437=79976 REVISION DETAIL

D28627: Adaptive panel opacity

ngraham added a comment. +1 for making this a user-controllable setting, but how does it interact with plasma themes where there isn't any transparency? Can we only show this UI for plasma themes with transparency? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28786: Add opacityMode

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN D28627 REPOSITORY R120 Plasma Workspace BRANCH

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79973. cblack added a comment. Add configuration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79972=79973 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79972. cblack added a comment. Filter by screen REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79970=79972 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28785: Don't request blur when panel is opaque

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN Probe panel windows with xprop or edit D28627 to make the panel

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79970. cblack added a comment. Fix errors REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79969=79970 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79969. cblack added a comment. Refactor to state/transitions and don't render two FrameSvgItems at once REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79968=79969 BRANCH arcpatch-D28627 REVISION

D28783: krunner: polish placement

apol added a subscriber: davidedmundson. apol added a comment. This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18 , so I'll wait for @davidedmundson's comment. REPOSITORY R120 Plasma

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79968. cblack added a comment. Use D28784 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79494=79968 BRANCH arcpatch-D28627 REVISION DETAIL

D28784: [libtm] Add filterNotMaximized property

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY There is a `filterNotMaximized` property that filters out windows that are not maximized. Self

D28783: krunner: polish placement

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Tell the parent Dialog class what the location is so it can configure the dialog accordingly.

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. I have a question though: we ship the pager widget in the panel that does the same by default. Wouldn't that have the same efficiency impact, if not even more? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove,

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

arfrever added inline comments. INLINE COMMENTS > CMakeLists.txt:23 > > -find_package(PipeWire) > -set_package_properties(PipeWire PROPERTIES > -TYPE OPTIONAL > -PURPOSE "Required for screencast portal" > -) > - > -find_package(GBM) > -set_package_properties(GBM PROPERTIES > -TYPE

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote: > > > > > We may need to do on-the-fly conversion of the kde: repo paths if they > > won't be expressible as 'kde:foo' in the future, but we should have the > > information needed to do this in kdesrc-build to make this happen > >

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. CMake bits look good. It's a bit of a shame that this whole complexity needs to be added, but oh well. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e680ff581a13: [applets/mediacontroller] Visually refresh media controller plasmoid (authored by cblack). REPOSITORY

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 79962. cblack added 1 blocking reviewer(s): broulik. cblack added a comment. This revision now requires review to proceed. Trim whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=79961=79962

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 79961. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=79960=79961 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 79960. cblack added a comment. Smaller fallback icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=79944=79960 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#646626 , @ngraham wrote: > Does `activeApplet.fullRepresentationItem` actually have a `header` property? Yes. I tried to console log it (...header) and it returns Toolbar qml element, which is

D28710: Make accidental panel and panel widget deletion more difficult

ngraham updated this revision to Diff 79952. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28710?vs=79950=79952 BRANCH make-accidental-panel-and-panel-widget-deletion-harder (branched from master) REVISION DETAIL

D28710: Make accidental panel and panel widget deletion more difficult

ngraham updated this revision to Diff 79953. ngraham added a comment. Correct the patch base (stupid arc) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28710?vs=79952=79953 BRANCH make-accidental-panel-and-panel-widget-deletion-harder (branched

D28710: Make accidental panel and panel widget deletion more difficult

ngraham updated this revision to Diff 79950. ngraham added a comment. - Also reposition the Remove Panel button pased on panel orientation - Ditch the overcomplicated loaders and components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich marked 2 inline comments as done. jgrulich added inline comments. INLINE COMMENTS > asturmlechner wrote in CMakeLists.txt:23-24 > maybe make it a proper cmake option? I made it a cmake option. I have never used it before so please check if it's correct. > asturmlechner wrote in

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 79948. jgrulich added a comment. Make DISABLE_PIPEWIRE_SUPPORT a cmake option and remove a leftover from previous change REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. Does `activeApplet.fullRepresentationItem` actually have a `header` property? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 79944. cblack added a comment. Wrap progressbar to prevent height filling REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=79886=79944 BRANCH media-plasmoid-relayout (branched from master) REVISION

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 79940. davidre added a comment. Actually show the dialog REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=79938=79940 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 79938. davidre added a comment. Do not use dialog.exec() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=79907=79938 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28651: Load and use global animation settings

ndavis added a comment. You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. It's still working for me. I also still need to restart apps for changes to the global animation settings to apply. REPOSITORY R31

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

asturmlechner added a comment. Thanks for keeping pipewire optional, this is in line with how we have been packaging xdg-desktop-portal-kde in Gentoo so far, we had just been conditionally disabling the cmake finding of these 3 libraries to do it, and will switch over to using the new

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu planned changes to this revision. z3ntu added inline comments. INLINE COMMENTS > nicolasfella wrote in config.cpp:99 > That sounds like a job for std::all_of I wasn't aware that C++ had such fancy methods :) I'm using equivalent functions a lot in Kotlin but they are honestly much nicer

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

romangg added a comment. I'm not sure about the renaming. the lock... implies that the rotation stays the way it is at the moment (what it does). But I'm fine either way. These are normally two separate commits, one refactor and one feature addition. But since it's only a small change

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +bool ret = true; > +for (KScreen::OutputPtr : m_data->outputs()) { That sounds like a job for std::all_of > config.h:50 > void setDeviceOrientation(QOrientationReading::Orientation orientation); > +

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY lockAutoRotate(true) would enable the automatic rotation and lockAutoRotate(false) would disable auto rotation which is the opposite

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79916. sandsmark added a comment. Now should reload the animation settings when changed anywhere. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28651?vs=79914=79916 REVISION DETAIL

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#643681 , @ndavis wrote: > I don't know enough about KDE configuration management to judge the code, but with this patch, changing animation speeds in SySe works if I restart apps after the change.

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79914. sandsmark added a comment. Also made it store to the global configuration. This way it is backwards compatible, but the config can also be changed from both places. I think it makes sense to have it both places, having it in the breeze

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 79907. davidre added a comment. forgot to implement defaults() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=79831=79907 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 1:06 AM Ben Cooksley wrote: > > On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk > wrote: > > > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > > wrote: > > > > > > Yes the only reason why a cleanup script might be needed is if the > > > logical path used to