KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Failing!

2020-04-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 16 Apr 2020 04:17:54 + Build duration: 21 sec and counting CONSOLE OUTPUT

D28873: Add SwipeNavigator component

2020-04-15 Thread Noah Davis
ndavis added a comment. So are these just all views that run simultaneously like apps on a task bar? What makes this different from tabs? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: ndavis, camiloh, plasma-devel,

D28873: Add SwipeNavigator component

2020-04-15 Thread Carson Black
cblack added a comment. In D28873#649388 , @ndavis wrote: > What is the usecase for this? Apps that have shallow and primarily lateral navigation. > The progress tab's page highlight changes width with the percent of progress,

D28873: Add SwipeNavigator component

2020-04-15 Thread Noah Davis
ndavis added a comment. What is the usecase for this? The progress tab's page highlight changes width with the percent of progress, correct? I think it looks wrong like that, unless I'm missing an important bit of context. REPOSITORY R169 Kirigami REVISION DETAIL

D28873: Add SwipeNavigator component

2020-04-15 Thread Carson Black
cblack updated this revision to Diff 80259. cblack added a comment. Add end-of-file newlines REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80258=80259 BRANCH cblack/lateral (branched from master) REVISION DETAIL

D28873: Add SwipeNavigator component

2020-04-15 Thread Carson Black
cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY SwipeNavigator is a component optimized for lateral page navigation rather than hierarchical

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

2020-04-15 Thread Filip Fila
filipf added a comment. I guess the top separator should be removed altogether then? (As opposed to just shortening it) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik,

D20569: RFC: Use more compact OSD

2020-04-15 Thread Filip Fila
filipf added a comment. I still like osds as notifications but I agree with @alexde, a vertical osd in the corner opposite (?) to where notifications spawn would be visually more pleasing than what is proposed in this patch and should even get in the way less. REPOSITORY R120 Plasma

D28859: Detect QQC2 version at build time with actual detection.

2020-04-15 Thread Xuetian Weng
xuetianweng added a comment. In D28859#649191 , @davidedmundson wrote: > I don't understand. > > We're still running this at compile time, so what's the practical difference? The old implement hard-codes it to (minor_version - 7),

D28859: Detect QQC2 version at build time with actual detection.

2020-04-15 Thread David Edmundson
davidedmundson added a comment. I don't understand. We're still running this at compile time, so what's the practical difference? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28859 To: xuetianweng, #plasma, rizzitello,

D25428: Improved support for desktop "Folder View"

2020-04-15 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Any update on the status of this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage,

D28859: Detect QQC2 version at build time with actual detection.

2020-04-15 Thread Xuetian Weng
xuetianweng updated this revision to Diff 80227. xuetianweng added a comment. fix header REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80226=80227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28859

D28859: Detect QQC2 version at build time with actual detection.

2020-04-15 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: Plasma, rizzitello, davidedmundson, apol, mart. xuetianweng added a project: Plasma. Herald added a subscriber: plasma-devel. xuetianweng requested review of this revision. REVISION SUMMARY Whenever qqc release a new version the

D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80224. davidre added a comment. - Add section checkbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80216=80224 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28383: Add PageRouter component

2020-04-15 Thread Carson Black
cblack updated this revision to Diff 80223. cblack marked 3 inline comments as done. cblack added a comment. Address feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79874=80223 BRANCH arcpatch-D28383 REVISION DETAIL

D27669: [kstyle] Tools area

2020-04-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This is probably fine as-is, and we can fine-tune it later if need be. We should wait to land it until the companion patches for Breeze GTK (https://invent.kde.org/kde/breeze-gtk/-/merge_requests/2), Kirigami (TBD) and

D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80216. davidre marked an inline comment as done. davidre added a comment. - Use pointing hand cursor - Rename error signals to errorOccured REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80198=80216

D28462: [KCM] Add color state probe to allow system settings to display current default state

2020-04-15 Thread Benjamin Port
bport updated this revision to Diff 80215. bport added a comment. fix build REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28462?vs=79781=80215 REVISION DETAIL https://phabricator.kde.org/D28462 AFFECTED FILES kcms/colors/CMakeLists.txt

D26934: KCM/Autostart Add a model to separate logic from UI

2020-04-15 Thread Méven Car
meven added inline comments. INLINE COMMENTS > ervin wrote in autostartmodel.h:52 > Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making > your own model. :-) As you want. IMO this is not a good pattern to expect reviewers to have any previous knowledge about enum values,

D26934: KCM/Autostart Add a model to separate logic from UI

2020-04-15 Thread Méven Car
meven updated this revision to Diff 80200. meven added a comment. Use Qt::DisplayRole directly instead of using Roles::DisplayRole REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=80196=80200 BRANCH D26934-2 REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80198. davidre added a comment. - Update the delegate REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80137=80198 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

2020-04-15 Thread Méven Car
meven updated this revision to Diff 80196. meven marked 11 inline comments as done. meven added a comment. Address review, fix an issue when adding a desktop item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=79639=80196 BRANCH D26934-2

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

2020-04-15 Thread David Redondo
davidre added subscribers: dfaure, davidre. davidre added a comment. This causes expired notifications to not vanish any more. This is supposed to work in the following way `ExpiredRole` is assigned `true` and `NotficiationFilterProxyModel` filters expired notifications out. I verified

D28853: krunner: Prevent regression

2020-04-15 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. apol added a project: Plasma. apol requested review of this revision. REVISION SUMMARY It was pointed out to me that using NoDisplay=true breaks starting krunner. Alternatively D24956 could be

D28852: Yep

2020-04-15 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28852 AFFECTED FILES krunner/CMakeLists.txt

D28822: Create StreamRestore channel if none exists

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R115:5bdd13689579: Create StreamRestore channel if none exists (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D28833: [kcm/touchpad] Simplify directory structure

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9f34469d04e3: [kcm/touchpad] Simplify directory structure (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28833?vs=80134=80185#toc REPOSITORY R119 Plasma Desktop

D28383: Add PageRouter component

2020-04-15 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > tst_pagerouter.qml:56 > +id: router > +initialRoute: "/home" > +columnView: root.columnView I find all the "/" in the examples confusing, not sure is a good naming convention (and works prefectly without having that /, and i

D28837: Add device icons to KDE Connect context menu

2020-04-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:60d074467453: Add device icons to KDE Connect context menu (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28849: [KSysGuardProcessList] Port away from KRun

2020-04-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R111:d8e46779566f: [KSysGuardProcessList] Port away from KRun (authored by broulik). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28849?vs=80175=80181

D28707: Show purpose context menu only when enabled

2020-04-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:7f3bc46f9044: Show purpose context menu only when enabled (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28707: Show purpose context menu only when enabled

2020-04-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 80177. broulik added a comment. - Call `updatePurposeMenu()` on connect REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28707?vs=80149=80177 REVISION DETAIL https://phabricator.kde.org/D28707

D28849: [KSysGuardProcessList] Port away from KRun

2020-04-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead use `ApplicationLauncherJob` with `KDialogJobUiDelegate` TEST PLAN - Clicking "Run

Re: Kickoff menu with empty history tab

2020-04-15 Thread David Edmundson
Either kactivitymanagerd not running, or it's database being corrupted. Running kactivitymanagerd manually might tell you. David

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

2020-04-15 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fe4d395d792d: Touchpad kcm: On X11 hide scroll speed as it is not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE