KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/23/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 04:18:52 + Build duration: 59 sec and counting CONSOLE OUTPUT

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80340. apol added a comment. Include the notification REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80285=80340 BRANCH master REVISION DETAIL

D28576: Converted to page and added Heading

ngraham added a comment. Needs a rebase, but LGTM! REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28467: Converted to Page with a PlasmoidHeading in the heading

This revision was automatically updated to reflect the committed changes. Closed by commit R97:4a8adbaeac4e: Converted to Page with a PlasmoidHeading in the heading (authored by niccolove). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80324=80327

D28575: Make headings of systray and applet merge

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a6b40cb5e0e: Make headings of systray and applet merge (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80315=80326

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham accepted this revision. ngraham added a comment. Shipit! Shipit real good! REPOSITORY R97 Bluedevil BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80324. niccolove added a comment. rebase x3 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80321=80324 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80321. niccolove added a comment. rebase x2 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80320=80321 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80320. niccolove added a comment. rebase REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=79889=80320 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM before the rebase though! REPOSITORY R97 Bluedevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma, ngraham Cc: ngraham,

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#649913 , @ngraham wrote: > Hmm, seems broke: > > file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1: Expected token `}' >

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. Sorry, I actually broke it in my attempt to rebase it so that it lands. You need to do the rebase on top of master: git checkout master git pull git checkout [your branch] git pull --rebase origin master arc diff REPOSITORY R97 Bluedevil

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. Hmm, seems broke: file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1: Expected token `}' REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma,

D28893: Detect Vivaldi based on binary name

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Vivaldi no longer includes its name in the User Agent, see [1]. Try detecting it based on

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove requested review of this revision. niccolove added a comment. Should finally work with latest D28575 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma, ngraham Cc: ngraham, plasma-devel,

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80315. niccolove added a comment. third one's a charm REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80314=80315 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80314. niccolove added a comment. try 2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80313=80314 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28575 AFFECTED FILES

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80313. niccolove added a comment. Only merge if header is actually visible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79483=80313 BRANCH arcpatch-D28467 REVISION DETAIL

D28888: Fix navigation regressions

ndavis added a comment. In D2#649712 , @cblack wrote: > In D2#649710 , @ngraham wrote: > > > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back

D28888: Fix navigation regressions

ngraham added a comment. I can understand that there are technical challenges, but, not to put too fine a point on it, this doesn't look very good: F8241927: Screenshot_20200416_101220.png REPOSITORY R1014 Kirigami Gallery REVISION DETAIL

D28888: Fix navigation regressions

cblack added a comment. In D2#649710 , @ngraham wrote: > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back to using real list items instead? That's what I initially attempted, but

D28888: Fix navigation regressions

ngraham added a comment. Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back to using real list items instead? REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: ngraham,

D28888: Fix navigation regressions

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch fixes navigation regressions caused by larger cards in the gallery. -

D28873: Add SwipeNavigator component

niccolove added inline comments. INLINE COMMENTS > mart wrote in SwipeNavigator.qml:55 > different tabbars should really depend only on whether it's a mobile device > or not (and be at bottom if mobile): a very small window on desktop is not a > mobile app I think the tabbar should not be at

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80285. apol added a comment. Fix build REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80280=80285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28884

D28383: Add PageRouter component

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:1d5398acecaa: Add PageRouter component (authored by cblack). CHANGED PRIOR TO COMMIT

D28383: Add PageRouter component

cblack updated this revision to Diff 80282. cblack marked an inline comment as done. cblack added a comment. Use more descriptive name REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=80275=80282 BRANCH arcpatch-D28383 REVISION DETAIL

D28873: Add SwipeNavigator component

cblack added inline comments. INLINE COMMENTS > mart wrote in Page.qml:238 > again, not convinced we should have this, seems a bit oddly specific it's not uncommon for apps to have one page associated with an ongoing task. examples: - clocks app running a progress indicator in reverse to

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 80281. cblack marked 5 inline comments as done. cblack added a comment. Address some feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80259=80281 BRANCH cblack/lateral (branched from master)

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of creating the pipewire feeds in the portal, they will be created in KWin. Then the portal task becomes to orchestrate the

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. Yeah. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D28383: Add PageRouter component

mart accepted this revision. mart added inline comments. INLINE COMMENTS > pagerouter.cpp:217 > +auto incomingRoutes = parseRoutes(route); > +QList mut; > + more descriptive name REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28383 To: cblack, #kirigami,

D28881: [Applet] Fix connecting with a password

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2e6878a37f6e: [Applet] Fix connecting with a password (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#649570 , @camiloh wrote: > What about having as a view a component that is not a Kirigami.Page? Such as a StackView or a Rectangle. Why not use an attached property to define its title, icon and other props

D28383: Add PageRouter component

cblack updated this revision to Diff 80275. cblack added a comment. Fix faulty navigateToRoute REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=80223=80275 BRANCH arcpatch-D28383 REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED

D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. See D28881 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: nicolasfella, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28881: [Applet] Fix connecting with a password

ngraham created this revision. ngraham added reviewers: jgrulich, nicolasfella, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY I could have sworn that I

D28873: Add SwipeNavigator component

camiloh added a comment. What about having as a view a component that is not a Kirigami.Page? Such as a StackView or a Rectangle. Why not use an attached property to define its title, icon and other props instead of focing to wrap those components into a kirigami.Page? REPOSITORY R169

D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. Crap. I could have sworn I tested that, but I see you're right. Will fix ASAP. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: nicolasfella, gvgeo, plasma-devel, Orage,

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/22/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 16 Apr 2020 13:17:00 + Build duration: 1 min 41 sec and counting CONSOLE OUTPUT

D28875: Screensharing: support variable stride

This revision was automatically updated to reflect the committed changes. Closed by commit R838:d1f0ec4d3a4c: Screensharing: support variable stride (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28034: [Applet] Port to ExpandableListItem

nicolasfella added a comment. This breaks entering a WiFi password for me. Pressing enter just closes the password field with no other reaction. Pressing the Connect button does nothing REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034

D20132: Actually make the network list view show up

nicolasfella added a comment. Is this still relevant? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc: nicolasfella, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28879: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

sunny created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sunny requested review of this revision. REVISION SUMMARY WidgetExplorer "get new widgets" dialogs live longer than WidgetExplorer, so it will be better to have external storage for that

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

sunny created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sunny requested review of this revision. REVISION SUMMARY WidgetExplorer "get new widgets" dialogs live longer than WidgetExplorer, so it will be better to have external storage for that

D28710: Make accidental panel and panel widget deletion more difficult

rikmills added a comment. In D28710#647340 , @davidedmundson wrote: > We shouldn't be making UX changes on the stable branch I agree. This could make getting the 5.18.5 release accepted as a K/Ubuntu stable release update (SRU) in a few

D28873: Add SwipeNavigator component

niccolove added a comment. My opinion from the consistency side: I actually think this is a good possibility for the Consistency goal. After some digging around, my opinion is that > Tabs should only be used on application views that are user-editable (eg: when it's possible to open a

D28833: [kcm/touchpad] Simplify directory structure

ltoscano added a comment. The Messages.sh script should have been changed as well. I pushed a change which fixes the message extraction: https://commits.kde.org/plasma-desktop/197d3076dd120b464998ad20d3bf0ae7c9c76664 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28873: Add SwipeNavigator component

mart added inline comments. INLINE COMMENTS > Page.qml:223 > + */ > +property variant icon > + for consistency, should be a private/ActionItemGroup.qml (which mimics the upstream qqc2 api icon.name/source/width/height/color) > Page.qml:238 > + */ > +property var progress:

D28875: Screensharing: support variable stride

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. TEST PLAN All current clients still work and also we now support higher stride we get from gbm_bo. REPOSITORY R838 Flatpak Support: KDE

D28873: Add SwipeNavigator component

mart added a comment. The tabbars have their own look, which it's against the consistency goal. I do prefer this look to the current breeze one, but this is a debate to have at the level of the future breeze direction. It's ok in the case of mobile with the tbbar on the bottom as it's a