KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/42/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 23 Apr 2020 04:37:18 + Build duration: 17 min and counting CONSOLE OUTPUT [...truncated 3048

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. Also you can now use `Kirigami.PlaceholderMessage` in this diff instead of making the messages manually using level 3 Headings. REPOSITORY R119 Plasma Desktop BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744 To:

D29117: [applet] Put the toolbar in the header area

ngraham created this revision. ngraham added reviewers: VDG, Plasma, jgrulich, niccolove, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY This patch

D29116: [applets/batterymonitor] Put the toolbar in the header area

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik, niccolove, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements part of the mockup at T10470

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. JFYI once this is ready to land, before doing so, please do an `arc amend` locally to pick up the changes in the description that I've made and ensure that all those bugs get closed! REPOSITORY R119 Plasma Desktop BRANCH kcmkeys2 (branched from master)

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6b76ce30811c: Icon: improve icon rendering on multi-screen multi-dpi setups (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:88 > Not sure it's actually a bug in the multi-page KCM system as @iasensio was > able to make this work properly in D28152 > . Maybe you can see what he did there? Seems to work for

D28154: Add users KCM

cblack updated this revision to Diff 80942. cblack marked 11 inline comments as done. cblack added a comment. Address feedback, needs fix for https://bugs.kde.org/show_bug.cgi?id=420439 in order to function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove accepted this revision. niccolove added a comment. This revision is now accepted and ready to land. Yeah, I agree. I see that this behavior is consistent, so I'll accept it. REPOSITORY R97 Bluedevil BRANCH port-to-PlaceholderMessage (branched from master) REVISION DETAIL

D29111: [applet] Port to Kirigami.PlaceholderMessage

ngraham added a comment. Well, this is the way we handle focus everywhere in KDE. When you press a focusable button, that button gains focus and retains it even after being pressed. IMO the only issue here is the super-obvious-bordering-on-overwhelming way we visually show focus, which

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove added a comment. Correct, but shouldn't the focus state stop after button press, or when I click away, or at least when I close the applet? Or am I getting the concept of focus wrong? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham,

D28996: Converted to page and added heading

This revision was automatically updated to reflect the committed changes. Closed by commit R115:a876b365bb22: Converted to page and added heading (authored by niccolove). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28996?vs=80589=80940

D29111: [applet] Port to Kirigami.PlaceholderMessage

ngraham added a comment. That's the focus state, not the hovered state. If I hit the tab key, focus goes somewhere else. Do you see the same? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca, niccolove Cc: plasma-devel,

D28996: Converted to page and added heading

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D28996 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham,

D29057: Introduce PlaceholderMessage component

ngraham added a comment. Oops. Fixed in 4c6252526c122081f7ac699d2655dc80306fde78 . Sorry about that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami,

D28996: Converted to page and added heading

niccolove added a comment. In D28996#652157 , @ngraham wrote: > Great! However the footer looks a bit weird since it doesn't touch the edges: F8247573: Screenshot_20200419_154306.png True but it's

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove added a comment. It seems like the button never gets out of hovered state: F8254176: Screenshot_20200422_231804.png REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca,

D29057: Introduce PlaceholderMessage component

nicolasfella added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:26 > + * @code{.qml} > + * import org.kde.kirigami 2.11 as Kirigami > + ** used as a "this view is empty" message This needs to be 2.12 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure added a comment. OK, that's above my head. Shall I push this or you'll rework it all? I just want to be able to deprecated KRun::run and friends :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik

D29111: [applet] Port to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca, niccolove. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch ports the Bluetooth applet to use

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > UserDetailsPage.qml:195 > +onClicked: { > +if (kcm.deleteUser(usersDetailPage.user.uid)) { > +kcm.pop() This no longer asks if you want to delete that user's home directory, so it's

D29110: [applet] port to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, ivan, niccolove. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch ports the Vaults applet to use the new

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik, niccolove. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Clipboard and Notifications applets live in plasma-workspace; port

D29060: Port placeholder message to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R1044:985d02fbb4da: Port placeholder message to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R1044 Plasma Thunderbolt Integration CHANGES SINCE LAST UPDATE

D29057: Introduce PlaceholderMessage component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5a434519aeb9: Introduce PlaceholderMessage component (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80892=80929 REVISION DETAIL

D29059: Port BrowsingPage to PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R134:24c3da41c422: Port BrowsingPage to PlaceholderMessage (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29059?vs=80824=80930

D28841: Raise size of default fixed-width font from 9 to 10pt

This revision was automatically updated to reflect the committed changes. Closed by commit R135:f30c8ca7c5c8: Raise size of default fixed-width font from 9 to 10pt (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D28842: Raise size of default fixed-width font from 9 to 10pt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:010c7a5e895a: Raise size of default fixed-width font from 9 to 10pt (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28842?vs=80159=80927#toc REPOSITORY R119 Plasma

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 80924. ngraham added a comment. Make the title look more like Kirigami section separators REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=80834=80924 BRANCH menu-title-looks-less-like-a-menu-item (branched

D29106: Introduce RouterWindow control

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Convenience subclass of ApplicationWindow with a PageRouter all set up. TEST PLAN `make test`

D29092: Various fixes to new Cards

ndavis added inline comments. INLINE COMMENTS > sdf.glsl:199 > // This > -const lowp float sdf_default_smoothing = 0.005; > +const lowp float sdf_default_smoothing = 0.4; > I played around with this value and found that 0.625 was pretty decent. It slightly improved the corners in bigscreen

D29064: Support module commandline paramenter

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, and I fully support the overall goal of getting rid of kcmshell. Doing so will fix a ton of bugs (all the systemsettings | kcmshell bugs as well as all the bug reports about

D29064: Support module commandline paramenter

mart updated this revision to Diff 80913. mart added a comment. - use namespace REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80904=80913 BRANCH phab/startupModule REVISION DETAIL https://phabricator.kde.org/D29064 AFFECTED FILES

D28711: WIP: OpenStore Integration

apol added a comment. Hey, I went through the review, the patch looks good. There's some fairly important bits missing: - un/installing - running - state of resources. Currently it searches only on the server but doesn't check if it's installed locally. - detecting if the

D29064: Support module commandline paramenter

ngraham added a comment. This doesn't build for me: /home/nate/kde/src/systemsettings/app/main.cpp: In function ‘int main(int, char**)’: /home/nate/kde/src/systemsettings/app/main.cpp:115:91: error: ‘endl’ was not declared in this scope; did you mean ‘std::endl’? 115 |

D29092: Various fixes to new Cards

ndavis added a comment. This has a ShadowedRectangle underneath and a transparent Rectangle with a border on top: F8253587: Screenshot_20200422_115104.png Is there nothing that can be done about that? REPOSITORY R169 Kirigami BRANCH

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

apol created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into account which window it's rendering to. Otherwise it was

D29064: Support module commandline paramenter

bport added inline comments. INLINE COMMENTS > IconMode.cpp:204 > + > +if (!startupModule().isEmpty()) { > +MenuItem *item = rootItem()->descendantForModule(startupModule()); Indentation is not correct REPOSITORY R124 System Settings REVISION DETAIL

D29064: Support module commandline paramenter

mart updated this revision to Diff 80904. mart marked 2 inline comments as done. mart added a comment. - remove leftovers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80903=80904 BRANCH phab/startupModule REVISION DETAIL

D29064: [WIP] Support module commandline paramenter

mart updated this revision to Diff 80903. mart added a comment. - support for startup module arguments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29064?vs=80790=80903 BRANCH phab/startupModule REVISION DETAIL

D28916: fix(kded): center action OSD on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R104:b3b45721ee17: fix(kded): center action OSD on wayland (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28916?vs=80376=80899#toc REPOSITORY R104 KScreen CHANGES SINCE

D28662: KCM LookAndFeel check widgetStyle availability before applying it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it. (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 80894. crossi added a comment. use qAsConst, indent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=80864=80894 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES

D28333: Add a new daemon for stats monitoring

ahiemstra added inline comments. INLINE COMMENTS > client.cpp:45 > +{ > +for (auto sensor : m_subscribedSensors) { > +sensor->unsubscribe(); This should probably use `qAsConst`. > ksysguarddaemon.cpp:76 > +auto factory = qobject_cast(plugin); > +if (!factory) { > +

D29092: Various fixes to new Cards

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Much better and thanks! LGTM REPOSITORY R169 Kirigami BRANCH cards_fixes REVISION DETAIL https://phabricator.kde.org/D29092 To: ahiemstra, #kirigami, ndavis Cc: ndavis,

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80892. ngraham added a comment. Add another code example showing now you could use it as a loading indicator REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80825=80892 BRANCH placeholder-message (branched

D29092: Various fixes to new Cards

ahiemstra added a comment. Urgh, I knew there was a point to that damn fwidth() call. As far as I can tell this version has about the same visual appearance without it changing dependent on resolution. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29092 To:

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80891. ahiemstra added a comment. - Restore fwidth() call in shader, tweak smoothing values more REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80885=80891 BRANCH cards_fixes REVISION DETAIL

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0e40a1cadf48: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ngraham added a comment. In D29080#654508 , @romangg wrote: > I like that. KCMs should be more inter-connected anyway. The message could just be shown all the time instead of making it dependent on the font size selected but no need to change

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80885. ahiemstra added a comment. - Remove sdf_polygon, it is unused and causes breakage on Android REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80878=80885 BRANCH cards_fixes REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

ngraham added a comment. In D29081#654374 , @broulik wrote: > Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use

D29092: Various fixes to new Cards

ndavis added a comment. Actually, width does affect the roughness. The corners are at their smoothest when the card is a square. F8253358: Screenshot_20200422_092539.png F8253360: Screenshot_20200422_092453.png

D29092: Various fixes to new Cards

ndavis added a comment. I found something vary curious and I don't know what the cause could be. The corners are smoother when the cards are taller and rougher when they are shorter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29092 To: ahiemstra, #kirigami

D29092: Various fixes to new Cards

ahiemstra updated this revision to Diff 80878. ahiemstra added a comment. - Slightly increase smoothing, to avoid too harsh corners REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29092?vs=80876=80878 BRANCH cards_fixes REVISION DETAIL

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654542 , @davidedmundson wrote: > A new dependency also needs to actually solve an actual problem. > > If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of

D29092: Various fixes to new Cards

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This contains various small fixes to the new Cards. - Still show the border of

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654535 , @anthonyfieroni wrote: > In D29028#653194 , @romangg wrote: > > > In D29028#653192 , @apol wrote: > > > >

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:315 > ManagedConfigModule::defaults(); > -m_settings->defaults(); > +for (auto *behaviorSettings : m_behaviorSettingsList) { > +

D29028: feat(wayland): add Wrapland plugin

romangg added a comment. In D29028#654526 , @tcanabrava wrote: > I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 80864. crossi added a comment. maange reset to default application notification REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=76004=80864 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED

D29028: feat(wayland): add Wrapland plugin

davidedmundson added a comment. A new dependency also needs to actually solve an actual problem. If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of Plasma used by 3rd parties. I'd certainly be very happy for us both to switch to a

D29028: feat(wayland): add Wrapland plugin

anthonyfieroni added a comment. In D29028#653194 , @romangg wrote: > In D29028#653192 , @apol wrote: > > > I don't really see why we'd want to support something that is not offering ABI stability

D29028: feat(wayland): add Wrapland plugin

tcanabrava added a comment. I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you suddenly quit / disappear and the project dies? Then kscreen will have a folder of dead

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

romangg added a comment. I like that. KCMs should be more inter-connected anyway. The message could just be shown all the time instead of making it dependent on the font size selected but no need to change that now. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

bshah accepted this revision. bshah added a comment. Sorry for delay in testing this, works fine! REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg,

D29057: Introduce PlaceholderMessage component

leinir added a comment. Nice! Got a few places where this could be very handy :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah updated this revision to Diff 80847. bshah added a comment. - pass raw body data to the watcher REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28509?vs=80833=80847 BRANCH bshah/notification-watcher REVISION DETAIL

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old signal syntax (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ahmadsamir added a reviewer: bport. ahmadsamir added a comment. Does InlineMessage have a "Don't show again" capability? it'll become irritating after seeing it 1-2 times. IIUC, the fontsHaveChanged() signal, nothing is listening to it in KDE code doesn't mean other 3rd party software

D27155: libnotificationmanager : add app-specific kconfig settings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

mart added a comment. so in the end, vertical centering? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28664 To: cblack, #kirigami Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D29081: [QStyle] Make menu titles look less like menu items

broulik added a comment. Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use proper sections for readability. REPOSITORY R31 Breeze REVISION DETAIL